[webkit-changes] [WebKit/WebKit] 0a4279: [ews-build.webkit.org] Use twisted defer when comm...

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0a4279f491040e274f94afd752e535777f4551cb
      https://github.com/WebKit/WebKit/commit/0a4279f491040e274f94afd752e535777f4551cb
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2022-12-09 (Fri, 09 Dec 2022)

  Changed paths:
    M Tools/CISupport/ews-build/results_db.py
    M Tools/CISupport/ews-build/steps.py

  Log Message:
  -----------
  [ews-build.webkit.org] Use twisted defer when communicating with results.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=249026
rdar://103184263

Rubber-stamped by Aakash Jain.

We have some evidence that requests to results.webkit.org are blocking the main thread in buildbot.
We should use Twisted's defer when making web requests to prevent this problem.

* Tools/CISupport/ews-build/results_db.py:
(ResultsDatabase.JsonPrinter): Protocol to receive the contents of a request body.
(ResultsDatabase.get_results_summary): Return a Twisted defer object which resolves into the appropriate json.
(ResultsDatabase.is_test_pre_existing_failure): Ditto.
(ResultsDatabase.is_test_expected_to): Ditto.
(ResultsDatabase.main): Resolve Twisted's defers.
* Tools/CISupport/ews-build/steps.py:
(RunWebKitTests.runCommand): Renamed from commandComplete, convert to a deferred response.
(RunWebKitTests.filter_failures_using_results_db): Convert to a deferred response.
(ReRunWebKitTests.runCommand): Renamed from commandComplete, convert to a deferred response.
(RunWebKitTestsWithoutChange.runCommand): Ditto.
(RunWebKitTests.commandComplete): Renamed to runCommand.
(ReRunWebKitTests.commandComplete): Ditto.
(RunWebKitTestsWithoutChange.commandComplete): Ditto.

Canonical link: https://commits.webkit.org/257654@main