[webkit-changes] [WebKit/WebKit] 59e644: Add more HeaderDoc comments to Web Extension headers.

Timothy Hatcher noreply at github.com
Fri Dec 9 16:01:25 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 59e644d90509b88a3098f47f71cbf0f88de74d95
      https://github.com/WebKit/WebKit/commit/59e644d90509b88a3098f47f71cbf0f88de74d95
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2022-12-09 (Fri, 09 Dec 2022)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtension.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtension.mm
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionController.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionController.mm
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerConfiguration.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMatchPattern.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMatchPattern.mm
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionTab.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionWindow.h

  Log Message:
  -----------
  Add more HeaderDoc comments to Web Extension headers.
https://bugs.webkit.org/show_bug.cgi?id=249046

Reviewed by Brian Weinstein.

Also tweak some methods based on review feedback.

* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtension.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtension.mm:
(-[_WKWebExtension defaultLocale]): Added.
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm:
(-[_WKWebExtensionContext webExtension]):
(-[_WKWebExtensionContext webExtensionController]):
(-[_WKWebExtensionContext extension]): Deleted.
(-[_WKWebExtensionContext extensionController]): Deleted.
(-[_WKWebExtensionContext userGesturePerformedInTab:]): Deleted.
(-[_WKWebExtensionContext cancelUserGestureForTab:]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionController.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionController.mm:
(-[_WKWebExtensionController loadExtensionContext:]): Deleted.
(-[_WKWebExtensionController unloadExtensionContext:]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionControllerConfiguration.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMatchPattern.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMatchPattern.mm:
(-[_WKWebExtensionMatchPattern initWithCoder:]):
(-[_WKWebExtensionMatchPattern initWithString:]): Deleted.
(-[_WKWebExtensionMatchPattern initWithScheme:host:path:]): Deleted.
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionTab.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionWindow.h:

Canonical link: https://commits.webkit.org/257652@main




More information about the webkit-changes mailing list