[webkit-changes] [WebKit/WebKit] b6621f: [Live Range Selection] editing/execCommand/reset-d...

Ryosuke Niwa noreply at github.com
Fri Dec 9 13:38:30 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b6621f17c494d644965239f7d5e79ca2b7cbd1df
      https://github.com/WebKit/WebKit/commit/b6621f17c494d644965239f7d5e79ca2b7cbd1df
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2022-12-09 (Fri, 09 Dec 2022)

  Changed paths:
    A LayoutTests/editing/execCommand/reset-direction-after-breaking-blockquote-live-range-expected.txt
    A LayoutTests/editing/execCommand/reset-direction-after-breaking-blockquote-live-range.html
    M Source/WebCore/editing/BreakBlockquoteCommand.cpp

  Log Message:
  -----------
  [Live Range Selection] editing/execCommand/reset-direction-after-breaking-blockquote.html fails
https://bugs.webkit.org/show_bug.cgi?id=248979

Reviewed by Wenson Hsieh.

The bug was caused by BreakBlockquoteCommand always using the position before breakNode even when the element
in question is a div. In this case, we need to use the first position in div instead.

* LayoutTests/editing/execCommand/reset-direction-after-breaking-blockquote-live-range-expected.txt: Added.
* LayoutTests/editing/execCommand/reset-direction-after-breaking-blockquote-live-range.html: Added.
* Source/WebCore/editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply):

Canonical link: https://commits.webkit.org/257644@main




More information about the webkit-changes mailing list