[webkit-changes] [WebKit/WebKit] 0476db: Drop shouldForceEnclosingCalcInCSSText flag recent...

Chris Dumez noreply at github.com
Fri Dec 9 04:16:05 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0476db43bf13052a41ccd19ef45f2e5f044f714c
      https://github.com/WebKit/WebKit/commit/0476db43bf13052a41ccd19ef45f2e5f044f714c
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2022-12-09 (Fri, 09 Dec 2022)

  Changed paths:
    M Source/WebCore/css/calc/CSSCalcExpressionNode.h
    M Source/WebCore/css/calc/CSSCalcOperationNode.cpp
    M Source/WebCore/css/typedom/CSSUnitValue.cpp

  Log Message:
  -----------
  Drop shouldForceEnclosingCalcInCSSText flag recently added to CSSCalcExpressionNode
https://bugs.webkit.org/show_bug.cgi?id=248966

Reviewed by Antoine Quint.

Drop shouldForceEnclosingCalcInCSSText flag that was recently added to
CSSCalcExpressionNode in 257485 at main. We don't need it, we can simply wrap the
number in a sum to make sure that the surrounding `calc()` isn't dropped during
serialization.

* Source/WebCore/css/calc/CSSCalcExpressionNode.h:
(WebCore::CSSCalcExpressionNode::shouldForceEnclosingCalcInCSSText const): Deleted.
(WebCore::CSSCalcExpressionNode::setShouldForceEnclosingCalcInCSSText): Deleted.
* Source/WebCore/css/calc/CSSCalcOperationNode.cpp:
(WebCore::CSSCalcOperationNode::buildCSSText):
* Source/WebCore/css/typedom/CSSUnitValue.cpp:
(WebCore::CSSUnitValue::toCSSValueWithProperty const):

Canonical link: https://commits.webkit.org/257619@main




More information about the webkit-changes mailing list