[webkit-changes] [WebKit/WebKit] 7a283b: [JSC] Fix X86Assembler namings

Yusuke Suzuki noreply at github.com
Thu Dec 8 21:58:08 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7a283b10d320b433d6ebb1f7dce4df1c5c508059
      https://github.com/WebKit/WebKit/commit/7a283b10d320b433d6ebb1f7dce4df1c5c508059
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2022-12-08 (Thu, 08 Dec 2022)

  Changed paths:
    M Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h
    M Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h
    M Source/JavaScriptCore/assembler/X86Assembler.h

  Log Message:
  -----------
  [JSC] Fix X86Assembler namings
https://bugs.webkit.org/show_bug.cgi?id=249000
rdar://103160841

Reviewed by Ross Kirsling and Justin Michaud.

1. AVX instructions taking three registers should have _rrr postfix.
2. AVX's 0x66 is not PRE_OPERAND_SIZE, coming from PRE_SSE_66.

* Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::addDouble):
(JSC::MacroAssemblerX86Common::addFloat):
(JSC::MacroAssemblerX86Common::subDouble):
(JSC::MacroAssemblerX86Common::subFloat):
(JSC::MacroAssemblerX86Common::mulDouble):
(JSC::MacroAssemblerX86Common::mulFloat):
* Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::compareFloatingPointVector):
(JSC::MacroAssemblerX86_64::compareIntegerVector):
(JSC::MacroAssemblerX86_64::vectorMax):
(JSC::MacroAssemblerX86_64::vectorMin):
(JSC::MacroAssemblerX86_64::vectorAbs):
(JSC::MacroAssemblerX86_64::vectorSignedTruncSatF64):
(JSC::MacroAssemblerX86_64::vectorUnsignedTruncSatF64):
(JSC::MacroAssemblerX86_64::vectorNarrow):
(JSC::MacroAssemblerX86_64::vectorConvertLow):
(JSC::MacroAssemblerX86_64::vectorAddSat):
(JSC::MacroAssemblerX86_64::vectorSubSat):
(JSC::MacroAssemblerX86_64::vectorAvgRound):
(JSC::MacroAssemblerX86_64::vectorMulSat):
(JSC::MacroAssemblerX86_64::vectorSwizzle):
* Source/JavaScriptCore/assembler/X86Assembler.h:
(JSC::X86Assembler::vunpcklps_rrr):
(JSC::X86Assembler::vpshufb_rrr):
(JSC::X86Assembler::vshufps_rrr):
(JSC::X86Assembler::vpaddsb_rrr):
(JSC::X86Assembler::vpaddusb_rrr):
(JSC::X86Assembler::vpaddsw_rrr):
(JSC::X86Assembler::vpaddusw_rrr):
(JSC::X86Assembler::vpsubsb_rrr):
(JSC::X86Assembler::vpsubusb_rrr):
(JSC::X86Assembler::vpsubsw_rrr):
(JSC::X86Assembler::vpsubusw_rrr):
(JSC::X86Assembler::vpmaxsb_rrr):
(JSC::X86Assembler::vpmaxsw_rrr):
(JSC::X86Assembler::vpmaxsd_rrr):
(JSC::X86Assembler::vpmaxub_rrr):
(JSC::X86Assembler::vpmaxuw_rrr):
(JSC::X86Assembler::vpmaxud_rrr):
(JSC::X86Assembler::vpminsb_rrr):
(JSC::X86Assembler::vpminsw_rrr):
(JSC::X86Assembler::vpminsd_rrr):
(JSC::X86Assembler::vpminub_rrr):
(JSC::X86Assembler::vpminuw_rrr):
(JSC::X86Assembler::vpminud_rrr):
(JSC::X86Assembler::vpavgb_rrr):
(JSC::X86Assembler::vpavgw_rrr):
(JSC::X86Assembler::vpxor_rrr):
(JSC::X86Assembler::vpsubq_rrr):
(JSC::X86Assembler::vblendvpd_rrrr):
(JSC::X86Assembler::vpmulhrsw_rrr):
(JSC::X86Assembler::vpcmpeqw_rrr):
(JSC::X86Assembler::vaddpd_rrr):
(JSC::X86Assembler::vpaddb_rrr):
(JSC::X86Assembler::vpaddw_rrr):
(JSC::X86Assembler::vpaddd_rrr):
(JSC::X86Assembler::vpaddq_rrr):
(JSC::X86Assembler::vsubpd_rrr):
(JSC::X86Assembler::vpsubb_rrr):
(JSC::X86Assembler::vpsubw_rrr):
(JSC::X86Assembler::vpsubd_rrr):
(JSC::X86Assembler::vmulpd_rrr):
(JSC::X86Assembler::vpmullw_rrr):
(JSC::X86Assembler::vpmulld_rrr):
(JSC::X86Assembler::vdivpd_rrr):
(JSC::X86Assembler::vroundps_rr):
(JSC::X86Assembler::vroundpd_rr):
(JSC::X86Assembler::vpmaddwd_rrr):
(JSC::X86Assembler::vpcmpeqb_rrr):
(JSC::X86Assembler::vpcmpeqd_rrr):
(JSC::X86Assembler::vpcmpeqq_rrr):
(JSC::X86Assembler::vpcmpgtb_rrr):
(JSC::X86Assembler::vpcmpgtw_rrr):
(JSC::X86Assembler::vpcmpgtd_rrr):
(JSC::X86Assembler::vpcmpgtq_rrr):
(JSC::X86Assembler::vcmpps_rrr):
(JSC::X86Assembler::vcmppd_rrr):
(JSC::X86Assembler::vxorpd_rrr):
(JSC::X86Assembler::vmaxpd_rrr):
(JSC::X86Assembler::vminpd_rrr):
(JSC::X86Assembler::vcmpeqpd_rrr):
(JSC::X86Assembler::vandpd_rrr):
(JSC::X86Assembler::vpacksswb_rrr):
(JSC::X86Assembler::vpackuswb_rrr):
(JSC::X86Assembler::vpackssdw_rrr):
(JSC::X86Assembler::vpackusdw_rrr):
(JSC::X86Assembler::vaddsd_rrr):
(JSC::X86Assembler::vaddss_rrr):
(JSC::X86Assembler::vmulsd_rrr):
(JSC::X86Assembler::vmulss_rrr):
(JSC::X86Assembler::vsubsd_rrr):
(JSC::X86Assembler::vsubss_rrr):
(JSC::X86Assembler::vunpcklps_rr): Deleted.
(JSC::X86Assembler::vpshufb_rr): Deleted.
(JSC::X86Assembler::vshufps_rr): Deleted.
(JSC::X86Assembler::vpaddsb_rr): Deleted.
(JSC::X86Assembler::vpaddusb_rr): Deleted.
(JSC::X86Assembler::vpaddsw_rr): Deleted.
(JSC::X86Assembler::vpaddusw_rr): Deleted.
(JSC::X86Assembler::vpsubsb_rr): Deleted.
(JSC::X86Assembler::vpsubusb_rr): Deleted.
(JSC::X86Assembler::vpsubsw_rr): Deleted.
(JSC::X86Assembler::vpsubusw_rr): Deleted.
(JSC::X86Assembler::vpmaxsb_rr): Deleted.
(JSC::X86Assembler::vpmaxsw_rr): Deleted.
(JSC::X86Assembler::vpmaxsd_rr): Deleted.
(JSC::X86Assembler::vpmaxub_rr): Deleted.
(JSC::X86Assembler::vpmaxuw_rr): Deleted.
(JSC::X86Assembler::vpmaxud_rr): Deleted.
(JSC::X86Assembler::vpminsb_rr): Deleted.
(JSC::X86Assembler::vpminsw_rr): Deleted.
(JSC::X86Assembler::vpminsd_rr): Deleted.
(JSC::X86Assembler::vpminub_rr): Deleted.
(JSC::X86Assembler::vpminuw_rr): Deleted.
(JSC::X86Assembler::vpminud_rr): Deleted.
(JSC::X86Assembler::vpavgb_rr): Deleted.
(JSC::X86Assembler::vpavgw_rr): Deleted.
(JSC::X86Assembler::vpxor_rr): Deleted.
(JSC::X86Assembler::vpsubq_rr): Deleted.
(JSC::X86Assembler::vblendvpd_rr): Deleted.
(JSC::X86Assembler::vpmulhrsw_rr): Deleted.
(JSC::X86Assembler::vpcmpeqw_rr): Deleted.
(JSC::X86Assembler::vpcmpeqb_rr): Deleted.
(JSC::X86Assembler::vpcmpeqd_rr): Deleted.
(JSC::X86Assembler::vpcmpeqq_rr): Deleted.
(JSC::X86Assembler::vpcmpgtb_rr): Deleted.
(JSC::X86Assembler::vpcmpgtw_rr): Deleted.
(JSC::X86Assembler::vpcmpgtd_rr): Deleted.
(JSC::X86Assembler::vpcmpgtq_rr): Deleted.
(JSC::X86Assembler::vcmpps_rr): Deleted.
(JSC::X86Assembler::vcmppd_rr): Deleted.
(JSC::X86Assembler::vsubpd_rr): Deleted.
(JSC::X86Assembler::vxorpd_rr): Deleted.
(JSC::X86Assembler::vmaxpd_rr): Deleted.
(JSC::X86Assembler::vminpd_rr): Deleted.
(JSC::X86Assembler::vaddpd_rr): Deleted.
(JSC::X86Assembler::vcmpeqpd_rr): Deleted.
(JSC::X86Assembler::vandpd_rr): Deleted.
(JSC::X86Assembler::vpacksswb_rr): Deleted.
(JSC::X86Assembler::vpackuswb_rr): Deleted.
(JSC::X86Assembler::vpackssdw_rr): Deleted.
(JSC::X86Assembler::vpackusdw_rr): Deleted.
(JSC::X86Assembler::vaddsd_rr): Deleted.
(JSC::X86Assembler::vaddss_rr): Deleted.
(JSC::X86Assembler::vmulsd_rr): Deleted.
(JSC::X86Assembler::vmulss_rr): Deleted.
(JSC::X86Assembler::vsubsd_rr): Deleted.
(JSC::X86Assembler::vsubss_rr): Deleted.

Canonical link: https://commits.webkit.org/257610@main




More information about the webkit-changes mailing list