[webkit-changes] [WebKit/WebKit] 8c5897: [macOS UI-side compositing] Fix hit-testing in ifr...
Simon Fraser
noreply at github.com
Thu Dec 8 12:16:53 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8c589785e316b6a54022eee297868e5cc939dedb
https://github.com/WebKit/WebKit/commit/8c589785e316b6a54022eee297868e5cc939dedb
Author: Simon Fraser <simon.fraser at apple.com>
Date: 2022-12-08 (Thu, 08 Dec 2022)
Changed paths:
M Source/WebCore/inspector/InspectorOverlay.cpp
M Source/WebCore/page/FrameView.cpp
M Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp
M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
Log Message:
-----------
[macOS UI-side compositing] Fix hit-testing in iframes (and some other things)
https://bugs.webkit.org/show_bug.cgi?id=248930
rdar://103080262
Reviewed by Tim Horton.
With UI-side compositing on macOS, events in iframes were offset because
`FrameView::convertFromContainingViewToRenderer()` failed to do the
`viewToContents()` conversion; checking `delegatesScrollingToNativeView()` fixes that.
Other fixes are noted below.
* Source/WebCore/inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::drawRulers): Fixed drawing of rules in scrolled content.
* Source/WebCore/page/FrameView.cpp:
(WebCore::FrameView::viewRectExpandedByContentInsets const): Follow the same code
path as macOS
(WebCore::FrameView::contentsResized): We rely on the scrollbar-related code path.
(WebCore::FrameView::computeScrollability const): We rely on the scrollbar-related code path.
(WebCore::FrameView::convertFromContainingViewToRenderer const): Fixes event coordinates in subframes.
(WebCore::FrameView::handleWheelEventForScrolling): Fixes wheel event handling.
* Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::convertRectFromFrameClientToRootView): Follow the same code path as FrameView.
(WebKit::convertPointFromFrameClientToRootView): Ditto
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::contentsSizeChanged const): Ditto
Canonical link: https://commits.webkit.org/257581@main
More information about the webkit-changes
mailing list