[webkit-changes] [WebKit/WebKit] 5f18c2: REGRESSION: File attachment icons appear upside down

Richard Robinson noreply at github.com
Wed Dec 7 17:16:09 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5f18c2a38b4330fc150979b68b1f94a6f72d1110
      https://github.com/WebKit/WebKit/commit/5f18c2a38b4330fc150979b68b1f94a6f72d1110
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2022-12-07 (Wed, 07 Dec 2022)

  Changed paths:
    M Source/WebCore/rendering/RenderThemeMac.mm

  Log Message:
  -----------
  REGRESSION: File attachment icons appear upside down
https://bugs.webkit.org/show_bug.cgi?id=248910
rdar://103089779

Reviewed by Simon Fraser.

Prior to https://github.com/WebKit/WebKit/pull/4954, attachment icons on macOS
were flipped in `IconMac` to preserve the correct orientation, however this
change removed that behavior in its refactoring.

This PR fixes this by adding back the flipping behavior where its needed
for attachemnts, which is in `RenderThemeMac::iconForAttachment`.

* Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::iconForAttachment):

Canonical link: https://commits.webkit.org/257524@main




More information about the webkit-changes mailing list