[webkit-changes] [WebKit/WebKit] a3b7a9: JSC options should check consistency after all opt...

Justin Michaud noreply at github.com
Wed Dec 7 09:59:17 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a3b7a9916a5322f641e2ad1ab1331c55bf5a9221
      https://github.com/WebKit/WebKit/commit/a3b7a9916a5322f641e2ad1ab1331c55bf5a9221
  Author: Justin Michaud <justin_michaud at apple.com>
  Date:   2022-12-07 (Wed, 07 Dec 2022)

  Changed paths:
    M Source/JavaScriptCore/jsc.cpp
    M Source/JavaScriptCore/runtime/Options.cpp
    M Source/JavaScriptCore/runtime/Options.h

  Log Message:
  -----------
  JSC options should check consistency after all options have been set.
https://bugs.webkit.org/show_bug.cgi?id=248843

Reviewed by Yusuke Suzuki.

Debug tests are failing because we validate options too early. The JSC
shell should wait until all command line options have been set before
validating that they are valid together.

* Source/JavaScriptCore/jsc.cpp:
(CommandLine::parseArguments):
* Source/JavaScriptCore/runtime/Options.cpp:
(JSC::Options::setOptionWithoutAlias):
(JSC::Options::setAliasedOption):
(JSC::Options::setOption):
* Source/JavaScriptCore/runtime/Options.h:

Canonical link: https://commits.webkit.org/257491@main




More information about the webkit-changes mailing list