[webkit-changes] [WebKit/WebKit] a2cdee: CoreIPC should be explicit about which methods can...

[Gavin]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a2cdee91de828a710f4329f60ae4a6d795d82d0d
      https://github.com/WebKit/WebKit/commit/a2cdee91de828a710f4329f60ae4a6d795d82d0d
  Author: Gavin Phillips <gavin.p at apple.com>
  Date:   2022-12-07 (Wed, 07 Dec 2022)

  Changed paths:
    M LayoutTests/ipc/pasteboard-write-custom-data.html
    M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.messages.in
    M Source/WebKit/GPUProcess/GPUProcess.messages.in
    M Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.messages.in
    M Source/WebKit/NetworkProcess/NetworkProcess.messages.in
    M Source/WebKit/Platform/IPC/Connection.cpp
    M Source/WebKit/Platform/IPC/Connection.h
    M Source/WebKit/Platform/IPC/Decoder.cpp
    M Source/WebKit/Platform/IPC/Decoder.h
    M Source/WebKit/Platform/IPC/Encoder.cpp
    M Source/WebKit/Platform/IPC/Encoder.h
    M Source/WebKit/Scripts/webkit/messages.py
    M Source/WebKit/Scripts/webkit/model.py
    M Source/WebKit/Scripts/webkit/tests/MessageNames.cpp
    M Source/WebKit/Scripts/webkit/tests/MessageNames.h
    M Source/WebKit/UIProcess/WebPageProxy.messages.in
    M Source/WebKit/UIProcess/WebProcessProxy.messages.in
    M Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.messages.in

  Log Message:
  -----------
  CoreIPC should be explicit about which methods can be called when WaitingForSyncReply

https://bugs.webkit.org/show_bug.cgi?id=247673
rdar://102134965

Reviewed by Alex Christensen.

CoreIPC should be explicit about which methods can be called when
WaitingForSyncReply. This change adds a new message attribute,
AllowedWhenWaitingForSyncReply, which specifies a message should be allowed.
Any messages which don't have this attribute will be queued as normal.
[Reland]

* LayoutTests/ipc/pasteboard-write-custom-data.html:
* Source/WebKit/GPUProcess/GPUConnectionToWebProcess.messages.in:
* Source/WebKit/GPUProcess/GPUProcess.messages.in:
* Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.messages.in:
* Source/WebKit/NetworkProcess/NetworkProcess.messages.in:
* Source/WebKit/Platform/IPC/Connection.cpp:
(IPC::Connection::sendMessage):
(IPC::Connection::processIncomingMessage):
* Source/WebKit/Platform/IPC/Connection.h:
* Source/WebKit/Platform/IPC/Decoder.cpp:
(IPC::Decoder::unwrapForTesting):
* Source/WebKit/Platform/IPC/Decoder.h:
(IPC::Decoder::isAllowedWhenWaitingForSyncReply const):
(IPC::Decoder::isAllowedWhenWaitingForUnboundedSyncReply const):
(IPC::Decoder::setIsAllowedWhenWaitingForSyncReplyOverride):
* Source/WebKit/Platform/IPC/Encoder.cpp:
(IPC::Encoder::isFullySynchronousModeForTesting const):
* Source/WebKit/Platform/IPC/Encoder.h:
* Source/WebKit/Scripts/webkit/messages.py:
(generate_message_names_header):
(generate_message_names_implementation):
* Source/WebKit/Scripts/webkit/model.py:
* Source/WebKit/Scripts/webkit/tests/MessageNames.cpp:
(IPC::messageAllowedWhenWaitingForSyncReply):
(IPC::messageAllowedWhenWaitingForUnboundedSyncReply):
* Source/WebKit/Scripts/webkit/tests/MessageNames.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/UIProcess/WebProcessProxy.messages.in:
* Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp:
(WebKit::IPCTestingAPI::sendMessageWithJSArguments):
(WebKit::IPCTestingAPI::JSIPCStreamClientConnection::sendMessage):
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:

Canonical link: https://commits.webkit.org/257469@main