[webkit-changes] [WebKit/WebKit] a1197f: Remove Quirk for shouldAutoplayForArbitraryUserGes...

[Karl Dubost]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a1197f89b028684053b8ef59c3e88babed27493a
      https://github.com/WebKit/WebKit/commit/a1197f89b028684053b8ef59c3e88babed27493a
  Author: Karl Dubost <karlcow at apple.com>
  Date:   2022-12-06 (Tue, 06 Dec 2022)

  Changed paths:
    M LayoutTests/media/media-usage-state-expected.txt
    M LayoutTests/media/media-usage-state.html
    M Source/WebCore/PAL/pal/cocoa/UsageTrackingSoftLink.h
    M Source/WebCore/PAL/pal/cocoa/UsageTrackingSoftLink.mm
    M Source/WebCore/html/MediaElementSession.cpp
    M Source/WebCore/page/Quirks.cpp
    M Source/WebCore/page/Quirks.h
    M Source/WebCore/platform/graphics/MediaUsageInfo.h
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/Internals.h
    M Source/WebCore/testing/Internals.idl
    M Source/WebKit/UIProcess/Media/cocoa/MediaUsageManagerCocoa.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm

  Log Message:
  -----------
  Remove Quirk for shouldAutoplayForArbitraryUserGesture
https://bugs.webkit.org/show_bug.cgi?id=248199
<rdar://102743471>

Reviewed by Eric Carlson.

The quirk is not needed anymore. Probably the way the way
twitter and facebook embed videos has changed. This has been tested
on Safari 15.5 and Safari Technical Preview 158, with Site Specific
Hacks disabled.

* LayoutTests/media/media-usage-state-expected.txt:
* LayoutTests/media/media-usage-state.html:
* Source/WebCore/html/MediaElementSession.cpp:
(WebCore::MediaElementSession::playbackStateChangePermitted const):
(WebCore::MediaElementSession::updateMediaUsageIfChanged):
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldAutoplayForArbitraryUserGesture const): Deleted.
* Source/WebCore/page/Quirks.h:
* Source/WebCore/PAL/pal/cocoa/UsageTrackingSoftLink.h:
* Source/WebCore/PAL/pal/cocoa/UsageTrackingSoftLink.mm:
* Source/WebCore/platform/graphics/MediaUsageInfo.h:
(WebCore::MediaUsageInfo::operator== const):
(WebCore::MediaUsageInfo::encode const):
(WebCore::MediaUsageInfo::decode):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::mediaUsageState const):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
* Source/WebKit/UIProcess/Media/cocoa/MediaUsageManagerCocoa.mm:
(WebKit::usageTrackingAvailable):
(WebKit::MediaUsageManagerCocoa::updateMediaUsage):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:

Canonical link: https://commits.webkit.org/257451@main