[webkit-changes] [WebKit/WebKit] 097054: Reland refactoring for <attachment> from r255903
Nikos Mouchtaris
noreply at github.com
Tue Dec 6 16:45:58 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0970540b2a228dd58910b1d4f9b9fa137bcd2511
https://github.com/WebKit/WebKit/commit/0970540b2a228dd58910b1d4f9b9fa137bcd2511
Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
Date: 2022-12-06 (Tue, 06 Dec 2022)
Changed paths:
M Source/WebCore/SourcesCocoa.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
A Source/WebCore/rendering/AttachmentLayout.h
M Source/WebCore/rendering/RenderTheme.cpp
M Source/WebCore/rendering/RenderTheme.h
M Source/WebCore/rendering/RenderThemeCocoa.h
M Source/WebCore/rendering/RenderThemeCocoa.mm
M Source/WebCore/rendering/RenderThemeIOS.h
M Source/WebCore/rendering/RenderThemeIOS.mm
M Source/WebCore/rendering/RenderThemeMac.h
M Source/WebCore/rendering/RenderThemeMac.mm
Log Message:
-----------
Reland refactoring for <attachment> from r255903
https://bugs.webkit.org/show_bug.cgi?id=248796
<rdar://103000899>
Unreviewed reland.
Reland refactoring from r255903. Will leave out
the icon specific additions from r255903 while investigating
the cause for icon flipping in Mail compose.
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/rendering/AttachmentLayout.h: Added.
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
* Source/WebCore/rendering/RenderTheme.h:
(WebCore::RenderTheme::paintAttachmentText):
* Source/WebCore/rendering/RenderThemeCocoa.h:
* Source/WebCore/rendering/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::attachmentBaseline const):
(WebCore::RenderThemeCocoa::paintAttachmentText):
* Source/WebCore/rendering/RenderThemeIOS.h:
* Source/WebCore/rendering/RenderThemeIOS.mm:
(WebCore::paintAttachmentIcon):
(WebCore::paintAttachmentProgress):
(WebCore::attachmentBorderPath):
(WebCore::RenderThemeIOS::paintAttachment):
(WebCore::attachmentActionFont): Deleted.
(WebCore::attachmentActionColor): Deleted.
(WebCore::attachmentTitleFont): Deleted.
(WebCore::shortCaptionPointSizeWithContentSizeCategory): Deleted.
(WebCore::attachmentDynamicTypeScaleFactor): Deleted.
(WebCore::attachmentTitleColor): Deleted.
(WebCore::attachmentSubtitleFont): Deleted.
(WebCore::attachmentSubtitleColor): Deleted.
(WebCore::RenderAttachmentInfo::addLine): Deleted.
(WebCore::RenderAttachmentInfo::buildWrappedLines): Deleted.
(WebCore::RenderAttachmentInfo::buildSingleLine): Deleted.
(WebCore::getAttachmentProgress): Deleted.
(WebCore::RenderAttachmentInfo::RenderAttachmentInfo): Deleted.
(WebCore::RenderThemeIOS::attachmentBaseline const): Deleted.
(WebCore::paintAttachmentText): Deleted.
* Source/WebCore/rendering/RenderThemeMac.h:
* Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintAttachment):
(WebCore::titleTextColorForAttachment): Deleted.
(WebCore::AttachmentLayout::addTitleLine): Deleted.
(WebCore::AttachmentLayout::layOutTitle): Deleted.
(WebCore::AttachmentLayout::layOutSubtitle): Deleted.
(WebCore::AttachmentLayout::AttachmentLayout): Deleted.
(WebCore::RenderThemeMac::attachmentBaseline const): Deleted.
(WebCore::paintAttachmentTitle): Deleted.
(WebCore::paintAttachmentSubtitle): Deleted.
Canonical link: https://commits.webkit.org/257448@main
More information about the webkit-changes
mailing list