[webkit-changes] [WebKit/WebKit] 7db4da: Button elements are clipping overflow by default

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7db4da203517ad5d8bfdc28593054beedbad2a74
      https://github.com/WebKit/WebKit/commit/7db4da203517ad5d8bfdc28593054beedbad2a74
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2022-12-06 (Tue, 06 Dec 2022)

  Changed paths:
    M LayoutTests/fast/forms/control-clip-overflow.html
    M LayoutTests/fast/forms/control-clip.html
    M LayoutTests/platform/gtk/fast/forms/control-clip-expected.png
    M LayoutTests/platform/gtk/fast/forms/control-clip-expected.txt
    M LayoutTests/platform/gtk/fast/forms/control-clip-overflow-expected.png
    M LayoutTests/platform/gtk/fast/forms/control-clip-overflow-expected.txt
    M LayoutTests/platform/ios/fast/forms/control-clip-expected.txt
    M LayoutTests/platform/ios/fast/forms/control-clip-overflow-expected.txt
    M LayoutTests/platform/mac/fast/forms/control-clip-expected.png
    M LayoutTests/platform/mac/fast/forms/control-clip-expected.txt
    M LayoutTests/platform/mac/fast/forms/control-clip-overflow-expected.png
    M LayoutTests/platform/mac/fast/forms/control-clip-overflow-expected.txt
    M Source/WebCore/rendering/RenderButton.cpp
    M Source/WebCore/rendering/RenderButton.h

  Log Message:
  -----------
  Button elements are clipping overflow by default

Button elements are clipping overflow by default
https://bugs.webkit.org/show_bug.cgi?id=173872

Reviewed by Aditya Keerthi.

This patch is to align Webkit with Gecko / Firefox and Blink / Chromium.

Merge - https://src.chromium.org/viewvc/blink?view=revision&revision=193213

By default, the button element has clipping overflow and it is not aligned with web
and causes webcompat issues (e.g., http://nydailynews.com (see the feedback button)).

* Source/WebCore/rendering/RenderButton.cpp:
(RenderButton::hasControlClip): Add new function
* Source/WebCore/rendering/RenderButton.h: Update "hasControlClip" to not return
true by default
* LayoutTests/fast/forms/control-clip.html: Rebaselined
* LayoutTests/fast/forms/control-clip-overflow.html: Rebaselined
* LayoutTests/platform/gtk/fast/forms/control-clip-expected.png: Rebaselined
* LayoutTests/platform/gtk/fast/forms/control-clip-expected.txt: Rebaselined
* LayoutTests/platform/gtk/fast/forms/control-clip-overflow-expected.png: Rebaselined
* LayoutTests/platform/gtk/fast/forms/control-clip-overflow-expected.txt: Rebaselined
* LayoutTests/platform/ios/fast/forms/control-clip-expected.txt: Rebaselined
* LayoutTests/platform/ios/fast/forms/control-clip-overflow-expected.txt: Rebaselined
* LayoutTests/platform/mac/fast/forms/control-clip-expected.png: Rebaselined
* LayoutTests/platform/mac/fast/forms/control-clip-expected.txt: Rebaselined
* LayoutTests/platform/mac/fast/forms/control-clip-overflow-expected.png: Rebaselined
* LayoutTests/platform/mac/fast/forms/control-clip-overflow-expected.txt: Rebaselined

Canonical link: https://commits.webkit.org/257439@main