[webkit-changes] [WebKit/WebKit] 6bfc06: REGRESSION (255664 at main): Unable to toggle Lockdow...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6bfc06607bbc2da4f1a32cbeab3bdedeb070df33
      https://github.com/WebKit/WebKit/commit/6bfc06607bbc2da4f1a32cbeab3bdedeb070df33
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2022-12-06 (Tue, 06 Dec 2022)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/_WKSystemPreferencesInternal.h
    M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
    M Source/WebKit/UIProcess/WebProcessPool.h

  Log Message:
  -----------
  REGRESSION (255664 at main): Unable to toggle Lockdown Mode through privacy settings
https://bugs.webkit.org/show_bug.cgi?id=248819

Reviewed by Chris Dumez and Brent Fulgham.

* Source/WebKit/UIProcess/API/Cocoa/_WKSystemPreferencesInternal.h:

Change the string value back to `"WKCaptivePortalModeContainerConfigurationChanged"`, since it's the
name of the notification that's dispatched when toggling the preference in privacy settings;
additionally, add a brief comment clarifying this.

* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::lockdownModeConfigurationUpdateCallback):

Drive-by fix: rename `lockdownModeConfigUpdateCallback` to `lockdownModeConfigurationUpdateCallback`
to align with WebKit style guidelines (full names over abbreviations).

(WebKit::WebProcessPool::registerNotificationObservers):
(WebKit::WebProcessPool::lockdownModeConfigUpdateCallback): Deleted.
* Source/WebKit/UIProcess/WebProcessPool.h:

Canonical link: https://commits.webkit.org/257436@main