[webkit-changes] [WebKit/WebKit] 30f0d4: Fix -Wtype-limits warning on mips

aoikonomopoulos noreply at github.com
Tue Dec 6 08:01:15 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 30f0d48dee99d3348df11e3b0d28e96313b5b631
      https://github.com/WebKit/WebKit/commit/30f0d48dee99d3348df11e3b0d28e96313b5b631
  Author: Angelos Oikonomopoulos <angelos at igalia.com>
  Date:   2022-12-06 (Tue, 06 Dec 2022)

  Changed paths:
    M Source/JavaScriptCore/jit/CCallHelpers.h

  Log Message:
  -----------
  Fix -Wtype-limits warning on mips
https://bugs.webkit.org/show_bug.cgi?id=248593

Reviewed by Mark Lam.

When setupStubCrossArgs is instantiated with NumCrossSources == 0, we
get
    warning: comparison of unsigned expression in ‘< 0’ is always false [-Wtype-limits]

Don't enter the loop if NumCrossSources is 0. We still need to mark the
parameters unused in the NumCrossSources == 0 path, to avoid
-Wunused-but-set-parameter warnings.

* Source/JavaScriptCore/jit/CCallHelpers.h:
(JSC::CCallHelpers::setupStubCrossArgs):

Canonical link: https://commits.webkit.org/257409@main




More information about the webkit-changes mailing list