[webkit-changes] [WebKit/WebKit] ab1162: Remove "pagination line grid" SPI
Antti Koivisto
noreply at github.com
Mon Dec 5 08:12:21 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ab116278c13504605c78ac58f342de7899691a19
https://github.com/WebKit/WebKit/commit/ab116278c13504605c78ac58f342de7899691a19
Author: Antti Koivisto <antti at apple.com>
Date: 2022-12-05 (Mon, 05 Dec 2022)
Changed paths:
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/style/StyleResolveForDocument.cpp
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
M Source/WebKit/Shared/WebPageCreationParameters.cpp
M Source/WebKit/Shared/WebPageCreationParameters.h
M Source/WebKit/UIProcess/API/C/WKPage.cpp
M Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Source/WebKitLegacy/mac/WebView/WebView.mm
Log Message:
-----------
Remove "pagination line grid" SPI
https://bugs.webkit.org/show_bug.cgi?id=248759
rdar://102975657
Reviewed by Alan Baradlay.
This SPI was implemented for Books (rdar://23041598) but never adopted (rdar://25075170).
* Source/WebCore/page/Page.cpp:
(WebCore::Page::setPaginationLineGridEnabled): Deleted.
* Source/WebCore/page/Page.h:
(WebCore::Page::paginationLineGridEnabled const): Deleted.
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
* Source/WebCore/style/StyleResolveForDocument.cpp:
(WebCore::Style::resolveForDocument):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setPaginationLineGridEnabled): Deleted.
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
* Source/WebKit/Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):
* Source/WebKit/Shared/WebPageCreationParameters.h:
* Source/WebKit/UIProcess/API/C/WKPage.cpp:
(WKPageSetPaginationLineGridEnabled):
(WKPageGetPaginationLineGridEnabled):
* Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController setPaginationLineGridEnabled:]):
(-[WKBrowsingContextController paginationLineGridEnabled]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _paginationLineGridEnabled]):
(-[WKWebView _setPaginationLineGridEnabled:]):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::setPaginationLineGridEnabled): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_appHighlightsVisible):
(WebKit::WebPage::setPaginationLineGridEnabled): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Source/WebKitLegacy/mac/WebView/WebView.mm:
(-[WebView _setPaginationLineGridEnabled:]):
(-[WebView _paginationLineGridEnabled]):
Leave stubs in place as clients may still be calling these with NO value.
Canonical link: https://commits.webkit.org/257372@main
More information about the webkit-changes
mailing list