[webkit-changes] [WebKit/WebKit] 81f661: [GTK][WPE] Add WebKitWebFormManager and deprecate ...

Carlos Garcia Campos noreply at github.com
Mon Dec 5 01:54:39 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 81f661ea4d757aa254c322965cba2c1e7881491f
      https://github.com/WebKit/WebKit/commit/81f661ea4d757aa254c322965cba2c1e7881491f
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2022-12-05 (Mon, 05 Dec 2022)

  Changed paths:
    M Source/WebKit/PlatformGTK.cmake
    M Source/WebKit/PlatformWPE.cmake
    M Source/WebKit/SourcesGTK.txt
    M Source/WebKit/SourcesWPE.txt
    M Source/WebKit/WebProcess/InjectedBundle/API/glib/DOM/WebKitDOMElement.cpp
    M Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitFrame.cpp
    M Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitFramePrivate.h
    A Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebFormManager.cpp
    A Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebFormManager.h.in
    A Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebFormManagerPrivate.h
    M Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp
    M Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.h.in
    M Source/WebKit/WebProcess/InjectedBundle/API/glib/webkit-web-extension.h.in
    M Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.h
    M Source/WebKit/WebProcess/InjectedBundle/API/wpe/DOM/WebKitDOMElement.h
    M Tools/TestWebKitAPI/Tests/WebKitGLib/DOMElementTest.cpp
    M Tools/TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp
    M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp
    M Tools/TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp
    M Tools/TestWebKitAPI/glib/TestExpectations.json

  Log Message:
  -----------
  [GTK][WPE] Add WebKitWebFormManager and deprecate WebKitWebPage form related signals and WebKitDOMElement
https://bugs.webkit.org/show_bug.cgi?id=248657

Reviewed by Michael Catanzaro.

Move the form signals from WebKitWebPage to WebKitWebFormManager that no longer uses WebKitDOMElement, but JSCValue.

* Source/WebKit/PlatformGTK.cmake:
* Source/WebKit/PlatformWPE.cmake:
* Source/WebKit/SourcesGTK.txt:
* Source/WebKit/SourcesWPE.txt:
* Source/WebKit/WebProcess/InjectedBundle/API/glib/DOM/WebKitDOMElement.cpp:
* Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitFrame.cpp:
(webkitFrameGetJSCValueForElementInWorld):
(webkitFrameGetJSCValuesForElementsInWorld):
* Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitFramePrivate.h:
* Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebFormManager.cpp: Added.
(webkit_web_form_manager_class_init):
(webkitWebFormManagerCreate):
(webkitWebFormManagerDidAssociateFormControls):
(webkitWebFormManagerWillSendSubmitEvent):
(webkitWebFormManagerWillSubmitForm):
(nodeForJSCValue):
(webkit_web_form_manager_input_element_is_user_edited):
(webkit_web_form_manager_input_element_auto_fill):
(webkit_web_form_manager_input_element_is_auto_filled):
* Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebFormManager.h.in: Added.
* Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebFormManagerPrivate.h: Added.
* Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp:
(worldDestroyed):
(webkitWebPageDispose):
(webkit_web_page_class_init):
(webkit_web_page_get_form_manager):
* Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.h.in:
* Source/WebKit/WebProcess/InjectedBundle/API/glib/webkit-web-extension.h.in:
* Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.h:
* Tools/TestWebKitAPI/Tests/WebKitGLib/DOMElementTest.cpp:
(DOMElementTest::testAutoFill):
* Tools/TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
(WebKitFrameTest::testJavaScriptValues):
(WebKitFrameTest::willSubmitFormCallback):
(WebKitFrameTest::testSubframe):
* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
(didAssociateFormControlsCallback):
(testWebExtensionFormControlsAssociated):
* Tools/TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
(formControlsAssociatedForFrameCallback):
(formControlsAssociatedCallback):
(willSubmitFormDeprecatedCallback):
(handleFormSubmissionCallback):
(willSendSubmitEventCallback):
(willSubmitFormCallback):
(pageCreatedCallback):
(windowObjectCleared):
(methodCallCallback):
(webkit_web_extension_initialize_with_user_data):
* Tools/TestWebKitAPI/glib/TestExpectations.json:

Canonical link: https://commits.webkit.org/257366@main




More information about the webkit-changes mailing list