[webkit-changes] [WebKit/WebKit] 97a80f: [SIMD] Refactor X86Assembler.h: All destinations s...

[Yijia Huang]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 97a80fa6aa7871c1aa1ef75c7e2598b5aa72cc44
      https://github.com/WebKit/WebKit/commit/97a80fa6aa7871c1aa1ef75c7e2598b5aa72cc44
  Author: Yijia Huang <hyjorc1 at gmail.com>
  Date:   2022-12-03 (Sat, 03 Dec 2022)

  Changed paths:
    M Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h
    M Source/JavaScriptCore/assembler/X86Assembler.h

  Log Message:
  -----------
  [SIMD] Refactor X86Assembler.h: All destinations should be on the right side.
https://bugs.webkit.org/show_bug.cgi?id=248703
rdar://102938073

Reviewed by Yusuke Suzuki.

Follow X86Assembler's convention and use AT&T syntax.

* JSTests/wasm/stress/simd-kitchen-sink.js:
(v128.const.f32x4.0x0p.0.0x0p.0.0x0p.0.0x0p.0.async test):
(1.4.3.4.3.16.6144_q15.i16x8.extract_lane_s.0.return.func.export.string_appeared_here.result.i32.v128.not.v128.const.i32x4.0.0.0.0.i32x4.eq.v128.const.i32x4.1.1.1.1.i32x4.extract_lane.0.return.func.export.string_appeared_here.param.i32.result.i32.i8x16.extract_lane_s.15.i8x16.splat.local.0.func.export.string_appeared_here.param.i32.i32.i32.i32.result.i32.local.0.i32.const.257.local.1.i32.const.128.local.2.i32.const.16.local.3.i32.const.16.i16x8.mul.v128.const.i16x8.16.16.16.16.16.16.16.16.v128.const.i16x8.16.16.16.16.16.16.16.16.i32x4.extract_lane.0.func.export.string_appeared_here.param.i.i32.result.i32.global.g.i32x4.splat.local.i.i32x4.extract_lane.0.global.g.return.func.export.string_appeared_here.param.address.i32.result.i64.local.ret.i64.v128.store8_lane.align.1.4.local.address.v128.const.i8x16.0.0.0.0.4.0.0.0.0.0.0.0.0.0.0.0.local.ret.i64.load.local.address.v128.store.offset.4.i32.const.0.global.zero.local.ret.func.export.string_appeared_here.result.i32.v128.const.f64x2.2147483647.0.2147483647.0.i32x4.trunc_sat_f64x2_s_zero.i32x4.extract_lane.0.func.export.string_appeared_here.result.i32.i8x16.bitmask.v128.const.i8x16.0xFF.0xFF.0xFF.0xFF.0xFF.0xFF.0xFF.0xFF.0xFF.0xFF.0xFF.0xFF.0xFF.0xFF.0xFF.0xFF.func.export.string_appeared_here.result.i32.i8x16.bitmask.v128.const.i8x16.1.0.1.2.3.4.5.6.7.8.9.0xA.0xB.0xC.0xD.0xF.func.export.string_appeared_here.result.f64.f64x2.extract_lane.0.f64x2.convert_low_i32x4_s.v128.const.i32x4.2147483647.2147483647.0.0.func.export.string_appeared_here.result.f32.f32x4.extract_lane.0.f32x4.pmin.v128.const.f32x4.0x0p.0.0x0p.0.0x0p.0.0x0p.0.v128.const.f32x4.0x0p.0.0x0p.0.0x0p.0.0x0p.0.async test): Deleted.
* Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::vectorReplaceLane):
(JSC::MacroAssemblerX86_64::vectorExtractLane):
(JSC::MacroAssemblerX86_64::vectorSplat):
* Source/JavaScriptCore/assembler/X86Assembler.h:
(JSC::X86Assembler::pinsr):
(JSC::X86Assembler::pextr):
(JSC::X86Assembler::vextractps):
(JSC::X86Assembler::pshufd):
(JSC::X86Assembler::pshufb):
(JSC::X86Assembler::pshuflw):
(JSC::X86Assembler::pshufhw):
(JSC::X86Assembler::punpcklqdq):
(JSC::X86Assembler::shufps):
(JSC::X86Assembler::shufpd):
(JSC::X86Assembler::X86InstructionFormatter::SingleInstructionBufferWriter::memoryModRM):

Canonical link: https://commits.webkit.org/257342@main