[webkit-changes] [WebKit/WebKit] dd9462: [IFC] Introduce LineBoxBuilder::setLayoutBoundsFor...
Alan Baradlay
noreply at github.com
Sat Dec 3 15:05:15 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: dd9462dc28e5f2cabcf590aea8be9a845cdfa1db
https://github.com/WebKit/WebKit/commit/dd9462dc28e5f2cabcf590aea8be9a845cdfa1db
Author: Alan Baradlay <zalan at apple.com>
Date: 2022-12-03 (Sat, 03 Dec 2022)
Changed paths:
M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h
Log Message:
-----------
[IFC] Introduce LineBoxBuilder::setLayoutBoundsForInlineBox
https://bugs.webkit.org/show_bug.cgi?id=248610
Reviewed by Antti Koivisto.
Move "layout bounds" logic to a dedicated function. It is in preparation for
supporting "text-edge" where the property values directly impact the computed "layout bounds" value.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::primaryFontMetricsForInlineBox): line gap and preferred line height are only needed for the leading computation. Remove them from the struct.
(WebCore::Layout::LineBoxBuilder::setLayoutBoundsForInlineBox const):
(WebCore::Layout::LineBoxBuilder::setVerticalPropertiesForInlineLevelBox const): move rounding from the callers to the callee.
(WebCore::Layout::LineBoxBuilder::adjustInlineBoxHeightsForLineBoxContainIfApplicable):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h:
Canonical link: https://commits.webkit.org/257334@main
More information about the webkit-changes
mailing list