[webkit-changes] [WebKit/WebKit] 943d09: [leading-trim][IFC] Ignore positive half leading w...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 943d096899a0684ff913cebce62d2e64cef774e0
      https://github.com/WebKit/WebKit/commit/943d096899a0684ff913cebce62d2e64cef774e0
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2022-12-03 (Sat, 03 Dec 2022)

  Changed paths:
    A LayoutTests/fast/text/text-edge-no-half-leading-with-line-height-simple-expected-mismatch.html
    A LayoutTests/fast/text/text-edge-no-half-leading-with-line-height-simple.html
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp

  Log Message:
  -----------
  [leading-trim][IFC] Ignore positive half leading when line-height is not 'normal'
https://bugs.webkit.org/show_bug.cgi?id=248571

Reviewed by Antti Koivisto.

https://www.w3.org/TR/css-inline-3/#inline-height

Reset the computed half-leading value when it is greater than 0 for line-heigh: "not normal" cases. It ensures that we don't add extra spacing between lines when text-edge is not leading.

* LayoutTests/fast/text/text-edge-no-half-leading-with-line-height-simple-expected-mismatch.html: Added.
* LayoutTests/fast/text/text-edge-no-half-leading-with-line-height-simple.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::LineBoxBuilder::setVerticalPropertiesForInlineLevelBox const):

Canonical link: https://commits.webkit.org/257322@main