[webkit-changes] [WebKit/WebKit] 3f4765: Make the debug assertion in AuxiliaryProcess::regi...

Wenson Hsieh noreply at github.com
Fri Dec 2 22:50:03 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3f4765beb0bdcc287d626d2818c04f631cd2058b
      https://github.com/WebKit/WebKit/commit/3f4765beb0bdcc287d626d2818c04f631cd2058b
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2022-12-02 (Fri, 02 Dec 2022)

  Changed paths:
    M Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm

  Log Message:
  -----------
  Make the debug assertion in AuxiliaryProcess::registerWithStateDumper more descriptive
https://bugs.webkit.org/show_bug.cgi?id=248696

Reviewed by Simon Fraser.

Use `ASSERT_NOT_REACHED_WITH_MESSAGE` instead of a regular `ASSERT`, so that:
1. The intent (to exit immediately in debug) is more explicit, and also:
2. To include a descriptive message containing the serialization error in the crash log.

* Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm:
(WebKit::AuxiliaryProcess::registerWithStateDumper):

Canonical link: https://commits.webkit.org/257317@main




More information about the webkit-changes mailing list