[webkit-changes] [WebKit/WebKit] b1c063: testdriver-vendor.js could use a cleanup + type an...
Marcos Cáceres
noreply at github.com
Fri Dec 2 22:03:22 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b1c0630822f90f6aeb042a2010dd3f0adeb3031e
https://github.com/WebKit/WebKit/commit/b1c0630822f90f6aeb042a2010dd3f0adeb3031e
Author: Marcos Caceres <marcos at marcosc.com>
Date: 2022-12-02 (Fri, 02 Dec 2022)
Changed paths:
M LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js
Log Message:
-----------
testdriver-vendor.js could use a cleanup + type annotations
https://bugs.webkit.org/show_bug.cgi?id=248379
Reviewed by Tim Nguyen.
Adds TypeScript type annotations to testdriver-vendor.js and cleans up the code a bit:
* Let the JS engine handle throwing for any missing methods/properties.
* Geolocation now only emits a single location, and only when permission is "granted".
Previously, the latter was causing compounding position objects to be emitted, which would confuse various tests.
* LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js:
(logDebug):
(async dispatchMouseActions):
(window.test_driver_internal.action_sequence):
(async switch):
(window.test_driver_internal.set_permission):
(async context):
(window.test_driver_internal.minimize_window):
(async if):
(window.test_driver_internal.set_window_rect):
(await.new.Promise): Deleted.
Canonical link: https://commits.webkit.org/257315@main
More information about the webkit-changes
mailing list