[webkit-changes] [WebKit/WebKit] e54fe8: [leading-trim][IFC] Only incorporate half leading ...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e54fe8f852c144385ebc7b29e2f55e9fa5e2d829
      https://github.com/WebKit/WebKit/commit/e54fe8f852c144385ebc7b29e2f55e9fa5e2d829
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2022-12-02 (Fri, 02 Dec 2022)

  Changed paths:
    A LayoutTests/fast/text/text-edge-no-half-leading-simple-expected-mismatch.html
    A LayoutTests/fast/text/text-edge-no-half-leading-simple.html
    M Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp

  Log Message:
  -----------
  [leading-trim][IFC] Only incorporate half leading when text-edge is leading (line-height normal edition)
https://bugs.webkit.org/show_bug.cgi?id=248514

Reviewed by Antti Koivisto.

https://www.w3.org/TR/css-inline-3/#inline-height
If line-height computes to normal and either text-edge is leading or this is the root inline box,
the font’s line gap metric may also be incorporated into A and D by adding half to each side as half-leading.

* LayoutTests/fast/text/text-edge-no-half-leading-simple-expected-mismatch.html: Added.
* LayoutTests/fast/text/text-edge-no-half-leading-simple.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h:
(WebCore::Layout::InlineLevelBox::textEdge const):
(WebCore::Layout::m_style):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::isTextEdgeLeading):
(WebCore::Layout::LineBoxBuilder::setVerticalPropertiesForInlineLevelBox const):

Canonical link: https://commits.webkit.org/257314@main