[webkit-changes] [WebKit/WebKit] f91e41: Masonry repeat(auto-fit) should behave as repeat(a...

Brandon Stewart noreply at github.com
Fri Dec 2 12:03:53 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f91e41a89ed67eb51626018c4c485931375876f5
      https://github.com/WebKit/WebKit/commit/f91e41a89ed67eb51626018c4c485931375876f5
  Author: Brandon Stewart <brandonstewart at apple.com>
  Date:   2022-12-02 (Fri, 02 Dec 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/masonry-grid-template-columns-computed-withcontent.html
    M Source/WebCore/rendering/RenderGrid.cpp
    M Source/WebCore/rendering/RenderGrid.h

  Log Message:
  -----------
  Masonry repeat(auto-fit) should behave as repeat(auto-fill)
https://bugs.webkit.org/show_bug.cgi?id=248577

Reviewed by Brent Fulgham.

Masonry repeat(auto-fit) should have the properities of repeat(auto-fill) according to the spec.
https://drafts.csswg.org/css-grid-3/#repeat-auto-fit

Update WPT test case for auto-fit to behave the same as auto-fill.

* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/masonry-grid-template-columns-computed-withcontent.html:
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeEmptyTracksForAutoRepeat const):
(WebCore::RenderGrid::isMasonryRows const):
(WebCore::RenderGrid::isMasonryColumns const):
(WebCore::RenderGrid::autoRepeatColumnsType const):
(WebCore::RenderGrid::autoRepeatRowsType const):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::gridAreaBreadthForChildIncludingAlignmentOffsets const):
(WebCore::RenderGrid::columnAxisOffsetForChild const):
(WebCore::RenderGrid::rowAxisOffsetForChild const):
(WebCore::isMasonryRows): Deleted.
(WebCore::isMasonryColumns): Deleted.
* Source/WebCore/rendering/RenderGrid.h:

Canonical link: https://commits.webkit.org/257300@main




More information about the webkit-changes mailing list