[webkit-changes] [WebKit/WebKit] 0a9f42: [cssom] Fix serialization for 'marker' shorthand

Oriol Brufau noreply at github.com
Fri Dec 2 05:50:42 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0a9f425ac8ebf7e8991d438a4b599e4f6c7fe2f1
      https://github.com/WebKit/WebKit/commit/0a9f425ac8ebf7e8991d438a4b599e4f6c7fe2f1
  Author: Oriol Brufau <obrufau at igalia.com>
  Date:   2022-12-02 (Fri, 02 Dec 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssom-getPropertyValue-common-checks-expected.txt
    M Source/WebCore/css/StyleProperties.cpp

  Log Message:
  -----------
  [cssom] Fix serialization for 'marker' shorthand
https://bugs.webkit.org/show_bug.cgi?id=248308

Reviewed by Tim Nguyen.

Serializing 'marker' at specified-value time would just provide the
value for 'marker-start', without ensuring that 'marker-mid' and
'marker-end' were also set to the same value.

Now, if 'marker' can't represent the values for the 3 longhands, it will
serilize as empty string. And then I don't see the need to disallow
'marker' in cssText.

* LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssom-getPropertyValue-common-checks-expected.txt:
* Source/WebCore/css/StyleProperties.cpp:
(WebCore::StyleProperties::getPropertyValue const):
(WebCore::canUseShorthandForLonghand):

Canonical link: https://commits.webkit.org/257282@main




More information about the webkit-changes mailing list