[webkit-changes] [WebKit/WebKit] f7a887: AX: Include AXKeyShortcutsValue in accessibilityAt...

[Tommy McHugh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f7a887f4c25742af054956aec6cf2ef5c2512e14
      https://github.com/WebKit/WebKit/commit/f7a887f4c25742af054956aec6cf2ef5c2512e14
  Author: Tommy McHugh <thomas_mchugh at apple.com>
  Date:   2022-12-01 (Thu, 01 Dec 2022)

  Changed paths:
    A LayoutTests/accessibility/aria-keyshortcuts-expected.txt
    A LayoutTests/accessibility/aria-keyshortcuts.html
    M LayoutTests/platform/glib/TestExpectations
    M LayoutTests/platform/win/TestExpectations
    M Source/WebCore/accessibility/AXLogger.cpp
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/AccessibilityObjectInterface.h
    M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

  Log Message:
  -----------
  AX: Include AXKeyShortcutsValue in accessibilityAttributeNames when there is an aria-keyshortcuts attribute
https://bugs.webkit.org/show_bug.cgi?id=248572
rdar://problem/102834471

Reviewed by Andres Gonzalez.

WebAccessibilityObjectWrapper supports returning the value of aria-keyshortcuts
through the AXKeyShortcutsValue accessibility attribute, but does not return the
attribute name in accessibilityAttributeNames if it is a supported attribute.
Additionally, this attribute is not updated in the isolated tree if it is changed.
This patch fixes that by including AXKeyShortcutsValue in accessibilityAttributeNames if it
is supported through AccessibilityObject::supportsKeyShortcutsValue and updates the AXIsolatedTree
value for AXPropertyName::KeyShortcutsValue if aria-keyshortcuts attribute is changed.

* LayoutTests/accessibility/aria-keyshortcuts-expected.txt: Added.
* LayoutTests/accessibility/aria-keyshortcuts.html: Added.
* LayoutTests/platform/win/TestExpectations:
* Source/WebCore/accessibility/AXLogger.cpp:
(WebCore::operator<<):
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::AXObjectCache::updateIsolatedTree):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::supportsKeyShortcuts const):
(WebCore::AccessibilityObject::keyShortcuts const):
(WebCore::AccessibilityObject::keyShortcutsValue const): Deleted.
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/AccessibilityObjectInterface.h:
* Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp:
(WebCore::AccessibilityObjectAtspi::attributes const):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeProperties):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateNodeProperties):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

Canonical link: https://commits.webkit.org/257274@main