[webkit-changes] [WebKit/WebKit] 652501: Remove needsBlackFullscreenBackgroundQuirk

Karl Dubost noreply at github.com
Thu Dec 1 22:54:18 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6525018e7c182a59c811dfe4e5f37e606ebf89be
      https://github.com/WebKit/WebKit/commit/6525018e7c182a59c811dfe4e5f37e606ebf89be
  Author: Karl Dubost <karlcow at apple.com>
  Date:   2022-12-01 (Thu, 01 Dec 2022)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/compositing/no-compositing-when-fulll-screen-is-present-expected.txt
    M LayoutTests/platform/gtk/compositing/no-compositing-when-fulll-screen-is-present-expected.txt
    M Source/WebCore/css/fullscreen.css
    M Source/WebCore/page/Quirks.cpp
    M Source/WebCore/page/Quirks.h
    M Source/WebCore/rendering/RenderTheme.h
    M Source/WebCore/style/UserAgentStyle.cpp

  Log Message:
  -----------
  Remove needsBlackFullscreenBackgroundQuirk
https://bugs.webkit.org/show_bug.cgi?id=248323
rdar://102653160

Reviewed by Tim Nguyen.

This is removing the mlb.com quirk which was needed when
the background was white. Backdrop will take over.
A simple change to allow the fake backdrop to take effect.
SeeAlso https://github.com/WebKit/WebKit/pull/6021/files
This also aligns WebKit with Gecko for the fullscreen
background.
Further fixes will be made in
https://github.com/WebKit/WebKit/pull/6688
https://bugs.webkit.org/show_bug.cgi?id=248148

* LayoutTests/TestExpectations:
* LayoutTests/compositing/no-compositing-when-fulll-screen-is-present-expected.txt:
* LayoutTests/platform/gtk/compositing/no-compositing-when-fulll-screen-is-present-expected.txt:
* Source/WebCore/css/fullscreen.css:
(:-webkit-full-screen):
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::needsBlackFullscreenBackgroundQuirk const): Deleted.
* Source/WebCore/page/Quirks.h:
* Source/WebCore/rendering/RenderTheme.h:
(WebCore::RenderTheme::extraFullScreenStyleSheet): Deleted.
* Source/WebCore/style/UserAgentStyle.cpp:
(WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement):

Canonical link: https://commits.webkit.org/257271@main




More information about the webkit-changes mailing list