[webkit-changes] [WebKit/WebKit] cf2a6c: Update m_grid(Columns/Rows) variable names to m_gr...

Brandon Stewart noreply at github.com
Thu Dec 1 17:27:30 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cf2a6c50ae69fa59d1d8aaaf424fe668e8a66898
      https://github.com/WebKit/WebKit/commit/cf2a6c50ae69fa59d1d8aaaf424fe668e8a66898
  Author: Brandon Stewart <brandonstewart at apple.com>
  Date:   2022-12-01 (Thu, 01 Dec 2022)

  Changed paths:
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
    M Source/WebCore/rendering/RenderGrid.cpp
    M Source/WebCore/rendering/style/GridPositionsResolver.cpp
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/StyleGridData.cpp
    M Source/WebCore/rendering/style/StyleGridData.h

  Log Message:
  -----------
  Update m_grid(Columns/Rows) variable names to m_grid(Column/Row)TrackSizes
https://bugs.webkit.org/show_bug.cgi?id=248613

Reviewed by Simon Fraser.

Small clarification on variable name. Based on some discussion
we found the m_gridColumns name a little confusing on what it was actually storing.
This is storing GridTrackSize, so it is just holding the track sizes.

* Source/WebCore/rendering/style/StyleGridData.cpp:
(WebCore::StyleGridData::StyleGridData):
(WebCore::StyleGridData::setRows):
(WebCore::StyleGridData::setColumns):
* Source/WebCore/rendering/style/StyleGridData.h:
(WebCore::StyleGridData::gridColumns const):
(WebCore::StyleGridData::gridRows const):

Canonical link: https://commits.webkit.org/257262@main




More information about the webkit-changes mailing list