[webkit-changes] [WebKit/WebKit] 7f50b6: Potential Crash fix by not propagating empty value...

Ahmad Saleem noreply at github.com
Thu Dec 1 11:52:40 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7f50b6d09b385b564a7e9733687178ac0d2692c8
      https://github.com/WebKit/WebKit/commit/7f50b6d09b385b564a7e9733687178ac0d2692c8
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2022-12-01 (Thu, 01 Dec 2022)

  Changed paths:
    A LayoutTests/fast/css/font-face-attribute-remove-expected.html
    A LayoutTests/fast/css/font-face-attribute-remove.html
    M Source/WebCore/html/HTMLFontElement.cpp

  Log Message:
  -----------
  Potential Crash fix by not propagating empty value for face attribute

Potential Crash fix by not propagating empty value for face attribute
https://bugs.webkit.org/show_bug.cgi?id=248434

Reviewed by Tim Nguyen.

Merge - https://src.chromium.org/viewvc/blink?view=revision&revision=190788

This patch is to add check to ensure that "faceAttr" is not null / empty value and such values are not propagated to lead to stability issues (i.e., crashes).

* Source/WebCore/html/HTMLFontElement.cpp:
(HTMLFontElement::collectPresentationalHintsForAttribute): Add check for empty / null values
* LayoutTests/fast/css/font-face-attribute-remove.html: Add Test Case
* LayoutTests/fast/css/font-face-attribute-remove-expected.html: Add Test Case Expectation

Canonical link: https://commits.webkit.org/257248@main




More information about the webkit-changes mailing list