[webkit-changes] [WebKit/WebKit] 808fe7: Avoid potential CAFenceHandle invalidation issue a...

Cameron McCormack noreply at github.com
Thu Dec 1 09:31:19 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 808fe7d3ce9961043f7011493579ac2eec4a2a00
      https://github.com/WebKit/WebKit/commit/808fe7d3ce9961043f7011493579ac2eec4a2a00
  Author: Cameron McCormack <heycam at apple.com>
  Date:   2022-12-01 (Thu, 01 Dec 2022)

  Changed paths:
    M LayoutTests/platform/ios-wk2/TestExpectations
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm

  Log Message:
  -----------
  Avoid potential CAFenceHandle invalidation issue and re-enable model tests
https://bugs.webkit.org/show_bug.cgi?id=237070
rdar://89325947

Reviewed by Antoine Quint.

>From EWS runs it looks like these tests are no longer causing crashes.

But the stack from those previous crashes leads me to believe that it
could be skipping invalidating the CAFenceHandle when
modelElementSizeDidChange's main thread task returns early might have
been the cause.

* LayoutTests/platform/ios-wk2/TestExpectations:
* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm:
(WebKit::ModelElementController::modelElementSizeDidChange):

Canonical link: https://commits.webkit.org/257243@main




More information about the webkit-changes mailing list