[webkit-changes] [WebKit/WebKit] 7429a6: Branch WebKitGTK+ for 2.2
Carlos Garcia Campos
noreply at github.com
Thu Dec 1 08:07:08 PST 2022
Branch: refs/heads/webkitgtk/2.2
Home: https://github.com/WebKit/WebKit
Commit: 7429a6b52e798fcdca7d6f535d2dbc39d1bdb086
https://github.com/WebKit/WebKit/commit/7429a6b52e798fcdca7d6f535d2dbc39d1bdb086
Author: Carlos Garcia Campos <carlosgc at webkit.org>
Date: 2013-08-27 (Tue, 27 Aug 2013)
Changed paths:
Log Message:
-----------
Branch WebKitGTK+ for 2.2
Commit: d8946862bfbf49813e5deaa25860728ccfee77bc
https://github.com/WebKit/WebKit/commit/d8946862bfbf49813e5deaa25860728ccfee77bc
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2013-08-27 (Tue, 27 Aug 2013)
Changed paths:
M Tools/ChangeLog
M Tools/TestWebKitAPI/GNUmakefile.am
Log Message:
-----------
Merge r154668 - Unreviewed. Fix GTK+ build after r154601.
* TestWebKitAPI/GNUmakefile.am: Remove mac specific file from
compilation added by mistake in r154601.
Commit: 36e6819b8b57648add9a93d6dcfbb936f07821f6
https://github.com/WebKit/WebKit/commit/36e6819b8b57648add9a93d6dcfbb936f07821f6
Author: Carlos Garcia Campos <carlosgc at webkit.org>
Date: 2013-08-27 (Tue, 27 Aug 2013)
Changed paths:
M LayoutTests/ChangeLog
R LayoutTests/fast/js/Promise-already-fulfilled-expected.txt
R LayoutTests/fast/js/Promise-already-fulfilled.html
R LayoutTests/fast/js/Promise-already-rejected-expected.txt
R LayoutTests/fast/js/Promise-already-rejected.html
R LayoutTests/fast/js/Promise-already-resolved-expected.txt
R LayoutTests/fast/js/Promise-already-resolved.html
R LayoutTests/fast/js/Promise-catch-expected.txt
R LayoutTests/fast/js/Promise-catch-in-workers-expected.txt
R LayoutTests/fast/js/Promise-catch-in-workers.html
R LayoutTests/fast/js/Promise-catch.html
R LayoutTests/fast/js/Promise-chain-expected.txt
R LayoutTests/fast/js/Promise-chain.html
R LayoutTests/fast/js/Promise-exception-expected.txt
R LayoutTests/fast/js/Promise-exception.html
R LayoutTests/fast/js/Promise-expected.txt
R LayoutTests/fast/js/Promise-fulfill-expected.txt
R LayoutTests/fast/js/Promise-fulfill-in-workers-expected.txt
R LayoutTests/fast/js/Promise-fulfill-in-workers.html
R LayoutTests/fast/js/Promise-fulfill.html
R LayoutTests/fast/js/Promise-init-expected.txt
R LayoutTests/fast/js/Promise-init-in-workers-expected.txt
R LayoutTests/fast/js/Promise-init-in-workers.html
R LayoutTests/fast/js/Promise-init.html
R LayoutTests/fast/js/Promise-reject-expected.txt
R LayoutTests/fast/js/Promise-reject-in-workers-expected.txt
R LayoutTests/fast/js/Promise-reject-in-workers.html
R LayoutTests/fast/js/Promise-reject.html
R LayoutTests/fast/js/Promise-resolve-chain-expected.txt
R LayoutTests/fast/js/Promise-resolve-chain.html
R LayoutTests/fast/js/Promise-resolve-expected.txt
R LayoutTests/fast/js/Promise-resolve-in-workers-expected.txt
R LayoutTests/fast/js/Promise-resolve-in-workers.html
R LayoutTests/fast/js/Promise-resolve-with-then-exception-expected.txt
R LayoutTests/fast/js/Promise-resolve-with-then-exception.html
R LayoutTests/fast/js/Promise-resolve-with-then-fulfill-expected.txt
R LayoutTests/fast/js/Promise-resolve-with-then-fulfill.html
R LayoutTests/fast/js/Promise-resolve-with-then-reject-expected.txt
R LayoutTests/fast/js/Promise-resolve-with-then-reject.html
R LayoutTests/fast/js/Promise-resolve.html
R LayoutTests/fast/js/Promise-simple-expected.txt
R LayoutTests/fast/js/Promise-simple-fulfill-expected.txt
R LayoutTests/fast/js/Promise-simple-fulfill-inside-callback-expected.txt
R LayoutTests/fast/js/Promise-simple-fulfill-inside-callback.html
R LayoutTests/fast/js/Promise-simple-fulfill.html
R LayoutTests/fast/js/Promise-simple-in-workers-expected.txt
R LayoutTests/fast/js/Promise-simple-in-workers.html
R LayoutTests/fast/js/Promise-simple.html
R LayoutTests/fast/js/Promise-static-fulfill-expected.txt
R LayoutTests/fast/js/Promise-static-fulfill.html
R LayoutTests/fast/js/Promise-static-reject-expected.txt
R LayoutTests/fast/js/Promise-static-reject.html
R LayoutTests/fast/js/Promise-static-resolve-expected.txt
R LayoutTests/fast/js/Promise-static-resolve.html
R LayoutTests/fast/js/Promise-then-expected.txt
R LayoutTests/fast/js/Promise-then-in-workers-expected.txt
R LayoutTests/fast/js/Promise-then-in-workers.html
R LayoutTests/fast/js/Promise-then-without-callbacks-expected.txt
R LayoutTests/fast/js/Promise-then-without-callbacks-in-workers-expected.txt
R LayoutTests/fast/js/Promise-then-without-callbacks-in-workers.html
R LayoutTests/fast/js/Promise-then-without-callbacks.html
R LayoutTests/fast/js/Promise-then.html
R LayoutTests/fast/js/Promise-types-expected.txt
R LayoutTests/fast/js/Promise-types.html
R LayoutTests/fast/js/Promise.html
R LayoutTests/fast/js/resources/Promise-catch-in-workers.js
R LayoutTests/fast/js/resources/Promise-fulfill-in-workers.js
R LayoutTests/fast/js/resources/Promise-init-in-workers.js
R LayoutTests/fast/js/resources/Promise-reject-in-workers.js
R LayoutTests/fast/js/resources/Promise-resolve-in-workers.js
R LayoutTests/fast/js/resources/Promise-simple-in-workers.js
R LayoutTests/fast/js/resources/Promise-then-in-workers.js
R LayoutTests/fast/js/resources/Promise-then-without-callbacks-in-workers.js
M Source/JavaScriptCore/CMakeLists.txt
M Source/JavaScriptCore/ChangeLog
M Source/JavaScriptCore/DerivedSources.make
M Source/JavaScriptCore/DerivedSources.pri
M Source/JavaScriptCore/GNUmakefile.list.am
M Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj
M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
M Source/JavaScriptCore/Target.pri
M Source/JavaScriptCore/interpreter/CallFrame.h
M Source/JavaScriptCore/jsc.cpp
M Source/JavaScriptCore/runtime/CommonIdentifiers.h
M Source/JavaScriptCore/runtime/JSGlobalObject.cpp
M Source/JavaScriptCore/runtime/JSGlobalObject.h
R Source/JavaScriptCore/runtime/JSPromise.cpp
R Source/JavaScriptCore/runtime/JSPromise.h
R Source/JavaScriptCore/runtime/JSPromiseCallback.cpp
R Source/JavaScriptCore/runtime/JSPromiseCallback.h
R Source/JavaScriptCore/runtime/JSPromiseConstructor.cpp
R Source/JavaScriptCore/runtime/JSPromiseConstructor.h
R Source/JavaScriptCore/runtime/JSPromisePrototype.cpp
R Source/JavaScriptCore/runtime/JSPromisePrototype.h
R Source/JavaScriptCore/runtime/JSPromiseResolver.cpp
R Source/JavaScriptCore/runtime/JSPromiseResolver.h
R Source/JavaScriptCore/runtime/JSPromiseResolverConstructor.cpp
R Source/JavaScriptCore/runtime/JSPromiseResolverConstructor.h
R Source/JavaScriptCore/runtime/JSPromiseResolverPrototype.cpp
R Source/JavaScriptCore/runtime/JSPromiseResolverPrototype.h
M Source/JavaScriptCore/runtime/VM.cpp
M Source/JavaScriptCore/runtime/VM.h
M Source/WebCore/ChangeLog
M Source/WebCore/GNUmakefile.list.am
M Source/WebCore/Target.pri
M Source/WebCore/UseJSC.cmake
M Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
M Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/bindings/js/JSBindingsAllInOne.cpp
R Source/WebCore/bindings/js/JSDOMGlobalObjectTask.cpp
R Source/WebCore/bindings/js/JSDOMGlobalObjectTask.h
M Source/WebCore/bindings/js/JSDOMWindowBase.cpp
M Source/WebCore/bindings/js/JSDOMWindowBase.h
M Source/WebCore/bindings/js/JSMainThreadExecState.h
M Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.cpp
M Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.h
Log Message:
-----------
Revert "Add support for Promises"
This reverts commit bd7606974ee8b78a8c53ccb635ea24234e8575f4.
This is a experimental feature added without a feature define.
Commit: f90b43fc73f35d24d577ebd11326bf6393cea71d
https://github.com/WebKit/WebKit/commit/f90b43fc73f35d24d577ebd11326bf6393cea71d
Author: Xabier Rodriguez-Calvar <calvaris at igalia.com>
Date: 2013-08-27 (Tue, 27 Aug 2013)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/platform/gtk/RenderThemeGtk.cpp
Log Message:
-----------
Merge r154666 - [GTK] Volume slider shows incorrect track when muted
https://bugs.webkit.org/show_bug.cgi?id=120253
Reviewed by Philippe Normand.
When painting the volume bar, consider that it could be muted even
then volume is different than zero.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack): Asign
painted volume as 0 when media is muted.
Commit: 4435fdcaed728a5d9314e207a6b63d914041e604
https://github.com/WebKit/WebKit/commit/4435fdcaed728a5d9314e207a6b63d914041e604
Author: Carlos Garcia Campos <carlosgc at webkit.org>
Date: 2013-08-27 (Tue, 27 Aug 2013)
Changed paths:
M ChangeLog
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/NEWS
M Source/autotools/Versions.m4
Log Message:
-----------
Unreviewed. Update NEWS and Versions.m4 for 2.1.90 release.
.:
* Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
* NEWS: Add release notes.
Commit: bb2fdff1a912f76845699a9c71ecbf75c1f80176
https://github.com/WebKit/WebKit/commit/bb2fdff1a912f76845699a9c71ecbf75c1f80176
Author: Gustavo Noronha Silva <kov at webkit.org>
Date: 2013-08-28 (Wed, 28 Aug 2013)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp
M Source/WebCore/bindings/gobject/WebKitDOMCustom.h
Log Message:
-----------
Merge 154786 - [GTK] HTMLElement lost setID and getID - need to add compatibility symbols
https://bugs.webkit.org/show_bug.cgi?id=120440
Reviewed by Martin Robinson.
No tests, just adding compatibility symbols.
setID and getID were removed, and the parent class (Element) ones should be used instead.
We need to keep our ABI compatible, though, so add compatibility symbols.
* bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_html_element_get_id):
(webkit_dom_html_element_set_id):
* bindings/gobject/WebKitDOMCustom.h:
Commit: 90f89084f6d20ac686af8712c43f8d442e5f375c
https://github.com/WebKit/WebKit/commit/90f89084f6d20ac686af8712c43f8d442e5f375c
Author: Gustavo Noronha Silva <kov at webkit.org>
Date: 2013-08-28 (Wed, 28 Aug 2013)
Changed paths:
M ChangeLog
M configure.ac
Log Message:
-----------
Merge 154787 - [GTK] Enable maintainer mode configure switch
https://bugs.webkit.org/show_bug.cgi?id=120424
Reviewed by Martin Robinson.
The maintainer mode feature is used by ostree and other automated builders to ensure no autotools
regeneration will happen for a regular tarball build; ostree builders, for instance, are very
conservative with toolchain upgrades, and are still using aclocal 1.12. WebKit's latest tarball
(2.1.90) for some reason tries to regenerate build files, and the build fails because it can't find
the version of aclocal that was used for generating the tarball (1.13).
* configure.ac: enable maintainer mode feature.
Commit: 322849da8031d079cc7ee9ea0cd59fffa2c33b98
https://github.com/WebKit/WebKit/commit/322849da8031d079cc7ee9ea0cd59fffa2c33b98
Author: Christian Kirbach <Christian.Kirbach at googlemail.com>
Date: 2013-08-28 (Wed, 28 Aug 2013)
Changed paths:
M Source/WebCore/platform/gtk/po/ChangeLog
M Source/WebCore/platform/gtk/po/de.po
Log Message:
-----------
Merge 154791 - [GTK] Please incorporate German translation update
https://bugs.webkit.org/show_bug.cgi?id=120016
Patch by Christian Kirbach <Christian.Kirbach at googlemail.com> on 2013-08-28
Reviewed by Gustavo Noronha.
* de.po: updated.
Commit: 7aa5480d7eeaa9df08f65b20e2b5631a09631ec0
https://github.com/WebKit/WebKit/commit/7aa5480d7eeaa9df08f65b20e2b5631a09631ec0
Author: Gustavo Noronha Silva <kov at webkit.org>
Date: 2013-08-29 (Thu, 29 Aug 2013)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/bindings/gobject/WebKitDOMCustom.h
Log Message:
-----------
Merge 154794 - Unreviewed build fix - copy/paste failure, copied too much.
* bindings/gobject/WebKitDOMCustom.h:
Commit: 7452ff1d9a0254422ab70de885b6953b4ba0ef2c
https://github.com/WebKit/WebKit/commit/7452ff1d9a0254422ab70de885b6953b4ba0ef2c
Author: Gustavo Noronha Silva <kov at webkit.org>
Date: 2013-08-29 (Thu, 29 Aug 2013)
Changed paths:
M ChangeLog
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/NEWS
M Source/autotools/Versions.m4
M configure.ac
Log Message:
-----------
Unreviewed. Update NEWS and Versions.m4 for 2.1.90.1 release.
.:
* Source/autotools/Versions.m4: bump to 2.1.90.1.
* configure.ac: Add webkit_patch_version to AC_INIT call.
Sources/WebKit/gtk:
* NEWS: Add release notes.
Commit: 3dc7e15853365d4149e906aa9da725d2a9f308a1
https://github.com/WebKit/WebKit/commit/3dc7e15853365d4149e906aa9da725d2a9f308a1
Author: Andre Moreira Magalhaes <andre.magalhaes at collabora.co.uk>
Date: 2013-09-08 (Sun, 08 Sep 2013)
Changed paths:
M Source/WebCore/ChangeLog
Log Message:
-----------
Adjust internal size on gstreamer source element when receiving data if necessary
https://bugs.webkit.org/show_bug.cgi?id=116534
Patch by Andre Moreira Magalhaes <andre.magalhaes at collabora.co.uk> on 2013-06-19
Reviewed by Philippe Normand.
If the size received in didReceiveResponse is smaller than the actual size of the received data
update the internal size and the appsrc size to the proper value.
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient::didReceiveData):
Commit: 0fae4ec768bbac3f47b950a5212a1c786e33f532
https://github.com/WebKit/WebKit/commit/0fae4ec768bbac3f47b950a5212a1c786e33f532
Author: Andre Moreira Magalhaes <andre.magalhaes at collabora.co.uk>
Date: 2013-09-08 (Sun, 08 Sep 2013)
Changed paths:
M Source/WTF/ChangeLog
M Source/WTF/GNUmakefile.list.am
A Source/WTF/wtf/gobject/GMutexLocker.h
M Source/WebCore/ChangeLog
M Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp
Log Message:
-----------
Merge r154683 - [gstreamer] Make sure gstreamer source element is thread-safe
https://bugs.webkit.org/show_bug.cgi?id=115352
Patch by Andre Moreira Magalhaes <andre.magalhaes at collabora.co.uk> on 2013-08-27
Reviewed by Philippe Normand.
Source/WebCore:
GStreamer source element may be created by any gstreamer element on any thread by calling
gst_element_make_from_uri with the URIs handled by the source element.
This patch makes sure the gstreamer source element is thread-safe to avoid issues with it
being created outside the main thread.
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_init):
(webKitWebSrcDispose):
(webKitWebSrcFinalize):
(webKitWebSrcSetProperty):
(webKitWebSrcGetProperty):
(removeTimeoutSources):
(webKitWebSrcStop):
(webKitWebSrcStart):
(webKitWebSrcChangeState):
(webKitWebSrcQueryWithParent):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri):
(webKitWebSrcNeedDataMainCb):
(webKitWebSrcNeedDataCb):
(webKitWebSrcEnoughDataMainCb):
(webKitWebSrcEnoughDataCb):
(webKitWebSrcSeekMainCb):
(webKitWebSrcSeekDataCb):
(webKitWebSrcSetMediaPlayer):
(StreamingClient::StreamingClient):
(StreamingClient::~StreamingClient):
(StreamingClient::createReadBuffer):
(StreamingClient::handleResponseReceived):
(StreamingClient::handleDataReceived):
(StreamingClient::handleNotifyFinished):
(CachedResourceStreamingClient::CachedResourceStreamingClient):
(CachedResourceStreamingClient::~CachedResourceStreamingClient):
(CachedResourceStreamingClient::loadFailed):
(CachedResourceStreamingClient::setDefersLoading):
(CachedResourceStreamingClient::getOrCreateReadBuffer):
(CachedResourceStreamingClient::responseReceived):
(CachedResourceStreamingClient::dataReceived):
(CachedResourceStreamingClient::notifyFinished):
(ResourceHandleStreamingClient::ResourceHandleStreamingClient):
(ResourceHandleStreamingClient::~ResourceHandleStreamingClient):
(ResourceHandleStreamingClient::loadFailed):
(ResourceHandleStreamingClient::setDefersLoading):
(ResourceHandleStreamingClient::getOrCreateReadBuffer):
(ResourceHandleStreamingClient::willSendRequest):
(ResourceHandleStreamingClient::didReceiveResponse):
(ResourceHandleStreamingClient::didReceiveData):
(ResourceHandleStreamingClient::didFinishLoading):
(ResourceHandleStreamingClient::didFail):
(ResourceHandleStreamingClient::wasBlocked):
(ResourceHandleStreamingClient::cannotShowURL):
Make element thread-safe, add support to use the element without a player associated (e.g.
the DASH plugin using the webkitsrc to download fragments), use GMutexLocker to simplify
locks and other general improvements.
Source/WTF:
Add convenience class that simplifies locking and unlocking a GMutex.
* GNUmakefile.list.am:
* wtf/gobject/GMutexLocker.h: Added.
(WebCore::GMutexLocker::GMutexLocker):
(WebCore::GMutexLocker::~GMutexLocker):
(WebCore::GMutexLocker::lock):
(WebCore::GMutexLocker::unlock):
(WebCore::GMutexLocker::mutex):
Commit: e8aec831ed88bb53aac4eac1160708349e68f138
https://github.com/WebKit/WebKit/commit/e8aec831ed88bb53aac4eac1160708349e68f138
Author: Xabier Rodriguez-Calvar <calvaris at igalia.com>
Date: 2013-09-08 (Sun, 08 Sep 2013)
Changed paths:
M LayoutTests/ChangeLog
A LayoutTests/media/volume-bar-empty-when-muted-expected.txt
A LayoutTests/media/volume-bar-empty-when-muted.html
M Source/WebCore/ChangeLog
M Source/WebCore/html/shadow/MediaControls.cpp
M Source/WebCore/html/shadow/MediaControls.h
M Source/WebCore/html/shadow/MediaControlsApple.cpp
M Source/WebCore/html/shadow/MediaControlsApple.h
M Source/WebCore/html/shadow/MediaControlsBlackBerry.cpp
Log Message:
-----------
Merge r154944 - Volume slider value should be 0 when audio is muted
https://bugs.webkit.org/show_bug.cgi?id=120553
Reviewed by Eric Carlson.
Source/WebCore:
Fixed the problem of showing a non empty slider when audio is
muted.
Test: media/volume-bar-empty-when-muted.html.
* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::reset): Use setSliderVolume.
(WebCore::MediaControls::changedVolume): Use setSliderVolume.
(WebCore::MediaControls::setSliderVolume): Added to set the volume
to 0 when muted and to its value otherwise.
* html/shadow/MediaControls.h: Added setSliderVolume.
* html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::reset): Used setSliderVolume and
setFullscreenSliderVolume.
(WebCore::MediaControlsApple::changedVolume): Used
setFullscreenSliderVolume.
(WebCore::MediaControlsApple::setFullscreenSliderVolume): Added to
set the volume to 0 when muted and to its value otherwise.
* html/shadow/MediaControlsApple.h: Added setFullscreenSliderVolume
* html/shadow/MediaControlsBlackBerry.cpp:
(WebCore::MediaControlsBlackBerry::reset): Used setSliderVolume.
LayoutTests:
Added test to check if the volume slider value is 0 when the
element is muted even if volume is set to something else.
* media/volume-bar-empty-when-muted-expected.txt: Added.
* media/volume-bar-empty-when-muted.html: Added.
Commit: 8e078f749dfd7d92880e8cbcf158de7d583f0cb7
https://github.com/WebKit/WebKit/commit/8e078f749dfd7d92880e8cbcf158de7d583f0cb7
Author: Xabier Rodriguez-Calvar <calvaris at igalia.com>
Date: 2013-09-08 (Sun, 08 Sep 2013)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/html/HTMLMediaElement.h
M Source/WebCore/platform/graphics/MediaPlayer.h
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
Log Message:
-----------
Merge r154970 - [GStreamer] Video player sets system volume to 100%
https://bugs.webkit.org/show_bug.cgi?id=118974
Reviewed by Philippe Normand.
In order to preserve the system volume we need to keep track of
the volume being initialized in the HTMLMediaElement and then just
setting the volume to the sink when initializing the pipeline if
that volume was changed before.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialized
attribute to false.
(WebCore::HTMLMediaElement::setVolume): Set the attribute to true
when volume is changed.
(WebCore::HTMLMediaElement::updateVolume): Set the volume only if
volume was initialized.
(WebCore::HTMLMediaElement::mediaPlayerPlatformVolumeConfigurationRequired):
Platform volume configuration is required only if volume was not
initialized before.
* html/HTMLMediaElement.h: Added attribute and interface method.
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerPlatformVolumeConfigurationRequired):
Declared and added default implementation for the interface method.
(WebCore::MediaPlayer::platformVolumeConfigurationRequired):
Asked the client, meaning the HTMLMediaElement if the platform
volume configuration is required.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::mediaPlayerPrivateVolumeChangedCallback): Added log.
(WebCore::MediaPlayerPrivateGStreamerBase::setVolume): Added log.
(WebCore::MediaPlayerPrivateGStreamerBase::setStreamVolumeElement):
Set the volume only if not platform volume is required and added log.
Commit: 93972946a5f91d71d6d8afaff875fc8432f44361
https://github.com/WebKit/WebKit/commit/93972946a5f91d71d6d8afaff875fc8432f44361
Author: Andre Moreira Magalhaes <andre.magalhaes at collabora.co.uk>
Date: 2013-09-08 (Sun, 08 Sep 2013)
Changed paths:
M LayoutTests/ChangeLog
A LayoutTests/http/tests/media/video-accept-encoding-expected.txt
A LayoutTests/http/tests/media/video-accept-encoding.cgi
A LayoutTests/http/tests/media/video-accept-encoding.html
M Source/WebCore/ChangeLog
M Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp
Log Message:
-----------
Merge r154977 - [gstreamer] Disable HTTP request "Accept-Encoding:" header field on gstreamer source element to avoid receiving the wrong size when retrieving data
https://bugs.webkit.org/show_bug.cgi?id=115354
Patch by Andre Moreira Magalhaes <andre.magalhaes at collabora.co.uk> on 2013-09-03
Reviewed by Philippe Normand.
Source/WebCore:
Also disable Accept-Encoding on ResourceRequest::toSoupMessage accordingly.
* platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::toSoupMessage):
Call ResourceRequest::updateSoupMessage from ResourceRequest::toSoupMessage so that the
Accept-Encoding header is also respected.
LayoutTests:
Add test to check that video requests will send no "Accept-Encoding" header.
* http/tests/media/video-accept-encoding-expected.txt: Added.
* http/tests/media/video-accept-encoding.cgi: Added.
* http/tests/media/video-accept-encoding.html: Added.
Commit: 98f0518c6c9f3bcf5f625ac1969c157e0ca7fd1c
https://github.com/WebKit/WebKit/commit/98f0518c6c9f3bcf5f625ac1969c157e0ca7fd1c
Author: Andre Moreira Magalhaes <andre.magalhaes at collabora.co.uk>
Date: 2013-09-08 (Sun, 08 Sep 2013)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/platform/network/soup/ResourceRequest.h
M Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp
Log Message:
-----------
Merge r155049 - REGRESSION(r154977): Do not urlencode soup message on ResourceRequest::toSoupMessage()
https://bugs.webkit.org/show_bug.cgi?id=120681
Patch by Andre Moreira Magalhaes <andre.magalhaes at collabora.co.uk> on 2013-09-04
Reviewed by Martin Robinson.
Do not call soup_message_set_uri with soupURI() (url encoded uri) on
ResourceRequest::toSoupMessage().
* platform/network/soup/ResourceRequest.h:
* platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateSoupMessageMembers):
(WebCore::ResourceRequest::updateSoupMessage):
(WebCore::ResourceRequest::toSoupMessage):
Split common code from updateSoupMessage/toSoupMessage into updateSoupMessageMembers.
Commit: c7acf389da6f24108aa40adb33b7977fa98aee8d
https://github.com/WebKit/WebKit/commit/c7acf389da6f24108aa40adb33b7977fa98aee8d
Author: Andre Moreira Magalhaes <andre.magalhaes at collabora.co.uk>
Date: 2013-09-09 (Mon, 09 Sep 2013)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h
Log Message:
-----------
Merge r154988 - [GStreamer] Don't set state to NULL until element is destroyed
https://bugs.webkit.org/show_bug.cgi?id=117354
Patch by Andre Moreira Magalhaes <andre.magalhaes at collabora.co.uk> on 2013-09-03
Reviewed by Philippe Normand.
Don't set playbin to NULL until it is going to be destroyed or if we stay
for too long on the READY state. Instead only set the state to READY as this
allows much faster state changes to PAUSED/PLAYING again. playbin internally
caches some state that is destroyed when setting it to NULL.
This state is independent of the URI and it is even possible to change the
URI in READY state.
To avoid having resources (e.g. audio devices) open indefinitely,
when setting the state to READY we create a timeout and if the timeout
is reached we reset the pipeline state to NULL to free resources.
Also now all state changes use the changePipelineState method instead of setting
the playbin state directly with gst_element_set_state, so we have a better control
of when we are requesting state changes.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaPlayerPrivateReadyStateTimeoutCallback):
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::commitLoad):
(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
(WebCore::MediaPlayerPrivateGStreamer::setRate):
(WebCore::MediaPlayerPrivateGStreamer::handlePluginInstallerResult):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
Commit: 81c585778bce8a5b569959e41ed989c06c957195
https://github.com/WebKit/WebKit/commit/81c585778bce8a5b569959e41ed989c06c957195
Author: Andre Moreira Magalhaes <andre.magalhaes at collabora.co.uk>
Date: 2013-09-09 (Mon, 09 Sep 2013)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
Log Message:
-----------
Merge r155104 - [Qt][WK1] REGRESSION(r154988): compositing/video/video-with-invalid-source.html
https://bugs.webkit.org/show_bug.cgi?id=120683
Patch by Andre Moreira Magalhaes <andre.magalhaes at collabora.co.uk> on 2013-09-05
Reviewed by Philippe Normand.
Do not set pipeline state to NULL on MediaPlayerPrivateGStreamer::loadingFailed()
otherwise the bus is flushed and we never get a GST_MESSAGE_ERROR when failing to
load uris.
Also restore previous behaviour (before r154988) of not invoking loadingFailed() for
all failed manual state change attempts.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
Do not call loadingFailed() if state change fails as all manual state changes are
now done with changePipelineState().
(WebCore::MediaPlayerPrivateGStreamer::play):
(WebCore::MediaPlayerPrivateGStreamer::pause):
(WebCore::MediaPlayerPrivateGStreamer::seek):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
Restore previous behaviour (before changeset r154988) when calling changePipelineState().
(WebCore::MediaPlayerPrivateGStreamer::updateStates):
Do nothing if changing to READY on EOS (same behaviour as setting to NULL as it was before
changeset r154988).
(WebCore::MediaPlayerPrivateGStreamer::loadingFailed):
Do not set pipeline state to NULL so we properly get GST_MESSAGE_ERROR on loading failures.
Commit: 6717f8c02a5966d853ab5d906fa3c338e50956cc
https://github.com/WebKit/WebKit/commit/6717f8c02a5966d853ab5d906fa3c338e50956cc
Author: Andre Moreira Magalhaes <andre.magalhaes at collabora.co.uk>
Date: 2013-09-09 (Mon, 09 Sep 2013)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
M Tools/ChangeLog
M Tools/gtk/jhbuild.modules
A Tools/gtk/patches/rtspsrc-timeout-on-udpsrc-is-in-nanoseconds.patch
A Tools/gtk/patches/udpsrc-improve-timeouts.patch
Log Message:
-----------
Merge r155024 - [GStreamer] cannot play live streams
https://bugs.webkit.org/show_bug.cgi?id=116831
Patch by Andre Moreira Magalhaes <andre.magalhaes at collabora.co.uk> on 2013-09-04
Reviewed by Philippe Normand.
Source/WebCore:
Fix issues with rtsp streams embedded on <video> not loading.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
Do not reset pipeline to READY state on STATE_CHANGE_ASYNC when entering PAUSED state for
live streams, otherwise we enter an endless loop of READY->PAUSED->READY->PAUSED when
starting playback.
Tools:
Fix timeout issues with rtspsrc/udpsrc gstreamer elements.
* gtk/jhbuild.modules:
* gtk/patches/rtspsrc-timeout-on-udpsrc-is-in-nanoseconds.patch: Added.
* gtk/patches/udpsrc-improve-timeouts.patch: Added.
Changed gstreamer jhbuild modules to use tarball repos (required to add patches)
and added 2 patches to gst-plugins-good to fix timeout issues with rtsp streams.
Both patches are applied upstream and can be removed once a new gstreamer release
is out (up to 1.0.10 the patches are not included) and we bump the requirements.
Commit: 10717c43c294cba79a452885b3d852398708d49a
https://github.com/WebKit/WebKit/commit/10717c43c294cba79a452885b3d852398708d49a
Author: Claudio Saavedra <csaavedra at igalia.com>
Date: 2013-09-09 (Mon, 09 Sep 2013)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/platform/gtk/RenderThemeGtk3.cpp
Log Message:
-----------
Merge r155039 - [GTK] Color of input button's text broken with recent gnome-themes-standard
https://bugs.webkit.org/show_bug.cgi?id=120581
Reviewed by Carlos Garcia Campos.
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::getStyleContext): add the "text-button" class.
(WebCore::RenderThemeGtk::systemColor): Use the ACTIVE state flag,
as this is the one actually used for button labels.
Commit: a380ebc165fc3f75793b641942ad3cb789419d00
https://github.com/WebKit/WebKit/commit/a380ebc165fc3f75793b641942ad3cb789419d00
Author: Alberto Garcia <berto at igalia.com>
Date: 2013-09-09 (Mon, 09 Sep 2013)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
M Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp
M Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBasePrivate.h
Log Message:
-----------
Merge r155066 - [WK2][GTK] ASSERTION in WebKit::LayerTreeHostGtk::invalidate
https://bugs.webkit.org/show_bug.cgi?id=117733
Reviewed by Martin Robinson.
If the GL context cannot be created then an invalid
LayerTreeHostGtk object will be returned.
This patch disables accelerated compositing if the system doesn't
support it.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewUpdateSettings):
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseUpdatePreferences):
(webkitWebViewBaseCreateWebPage):
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
Commit: 8f193917f538bf0d7ee3acba8a17667e80a28035
https://github.com/WebKit/WebKit/commit/8f193917f538bf0d7ee3acba8a17667e80a28035
Author: Žan Doberšek <zdobersek at igalia.com>
Date: 2013-09-09 (Mon, 09 Sep 2013)
Changed paths:
M ChangeLog
M Source/WebCore/ChangeLog
M Source/WebCore/GNUmakefile.list.am
M Source/WebCore/platform/gtk/GtkVersioning.c
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp
M Source/WebKit2/ChangeLog
M Source/WebKit2/GNUmakefile.list.am
M Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp
M Source/WebKit2/UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp
M Source/WebKit2/UIProcess/cairo/BackingStoreCairo.cpp
M Source/WebKit2/UIProcess/gtk/WebPageProxyGtk.cpp
M Source/WebKit2/config.h
M Source/autotools/FindDependencies.m4
M Source/autotools/PrintBuildConfiguration.m4
M Source/autotools/ReadCommandLineArguments.m4
M Source/autotools/SetupAutoconfHeader.m4
M Source/autotools/SetupAutomake.m4
M Tools/ChangeLog
M Tools/GNUmakefile.am
Log Message:
-----------
Merge r155032 - [GTK] Add support for the Wayland build target
https://bugs.webkit.org/show_bug.cgi?id=120627
Reviewed by Gustavo Noronha Silva.
.:
Add support for building the GTK port with Wayland as the target. The Wayland target can be the sole target
that's enabled, or it can be enabled in parallel with the X11 target.
Each of those two targets, when enabled, checks for the corresponding GTK+ windowing dependency being present.
In the case of only the Wayland target being enabled, the accelerated compositing feature is disabled at
build-time as the feature is not yet supported under the Wayland display protocol. X11-based plugin support is
also disabled under that configuration, even if the WebKitPluginProcess is still built but is left non-operational.
GLX support is also disabled if not building the X11 target.
The Wayland target can be enabled through using the --with-target configuration option that now accepts two
additional values:
- 'wayland' - only enables the Wayland target,
- 'x11,wayland' - enables the X11 and Wayland targets that are to be built in parallel.
This makes it possible to build the GTK port of WebKit with the Wayland target, relying solely on the GTK+
dependency that only has the Wayland backend enabled, and removes linking against any X11-related library.
Note that at the moment there seem to be other dependencies that still link to X11-related libraries.
Complete functionality is not yet guaranteed, but is of course the goal.
* Source/autotools/FindDependencies.m4: Store the version of the basic GTK+ dependency that was found.
This is later used to check that the GTK+ X11 and GTK+ Wayland dependencies are of the same version. The
X11-specific dependencies are grouped into one section (apart from the XComposite and XDamage dependencies),
also checking for the GTK+ X11 dependency. If the X11 target is not enabled, the GLX dependency is disabled.
Additionally check for the GTK+ Wayland dependency if the Wayland target is enabled.
We only check for the presence and correct version of the GTK+ X11 and Wayland dependencies, if necessary.
Check for the XComposite and XDamage dependencies if the X11 target is enabled (in addition to the OpenGL
headers being present).
In case of the Wayland target being enabled while the X11 target is not, disable the accelerated compositing
feature as there's no support yet for it under the Wayland display protocol.
* Source/autotools/PrintBuildConfiguration.m4: The build configuration should now print out 'GDK targets'.
* Source/autotools/ReadCommandLineArguments.m4: The --with-target option can now take two additional values,
'wayland' and 'x11,wayland'. The first one enables only the Wayland target, while the second one enables both
X11 and Wayland targets. This makes it possible to build the GTK port with both X11 and Wayland display protocols
supported in the same build.
We must now check the outcoming with_target variable to see if the special case of building one or both of the
possible parallel targets was chosen. We define with_x11_target and with_wayland_target variables if the
with_target value applies to that case.
* Source/autotools/SetupAutoconfHeader.m4: Do not define the XP_UNIX macro on builds that enable the Wayland-only
target. It should still be defined if we're building both X11 and Wayland targets in parallel.
* Source/autotools/SetupAutomake.m4: Define TARGET_X11 and TARGET_WAYLAND Automake conditionals if the new
with_x11_target or with_wayland_target variables were set, respectively. Additionall, define the TARGET_X11_OR_WAYLAND
Automake conditional if we're building either of the two targets.
Source/WebCore:
* GNUmakefile.list.am: Reorder the Source/WebCore/plugins/np* source files.
The X11-specific source files should only be included if the X11 target is being built. PluginPackageNone and
PluginViewNone source files must be included in non-X11-target builds. Other source files that were previously
guarded with the TARGET_X11 conditional should also be built for the Wayland target, so the new TARGET_X11_OR_WAYLAND
conditional is used. If neither of those two targets is being built we fall back to adding source files to the build
as necessary by the actual build target.
* platform/gtk/GtkVersioning.c:
(gdk_screen_get_monitor_workarea): Additionally guard bits of code that depend on the GDK_WINDOWING_X11 macro being
defined - these should only be built when building the X11 target, checked for with PLATFORM(X11).
Source/WebKit/gtk:
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::createBackingStore): Additionally guard the <gdk/gdkx.h> inclusion and the inclusion and use of
WidgetBackingStoreGtkX11 with PLATFORM(X11), ensuring this code is built when also building with X11 target
enabled. GDK_WINDOWING_X11 macro can be defined even if the X11 target is disabled.
Source/WebKit2:
* GNUmakefile.list.am: Build X11-specific NetscapePluginModule and NetscapePlugin classes if building the X11 target,
fall back to the generic, empty classes otherwise.
* PluginProcess/unix/PluginProcessMainUnix.cpp:
(WebKit::PluginProcessMainUnix): Guard the NetscapePluginModule::scanPlugin() invocation with PLUGIN_ARCHITECTURE(X11),
it's at the moment specific to the X11 implementation of the Netscape plugins.
* UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp: Guard PluginProcessProxy::scanPlugin() with PLUGIN_ARCHITECTURE(X11),
just like it's guarded in the PluginProcessProxy class declaration.
* UIProcess/cairo/BackingStoreCairo.cpp: Additionally guard <gdk/gdkx.h> and WidgetBackingStoreGtkX11 inclusion and use
with PLATFORM(X11), this code should only be built when building the X11 target.
(WebKit::createBackingStoreForGTK):
* UIProcess/gtk/WebPageProxyGtk.cpp: Guard the createPluginContainer() and windowedPluginGeometryDidChange() methods and their
helper functions and objects with PLUGIN_ARCHITECTURE(X11), just like they're guarded in the WebPageProxy class declaration.
* config.h: Only define PLUGIN_ARCHITECTURE_X11 to 1 if we're actually building the X11 target.
Tools:
* GNUmakefile.am: Define the additional macros also if building the Wayland target.
Commit: 15deaf58b3359b7d86444c5c3e55fd25ef551d82
https://github.com/WebKit/WebKit/commit/15deaf58b3359b7d86444c5c3e55fd25ef551d82
Author: Žan Doberšek <zdobersek at igalia.com>
Date: 2013-09-09 (Mon, 09 Sep 2013)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/WebKitWebViewGroup.cpp
Log Message:
-----------
Merge r154728 - [GTK][WK2] Disable accelerated compositing under Wayland
https://bugs.webkit.org/show_bug.cgi?id=120347
Reviewed by Martin Robinson.
Accelerated compositing is not yet supported under the Wayland display protocol,
so it should be disabled. Since it is enabled by default and the GTK WK2 API does
not provide any way to change that, it's enough to disable it when attaching the
WebKitSettings object to the WebPageGroup if running under Wayland.
* UIProcess/API/gtk/WebKitWebViewGroup.cpp:
(webkitWebViewGroupAttachSettingsToPageGroup):
Commit: 661b92bff0ff35477cf46ef99760e7a6265b54b2
https://github.com/WebKit/WebKit/commit/661b92bff0ff35477cf46ef99760e7a6265b54b2
Author: Alberto Garcia <berto at igalia.com>
Date: 2013-09-09 (Mon, 09 Sep 2013)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp
M Source/WebKit2/UIProcess/API/gtk/WebKitWebViewGroup.cpp
Log Message:
-----------
Merge r155125 - [WK2] [GTK] Remove the test to disable AC under Wayland from WebKitWebViewGroup
https://bugs.webkit.org/show_bug.cgi?id=120762
Reviewed by Gustavo Noronha Silva.
The code to disable AC under Wayland is not run if we're using
WebKitTestRunner, so it would be better to move it to
WebKitWebViewBase.
However it's not really necessary to do that, instead it's much
simpler to disable accelerated compositing in all cases unless we
know we can support it.
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseUpdatePreferences):
* UIProcess/API/gtk/WebKitWebViewGroup.cpp:
(webkitWebViewGroupAttachSettingsToPageGroup):
Commit: 36ea9add9ed65bd71b69a697ababa18a121c224a
https://github.com/WebKit/WebKit/commit/36ea9add9ed65bd71b69a697ababa18a121c224a
Author: Alberto Garcia <berto at igalia.com>
Date: 2013-09-09 (Mon, 09 Sep 2013)
Changed paths:
M Source/WTF/ChangeLog
M Source/WTF/wtf/gobject/GlibUtilities.cpp
Log Message:
-----------
Merge r155193 - [GTK] GlibUtilities: getCurrentExecutablePath() does not compile on GNU/Hurd
https://bugs.webkit.org/show_bug.cgi?id=120793
Reviewed by Gustavo Noronha Silva.
Original patch by Svante Signell <svante.signell at telia.com>.
PATH_MAX is not defined in GNU/Hurd, this patch adds a dummy
implementation to make it compile.
* wtf/gobject/GlibUtilities.cpp:
(getCurrentExecutablePath):
Commit: 063a820a74ab951c0425bcd144b68632bcf1ab2c
https://github.com/WebKit/WebKit/commit/063a820a74ab951c0425bcd144b68632bcf1ab2c
Author: Alberto Garcia <berto at igalia.com>
Date: 2013-09-09 (Mon, 09 Sep 2013)
Changed paths:
M Source/ThirdParty/ChangeLog
M Source/ThirdParty/gtest/include/gtest/internal/gtest-port.h
Log Message:
-----------
Merge r155210 - GTest: add support for FreeBSD and Hurd
https://bugs.webkit.org/show_bug.cgi?id=120870
Patch by Emilio Pozuelo Monfort <pochu at debian.org>
Reviewed by Gustavo Noronha Silva.
* gtest/include/gtest/internal/gtest-port.h:
Commit: f8b737a3b81eb89db6bf4bf4bef32d40684f3b7d
https://github.com/WebKit/WebKit/commit/f8b737a3b81eb89db6bf4bf4bef32d40684f3b7d
Author: Žan Doberšek <zdobersek at igalia.com>
Date: 2013-09-09 (Mon, 09 Sep 2013)
Changed paths:
M ChangeLog
M Source/autotools/CheckSystemAndBasicDependencies.m4
Log Message:
-----------
Merge r155245 - [GTK] Bump the required Clang version to 3.2
https://bugs.webkit.org/show_bug.cgi?id=112537
Reviewed by Gustavo Noronha Silva.
* Source/autotools/CheckSystemAndBasicDependencies.m4: Require the Clang 3.2 stack
when the Clang compiler is specified.
Commit: c424dbcd3a8c569c138b7880932aebb8490198c6
https://github.com/WebKit/WebKit/commit/c424dbcd3a8c569c138b7880932aebb8490198c6
Author: Claudio Saavedra <csaavedra at igalia.com>
Date: 2013-09-09 (Mon, 09 Sep 2013)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/platform/gtk/CursorGtk.cpp
Log Message:
-----------
Merge r155329 - [GTK] ghost cursor when mouse hovers over an image file in a tab
https://bugs.webkit.org/show_bug.cgi?id=120675
Reviewed by Carlos Garcia Campos.
No new tests, covered by existing.
* platform/gtk/CursorGtk.cpp:
(WebCore::createNamedCursor): Use new gdk_cursor_new_from_surface()
when compiling against GTK+ 3.9.12 or newer.
Commit: 65adf3015e33bcd0b825fc08ce58271f1b4785e5
https://github.com/WebKit/WebKit/commit/65adf3015e33bcd0b825fc08ce58271f1b4785e5
Author: Andre Moreira Magalhaes <andre.magalhaes at collabora.co.uk>
Date: 2013-09-09 (Mon, 09 Sep 2013)
Changed paths:
M Tools/ChangeLog
M Tools/MiniBrowser/gtk/main.c
Log Message:
-----------
Merge r154841 - [GTK] Should enable WebGL by default on MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=120420
Patch by Andre Moreira Magalhaes <andre.magalhaes at collabora.co.uk> on 2013-08-29
Reviewed by Gustavo Noronha Silva.
Enable WebGL by default on MiniBrowser.
* MiniBrowser/gtk/main.c:
(main):
Commit: 21db3d9d55137efdfae28e113c6cfb37fd2bafc4
https://github.com/WebKit/WebKit/commit/21db3d9d55137efdfae28e113c6cfb37fd2bafc4
Author: Anton Obzhirov <a.obzhirov at samsung.com>
Date: 2013-09-09 (Mon, 09 Sep 2013)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp
M Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.h
M Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationRequest.cpp
M Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
M Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp
M Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp
Log Message:
-----------
Merge r155347 - [GTK] Cancel the current active WebKitAuthenticationRequest on load failed
https://bugs.webkit.org/show_bug.cgi?id=120350
Patch by Anton Obzhirov <a.obzhirov at samsung.com> on 2013-09-09
Reviewed by Carlos Garcia Campos.
The default dialog does not get closed and the authentication is not cancelled
if loading fails or is stopped on a page which requires HTTP authentication.
This patch cancels the authentication request on load failed
and adds new authentication cancelled signal in WebKitAuthenticationRequest
to allow the application handling of authentication UI.
* UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:
(authenticationCancelled):
(webkitAuthenticationDialogInitialize):
(webkitAuthenticationDialogDispose):
(webkitAuthenticationDialogNew):
* UIProcess/API/gtk/WebKitAuthenticationDialog.h:
* UIProcess/API/gtk/WebKitAuthenticationRequest.cpp:
(webkit_authentication_request_class_init):
(webkit_authentication_request_cancel):
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewAuthenticate):
(webkitWebViewLoadFailed):
(webkitWebViewHandleAuthenticationChallenge):
(webkitWebViewCancelAuthenticationRequest):
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewAuthenticationLoadCancelled):
(beforeAll):
Commit: 787e8b12cc7a6b72d10e874baa1a0fa9210f632f
https://github.com/WebKit/WebKit/commit/787e8b12cc7a6b72d10e874baa1a0fa9210f632f
Author: Gustavo Noronha Silva <gns at gnome.org>
Date: 2013-09-09 (Mon, 09 Sep 2013)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/GNUmakefile.list.am
Log Message:
-----------
Merge r155353 - Unreviewed build fix.
* GNUmakefile.list.am: Typo - left-over \ from a copy/paste, most likely.
Commit: c731240ed8960f3a3f157aaf172ab07460c051b3
https://github.com/WebKit/WebKit/commit/c731240ed8960f3a3f157aaf172ab07460c051b3
Author: Anders Carlsson <andersca at apple.com>
Date: 2013-09-10 (Tue, 10 Sep 2013)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/platform/audio/FFTFrame.h
M Source/WebCore/platform/audio/gstreamer/FFTFrameGStreamer.cpp
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
M Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp
Log Message:
-----------
Merge r155198 - Stop using fastNew/fastDelete in WebCore
https://bugs.webkit.org/show_bug.cgi?id=120867
Reviewed by Geoffrey Garen.
Using fastNew/fastDelete can be dangerous, especially when put into a smart pointer
such as OwnPtr which uses regular delete. Because of this I'd like to remove fastNew/fastDelete.
Turns out it's only used in a couple of places in WebCore, so just use new/delete here instead.
* platform/audio/FFTFrame.h:
* platform/audio/gstreamer/FFTFrameGStreamer.cpp:
(WebCore::FFTFrame::FFTFrame):
(WebCore::FFTFrame::~FFTFrame):
(WebCore::FFTFrame::doFFT):
(WebCore::FFTFrame::doInverseFFT):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkDispose):
Commit: 525c1e7465ea8bad2466156947acbd4c6590cb9f
https://github.com/WebKit/WebKit/commit/525c1e7465ea8bad2466156947acbd4c6590cb9f
Author: Brian Holt <brian.holt at samsung.com>
Date: 2013-09-10 (Tue, 10 Sep 2013)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp
Log Message:
-----------
Merge r154818 - [GTK] [WK2] TestWebKitWebView page-visibility fails
https://bugs.webkit.org/show_bug.cgi?id=120406
Patch by Brian Holt <brian.holt at samsung.com> on 2013-08-29
Reviewed by Gustavo Noronha Silva.
Removed the webkit prefix for document visibility properties.
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewPageVisibility):
Commit: 7d5171ea9781e372b84f70ec31c158b91c70708c
https://github.com/WebKit/WebKit/commit/7d5171ea9781e372b84f70ec31c158b91c70708c
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2013-09-10 (Tue, 10 Sep 2013)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp
Log Message:
-----------
Merge r155430 - [GTK] /webkit2/WebKitWebView/default-menu fails when GtkSettings:gtk-show-input-method-menu is disabled
https://bugs.webkit.org/show_bug.cgi?id=121088
Reviewed by Xan Lopez.
* UIProcess/API/gtk/tests/TestContextMenu.cpp: Always check
Unicode submenu is present in default context menu for editable
content.
Commit: 1160f6f62aa5b8d5e2c578553aa921584315ed4f
https://github.com/WebKit/WebKit/commit/1160f6f62aa5b8d5e2c578553aa921584315ed4f
Author: Brian Holt <brian.holt at samsung.com>
Date: 2013-09-10 (Tue, 10 Sep 2013)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuActions.cpp
M Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuActions.h
M Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp
Log Message:
-----------
Merge r154987 - [GTK] [WK2] TestContextMenu default-menu fails
https://bugs.webkit.org/show_bug.cgi?id=120459
Patch by Brian Holt <brian.holt at samsung.com> on 2013-09-03
Reviewed by Gustavo Noronha Silva.
Add context menu items for downloading media elements.
* UIProcess/API/gtk/WebKitContextMenuActions.cpp:
(webkitContextMenuActionGetActionTag):
(webkitContextMenuActionGetForContextMenuItem):
(webkitContextMenuActionGetLabel):
* UIProcess/API/gtk/WebKitContextMenuActions.h:
* UIProcess/API/gtk/tests/TestContextMenu.cpp:
Commit: 809325ac99718970d267cf746866e3e7adc4037f
https://github.com/WebKit/WebKit/commit/809325ac99718970d267cf746866e3e7adc4037f
Author: Brian Holt <brian.holt at samsung.com>
Date: 2013-09-10 (Tue, 10 Sep 2013)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuActions.h
M Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp
Log Message:
-----------
Merge r155345 - [GTK][WK2] Update ContextMenu Download API
https://bugs.webkit.org/show_bug.cgi?id=120763
Patch by Brian Holt <brian.holt at samsung.com> on 2013-09-09
Reviewed by Carlos Garcia Campos.
Mark the new Download items in the Context Menu with the Since
tag, and include a unit test for Context Menu audio.
* UIProcess/API/gtk/WebKitContextMenuActions.h:
* UIProcess/API/gtk/tests/TestContextMenu.cpp:
(testContextMenuDefaultMenu):
Commit: b62d0acc51c37d99cc1ba86a6d0cb06ecc1c3132
https://github.com/WebKit/WebKit/commit/b62d0acc51c37d99cc1ba86a6d0cb06ecc1c3132
Author: Enrico Nicoletto <liverig at gmail.com>
Date: 2013-09-10 (Tue, 10 Sep 2013)
Changed paths:
M Source/WebCore/platform/gtk/po/ChangeLog
M Source/WebCore/platform/gtk/po/pt_BR.po
Log Message:
-----------
Merge 155439 - [l10n] [pt_BR] Updated Brazilian Portuguese translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=120642
Patch by Enrico Nicoletto <liverig at gmail.com> on 2013-09-10
Reviewed by Gustavo Noronha.
* pt_BR.po: updated.
Commit: 59f80618924e0aae385256bf0c06d54f8acd722a
https://github.com/WebKit/WebKit/commit/59f80618924e0aae385256bf0c06d54f8acd722a
Author: Daniel Mustieles <daniel.mustieles at gmail.com>
Date: 2013-09-10 (Tue, 10 Sep 2013)
Changed paths:
M Source/WebCore/platform/gtk/po/ChangeLog
M Source/WebCore/platform/gtk/po/es.po
Log Message:
-----------
Merge 155441 - Updated Spanish translation for WebKitGtk+
https://bugs.webkit.org/show_bug.cgi?id=121032
Patch by Daniel Mustieles <daniel.mustieles at gmail.com> on 2013-09-10
Reviewed by Gustavo Noronha.
* es.po: updated.
Commit: 0af889a3608f40322ae2ef934d5de503d53b7bee
https://github.com/WebKit/WebKit/commit/0af889a3608f40322ae2ef934d5de503d53b7bee
Author: Žan Doberšek <zandobersek at gmail.com>
Date: 2013-09-10 (Tue, 10 Sep 2013)
Changed paths:
M Source/WebKit2/GNUmakefile.list.am
Log Message:
-----------
Build fix - removing duplicate build targets for NetscapePluginModuleNone and NetscapePluginNone.
Commit: bbca0651f453ef858e959ead5e0b7c526b2a89d2
https://github.com/WebKit/WebKit/commit/bbca0651f453ef858e959ead5e0b7c526b2a89d2
Author: Sergio Villar Senin <svillar at igalia.com>
Date: 2013-09-11 (Wed, 11 Sep 2013)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp
M Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.h
Log Message:
-----------
Merge r155459 - [WK2][GTK] Frequent crashes when showing context menus in Debug builds
https://bugs.webkit.org/show_bug.cgi?id=121099
Reviewed by Carlos Garcia Campos.
Disconnect signal handlers when destroying the context menu proxy
object. This avoids use-after-free crashes when opening several
context menus in a row.
* UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::WebContextMenuProxyGtk::append):
(WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk):
* UIProcess/gtk/WebContextMenuProxyGtk.h:
Commit: 08ad35318d0a8f403d67d44b0a080ec1ca2b0b10
https://github.com/WebKit/WebKit/commit/08ad35318d0a8f403d67d44b0a080ec1ca2b0b10
Author: Carlos Garcia Campos <carlosgc at webkit.org>
Date: 2013-09-11 (Wed, 11 Sep 2013)
Changed paths:
M ChangeLog
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/NEWS
M Source/autotools/Versions.m4
M configure.ac
Log Message:
-----------
Unreviewed. Update NEWS and Versions.m4 for 2.1.91 release.
.:
* Source/autotools/Versions.m4: Bump version numbers.
* configure.ac: Remove webkit_patch_version from AC_INIT call.
Source/WebKit/gtk:
* NEWS: Add release notes.
Commit: 0a54f60619db0071a832fd2634d081ae7ab588e1
https://github.com/WebKit/WebKit/commit/0a54f60619db0071a832fd2634d081ae7ab588e1
Author: Žan Doberšek <zdobersek at igalia.com>
Date: 2013-09-11 (Wed, 11 Sep 2013)
Changed paths:
M ChangeLog
M Source/autotools/SetupAutoconfHeader.m4
Log Message:
-----------
Merge r155509 - [GTK] Stop disabling deprecated symbols in debug builds
https://bugs.webkit.org/show_bug.cgi?id=121145
Reviewed by Carlos Garcia Campos.
Disabling the dependencies' deprecated symbols in debug builds is only causing unnecessary
build failures. Compiler warnings are being thrown whenever a deprecated symbol is being
used, so a build failure is an overreach in this case.
* Source/autotools/SetupAutoconfHeader.m4:
Commit: 21a845af368baf81bfea73d663675797464754f3
https://github.com/WebKit/WebKit/commit/21a845af368baf81bfea73d663675797464754f3
Author: Žan Doberšek <zdobersek at igalia.com>
Date: 2013-09-11 (Wed, 11 Sep 2013)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp
Log Message:
-----------
Merge r154729 - [GTK][WK2] Only set up a RedirectedXCompositeWindow if running under an X11 display
https://bugs.webkit.org/show_bug.cgi?id=120321
Reviewed by Gustavo Noronha Silva.
Only set up the RedirectedXCompositeWindow member of the WebKitWebViewBasePrivate struct
if we're running under an X11 display. This is now done in the webkitWebViewBaseConstructed
function rather than the constructor, which is removed.
This allows for the UIProcess to run in a Wayland environment even when built with accelerated
compositing enabled. Of course, at the moment there's no support yet for accelerated compositing
under Wayland, so we fall back to rendering the backing store. No changes are introduced to
the behavior under X11 - accelerated compositing will be used where possible, if supported.
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseConstructed):
Commit: e3e0634a6fb0d44e696deadbc89b0075d380c688
https://github.com/WebKit/WebKit/commit/e3e0634a6fb0d44e696deadbc89b0075d380c688
Author: Žan Doberšek <zdobersek at igalia.com>
Date: 2013-09-12 (Thu, 12 Sep 2013)
Changed paths:
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp
M Source/WebKit/gtk/webkit/webkitwebview.cpp
Log Message:
-----------
Merge r155619 - [GTK][WK1] Block accelerated compositing under non-X11 displays
https://bugs.webkit.org/show_bug.cgi?id=121165
Reviewed by Martin Robinson.
This is analogous to the changes in r154728 and r154729 that enforce disabling accelerated compositing
under Wayland displays and made the RedirectedXCompositeWindow use in WebKit2 limited only to the X11 displays.
* WebCoreSupport/AcceleratedCompositingContextGL.cpp: Remove two unnecessary header includes that also
introduce symbols that conflict with the symbols defined in the X headers. Include the <gdk/gdkx.h> header
if the GTK+ dependency can provide it.
(WebKit::AcceleratedCompositingContext::initialize): Only set up the RedirectedXCompositeWindow instance
if running under an X11 display.
(WebKit::AcceleratedCompositingContext::renderLayersToWindow): The removal of the unnecessary header
inclusions also removed the std::max() injection into the global scope. Using std::max directly instead.
(WebKit::AcceleratedCompositingContext::scheduleLayerFlush): Ditto.
* webkit/webkitwebview.cpp:
(updateAcceleratedCompositingSetting): A helper function that ensures the accelerated compositing feature
stays disabled under Wayland displays. It also prints out a warning message the first time the user tries
to enable accelerated compositing under Wayland displays, telling that the feature is not supported and
will remain disabled.
(webkit_web_view_update_settings): Call updateAcceleratedCompositingSetting() to enable the feature if possible.
(webkit_web_view_settings_notify): Ditto.
Commit: 68dc8dd2a7b17e7fecf711b465b9fd0936dca319
https://github.com/WebKit/WebKit/commit/68dc8dd2a7b17e7fecf711b465b9fd0936dca319
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2013-09-15 (Sun, 15 Sep 2013)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp
Log Message:
-----------
Merge r155814 - [GTK] The web inspector is not rendered when docked in WebKit2 when AC is used
https://bugs.webkit.org/show_bug.cgi?id=121381
Reviewed by Martin Robinson.
When accelerated compositing results are rendered we return early
from webkitWebViewBaseDraw and other WebView children are not
drawn. We need to chain up the draw signal handler, so that the
GtkContainer propagates the draw to all its children.
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseDraw):
Commit: 777a7a059b775ddb382343bc32cfaa7ff3bf5213
https://github.com/WebKit/WebKit/commit/777a7a059b775ddb382343bc32cfaa7ff3bf5213
Author: Alberto Garcia <berto at igalia.com>
Date: 2013-09-16 (Mon, 16 Sep 2013)
Changed paths:
M ChangeLog
M autogen.sh
Log Message:
-----------
Merge r155515 - Unquoted $ORIGDIR in autogen.sh
https://bugs.webkit.org/show_bug.cgi?id=19512
Reviewed by Carlos Garcia Campos.
Quote all directory names. This doesn't mean that all possible
directory names are safe for building webkit, but the configure
script already runs a sanity check.
* autogen.sh:
Commit: 0d8e82b48fb5ecd2d3ee680680577dec102ca3fa
https://github.com/WebKit/WebKit/commit/0d8e82b48fb5ecd2d3ee680680577dec102ca3fa
Author: Alberto Garcia <berto at igalia.com>
Date: 2013-09-16 (Mon, 16 Sep 2013)
Changed paths:
M ChangeLog
M autogen.sh
Log Message:
-----------
Merge r155517 - autogen.sh: fix removal of autom4te.cache
https://bugs.webkit.org/show_bug.cgi?id=121150
Reviewed by Carlos Garcia Campos.
The removal of autom4te.cache is wrong, it uses 'rm -f' instead of
'rm -rf' and it relies on an undefined variable.
In addition to that, it should be done after running autoreconf,
which is when it's no longer needed.
* autogen.sh:
Commit: 44f49e151053b1510937ace02a86d484ef4b245c
https://github.com/WebKit/WebKit/commit/44f49e151053b1510937ace02a86d484ef4b245c
Author: Alberto Garcia <berto at igalia.com>
Date: 2013-09-16 (Mon, 16 Sep 2013)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp
Log Message:
-----------
Merge r155533 - [WK2] [GTK] LayerTreeHostGtk: don't set m_isValid to false if glContext() returns null
https://bugs.webkit.org/show_bug.cgi?id=120892
Reviewed by Martin Robinson.
If the GL context cannot be created then m_isValid is set to false
during the initialization of LayerTreeHostGtk.
This is not really necessary since the rest of the code already
deals with that situation, so it doesn't have any effect other
than breaking the assertion in invalidate().
* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::initialize):
Commit: f1859363c614c5cb1f68e5a00d9341abff49bd25
https://github.com/WebKit/WebKit/commit/f1859363c614c5cb1f68e5a00d9341abff49bd25
Author: Alberto Garcia <berto at igalia.com>
Date: 2013-09-16 (Mon, 16 Sep 2013)
Changed paths:
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/webkit/webkitwebview.cpp
Log Message:
-----------
Merge r155677 - download-requested arg should be WEBKIT_TYPE_DOWNLOAD not G_TYPE_OBJECT
https://bugs.webkit.org/show_bug.cgi?id=57634
Reviewed by Darin Adler.
* webkit/webkitwebview.cpp:
(webkit_web_view_class_init):
Commit: 3cc8a5f3f385314fbf1690865c00ab4111d0fbe8
https://github.com/WebKit/WebKit/commit/3cc8a5f3f385314fbf1690865c00ab4111d0fbe8
Author: Alberto Garcia <berto at igalia.com>
Date: 2013-09-16 (Mon, 16 Sep 2013)
Changed paths:
M Tools/ChangeLog
M Tools/gtk/gtkdoc.py
Log Message:
-----------
Merge r155757 - [GTK] Fails to compile if the build directory is in a different partition
https://bugs.webkit.org/show_bug.cgi?id=121296
Reviewed by Carlos Garcia Campos.
Use symlinks instead of hard links to support building on a
different file system.
* gtk/gtkdoc.py:
(GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
Commit: ef066c98dee226db3ff86ad2f5b587934ca7cf14
https://github.com/WebKit/WebKit/commit/ef066c98dee226db3ff86ad2f5b587934ca7cf14
Author: Alberto Garcia <berto at igalia.com>
Date: 2013-09-16 (Mon, 16 Sep 2013)
Changed paths:
M Tools/ChangeLog
M Tools/gtk/gtkdoc.py
Log Message:
-----------
Merge r155772 - [GTK] Fails to compile if the build directory is in a different partition
https://bugs.webkit.org/show_bug.cgi?id=121296
Reviewed by Martin Robinson.
Instead of using os.symlink() to install the gtk-doc templates,
use os.link() first and fall back to os.symlink() if it fails.
* gtk/gtkdoc.py:
(GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
Commit: 0e8cd5608da71b25bf83f5292cb0ebc8e35fb80f
https://github.com/WebKit/WebKit/commit/0e8cd5608da71b25bf83f5292cb0ebc8e35fb80f
Author: Ross Burton <ross.burton at intel.com>
Date: 2013-09-16 (Mon, 16 Sep 2013)
Changed paths:
M Tools/ChangeLog
M Tools/GNUmakefile.am
Log Message:
-----------
Merge r155758 - Uses gtk-doc tools even when --disable-gtk-doc passed
https://bugs.webkit.org/show_bug.cgi?id=91239
Patch by Ross Burton <ross.burton at intel.com> on 2013-09-14
Reviewed by Martin Robinson.
Don't run generate-gtkdoc on install if gtk-doc is disabled.
* GNUmakefile.am:
Commit: 1033cd4121f33421c7f6c64a2899ce81c1d4b8b5
https://github.com/WebKit/WebKit/commit/1033cd4121f33421c7f6c64a2899ce81c1d4b8b5
Author: Alberto Garcia <berto at igalia.com>
Date: 2013-09-16 (Mon, 16 Sep 2013)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/GNUmakefile.am
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/GNUmakefile.am
M Source/WebKit2/ChangeLog
M Source/WebKit2/GNUmakefile.am
M Tools/ChangeLog
M Tools/MiniBrowser/gtk/GNUmakefile.am
M Tools/TestWebKitAPI/GNUmakefile.am
M Tools/WebKitTestRunner/GNUmakefile.am
Log Message:
-----------
Merge r155768 - [GTK] WebKitGTK+ is linking against libxslt in too many places
https://bugs.webkit.org/show_bug.cgi?id=121356
Reviewed by Martin Robinson.
Source/WebCore:
Don't use LIBXSLT_CFLAGS when compiling libWebCorePlatform and
libWebCoreGtk, no source files use libxslt there.
* GNUmakefile.am:
Source/WebKit/gtk:
Don't use LIBXSLT_CFLAGS when compiling libwebkitgtk, no source
files use libxslt there.
The webkit tests don't use libxslt, so we shouldn't link against
it.
* GNUmakefile.am:
Source/WebKit2:
Don't use LIBXSLT_CFLAGS when compiling libWebCoreGtk2, no source
files use libxslt there.
* GNUmakefile.am:
Tools:
TestWebCore, WebKitTestRunner and MiniBrowser don't use libxslt,
so we don't need to link against it.
* MiniBrowser/gtk/GNUmakefile.am:
* TestWebKitAPI/GNUmakefile.am:
* WebKitTestRunner/GNUmakefile.am:
Commit: 3b447b8693ce952c366155a3ad8bfdd42c444bc3
https://github.com/WebKit/WebKit/commit/3b447b8693ce952c366155a3ad8bfdd42c444bc3
Author: Alberto Garcia <berto at igalia.com>
Date: 2013-09-16 (Mon, 16 Sep 2013)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm
Log Message:
-----------
Merge r155778 - Missing allow-none introspection annotation for DomDocument.evaluate method
https://bugs.webkit.org/show_bug.cgi?id=118310
Reviewed by Martin Robinson.
Add (allow-none) introspection annotation to parameters that can
be NULL.
* bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunction):
Commit: b070405465b41122ecd8b09fa6e7a13304009c73
https://github.com/WebKit/WebKit/commit/b070405465b41122ecd8b09fa6e7a13304009c73
Author: Piotr Drąg <piotrdrag at gmail.com>
Date: 2013-09-16 (Mon, 16 Sep 2013)
Changed paths:
M Source/WebCore/platform/gtk/po/ChangeLog
M Source/WebCore/platform/gtk/po/pl.po
Log Message:
-----------
Merge 154677 - [l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=119986
Patch by Piotr Drąg <piotrdrag at gmail.com> on 2013-08-27
Reviewed by Gustavo Noronha Silva.
* pl.po: updated.
Commit: 71e186019d5d45143bebddf7e1eb335d73bd9d49
https://github.com/WebKit/WebKit/commit/71e186019d5d45143bebddf7e1eb335d73bd9d49
Author: Piotr Drąg <piotrdrag at gmail.com>
Date: 2013-09-16 (Mon, 16 Sep 2013)
Changed paths:
M Source/WebCore/platform/gtk/po/ChangeLog
M Source/WebCore/platform/gtk/po/pl.po
Log Message:
-----------
Merge 155831 - [l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=121392
Patch by Piotr Drąg <piotrdrag at gmail.com> on 2013-09-15
Reviewed by Gustavo Noronha Silva.
* pl.po: updated.
Commit: 67bd68865a74adf834b119be37dd06aa2b27701f
https://github.com/WebKit/WebKit/commit/67bd68865a74adf834b119be37dd06aa2b27701f
Author: Enrico Nicoletto <liverig at gmail.com>
Date: 2013-09-16 (Mon, 16 Sep 2013)
Changed paths:
M Source/WebCore/platform/gtk/po/ChangeLog
M Source/WebCore/platform/gtk/po/pt_BR.po
Log Message:
-----------
Merge 155855 - [l10n] [pt_BR] Updated Brazilian Portuguese translation of WebKitGTK+ - 12/09/2013
https://bugs.webkit.org/show_bug.cgi?id=121255
Patch by Enrico Nicoletto <liverig at gmail.com> on 2013-09-16
Reviewed by Gustavo Noronha.
* pt_BR.po: updated.
Commit: 3ba91559575a0a756cebc905e016709d68095edf
https://github.com/WebKit/WebKit/commit/3ba91559575a0a756cebc905e016709d68095edf
Author: Mario Sanchez Prada <mario at webkit.org>
Date: 2013-09-16 (Mon, 16 Sep 2013)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp
Log Message:
-----------
Merge r155031 - [GTK] Reimplement atk_text_get_text_*_offset for SENTENCE boundaries
https://bugs.webkit.org/show_bug.cgi?id=114873
Reviewed by Chris Fleizach.
Re-implement these functions without using GailTextUtil nor Pango.
* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextWordForBoundary): Renamed from webkitAccessibleTextGetWordForBoundary,
to keep it consistent with names for new functions.
(isSentenceBoundary): Helper function to know when we are either
at the beginning or the end of a sentence.
(isWhiteSpaceBetweenSentences): It returns true if we are in the
middle of a white space between sentences. Useful for implementing
the SENTENCE_END boundary type.
(sentenceAtPositionForAtkBoundary): New helper function to find the
sentence at a given position considering values of AtkTextBoundary.
(webkitAccessibleTextSentenceForBoundary): New function,
implementing atk_text_get_text_*_offset for SENTENCE.
(webkitAccessibleTextGetTextForOffset): Replace usage of Gail for
SENTENCE boundaries with webkitAccessibleTextSentenceForBoundary().
Commit: 308b28af33e5eb535b021481767b5107b1211a6c
https://github.com/WebKit/WebKit/commit/308b28af33e5eb535b021481767b5107b1211a6c
Author: Mario Sanchez Prada <mario at webkit.org>
Date: 2013-09-16 (Mon, 16 Sep 2013)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/tests/testatk.c
Log Message:
-----------
Merge r155516 - [GTK] Reimplement atk_text_get_text_*_offset for LINE boundaries
https://bugs.webkit.org/show_bug.cgi?id=114872
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Re-implement these functions without using GailTextUtil nor Pango.
* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(lineAtPositionForAtkBoundary): New helper function to find the
line at a given position considering values of AtkTextBoundary.
(webkitAccessibleTextLineForBoundary): New function,
implementing atk_text_get_text_*_offset for LINE.
(webkitAccessibleTextGetTextForOffset): Replace usage of Gail for
LINE boundaries with webkitAccessibleTextLineForBoundary().
Source/WebKit/gtk:
Fixed wrong unit test.
* tests/testatk.c:
(testWebkitAtkGetTextAtOffsetWithPreformattedText): This test was
reporting a trailing '\n' for some reason for a <pre> block, which
is plainly wrong since, in order to return that, there should be
at least a trailing empty space after that and before the </pre>
closing tag. This is fixed now.
(testWebkitAtkGetTextAtOffsetWithWrappedLines): Uncommented tests
that were previously not passing due to a bug in GailTextUtil.
Commit: cab733aba185c9f14b727cbca57606e4b1a06fb8
https://github.com/WebKit/WebKit/commit/cab733aba185c9f14b727cbca57606e4b1a06fb8
Author: Mario Sanchez Prada <mario at webkit.org>
Date: 2013-09-16 (Mon, 16 Sep 2013)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp
Log Message:
-----------
Merge r155520 - [GTK] Get rid of Pango/Gail dependencies in accessibility for ATK
https://bugs.webkit.org/show_bug.cgi?id=114867
Reviewed by Martin Robinson.
Removed all trace of Gail and Pango specific code from the AtkText
implementation, now everything has been reimplemented.
* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetTextForOffset): Removed fallback code
relying in Gail/Pango, now all the related code has been
removed. Also, replaced the collection of if statements with a
switch, for better readability of the code.
Commit: 8a9fc839eb19e451736ddfab5194105d9ebba41d
https://github.com/WebKit/WebKit/commit/8a9fc839eb19e451736ddfab5194105d9ebba41d
Author: Mario Sanchez Prada <mario at webkit.org>
Date: 2013-09-16 (Mon, 16 Sep 2013)
Changed paths:
M ChangeLog
M Source/WebCore/ChangeLog
M Source/WebCore/GNUmakefile.am
M Source/WebCore/PlatformGTK.cmake
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/GNUmakefile.am
M Source/WebKit2/ChangeLog
M Source/WebKit2/GNUmakefile.am
M Source/autotools/FindDependencies.m4
M Source/autotools/Versions.m4
R Source/cmake/FindGAIL3.cmake
M Source/cmake/OptionsGTK.cmake
M Tools/ChangeLog
M Tools/EWSTools/ubuntu-ews-packages
M Tools/Scripts/webkitpy/port/gtk.py
M Tools/TestWebKitAPI/GNUmakefile.am
M Tools/gtk/install-dependencies
Log Message:
-----------
Merge r155534 - [GTK] Remove Gail dependency from build system for GTK3
https://bugs.webkit.org/show_bug.cgi?id=119673
Reviewed by Gustavo Noronha Silva.
.:
* Source/autotools/FindDependencies.m4: Don't look for GAIL at all.
* Source/autotools/Versions.m4: Removed any reference to GAIL.
* Source/cmake/FindGAIL3.cmake: Removed.
* Source/cmake/OptionsGTK.cmake: Don't look for the GAIL package.
Source/WebCore:
* GNUmakefile.am: Removed GAIL_CFLAGS.
* PlatformGTK.cmake: Removed GAIL3_INCLUDE_DIRS and GAIL3_LIBRARIES.
Source/WebKit/gtk:
* GNUmakefile.am: Removed GAIL_CFLAGS and GAIL_LIBS.
Source/WebKit2:
* GNUmakefile.am: Removed GAIL_LIBS.
Tools:
* EWSTools/ubuntu-ews-packages: Removed libgail-dev package.
* Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server): Do not load the 'gail' module anymore.
* TestWebKitAPI/GNUmakefile.am: Removed GAIL_LIBS.
Commit: 26333ba4c1dff4a4c140fd0303772d0ffc624faa
https://github.com/WebKit/WebKit/commit/26333ba4c1dff4a4c140fd0303772d0ffc624faa
Author: Andre Moreira Magalhaes <andre.magalhaes at collabora.co.uk>
Date: 2013-09-16 (Mon, 16 Sep 2013)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/tests/TestInspectorServer.cpp
M Source/WebKit2/UIProcess/InspectorServer/HTTPRequest.cpp
Log Message:
-----------
Merge r155642 - Web Inspector: Do not try to parse incomplete HTTP requests
https://bugs.webkit.org/show_bug.cgi?id=121123
Patch by Andre Moreira Magalhaes <andre.magalhaes at collabora.co.uk> on 2013-09-12
Reviewed by Darin Adler.
When working on a patch for bug #121121 I found an issue with the InspectorServer where it would try
to parse an HTTP message before receiving the full message and thus fail connecting with the
chromedevtools plugin.
What happens is that the WebSocketServerConnection receives buffers on
WebSocketServerConnection::didReceiveSocketStreamData and calls
WebSocketServerConnection::readHTTPMessage which then checks if we have a valid request by calling
HTTPRequest::parseHTTPRequestFromBuffer. If the request is valid it tries to parse the message and
clears the buffer, otherwise it continues adding data to the internal buffer until we have a valid
request.
The problem is that currently HTTPRequest::parseHTTPRequestFromBuffer considers the request as valid
before receiving the full message. To solve this we should make the method check if the request
headers end with a blank line otherwise we consider the request as invalid (see also
http://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html).
* UIProcess/API/gtk/tests/TestInspectorServer.cpp:
(sendIncompleteRequest):
(beforeAll):
Add GTK specific test to check if the inspector server replies to incomplete requests.
* UIProcess/InspectorServer/HTTPRequest.cpp:
(WebKit::HTTPRequest::parseHeaders):
Do not consider request valid if headers didn't end with a blank line.
Commit: 76ac050ad6499c3666897a8bc77602f0b3cbd183
https://github.com/WebKit/WebKit/commit/76ac050ad6499c3666897a8bc77602f0b3cbd183
Author: Andre Moreira Magalhaes <andre.magalhaes at collabora.co.uk>
Date: 2013-09-16 (Mon, 16 Sep 2013)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/tests/TestInspectorServer.cpp
Log Message:
-----------
Merge r155861 - Web Inspector: Do not try to parse incomplete HTTP requests
https://bugs.webkit.org/show_bug.cgi?id=121123
Patch by Andre Moreira Magalhaes <andre.magalhaes at collabora.co.uk> on 2013-09-16
Reviewed by Carlos Garcia Campos.
Update to incorporate additional review suggestions.
* UIProcess/API/gtk/tests/TestInspectorServer.cpp:
(sendIncompleteRequest):
Fix memory leaks, change test timeout from 2 seconds to 1 second,
use "0" instead of "NULL" and use g_assert_no_error when checking
for GError.
Commit: 93937f3efe17fa6565f5a8f3bab497f7f0322bc0
https://github.com/WebKit/WebKit/commit/93937f3efe17fa6565f5a8f3bab497f7f0322bc0
Author: Daniel Mustieles <daniel.mustieles at gmail.com>
Date: 2013-09-16 (Mon, 16 Sep 2013)
Changed paths:
M Source/WebCore/platform/gtk/po/ChangeLog
M Source/WebCore/platform/gtk/po/es.po
Log Message:
-----------
Merge 155869 - Updated spanish Translation
https://bugs.webkit.org/show_bug.cgi?id=100677
Patch by Daniel Mustieles <daniel.mustieles at gmail.com> on 2013-09-16
Reviewed by Gustavo Noronha Silva.
* es.po: updated.
Commit: 2fdaedc1f832ae772e2f41908f4900670e4d408c
https://github.com/WebKit/WebKit/commit/2fdaedc1f832ae772e2f41908f4900670e4d408c
Author: Chris Leonard <cjlhomeaddress at gmail.com>
Date: 2013-09-16 (Mon, 16 Sep 2013)
Changed paths:
M Source/WebCore/platform/gtk/po/ChangeLog
M Source/WebCore/platform/gtk/po/en_GB.po
Log Message:
-----------
Merge 155866 - L10n - en_GB PO file for WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=100255
Patch by Chris Leonard <cjlhomeaddress at gmail.com> on 2013-09-16
Reviewed by Gustavo Noronha Silva.
* en_GB.po: updated.
Commit: 61f402339b8b06d9470c8c3ea1a66ea4e916f78a
https://github.com/WebKit/WebKit/commit/61f402339b8b06d9470c8c3ea1a66ea4e916f78a
Author: Fran Dieguez <frandieguez at gnome.org>
Date: 2013-09-16 (Mon, 16 Sep 2013)
Changed paths:
M Source/WebCore/platform/gtk/po/ChangeLog
M Source/WebCore/platform/gtk/po/gl.po
Log Message:
-----------
Merge 155867 - Add new Galician translations
https://bugs.webkit.org/show_bug.cgi?id=105079
Patch by Fran Dieguez <frandieguez at gnome.org> on 2013-09-16
Reviewed by Gustavo Noronha Silva.
* gl.po: updated
Commit: 42108c5a66c0e3d5dd15a0b92063a8662f760e78
https://github.com/WebKit/WebKit/commit/42108c5a66c0e3d5dd15a0b92063a8662f760e78
Author: Žan Doberšek <zandobersek at gmail.com>
Date: 2013-09-16 (Mon, 16 Sep 2013)
Changed paths:
M ChangeLog
M Source/autotools/FindDependencies.m4
M Source/autotools/PrintBuildConfiguration.m4
M Source/autotools/ReadCommandLineArguments.m4
M Source/autotools/Versions.m4
Log Message:
-----------
[GTK][2.2] Enable the Wayland target by default if the GTK+ Wayland dependency is available
https://bugs.webkit.org/show_bug.cgi?id=121414
Reviewed by Martin Robinson.
* Source/autotools/FindDependencies.m4: If the Wayland target is not strictly disabled, also check that the GTK+ Wayland
package (gtk+-wayland-3.0) has a recent-enough version. If the dependency could not be satisfied, either a warning or an
error is printed out, depending if the Wayland target was required or just optional.
* Source/autotools/PrintBuildConfiguration.m4: Add a new macro, AM_APPEND_TO_DESRIPTION, that's helpful when producing
a description string that can contain multiple items that should be nicely formatted when listed in that string. This is
then used when creating the description for all the enabled targets, so for instance 'x11, wayland' string would be displayed
if both the X11 and Wayland targets are enabled.
* Source/autotools/ReadCommandLineArguments.m4: The --with-target configuration options should default to 'x11,wayland' if
not given, with the Wayland target in that case not being a hard requirement (i.e. it should be disabled if the dependencies
for the Wayland target could not be found).
* Source/autotools/Versions.m4: The GTK+ Wayland dependency should be of version 3.9.14 or greater (the 3.10 release series).
Commit: a92ec2899f985ce575dc27adddb0e14188b5038d
https://github.com/WebKit/WebKit/commit/a92ec2899f985ce575dc27adddb0e14188b5038d
Author: Gustavo Noronha Silva <kov at webkit.org>
Date: 2013-09-17 (Tue, 17 Sep 2013)
Changed paths:
M Source/WebInspectorUI/ChangeLog
M Source/WebInspectorUI/UserInterface/InspectorFrontendHostStub.js
M Source/WebInspectorUI/UserInterface/Main.js
Log Message:
-----------
Merge 155966 - Clean up the Inspector's WebSocket code and prevent it from dropping messages.
https://bugs.webkit.org/show_bug.cgi?id=121391
Reviewed by Joseph Pecoraro.
* UserInterface/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.initializeWebSocket): Added. Create the socket
and call _sendPendingMessagesToBackendIfNeeded.
(.WebInspector.InspectorFrontendHostStub.prototype.sendMessageToBackend): Store messages as pending
if the socket isn't ready yet. Call _sendPendingMessagesToBackendIfNeeded.
(.WebInspector.InspectorFrontendHostStub.prototype._sendPendingMessagesToBackendIfNeeded): Added.
* UserInterface/Main.js:
(WebInspector._initializeWebSocketIfNeeded): Move socket creation to initializeWebSocket.
Commit: 90dbe4e0123a7da653a598143d4d0b1914f7ad96
https://github.com/WebKit/WebKit/commit/90dbe4e0123a7da653a598143d4d0b1914f7ad96
Author: Gustavo Noronha Silva <kov at webkit.org>
Date: 2013-09-17 (Tue, 17 Sep 2013)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/tests/TestInspectorServer.cpp
Log Message:
-----------
Merge 155985 - [GTK] Test /webkit2/WebKitWebInspectorServer/test-open-debugging-session times out after r155714
https://bugs.webkit.org/show_bug.cgi?id=121383
Reviewed by Carlos Garcia Campos.
* UIProcess/API/gtk/tests/TestInspectorServer.cpp:
(openRemoteDebuggingSession): use the page contents' to check the remote debugging of the page
has been successfuly opened, as the title is no longer the same after the switch to the new
frontend.
Commit: 65a642c20a3bc9037bb63277c4d46116e9c6248a
https://github.com/WebKit/WebKit/commit/65a642c20a3bc9037bb63277c4d46116e9c6248a
Author: Gustavo Noronha Silva <gustavo.noronha at collabora.com>
Date: 2013-09-18 (Wed, 18 Sep 2013)
Changed paths:
M ChangeLog
M GNUmakefile.am
M LayoutTests/ChangeLog
M LayoutTests/platform/gtk/TestExpectations
M Source/WebCore/ChangeLog
M Source/WebCore/GNUmakefile.am
M Source/WebCore/WebCore.exp.in
M Source/WebInspectorUI/ChangeLog
A Source/WebInspectorUI/GNUmakefile.am
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp
M Source/WebKit/gtk/tests/testwebinspector.c
M Source/WebKit/gtk/webkit/webkitglobals.cpp
M Source/WebKit2/ChangeLog
M Source/WebKit2/GNUmakefile.am
M Source/WebKit2/UIProcess/API/gtk/tests/GNUmakefile.am
M Source/WebKit2/UIProcess/API/gtk/tests/InspectorTestServer.cpp
M Source/WebKit2/UIProcess/API/gtk/tests/TestInspector.cpp
M Source/WebKit2/UIProcess/API/gtk/tests/TestInspectorServer.cpp
M Source/WebKit2/UIProcess/InspectorServer/WebInspectorServer.h
M Source/WebKit2/UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp
M Source/WebKit2/UIProcess/WebInspectorProxy.cpp
M Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp
M Source/WebKit2/UIProcess/gtk/WebInspectorProxyGtk.cpp
M Source/WebKit2/WebProcess/WebPage/gtk/WebInspectorGtk.cpp
M Tools/ChangeLog
M Tools/GtkLauncher/main.c
M Tools/MiniBrowser/gtk/main.c
M Tools/Scripts/old-run-webkit-tests
M Tools/Scripts/run-gtk-tests
M Tools/Scripts/webkitpy/port/gtk.py
Log Message:
-----------
Merge r155714 - [GTK] Move to the new web inspector
https://bugs.webkit.org/show_bug.cgi?id=120647
Patch by Gustavo Noronha Silva <gustavo.noronha at collabora.com> on 2013-09-13
Reviewed by Carlos Garcia Campos.
.:
* GNUmakefile.am: include the new WebInspectorUI GNUmakefile.am.
Source/WebCore:
No tests for the new inspector UI as of yet.
* GNUmakefile.am: no longer install the deprecated inspector UI files.
* WebCore.exp.in: add SchemeRegistry symbol that is now used.
Source/WebInspectorUI:
* GNUmakefile.am: Added. Generate the GResource source and link it into libWebCore.
Source/WebKit/gtk:
* WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::openInspectorFrontend): update paths to the internal resource ones.
(WebKit::InspectorClient::inspectorFilesPath): ditto.
* tests/testwebinspector.c:
(consoleMessageCallback): the new inspector currently emits an error when loading, so add it to
the list of messages which are not considered failures.
* webkit/webkitglobals.cpp:
(webkitInit): register resource as a local scheme; currently used by the inspector.
Source/WebKit2:
* GNUmakefile.am: bundle the remote inspector page list HTML into libwebkit2gtk as a GResource.
* UIProcess/API/gtk/tests/GNUmakefile.am: no need to set WEBKIT_INSPECTOR_PATH anymore.
* UIProcess/API/gtk/tests/InspectorTestServer.cpp:
(main): ditto.
* UIProcess/API/gtk/tests/TestInspector.cpp:
(beforeAll): ditto.
* UIProcess/API/gtk/tests/TestInspectorServer.cpp:
(testInspectorServerPageList): update paths to the internal resource ones.
* UIProcess/InspectorServer/WebInspectorServer.h:
* UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
(WebKit::WebInspectorServer::platformResourceForPath): ditto.
(WebKit::WebInspectorServer::buildPageList): ditto.
* UIProcess/WebInspectorProxy.cpp:
(WebKit::isMainInspectorPage): factor out checking for the inspector main resource, to make
the code more readable.
(WebKit::decidePolicyForNavigationAction): use SchemeRegistry to figure out whether the
request is for a local resource instead of KURL::isLocalFile() to allow using schemes
other than file:// for the inspector resources.
* UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::inspectorPageURL): use the new internal resource URL; since it's now
static we no longer need to generate and store the string.
(WebKit::WebInspectorProxy::inspectorBaseURL): ditto.
* WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspector::localizedStringsURL): use the new internal resource URL.
* UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformInitializeWebProcess): register resource as a local scheme.
Tools:
* GtkLauncher/main.c:
(main): no longer set WEBKIT_INSPECTOR_PATH.
* MiniBrowser/gtk/main.c:
(main): ditto.
* Scripts/old-run-webkit-tests:
(openDumpTool): ditto.
* Scripts/run-gtk-tests: ditto.
* Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server): ditto.
LayoutTests:
* platform/gtk/TestExpectations: the new inspector UI does not support the current
inspector testing harness so keep it skipped, a new one will eventually be landed.
Commit: 1c6bc9bc3e819aff15673ce1b268bfec7a4914db
https://github.com/WebKit/WebKit/commit/1c6bc9bc3e819aff15673ce1b268bfec7a4914db
Author: Gustavo Noronha Silva <gns at gnome.org>
Date: 2013-09-18 (Wed, 18 Sep 2013)
Changed paths:
M Source/WebInspectorUI/ChangeLog
M Source/WebInspectorUI/GNUmakefile.am
Log Message:
-----------
Merge r156027 - [GTK] Cannot find WebInspectorUI/UserInterface/Main.html referenced in GResourceBundle.xml
https://bugs.webkit.org/show_bug.cgi?id=121405
Patch by Gustavo Noronha Silva <gns at gnome.org> on 2013-09-17
Reviewed by Carlos Garcia Campos.
* GNUmakefile.am: if srcdir == builddir the WebInspectorUI variable that is used both to list
the dependencies of the GResourceBundle and to normalize the paths added to the XML through sed
replacement will end up starting with ./, which would be fine if automake did not remove that
from the paths in the target's dependency. We deal with that by normalizing the path we use to
take that quirk into account.
Commit: 97a172d8b1ccde47c03862f72de44112d59e588a
https://github.com/WebKit/WebKit/commit/97a172d8b1ccde47c03862f72de44112d59e588a
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2013-09-18 (Wed, 18 Sep 2013)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-docs.sgml
Log Message:
-----------
Merge r156028 - [GTK] WebKitScriptWorld not in API documentation
https://bugs.webkit.org/show_bug.cgi?id=121539
Reviewed by Philippe Normand.
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add WebKitScriptWorld.
Commit: aed99717ec09c5e7423bb0ec6a3a053ad9a5a6c0
https://github.com/WebKit/WebKit/commit/aed99717ec09c5e7423bb0ec6a3a053ad9a5a6c0
Author: Carlos Garcia Campos <carlosgc at webkit.org>
Date: 2013-09-18 (Wed, 18 Sep 2013)
Changed paths:
M ChangeLog
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/NEWS
M Source/autotools/Versions.m4
Log Message:
-----------
Unreviewed. Update NEWS and Versions.m4 for 2.1.92 release.
.:
* Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
* NEWS: Add release notes.
Commit: c3d1fd085f9aba5ce00b8f97ecee983b2e730804
https://github.com/WebKit/WebKit/commit/c3d1fd085f9aba5ce00b8f97ecee983b2e730804
Author: Žan Doberšek <zandobersek at gmail.com>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M Source/autotools/Versions.m4
Log Message:
-----------
Bump the GTK+ Wayland dependency to 3.10.0 for the forthcoming 2.2 release.
Commit: 0ee92201b915afff1563192c2680bda83338b713
https://github.com/WebKit/WebKit/commit/0ee92201b915afff1563192c2680bda83338b713
Author: Žan Doberšek <zdobersek at igalia.com>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextGL.cpp
Log Message:
-----------
Merge r156261 - Unreviewed, GTK build fix when building with GTK+ 2.0.
Patch provided by Dominique Leuenberger <dimstar at opensuse.org>.
* WebCoreSupport/AcceleratedCompositingContextGL.cpp: Include GtkVersioning.h to set up
the mock GDK_IS_X11_DISPLAY macro if it's not provided by the GTK+ headers.
Commit: 37513938359fca01e01cff3df5c009005d6612c1
https://github.com/WebKit/WebKit/commit/37513938359fca01e01cff3df5c009005d6612c1
Author: Carlos Garcia Campos <carlosgc at webkit.org>
Date: 2013-09-27 (Fri, 27 Sep 2013)
Changed paths:
M ChangeLog
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/NEWS
M Source/autotools/Versions.m4
Log Message:
-----------
Unreviewed. Update NEWS and Versions.m4 for 2.2.0 release.
.:
* Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
* NEWS: Add release notes.
Commit: 4cc4b33ac0911d480d6d14b0be9200333d75dc89
https://github.com/WebKit/WebKit/commit/4cc4b33ac0911d480d6d14b0be9200333d75dc89
Author: Chris Curtis <chris_curtis at apple.com>
Date: 2013-10-07 (Mon, 07 Oct 2013)
Changed paths:
M LayoutTests/ChangeLog
M LayoutTests/fast/events/window-onerror4-expected.txt
M LayoutTests/fast/js/exception-properties-expected.txt
M LayoutTests/fast/js/global-recursion-on-full-stack-expected.txt
M LayoutTests/fast/js/mozilla/resources/js-test-pre.js
M LayoutTests/fast/js/script-tests/exception-properties.js
M LayoutTests/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt
M LayoutTests/fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html
M Source/JavaScriptCore/API/APICallbackFunction.h
M Source/JavaScriptCore/API/JSCallbackConstructor.cpp
M Source/JavaScriptCore/API/JSCallbackObjectFunctions.h
M Source/JavaScriptCore/ChangeLog
M Source/JavaScriptCore/debugger/Debugger.cpp
M Source/JavaScriptCore/debugger/DebuggerCallFrame.cpp
M Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h
M Source/JavaScriptCore/dfg/DFGOperations.cpp
M Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp
M Source/JavaScriptCore/heap/Heap.cpp
M Source/JavaScriptCore/interpreter/CallFrame.h
M Source/JavaScriptCore/interpreter/Interpreter.cpp
M Source/JavaScriptCore/interpreter/Interpreter.h
M Source/JavaScriptCore/jit/JITCode.cpp
M Source/JavaScriptCore/jit/JITExceptions.cpp
M Source/JavaScriptCore/jit/JITOpcodes.cpp
M Source/JavaScriptCore/jit/JITOpcodes32_64.cpp
M Source/JavaScriptCore/jit/JITStubs.cpp
M Source/JavaScriptCore/jit/SlowPathCall.h
M Source/JavaScriptCore/jit/ThunkGenerators.cpp
M Source/JavaScriptCore/jsc.cpp
M Source/JavaScriptCore/llint/LLIntExceptions.cpp
M Source/JavaScriptCore/llint/LLIntSlowPaths.cpp
M Source/JavaScriptCore/llint/LowLevelInterpreter.cpp
M Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm
M Source/JavaScriptCore/llint/LowLevelInterpreter64.asm
M Source/JavaScriptCore/runtime/ArrayConstructor.cpp
M Source/JavaScriptCore/runtime/CommonSlowPaths.cpp
M Source/JavaScriptCore/runtime/CommonSlowPaths.h
M Source/JavaScriptCore/runtime/CommonSlowPathsExceptions.cpp
M Source/JavaScriptCore/runtime/Completion.cpp
M Source/JavaScriptCore/runtime/Error.cpp
M Source/JavaScriptCore/runtime/Error.h
M Source/JavaScriptCore/runtime/ExceptionHelpers.cpp
M Source/JavaScriptCore/runtime/Executable.cpp
M Source/JavaScriptCore/runtime/FunctionConstructor.cpp
M Source/JavaScriptCore/runtime/JSArray.cpp
M Source/JavaScriptCore/runtime/JSCJSValue.cpp
M Source/JavaScriptCore/runtime/JSFunction.cpp
M Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h
M Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp
M Source/JavaScriptCore/runtime/JSNameScope.cpp
M Source/JavaScriptCore/runtime/JSONObject.cpp
M Source/JavaScriptCore/runtime/JSObject.cpp
M Source/JavaScriptCore/runtime/ObjectConstructor.cpp
M Source/JavaScriptCore/runtime/RegExpConstructor.cpp
M Source/JavaScriptCore/runtime/StringObject.cpp
M Source/JavaScriptCore/runtime/StringRecursionChecker.cpp
M Source/JavaScriptCore/runtime/VM.cpp
M Source/JavaScriptCore/runtime/VM.h
M Source/WebCore/ChangeLog
M Source/WebCore/bindings/js/JSAudioBufferSourceNodeCustom.cpp
M Source/WebCore/bindings/js/JSBiquadFilterNodeCustom.cpp
M Source/WebCore/bindings/js/JSCryptoCustom.cpp
M Source/WebCore/bindings/js/JSDOMBinding.cpp
M Source/WebCore/bindings/js/JSIDBDatabaseCustom.cpp
M Source/WebCore/bindings/js/JSIDBObjectStoreCustom.cpp
M Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp
M Source/WebCore/bindings/js/JSJavaScriptCallFrameCustom.cpp
M Source/WebCore/bindings/js/JSNodeFilterCondition.cpp
M Source/WebCore/bindings/js/JSOscillatorNodeCustom.cpp
M Source/WebCore/bindings/js/JSPannerNodeCustom.cpp
M Source/WebCore/bindings/js/JSSVGLengthCustom.cpp
M Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp
M Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp
M Source/WebCore/bindings/js/ScriptCallStackFactory.cpp
M Source/WebCore/bindings/js/SerializedScriptValue.cpp
M Source/WebCore/bindings/js/WorkerScriptController.cpp
M Source/WebCore/bridge/c/c_instance.cpp
M Source/WebCore/bridge/objc/objc_instance.mm
M Source/WebCore/bridge/objc/objc_runtime.mm
M Source/WebCore/bridge/objc/objc_utility.mm
M Source/WebCore/bridge/qt/qt_class.cpp
M Source/WebCore/bridge/qt/qt_instance.cpp
M Source/WebCore/bridge/runtime_array.cpp
M Source/WebCore/bridge/runtime_object.cpp
M Source/WebKit/mac/ChangeLog
M Source/WebKit/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm
M Source/WebKit/mac/Plugins/Hosted/ProxyInstance.mm
M Source/WebKit2/ChangeLog
M Source/WebKit2/WebProcess/Plugins/Netscape/JSNPObject.cpp
M Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp
Log Message:
-----------
Merge r154797 - Source/JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=119548
Refactoring Exception throws.
Patch by Chris Curtis <chris_curtis at apple.com> on 2013-08-28
Reviewed by Geoffrey Garen.
Gardening of exception throws. The act of throwing an exception was being handled in
different ways depending on whether the code was running in the LLint, Baseline JIT,
or the DFG Jit. This made development in the vm exception and error objects difficult.
* runtime/VM.cpp:
(JSC::appendSourceToError):
This function moved from the interpreter into the VM. It views the developers code
(if there is a codeBlock) to extract what was trying to be evaluated when the error
occurred.
(JSC::VM::throwException):
This function takes in the error object and sets the following:
1: The VM's exception stack
2: The VM's exception
3: Appends extra information on the error message(via appendSourceToError)
4: The error object's line number
5: The error object's column number
6: The error object's sourceURL
7: The error object's stack trace (unless it already exists because the developer
created the error object).
(JSC::VM::getExceptionInfo):
(JSC::VM::setExceptionInfo):
(JSC::VM::clearException):
(JSC::clearExceptionStack):
* runtime/VM.h:
(JSC::VM::exceptionOffset):
(JSC::VM::exception):
(JSC::VM::addressOfException):
(JSC::VM::exceptionStack):
VM exception and exceptionStack are now private data members.
* interpreter/Interpreter.h:
(JSC::ClearExceptionScope::ClearExceptionScope):
Created this structure to temporarily clear the exception within the VM. This
needed to see if addition errors occur when setting the debugger as we are
unwinding the stack.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::unwind):
Removed the code that would try to add error information if it did not exist.
All of this functionality has moved into the VM and all error information is set
at the time the error occurs.
The rest of these functions reference the new calling convention to throw an error.
* API/APICallbackFunction.h:
(JSC::APICallbackFunction::call):
* API/JSCallbackConstructor.cpp:
(JSC::constructJSCallback):
* API/JSCallbackObjectFunctions.h:
(JSC::::getOwnPropertySlot):
(JSC::::defaultValue):
(JSC::::put):
(JSC::::putByIndex):
(JSC::::deleteProperty):
(JSC::::construct):
(JSC::::customHasInstance):
(JSC::::call):
(JSC::::getStaticValue):
(JSC::::staticFunctionGetter):
(JSC::::callbackGetter):
* debugger/Debugger.cpp:
(JSC::evaluateInGlobalCallFrame):
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::evaluate):
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::emitExceptionCheck):
* dfg/DFGOperations.cpp:
(JSC::DFG::operationPutByValInternal):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::callCheck):
* heap/Heap.cpp:
(JSC::Heap::markRoots):
* interpreter/CallFrame.h:
(JSC::ExecState::clearException):
(JSC::ExecState::exception):
(JSC::ExecState::hadException):
* interpreter/Interpreter.cpp:
(JSC::eval):
(JSC::loadVarargs):
(JSC::stackTraceAsString):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
* interpreter/Interpreter.h:
(JSC::ClearExceptionScope::ClearExceptionScope):
* jit/JITCode.cpp:
(JSC::JITCode::execute):
* jit/JITExceptions.cpp:
(JSC::genericThrow):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_catch):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_catch):
* jit/JITStubs.cpp:
(JSC::returnToThrowTrampoline):
(JSC::throwExceptionFromOpCall):
(JSC::DEFINE_STUB_FUNCTION):
(JSC::jitCompileFor):
(JSC::lazyLinkFor):
(JSC::putByVal):
(JSC::cti_vm_handle_exception):
* jit/SlowPathCall.h:
(JSC::JITSlowPathCall::call):
* jit/ThunkGenerators.cpp:
(JSC::nativeForGenerator):
* jsc.cpp:
(functionRun):
(functionLoad):
(functionCheckSyntax):
* llint/LLIntExceptions.cpp:
(JSC::LLInt::doThrow):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* llint/LowLevelInterpreter.cpp:
(JSC::CLoop::execute):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* runtime/ArrayConstructor.cpp:
(JSC::constructArrayWithSizeQuirk):
* runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
* runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::opIn):
* runtime/CommonSlowPathsExceptions.cpp:
(JSC::CommonSlowPaths::interpreterThrowInCaller):
* runtime/Completion.cpp:
(JSC::evaluate):
* runtime/Error.cpp:
(JSC::addErrorInfo):
(JSC::throwTypeError):
(JSC::throwSyntaxError):
* runtime/Error.h:
(JSC::throwVMError):
* runtime/ExceptionHelpers.cpp:
(JSC::throwOutOfMemoryError):
(JSC::throwStackOverflowError):
(JSC::throwTerminatedExecutionException):
* runtime/Executable.cpp:
(JSC::EvalExecutable::create):
(JSC::FunctionExecutable::produceCodeBlockFor):
* runtime/FunctionConstructor.cpp:
(JSC::constructFunction):
(JSC::constructFunctionSkippingEvalEnabledCheck):
* runtime/JSArray.cpp:
(JSC::JSArray::defineOwnProperty):
(JSC::JSArray::put):
(JSC::JSArray::push):
* runtime/JSCJSValue.cpp:
(JSC::JSValue::toObjectSlowCase):
(JSC::JSValue::synthesizePrototype):
(JSC::JSValue::putToPrimitive):
* runtime/JSFunction.cpp:
(JSC::JSFunction::defineOwnProperty):
* runtime/JSGenericTypedArrayViewInlines.h:
(JSC::::create):
(JSC::::createUninitialized):
(JSC::::validateRange):
(JSC::::setWithSpecificType):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::decode):
(JSC::globalFuncProtoSetter):
* runtime/JSNameScope.cpp:
(JSC::JSNameScope::put):
* runtime/JSONObject.cpp:
(JSC::Stringifier::appendStringifiedValue):
(JSC::Walker::walk):
* runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::defaultValue):
(JSC::JSObject::hasInstance):
(JSC::JSObject::defaultHasInstance):
(JSC::JSObject::defineOwnNonIndexProperty):
(JSC::throwTypeError):
* runtime/ObjectConstructor.cpp:
(JSC::toPropertyDescriptor):
* runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
* runtime/StringObject.cpp:
(JSC::StringObject::defineOwnProperty):
* runtime/StringRecursionChecker.cpp:
(JSC::StringRecursionChecker::throwStackOverflowError):
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=119548
Refactoring Exception throws.
Patch by Chris Curtis <chris_curtis at apple.com> on 2013-08-28
Reviewed by Geoffrey Garen.
Gets column information from the error object for reporting exceptions.
* bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
* bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStackFromException):
Moved setting an exception into the vm, These functions changed to use the new functionality.
* bindings/js/JSAudioBufferSourceNodeCustom.cpp:
(WebCore::JSAudioBufferSourceNode::setBuffer):
* bindings/js/JSBiquadFilterNodeCustom.cpp:
(WebCore::JSBiquadFilterNode::setType):
* bindings/js/JSCryptoCustom.cpp:
(WebCore::JSCrypto::getRandomValues):
* bindings/js/JSDOMBinding.cpp:
(WebCore::setDOMException):
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::setFunctionVariableValue):
* bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::evaluate):
(WebCore::JSJavaScriptCallFrame::setVariableValue):
* bindings/js/JSNodeFilterCondition.cpp:
(WebCore::JSNodeFilterCondition::acceptNode):
* bindings/js/JSOscillatorNodeCustom.cpp:
(WebCore::JSOscillatorNode::setType):
* bindings/js/JSPannerNodeCustom.cpp:
(WebCore::JSPannerNode::setPanningModel):
(WebCore::JSPannerNode::setDistanceModel):
* bindings/js/JSSVGLengthCustom.cpp:
(WebCore::JSSVGLength::convertToSpecifiedUnits):
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::getObjectParameter):
(WebCore::JSWebGLRenderingContext::getAttachedShaders):
(WebCore::JSWebGLRenderingContext::getExtension):
(WebCore::JSWebGLRenderingContext::getFramebufferAttachmentParameter):
(WebCore::JSWebGLRenderingContext::getParameter):
(WebCore::JSWebGLRenderingContext::getProgramParameter):
(WebCore::JSWebGLRenderingContext::getShaderParameter):
(WebCore::JSWebGLRenderingContext::getUniform):
(WebCore::dataFunctionf):
(WebCore::dataFunctioni):
(WebCore::dataFunctionMatrix):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::open):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneBase::throwStackOverflow):
(WebCore::CloneDeserializer::throwValidationError):
(WebCore::SerializedScriptValue::maybeThrowExceptionIfSerializationFailed):
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
(WebCore::WorkerScriptController::setException):
* bridge/c/c_instance.cpp:
(JSC::Bindings::CInstance::moveGlobalExceptionToExecState):
(JSC::Bindings::CInstance::invokeMethod):
(JSC::Bindings::CInstance::invokeDefaultMethod):
(JSC::Bindings::CInstance::invokeConstruct):
(JSC::Bindings::CInstance::toJSPrimitive):
* bridge/objc/objc_instance.mm:
(ObjcInstance::invokeMethod):
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcArray::setValueAt):
(JSC::Bindings::ObjcArray::valueAt):
* bridge/objc/objc_utility.mm:
(JSC::Bindings::throwError):
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtField::valueFromInstance):
(JSC::Bindings::QtField::setValueToInstance):
* bridge/runtime_array.cpp:
(JSC::RuntimeArray::put):
(JSC::RuntimeArray::putByIndex):
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::throwInvalidAccessError):
Source/WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=119548
Refactoring Exception throws.
Patch by Chris Curtis <chris_curtis at apple.com> on 2013-08-28
Reviewed by Geoffrey Garen.
Moved setting an exception into the vm, These functions changed to use the new functionality.
* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
* Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::invokeMethod):
Source/WebKit2: https://bugs.webkit.org/show_bug.cgi?id=119548
Refactoring Exception throws.
Patch by Chris Curtis <chris_curtis at apple.com> on 2013-08-28
Reviewed by Geoffrey Garen.
Moved setting an exception into the vm, These functions changed to use the new functionality.
* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::callMethod):
(WebKit::JSNPObject::callObject):
(WebKit::JSNPObject::callConstructor):
(WebKit::JSNPObject::throwInvalidAccessError):
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::moveGlobalExceptionToExecState):
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=119548
Refactoring Exception throws.
Patch by Chris Curtis <chris_curtis at apple.com> on 2013-08-28
Reviewed by Geoffrey Garen.
Column/line information was added into these results.
* fast/events/window-onerror4-expected.txt:
* fast/js/global-recursion-on-full-stack-expected.txt:
fixed a variable name in a case when shouldThrowType failed.
* fast/js/mozilla/resources/js-test-pre.js:
(shouldThrowType):
Sorted the properties to allow the results always show in the same order.
* fast/js/script-tests/exception-properties.js:
* fast/js/exception-properties-expected.txt:
This test needed to be modified to have the line numbers match on the output across
wk and wk2. This test is inherently flaky because is relies on size of the available
native stack. To account for the flakiness an additional call was made to force the
results to match.
This patch now records and outputs the line number where the errors were occurring.
This was causing the test results to no longer match because of the line numbers.
By changing how to account for the flakiness, the results match again.
* fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt:
* fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html:
Commit: 3050e0b8134b63c44e81c8cbbb97108afd9101a9
https://github.com/WebKit/WebKit/commit/3050e0b8134b63c44e81c8cbbb97108afd9101a9
Author: Filip Pizlo <fpizlo at apple.com>
Date: 2013-10-07 (Mon, 07 Oct 2013)
Changed paths:
M Source/JavaScriptCore/CMakeLists.txt
M Source/JavaScriptCore/ChangeLog
M Source/JavaScriptCore/GNUmakefile.list.am
M Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj
M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
M Source/JavaScriptCore/Target.pri
M Source/JavaScriptCore/bytecode/CodeBlock.cpp
M Source/JavaScriptCore/bytecode/CodeBlock.h
A Source/JavaScriptCore/bytecode/DeferredCompilationCallback.cpp
A Source/JavaScriptCore/bytecode/DeferredCompilationCallback.h
M Source/JavaScriptCore/dfg/DFGDriver.cpp
M Source/JavaScriptCore/dfg/DFGDriver.h
M Source/JavaScriptCore/dfg/DFGFailedFinalizer.cpp
M Source/JavaScriptCore/dfg/DFGFailedFinalizer.h
M Source/JavaScriptCore/dfg/DFGFinalizer.h
M Source/JavaScriptCore/dfg/DFGJITFinalizer.cpp
M Source/JavaScriptCore/dfg/DFGJITFinalizer.h
M Source/JavaScriptCore/dfg/DFGOSRExitPreparation.cpp
M Source/JavaScriptCore/dfg/DFGOperations.cpp
M Source/JavaScriptCore/dfg/DFGPlan.cpp
M Source/JavaScriptCore/dfg/DFGPlan.h
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp
M Source/JavaScriptCore/dfg/DFGWorklist.cpp
M Source/JavaScriptCore/ftl/FTLJITFinalizer.cpp
M Source/JavaScriptCore/ftl/FTLJITFinalizer.h
M Source/JavaScriptCore/heap/Heap.h
M Source/JavaScriptCore/interpreter/Interpreter.cpp
R Source/JavaScriptCore/jit/JITDriver.h
M Source/JavaScriptCore/jit/JITStubs.cpp
A Source/JavaScriptCore/jit/JITToDFGDeferredCompilationCallback.cpp
A Source/JavaScriptCore/jit/JITToDFGDeferredCompilationCallback.h
M Source/JavaScriptCore/llint/LLIntEntrypoints.cpp
M Source/JavaScriptCore/llint/LLIntEntrypoints.h
M Source/JavaScriptCore/llint/LLIntSlowPaths.cpp
M Source/JavaScriptCore/runtime/ArrayPrototype.cpp
M Source/JavaScriptCore/runtime/CommonSlowPaths.cpp
M Source/JavaScriptCore/runtime/CompilationResult.cpp
M Source/JavaScriptCore/runtime/CompilationResult.h
M Source/JavaScriptCore/runtime/Executable.cpp
M Source/JavaScriptCore/runtime/Executable.h
R Source/JavaScriptCore/runtime/ExecutionHarness.h
Log Message:
-----------
Merge r154824 - CodeBlock compilation and installation should be simplified and rationalized
https://bugs.webkit.org/show_bug.cgi?id=120326
Reviewed by Oliver Hunt.
Rolling r154804 back in after fixing no-LLInt build.
Previously Executable owned the code for generating JIT code; you always had
to go through Executable. But often you also had to go through CodeBlock,
because ScriptExecutable couldn't have virtual methods, but CodeBlock could.
So you'd ask CodeBlock to do something, which would dispatch through a
virtual method that would select the appropriate Executable subtype's method.
This all meant that the same code would often be duplicated, because most of
the work needed to compile something was identical regardless of code type.
But then we tried to fix this, by having templatized helpers in
ExecutionHarness.h and JITDriver.h. The result was that if you wanted to find
out what happened when you asked for something to be compiled, you'd go on a
wild ride that started with CodeBlock, touched upon Executable, and then
ricocheted into either ExecutionHarness or JITDriver (likely both).
Another awkwardness was that for concurrent compiles, the DFG::Worklist had
super-special inside knowledge of what JITStubs.cpp's cti_optimize would have
done once the compilation finished.
Also, most of the DFG JIT drivers assumed that they couldn't install the
JITCode into the CodeBlock directly - instead they would return it via a
reference, which happened to be a reference to the JITCode pointer in
Executable. This was super weird.
Finally, there was no notion of compiling code into a special CodeBlock that
wasn't used for handling calls into an Executable. I'd like this for FTL OSR
entry.
This patch solves these problems by reducing all of that complexity into just
three primitives:
- Executable::newCodeBlock(). This gives you a new code block, either for call
or for construct, and either to serve as the baseline code or the optimized
code. The new code block is then owned by the caller; Executable doesn't
register it anywhere. The new code block has no JITCode and isn't callable,
but it has all of the bytecode.
- CodeBlock::prepareForExecution(). This takes the CodeBlock's bytecode and
produces a JITCode, and then installs the JITCode into the CodeBlock. This
method takes a JITType, and always compiles with that JIT. If you ask for
JITCode::InterpreterThunk then you'll get JITCode that just points to the
LLInt entrypoints. Once this returns, it is possible to call into the
CodeBlock if you do so manually - but the Executable still won't know about
it so JS calls to that Executable will still be routed to whatever CodeBlock
is associated with the Executable.
- Executable::installCode(). This takes a CodeBlock and makes it the code-for-
entry for that Executable. This involves unlinking the Executable's last
CodeBlock, if there was one. This also tells the GC about any effect on
memory usage and does a bunch of weird data structure rewiring, since
Executable caches some of CodeBlock's fields for the benefit of virtual call
fast paths.
This functionality is then wrapped around three convenience methods:
- Executable::prepareForExecution(). If there is no code block for that
Executable, then one is created (newCodeBlock()), compiled
(CodeBlock::prepareForExecution()) and installed (installCode()).
- CodeBlock::newReplacement(). Asks the Executable for a new CodeBlock that
can serve as an optimized replacement of the current one.
- CodeBlock::install(). Asks the Executable to install this code block.
This patch allows me to kill *a lot* of code and to remove a lot of
specializations for functions vs. not-functions, and a lot of places where we
pass around JITCode references and such. ExecutionHarness and JITDriver are
both gone. Overall this patch has more red than green.
It also allows me to work on FTL OSR entry and tier-up:
- FTL tier-up: this will involve DFGOperations.cpp asking the DFG::Worklist
to do some compilation, but it will require the DFG::Worklist to do
something different than what JITStubs.cpp would want, once the compilation
finishes. This patch introduces a callback mechanism for that purpose.
- FTL OSR entry: this will involve creating a special auto-jettisoned
CodeBlock that is used only for FTL OSR entry. The new set of primitives
allows for this: Executable can vend you a fresh new CodeBlock, and you can
ask that CodeBlock to compile itself with any JIT of your choosing. Or you
can take that CodeBlock and compile it yourself. Previously the act of
producing a CodeBlock-for-optimization and the act of compiling code for it
were tightly coupled; now you can separate them and you can create such
auto-jettisoned CodeBlocks that are used for a one-shot OSR entry.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::unlinkIncomingCalls):
(JSC::CodeBlock::prepareForExecutionImpl):
(JSC::CodeBlock::prepareForExecution):
(JSC::CodeBlock::prepareForExecutionAsynchronously):
(JSC::CodeBlock::install):
(JSC::CodeBlock::newReplacement):
(JSC::FunctionCodeBlock::jettisonImpl):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::hasBaselineJITProfiling):
* bytecode/DeferredCompilationCallback.cpp: Added.
(JSC::DeferredCompilationCallback::DeferredCompilationCallback):
(JSC::DeferredCompilationCallback::~DeferredCompilationCallback):
* bytecode/DeferredCompilationCallback.h: Added.
* dfg/DFGDriver.cpp:
(JSC::DFG::tryCompile):
* dfg/DFGDriver.h:
(JSC::DFG::tryCompile):
* dfg/DFGFailedFinalizer.cpp:
(JSC::DFG::FailedFinalizer::finalize):
(JSC::DFG::FailedFinalizer::finalizeFunction):
* dfg/DFGFailedFinalizer.h:
* dfg/DFGFinalizer.h:
* dfg/DFGJITFinalizer.cpp:
(JSC::DFG::JITFinalizer::finalize):
(JSC::DFG::JITFinalizer::finalizeFunction):
* dfg/DFGJITFinalizer.h:
* dfg/DFGOSRExitPreparation.cpp:
(JSC::DFG::prepareCodeOriginForOSRExit):
* dfg/DFGOperations.cpp:
* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::Plan):
(JSC::DFG::Plan::compileInThreadImpl):
(JSC::DFG::Plan::notifyReady):
(JSC::DFG::Plan::finalizeWithoutNotifyingCallback):
(JSC::DFG::Plan::finalizeAndNotifyCallback):
* dfg/DFGPlan.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGWorklist.cpp:
(JSC::DFG::Worklist::completeAllReadyPlansForVM):
(JSC::DFG::Worklist::runThread):
* ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::finalize):
(JSC::FTL::JITFinalizer::finalizeFunction):
* ftl/FTLJITFinalizer.h:
* heap/Heap.h:
(JSC::Heap::isDeferred):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
* jit/JITDriver.h: Removed.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
(JSC::jitCompileFor):
(JSC::lazyLinkFor):
* jit/JITToDFGDeferredCompilationCallback.cpp: Added.
(JSC::JITToDFGDeferredCompilationCallback::JITToDFGDeferredCompilationCallback):
(JSC::JITToDFGDeferredCompilationCallback::~JITToDFGDeferredCompilationCallback):
(JSC::JITToDFGDeferredCompilationCallback::create):
(JSC::JITToDFGDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
(JSC::JITToDFGDeferredCompilationCallback::compilationDidComplete):
* jit/JITToDFGDeferredCompilationCallback.h: Added.
* llint/LLIntEntrypoints.cpp:
(JSC::LLInt::setFunctionEntrypoint):
(JSC::LLInt::setEvalEntrypoint):
(JSC::LLInt::setProgramEntrypoint):
* llint/LLIntEntrypoints.h:
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::jitCompileAndSetHeuristics):
(JSC::LLInt::setUpCall):
* runtime/ArrayPrototype.cpp:
(JSC::isNumericCompareFunction):
* runtime/CommonSlowPaths.cpp:
* runtime/CompilationResult.cpp:
(WTF::printInternal):
* runtime/CompilationResult.h:
* runtime/Executable.cpp:
(JSC::ScriptExecutable::installCode):
(JSC::ScriptExecutable::newCodeBlockFor):
(JSC::ScriptExecutable::newReplacementCodeBlockFor):
(JSC::ScriptExecutable::prepareForExecutionImpl):
* runtime/Executable.h:
(JSC::ExecutableBase::offsetOfJITCodeWithArityCheckFor):
(JSC::ExecutableBase::offsetOfNumParametersFor):
(JSC::ScriptExecutable::prepareForExecution):
(JSC::FunctionExecutable::jettisonOptimizedCodeFor):
* runtime/ExecutionHarness.h: Removed.
Commit: 0ca0dbe6ef1ec7bcfa6975358e5084110b8b4bad
https://github.com/WebKit/WebKit/commit/0ca0dbe6ef1ec7bcfa6975358e5084110b8b4bad
Author: Chris Curtis <chris_curtis at apple.com>
Date: 2013-10-07 (Mon, 07 Oct 2013)
Changed paths:
M Source/JavaScriptCore/API/tests/testapi.c
M Source/JavaScriptCore/ChangeLog
M Source/JavaScriptCore/runtime/VM.cpp
Log Message:
-----------
Merge r155495 - WebKit crashes when trying to send a msg via 'today's birthdays' dialogue box on Facebook
https://bugs.webkit.org/show_bug.cgi?id=120612#add_comment
Patch by Chris Curtis <chris_curtis at apple.com> on 2013-09-10
Reviewed by Geoffrey Garen.
The codeBlock was assumed to exist when appendSourceToMessage was set.
This was an invalid assumption. I added a check to ensure that there is a
valid codeBlock before accessing it.
* API/tests/testapi.c:
(valueToObjectExceptionCallAsFunction):
(valueToObjectExceptionTest):
(main):
* runtime/VM.cpp:
(JSC::VM::throwException):
Commit: 0dff2a8ab4ce654f6f76da68aded8244c4a6092f
https://github.com/WebKit/WebKit/commit/0dff2a8ab4ce654f6f76da68aded8244c4a6092f
Author: Mark Hahnenberg <mhahnenb at gmail.com>
Date: 2013-10-07 (Mon, 07 Oct 2013)
Changed paths:
M Source/JavaScriptCore/ChangeLog
M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp
Log Message:
-----------
Merge r156003 - DFG doesn't properly keep scope alive for op_put_to_scope
https://bugs.webkit.org/show_bug.cgi?id=121519
Reviewed by Michael Saboff.
This was a latent bug that can't actually occur in ToT. It was uncovered by causing slow
path calls in the baseline JIT for op_put_to_scope in places where we couldn't before (but
which were necessary for gen GC).
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
Commit: ab1a06b565fd1392659cb33b728f76af7c200e7b
https://github.com/WebKit/WebKit/commit/ab1a06b565fd1392659cb33b728f76af7c200e7b
Author: changseok.oh at collabora.com <changseok.oh at collabora.com>
Date: 2013-10-07 (Mon, 07 Oct 2013)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp
Log Message:
-----------
Merge r156287 - [GTK][WK2] A plugin dirtyRect within iframe remains after moving to a different page.
https://bugs.webkit.org/show_bug.cgi?id=121600
Reviewed by Gustavo Noronha Silva.
Nowhere to destroy NetscapePlugin::m_platformPluginWidget even after destroying
an instance of NetscapePlugin. So the created GtkWidget remains visible.
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformDestroy):
Commit: e13e55d5f66d0c16399dba021360fb85090ec1bb
https://github.com/WebKit/WebKit/commit/e13e55d5f66d0c16399dba021360fb85090ec1bb
Author: Lorenzo Tilve <ltilve at igalia.com>
Date: 2013-10-07 (Mon, 07 Oct 2013)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/page/gtk/EventHandlerGtk.cpp
M Source/WebCore/platform/gtk/PasteboardGtk.cpp
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/WebCoreSupport/DragClientGtk.cpp
M Source/WebKit/gtk/WebCoreSupport/DragClientGtk.h
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp
M Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp
Log Message:
-----------
Merge r156345 - [GTK] Fix compilation problems when setting ENABLE_DRAG_SUPPORT = FALSE
https://bugs.webkit.org/show_bug.cgi?id=121782
Patch by Lorenzo Tilve <ltilve at igalia.com> on 2013-09-24
Reviewed by Martin Robinson.
Disabled drag functions.
Source/WebCore:
* page/gtk/EventHandlerGtk.cpp:
* platform/gtk/PasteboardGtk.cpp:
Source/WebKit/gtk:
* WebCoreSupport/DragClientGtk.cpp:
* WebCoreSupport/DragClientGtk.h:
Source/WebKit2:
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkit_web_view_base_class_init):
* WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
Commit: 750cde637cbd9582db8e59c00031358da3b5ad4e
https://github.com/WebKit/WebKit/commit/750cde637cbd9582db8e59c00031358da3b5ad4e
Author: Carlos Garcia Campos <carlosgc at webkit.org>
Date: 2013-10-16 (Wed, 16 Oct 2013)
Changed paths:
M ChangeLog
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/NEWS
M Source/autotools/Versions.m4
Log Message:
-----------
Unreviewed. Update NEWS and Versions.m4 for 2.2.1 release.
.:
* Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
* NEWS: Add release notes.
Commit: b3dc1b045e0d4c3e6598259146eb6c9a94f60c46
https://github.com/WebKit/WebKit/commit/b3dc1b045e0d4c3e6598259146eb6c9a94f60c46
Author: Emilio Pozuelo Monfort <pochu27 at gmail.com>
Date: 2013-11-11 (Mon, 11 Nov 2013)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp
Log Message:
-----------
Merge r158444 - Fix build on non-linux platforms
https://bugs.webkit.org/show_bug.cgi?id=123622
Patch by Emilio Pozuelo Monfort <pochu27 at gmail.com> on 2013-11-01
Reviewed by Darin Adler.
* UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
Commit: 1435ca6169cc05f7ffc6273ce3fc5ba66a5f459b
https://github.com/WebKit/WebKit/commit/1435ca6169cc05f7ffc6273ce3fc5ba66a5f459b
Author: Emilio Pozuelo Monfort <pochu27 at gmail.com>
Date: 2013-11-11 (Mon, 11 Nov 2013)
Changed paths:
M Source/WTF/ChangeLog
M Source/WTF/wtf/Platform.h
M Source/WTF/wtf/dtoa/utils.h
Log Message:
-----------
Merge r158445 - HPPA build fixes
https://bugs.webkit.org/show_bug.cgi?id=123625
Original patch from John David Anglin <dave.anglin at bell.net>
Patch by Emilio Pozuelo Monfort <pochu27 at gmail.com> on 2013-11-01
Reviewed by Darin Adler.
* wtf/Platform.h:
* wtf/dtoa/utils.h:
Commit: b0624a8811f8eff026923443bc21a1de9048ae41
https://github.com/WebKit/WebKit/commit/b0624a8811f8eff026923443bc21a1de9048ae41
Author: Lorenzo Tilve <ltilve at igalia.com>
Date: 2013-11-11 (Mon, 11 Nov 2013)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/GNUmakefile.list.am
M Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp
M Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h
Log Message:
-----------
Merge r156892 - [GTK] Enable text edition UndoOperations support in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=122305
Patch by Lorenzo Tilve <ltilve at igalia.com> on 2013-10-04
Reviewed by Carlos Garcia Campos.
Source/WebKit2:
Replaced the notImplemented() function calls for
the corresponding implementation of the edit operations
provided by the DefaultUndoController class.
* GNUmakefile.list.am:
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::clearAllEditCommands):
(WebKit::PageClientImpl::canUndoRedo):
(WebKit::PageClientImpl::executeUndoRedo):
* UIProcess/API/gtk/PageClientImpl.h:
Commit: 9fab8fed7a2eca1e51ca522e392533b462f6c91c
https://github.com/WebKit/WebKit/commit/9fab8fed7a2eca1e51ca522e392533b462f6c91c
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2013-11-11 (Mon, 11 Nov 2013)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp
Log Message:
-----------
Merge r159041 - [GTK] [WebKit2] Crash when printing to a file via javascript
https://bugs.webkit.org/show_bug.cgi?id=122801
Reviewed by Martin Robinson.
This crash is caused by a GTK+ bug, but we can work around it by
ensuring the print dialog is always shown with a valid
GtkPrintSettings object.
* UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkitPrintOperationRunDialog):
Commit: b2c5652710773032ada9b89bc49d5efe144c5824
https://github.com/WebKit/WebKit/commit/b2c5652710773032ada9b89bc49d5efe144c5824
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2013-11-11 (Mon, 11 Nov 2013)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/Shared/PrintInfo.cpp
M Source/WebKit2/Shared/PrintInfo.h
M Source/WebKit2/Shared/gtk/PrintInfoGtk.cpp
M Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp
M Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperationPrivate.h
M Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
M Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp
M Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.h
Log Message:
-----------
Merge r159042 - [GTK] Crash when printing via javascript in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=124043
Reviewed by Martin Robinson.
It happens because the print operation when started by the
WebProcess due to a DOM operation is supposed to be synchronous
and our print operation is always asynchronous. This is currently
handled only in the UI process because other ports print
synchronously in the WebProcess. In the GTK+ port we need to
notify the WebProcess that the print operation should run
synchronously when request by a DOM operation. Together with the
print settings and page setup we now send a print mode that can be
sync or async. When printing in sync mode we run a nested main loop
for the print operation, making sure that print sources have a
higher priority.
* Shared/PrintInfo.cpp:
(WebKit::PrintInfo::encode): Encode the print mode.
(WebKit::PrintInfo::decode): Decode the print mode.
* Shared/PrintInfo.h: Add PrintMode enum.
* Shared/gtk/PrintInfoGtk.cpp:
(WebKit::PrintInfo::PrintInfo): Initialize print mode.
* UIProcess/API/gtk/WebKitPrintOperation.cpp:
(drawPagesForPrintingCompleted): Do not call endPrinting() when
printing synchronously because WebPageProxy already calls it right
after sending the message to the WebProcess.
(webkitPrintOperationPrintPagesForFrame): Create the PrintInfo
struct with a print mode.
(webkitPrintOperationSetPrintMode): Helper private function to set
the print mode of the print operation.
* UIProcess/API/gtk/WebKitPrintOperationPrivate.h:
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewPrintFrame): Set sync print mode when printing due
to a UIClient request.
* WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::PrintPagesData::PrintPagesData): Create a main loop when
printing synchronously.
(WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize
print mode.
(WebKit::WebPrintOperationGtk::printPagesIdleDone): Finish the
nested main loop when printing synchronously.
(WebKit::WebPrintOperationGtk::print): Run a nested main loop when
printing synchronously.
* WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
(WebKit::WebPrintOperationGtk::printMode): Return the print mode.
Commit: 7f81c0a151cad5649e560e5d472ecb80780c5e2b
https://github.com/WebKit/WebKit/commit/7f81c0a151cad5649e560e5d472ecb80780c5e2b
Author: Carlos Garcia Campos <carlosgc at webkit.org>
Date: 2013-11-11 (Mon, 11 Nov 2013)
Changed paths:
M ChangeLog
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/NEWS
M Source/autotools/Versions.m4
Log Message:
-----------
Unreviewed. Update NEWS and Versions.m4 for 2.2.2 release.
.:
* Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
* NEWS: Add release notes.
Commit: e7acd841b4ba8bc8d8c726eac78880dfd327032a
https://github.com/WebKit/WebKit/commit/e7acd841b4ba8bc8d8c726eac78880dfd327032a
Author: Filip Pizlo <fpizlo at apple.com>
Date: 2013-12-02 (Mon, 02 Dec 2013)
Changed paths:
M Source/JavaScriptCore/ChangeLog
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp
Log Message:
-----------
Merge r158687 - Fix register allocation inside control flow in GetByVal String
https://bugs.webkit.org/show_bug.cgi?id=123816
Reviewed by Geoffrey Garen.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
Commit: a5ddc63b43d98885c18a4733739451be249f3c73
https://github.com/WebKit/WebKit/commit/a5ddc63b43d98885c18a4733739451be249f3c73
Author: Victor Jaquez <vjaquez at igalia.com>
Date: 2013-12-02 (Mon, 02 Dec 2013)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/platform/gtk/UserAgentGtk.cpp
Log Message:
-----------
Merge r159572 - [GTK] Remove Chromium as user agent and claim to be Safari in OS X
https://bugs.webkit.org/show_bug.cgi?id=124229
Reviewed by Martin Robinson.
http://www.duolingo.com/ doesn't get render correctly because it uses
Chrome/Chromium specific variables, added after it was forked. Because
of this, it is necessary to remove the Chrome/Chromium identification
in the user agent. Also, from now on, by default, The GTK+ port will
claim to be Safari in OS X to avoid loading wrong resources.
* platform/gtk/UserAgentGtk.cpp:
(WebCore::standardUserAgent):
Commit: 7720cf331a21bc42c6b9c22eb268e0503c9c6f79
https://github.com/WebKit/WebKit/commit/7720cf331a21bc42c6b9c22eb268e0503c9c6f79
Author: Žan Doberšek <zdobersek at igalia.com>
Date: 2013-12-02 (Mon, 02 Dec 2013)
Changed paths:
M LayoutTests/ChangeLog
M LayoutTests/platform/gtk/TestExpectations
Log Message:
-----------
Merge r159686 - Unreviewed GTK gardening.
Adding failure expectations for tests that regressed with r159572.
* platform/gtk/TestExpectations:
Commit: 17fc0291729e93388eb3d1cc098ff610ef365772
https://github.com/WebKit/WebKit/commit/17fc0291729e93388eb3d1cc098ff610ef365772
Author: Žan Doberšek <zdobersek at igalia.com>
Date: 2013-12-02 (Mon, 02 Dec 2013)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp
Log Message:
-----------
Merge r159811 - [GTK] Programs/WebKit2APITests/TestWebKitSettings unit test is failing
https://bugs.webkit.org/show_bug.cgi?id=124924
Reviewed by Carlos Garcia Campos.
'Chrome'/'Chromium' substrings were removed from the user agent string in r159572, meaning the unit
test shouldn't check for those two substrings anymore. Instead, 'Safari' (as until now) and 'AppleWebKit'
substrings should be checked for.
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettingsUserAgent):
Commit: 18c0b2975b019e8d114d83e20a8b954abb298546
https://github.com/WebKit/WebKit/commit/18c0b2975b019e8d114d83e20a8b954abb298546
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2013-12-02 (Mon, 02 Dec 2013)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/platform/gtk/GtkPopupMenu.cpp
Log Message:
-----------
Merge r159615 - [GTK] Cannot scroll in option menu when it larger than the screen
https://bugs.webkit.org/show_bug.cgi?id=124671
Reviewed by Martin Robinson.
The problem is that the popup menu is not resized to fit in the
screen, so it doesn't scroll and some of the items are offscreen
so they can't be selected either. GTK+ automatically resizes the
popup menus to fit in the work area, but only when the menu is
already positioned.
* platform/gtk/GtkPopupMenu.cpp:
(WebCore::GtkPopupMenu::popUp): Schedule a resize of the popup
menu right after showing it once it has a position.
Commit: 45e746291ec4e45e004d63032cc5898841046c8c
https://github.com/WebKit/WebKit/commit/45e746291ec4e45e004d63032cc5898841046c8c
Author: Gustavo Noronha Silva <gustavo.noronha at collabora.com>
Date: 2013-12-02 (Mon, 02 Dec 2013)
Changed paths:
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/tests/testwebview.c
M Source/WebKit/gtk/webkit/webkitwebview.cpp
Log Message:
-----------
Merge r159843 - REGRESSION(r154658): webkit_web_view_get_view_source_mode always returns false
https://bugs.webkit.org/show_bug.cgi?id=124954
Patch by Gustavo Noronha Silva <gustavo.noronha at collabora.com> on 2013-11-28
Reviewed by Carlos Garcia Campos.
* tests/testwebview.c: new test to ensure setting and getting source mode work as intended.
* webkit/webkitwebview.cpp:
(webkit_web_view_get_view_source_mode): actually return the value we query from WebCore.
Commit: 1566032231cebbd44d7581425e8d752375229cd4
https://github.com/WebKit/WebKit/commit/1566032231cebbd44d7581425e8d752375229cd4
Author: Filip Pizlo <fpizlo at apple.com>
Date: 2013-12-02 (Mon, 02 Dec 2013)
Changed paths:
M LayoutTests/fast/js/dfg-check-structure-elimination-for-non-cell-expected.txt
M LayoutTests/fast/js/dfg-check-two-structures-expected.txt
M LayoutTests/fast/js/dfg-compare-final-object-to-final-object-or-other-when-both-proven-final-object-expected.txt
M LayoutTests/fast/js/dfg-compare-final-object-to-final-object-or-other-when-proven-final-object-expected.txt
M LayoutTests/fast/js/dfg-constant-fold-first-local-read-after-block-merge-expected.txt
M LayoutTests/fast/js/dfg-constant-fold-logical-not-branch-expected.txt
M LayoutTests/fast/js/dfg-constant-fold-misprediction-expected.txt
M LayoutTests/fast/js/dfg-constant-fold-uncaptured-variable-that-is-later-captured-expected.txt
M LayoutTests/fast/js/dfg-convert-this-dom-window-expected.txt
M LayoutTests/fast/js/dfg-convert-this-object-then-exit-on-other-expected.txt
M LayoutTests/fast/js/dfg-convert-this-other-then-exit-on-object-expected.txt
M LayoutTests/fast/js/dfg-convert-this-polymorphic-object-then-exit-on-other-expected.txt
M LayoutTests/fast/js/dfg-convert-this-polymorphic-object-then-exit-on-string-expected.txt
M LayoutTests/fast/js/dfg-create-inlined-arguments-in-closure-inline-expected.txt
M LayoutTests/fast/js/dfg-cross-global-object-inline-new-array-literal-expected.txt
M LayoutTests/fast/js/dfg-cross-global-object-inline-new-array-literal-with-variables-expected.txt
M LayoutTests/fast/js/jsc-test-list
M LayoutTests/fast/js/script-tests/dfg-check-structure-elimination-for-non-cell.js
M LayoutTests/fast/js/script-tests/dfg-check-two-structures.js
M LayoutTests/fast/js/script-tests/dfg-compare-final-object-to-final-object-or-other-when-both-proven-final-object.js
M LayoutTests/fast/js/script-tests/dfg-compare-final-object-to-final-object-or-other-when-proven-final-object.js
M LayoutTests/fast/js/script-tests/dfg-compare-final-object-to-final-object-or-other.js
M LayoutTests/fast/js/script-tests/dfg-constant-fold-first-local-read-after-block-merge.js
M LayoutTests/fast/js/script-tests/dfg-constant-fold-logical-not-branch.js
M LayoutTests/fast/js/script-tests/dfg-constant-fold-misprediction.js
M LayoutTests/fast/js/script-tests/dfg-constant-fold-uncaptured-variable-that-is-later-captured.js
M LayoutTests/fast/js/script-tests/dfg-convert-this-dom-window.js
M LayoutTests/fast/js/script-tests/dfg-convert-this-object-then-exit-on-other.js
M LayoutTests/fast/js/script-tests/dfg-convert-this-other-then-exit-on-object.js
M LayoutTests/fast/js/script-tests/dfg-convert-this-polymorphic-object-then-exit-on-other.js
M LayoutTests/fast/js/script-tests/dfg-convert-this-polymorphic-object-then-exit-on-string.js
M LayoutTests/fast/js/script-tests/dfg-create-inlined-arguments-in-closure-inline.js
M LayoutTests/fast/js/script-tests/dfg-cross-global-object-inline-new-array-literal-with-variables.js
M LayoutTests/fast/js/script-tests/dfg-cross-global-object-inline-new-array-literal.js
M Source/JavaScriptCore/ChangeLog
M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h
M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp
M Source/JavaScriptCore/dfg/DFGFixupPhase.cpp
M Source/JavaScriptCore/dfg/DFGRepatch.cpp
M Source/JavaScriptCore/dfg/DFGSafeToExecute.h
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp
M Source/JavaScriptCore/dfg/DFGUseKind.cpp
M Source/JavaScriptCore/dfg/DFGUseKind.h
Log Message:
-----------
Merge r155201 - REGRESSION(149636, merged in 153145): ToThis conversion doesn't work in the DFG
https://bugs.webkit.org/show_bug.cgi?id=120781
Reviewed by Mark Hahnenberg.
Roll this back in with a build fix.
- Use some method table hacks to detect if the CheckStructure optimization is
valid for to_this.
- Introduce a FinalObjectUse and use it for ToThis->Identity conversion.
This looks like it might be perf-neutral on the major benchmarks, but it
introduces some horrible performance cliffs. For example if you add methods to
the Array prototype, you'll get horrible performance cliffs. As in virtual calls
to C++ every time you call a JS function even if it's inlined.
LongSpider/3d-cube appears to hit this.
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGRepatch.cpp:
(JSC::DFG::emitPutTransitionStub):
* dfg/DFGSafeToExecute.h:
(JSC::DFG::SafeToExecuteEdge::operator()):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::speculateFinalObject):
(JSC::DFG::SpeculativeJIT::speculate):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGUseKind.cpp:
(WTF::printInternal):
* dfg/DFGUseKind.h:
(JSC::DFG::typeFilterFor):
(JSC::DFG::isCell):
Commit: e9f5d5963d3300c1915a5fab92584a070c0c503a
https://github.com/WebKit/WebKit/commit/e9f5d5963d3300c1915a5fab92584a070c0c503a
Author: Gustavo Noronha Silva <gustavo.noronha at collabora.com>
Date: 2013-12-02 (Mon, 02 Dec 2013)
Changed paths:
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/webkit/webkitwebview.cpp
Log Message:
-----------
Merge r159926 - [GTK] GTK2 paint code path does not render AC layers
https://bugs.webkit.org/show_bug.cgi?id=124967
Patch by Gustavo Noronha Silva <gustavo.noronha at collabora.com> on 2013-12-02
Reviewed by Carlos Garcia Campos.
* webkit/webkitwebview.cpp:
(webkit_web_view_expose_event): also paint AC layers when painting the widget,
when AC is on.
Commit: ce2b8c64b81ad60396e8a6706aed7df4c5b39d18
https://github.com/WebKit/WebKit/commit/ce2b8c64b81ad60396e8a6706aed7df4c5b39d18
Author: Andres Gomez <agomez at igalia.com>
Date: 2013-12-04 (Wed, 04 Dec 2013)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp
Log Message:
-----------
Merge r159939 - [GTK] Fails to build with freetype 2.5.1
https://bugs.webkit.org/show_bug.cgi?id=125074
Patch by Andres Gomez <agomez at igalia.com> on 2013-12-02
Reviewed by Carlos Garcia Campos.
FreeType specifies a canonical way of including their own
headers. Now, we are following this recommendation so the
compilation won't be broken again due to an upgrade in FeeType's
including paths.
* platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:
Commit: ee9ad4d2b50783b04902ec99eaf28ed927bc2a9c
https://github.com/WebKit/WebKit/commit/ee9ad4d2b50783b04902ec99eaf28ed927bc2a9c
Author: Julien Brianceau <julien.brianceau at gmail.com>
Date: 2013-12-04 (Wed, 04 Dec 2013)
Changed paths:
M Source/JavaScriptCore/ChangeLog
M Source/JavaScriptCore/jit/JITOpcodes32_64.cpp
Log Message:
-----------
Merge r154839 - REGRESSION(r153222, 32-bit): NULL JSValue() seen when running peacekeeper benchmark.
https://bugs.webkit.org/show_bug.cgi?id=120080
Patch by Julien Brianceau <jbriance at cisco.com> on 2013-08-29
Reviewed by Michael Saboff.
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emitSlow_op_get_argument_by_val): Revert changes introduced by r153222 in this function.
Commit: dd47974808d3e1cee6d443fffc0ab8a2bb305a39
https://github.com/WebKit/WebKit/commit/dd47974808d3e1cee6d443fffc0ab8a2bb305a39
Author: Chris Curtis <chris_curtis at apple.com>
Date: 2013-12-04 (Wed, 04 Dec 2013)
Changed paths:
M Source/JavaScriptCore/ChangeLog
M Source/JavaScriptCore/runtime/ExceptionHelpers.cpp
Log Message:
-----------
Merge r154892 - Cleaning errorDescriptionForValue after r154839
https://bugs.webkit.org/show_bug.cgi?id=120531
Patch by Chris Curtis <chris_curtis at apple.com> on 2013-08-30
Reviewed by Darin Adler.
Changed the assert to ASSERT_NOT_REACHED, now that r154839 has landed. errorDescriptionForValue
can assert again that the parameterized JSValue is !isEmpty().
* runtime/ExceptionHelpers.cpp:
(JSC::errorDescriptionForValue):
Commit: fd57321c973c72ebdfdbd8e76be856832d96ef71
https://github.com/WebKit/WebKit/commit/fd57321c973c72ebdfdbd8e76be856832d96ef71
Author: Arno Renevier <a.renevier at samsung.com>
Date: 2013-12-04 (Wed, 04 Dec 2013)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/platform/graphics/cairo/BitmapImageCairo.cpp
M Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp
M Source/WebCore/platform/graphics/cairo/CairoUtilities.h
M Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp
M Source/WebCore/platform/graphics/gtk/GdkCairoUtilities.cpp
M Source/WebCore/platform/graphics/gtk/GdkCairoUtilities.h
M Source/WebCore/platform/graphics/gtk/ImageBufferGtk.cpp
M Source/WebCore/platform/graphics/gtk/ImageGtk.cpp
M Source/WebCore/platform/gtk/DragIcon.cpp
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/webkit/webkitfavicondatabase.cpp
Log Message:
-----------
Merge r154819 - [cairo] canvas drawing on itself doesn't work with accelerated canvas
https://bugs.webkit.org/show_bug.cgi?id=118808
Reviewed by Martin Robinson.
Source/WebCore:
When copying an accelerated image, we try to get its dimensions with
cairo_image_surface_get_width/cairo_image_surface_get_height. As
surface is not an image, this returns width and height of 0.
Many other places use cairo_image_surface_get although the surface may
be a gl surface.
This patch fixes those issues by implementing a cairoSurfaceSize
helper that returns the surface size whatever type it is.
It use cairo_surface_create_similar instead of
cairo_image_surface_create in copyCairoImageSurface. It also calls
cairo_paint in encodeImage when a drawing over a black background is
needed.
It copies the surface to an image surface if needed in extractImage.
No new tests. Covered by existing tests.
* platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::checkForSolidColor):
* platform/graphics/cairo/CairoUtilities.cpp:
(WebCore::copyCairoImageSurface):
(WebCore::cairoSurfaceSize):
* platform/graphics/cairo/CairoUtilities.h:
* platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
* platform/graphics/gtk/GdkCairoUtilities.cpp:
(cairoSurfaceToGdkPixbuf):
* platform/graphics/gtk/GdkCairoUtilities.h:
* platform/graphics/gtk/ImageBufferGtk.cpp:
(WebCore::encodeImage):
* platform/graphics/gtk/ImageGtk.cpp:
(WebCore::BitmapImage::getGdkPixbuf):
* platform/gtk/DragIcon.cpp:
(WebCore::DragIcon::setImage):
Source/WebKit/gtk:
Change cairoImageSurfaceToGdkPixbuf to cairoSurfaceToGdkPixbuf.
* webkit/webkitfavicondatabase.cpp:
(getIconPixbufSynchronously):
Commit: faedf9448e3a28053501b4b54bad3249a843b531
https://github.com/WebKit/WebKit/commit/faedf9448e3a28053501b4b54bad3249a843b531
Author: Aloisio Almeida Jr <aloisio.almeida at openbossa.org>
Date: 2013-12-04 (Wed, 04 Dec 2013)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/platform/graphics/cairo/PlatformContextCairo.cpp
Log Message:
-----------
Merge r159314 - [Cairo] Avoid extra copy when drawing images
https://bugs.webkit.org/show_bug.cgi?id=124209
Patch by Aloisio Almeida Jr <aloisio.almeida at openbossa.org> on 2013-11-14
Reviewed by Martin Robinson.
To solve the bug #58309 a cairo subsurface is being used to limit the
source image boundaries.
In many cases, when a cairo subsurface is used for drawing an image,
it occurs an image copy, causing performance penalty. In the case of
the function PlatformContextCairo::drawSurfaceToContext, the image
copy always happens.
So, we should use the subsurface only when it's really necessary.
In cases where we're drawing the whole image, the subsurface is
unnecessary.
The proposed patch avoid the use of subsurfaces when sampling the whole
image.
No new tests. It's an enhancement. Already covered by existing tests.
* platform/graphics/cairo/PlatformContextCairo.cpp:
(WebCore::PlatformContextCairo::drawSurfaceToContext):
Commit: a148f6b452f571e8ec2c4de1e49918bd5d6abfd7
https://github.com/WebKit/WebKit/commit/a148f6b452f571e8ec2c4de1e49918bd5d6abfd7
Author: Carlos Garcia Campos <carlosgc at webkit.org>
Date: 2013-12-04 (Wed, 04 Dec 2013)
Changed paths:
M ChangeLog
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/NEWS
M Source/autotools/Versions.m4
Log Message:
-----------
Unreviewed. Update NEWS and Versions.m4 for 2.2.3 release.
.:
* Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
* NEWS: Add release notes.
Commit: 54721993280396ecd735caf178d634ce40e8c436
https://github.com/WebKit/WebKit/commit/54721993280396ecd735caf178d634ce40e8c436
Author: Gustavo Noronha Silva <gns at gnome.org>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/platform/gtk/UserAgentGtk.cpp
Log Message:
-----------
Merge r160354 - [GTK] REGRESSION: www.yahoo.com redirects to the mobile version after UA change
https://bugs.webkit.org/show_bug.cgi?id=125444
Reviewed by Martin Robinson.
* platform/gtk/UserAgentGtk.cpp:
(WebCore::platformVersionForUAString): more correctly pretend we're Mac OS X.
(WebCore::standardUserAgent): ditto.
Commit: 7adef5907f8b6255d09470831e6f2ab3f2733d10
https://github.com/WebKit/WebKit/commit/7adef5907f8b6255d09470831e6f2ab3f2733d10
Author: Allan Sandfeld Jensen <allan.jensen at digia.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M LayoutTests/ChangeLog
R LayoutTests/http/conf/apache2-debian-httpd.conf
A LayoutTests/http/conf/debian-httpd-2.2.conf
A LayoutTests/http/conf/debian-httpd-2.4.conf
M Tools/ChangeLog
M Tools/Scripts/webkitpy/port/base.py
Log Message:
-----------
Merge r154736 - Http tests fails on Debian with Apache 2.4
https://bugs.webkit.org/show_bug.cgi?id=120352
Reviewed by Andreas Kling.
Tools:
Select httpd.conf file for debian based on version, matching Fedora behavior.
* Scripts/webkitpy/port/base.py:
(Port._apache_config_file_name_for_platform):
LayoutTests:
Added an apache 2.4 configuration file adapted from Fedora's,
and renamed the 2.2 file to have consistent naming.
* http/conf/debian-httpd-2.2.conf: Renamed from LayoutTests/http/conf/apache2-debian-httpd.conf.
* http/conf/debian-httpd-2.4.conf: Added.
Commit: 07872debe8537f5082289c931cc04622d38d519a
https://github.com/WebKit/WebKit/commit/07872debe8537f5082289c931cc04622d38d519a
Author: Nick Diego Yamane <nick.yamane at openbossa.org>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Tools/ChangeLog
M Tools/gtk/jhbuild.modules
Log Message:
-----------
Merge r158866 - [Gtk] Disable LTO when building cairo
https://bugs.webkit.org/show_bug.cgi?id=123954
Patch by Nick Diego Yamane <nick.yamane at openbossa.org> on 2013-11-07
Reviewed by Martin Robinson.
Cairo always uses LTO, when it detects compiler support.
LTO is buggy in many/all versions of GCC and shouldn't be enabled by
default. This patch disables LTO when building cairo library.
- See: https://bugs.freedesktop.org/show_bug.cgi?id=60852
With gcc 4.7.3, for example, the build fails with the following message:
'lto1: fatal error: LTO_tags out of range: Range is 0 to 361, value is 15872'
* gtk/jhbuild.modules:
Commit: c1cf8e2560b67a8c8d4fdf5d9c10ebe1a3d45792
https://github.com/WebKit/WebKit/commit/c1cf8e2560b67a8c8d4fdf5d9c10ebe1a3d45792
Author: Alberto Garcia <berto at igalia.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M ChangeLog
M Source/autotools/ReadCommandLineArguments.m4
Log Message:
-----------
Merge r160215 - [GTK] Enable web audio by default
https://bugs.webkit.org/show_bug.cgi?id=124888
Reviewed by Martin Robinson.
When building with ./configure, enable_web_audio defaults to
"no". However the basic functionality has been working for months
so it's safe to enable it now.
* Source/autotools/ReadCommandLineArguments.m4:
Commit: 257c7e1b7040c33018702b6a92a0df2a3a3b7e0c
https://github.com/WebKit/WebKit/commit/257c7e1b7040c33018702b6a92a0df2a3a3b7e0c
Author: Gustavo Noronha Silva <gns at gnome.org>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/platform/gtk/WidgetBackingStoreGtkX11.cpp
Log Message:
-----------
Merge r160269 - ubuntu software center hits _XReadEvents() error
https://bugs.webkit.org/show_bug.cgi?id=123480
Reviewed by Martin Robinson.
* platform/gtk/WidgetBackingStoreGtkX11.cpp:
(WebCore::WidgetBackingStoreGtkX11::~WidgetBackingStoreGtkX11): clear the surface
before freeing the associated pixmap.
Commit: 431d373c8e70b1efbfc6ff27bd792318e5c5e509
https://github.com/WebKit/WebKit/commit/431d373c8e70b1efbfc6ff27bd792318e5c5e509
Author: Dean Jackson <dino at apple.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Source/ThirdParty/ANGLE/ChangeLog
M Source/ThirdParty/ANGLE/src/compiler/debug.cpp
Log Message:
-----------
Merge r158807 - kTraceBufferLen is unused in default builds
https://bugs.webkit.org/show_bug.cgi?id=123941
<rdar://problem/15409804>
Reviewed by Tim Horton.
kTraceBufferLen is not used in debug.cpp if TRACE_ENABLED is
not defined. This causes a warning in newer builds of clang.
For now, skip warnings on unused variables until we
update from ANGLE.
* src/compiler/debug.cpp: Add unused-variable ignore pragma.
Commit: af669926889f7088ec8df96e314fad3e5b572465
https://github.com/WebKit/WebKit/commit/af669926889f7088ec8df96e314fad3e5b572465
Author: Roger Fong <roger_fong at apple.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Source/ThirdParty/ANGLE/ANGLE.plist
M Source/ThirdParty/ANGLE/ChangeLog
R Source/ThirdParty/ANGLE/DerivedSources.make
M Source/ThirdParty/ANGLE/GNUmakefile.am
M Source/ThirdParty/ANGLE/include/EGL/egl.h
R Source/ThirdParty/ANGLE/include/EGL/eglsoftlinking.h
M Source/ThirdParty/ANGLE/include/GLES2/gl2.h
R Source/ThirdParty/ANGLE/include/GLES2/gl2softlinking.h
M Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h
M Source/ThirdParty/ANGLE/include/KHR/khrplatform.h
A Source/ThirdParty/ANGLE/src/ANGLE.sln
M Source/ThirdParty/ANGLE/src/build_angle.gypi
M Source/ThirdParty/ANGLE/src/common/debug.h
A Source/ThirdParty/ANGLE/src/common/event_tracer.cpp
A Source/ThirdParty/ANGLE/src/common/event_tracer.h
M Source/ThirdParty/ANGLE/src/common/version.h
A Source/ThirdParty/ANGLE/src/compiler/CodeGen.cpp
R Source/ThirdParty/ANGLE/src/compiler/CodeGenGLSL.cpp
R Source/ThirdParty/ANGLE/src/compiler/CodeGenHLSL.cpp
M Source/ThirdParty/ANGLE/src/compiler/Common.h
M Source/ThirdParty/ANGLE/src/compiler/Compiler.cpp
M Source/ThirdParty/ANGLE/src/compiler/ConstantUnion.h
M Source/ThirdParty/ANGLE/src/compiler/DetectDiscontinuity.cpp
M Source/ThirdParty/ANGLE/src/compiler/InfoSink.h
M Source/ThirdParty/ANGLE/src/compiler/InitializeDll.cpp
M Source/ThirdParty/ANGLE/src/compiler/InitializeDll.h
A Source/ThirdParty/ANGLE/src/compiler/InitializeGLPosition.cpp
A Source/ThirdParty/ANGLE/src/compiler/InitializeGLPosition.h
M Source/ThirdParty/ANGLE/src/compiler/InitializeGlobals.h
M Source/ThirdParty/ANGLE/src/compiler/InitializeParseContext.cpp
M Source/ThirdParty/ANGLE/src/compiler/InitializeParseContext.h
M Source/ThirdParty/ANGLE/src/compiler/IntermTraverse.cpp
M Source/ThirdParty/ANGLE/src/compiler/Intermediate.cpp
M Source/ThirdParty/ANGLE/src/compiler/MapLongVariableNames.cpp
M Source/ThirdParty/ANGLE/src/compiler/MapLongVariableNames.h
A Source/ThirdParty/ANGLE/src/compiler/NodeSearch.h
M Source/ThirdParty/ANGLE/src/compiler/OutputGLSLBase.cpp
M Source/ThirdParty/ANGLE/src/compiler/OutputGLSLBase.h
M Source/ThirdParty/ANGLE/src/compiler/OutputHLSL.cpp
M Source/ThirdParty/ANGLE/src/compiler/OutputHLSL.h
A Source/ThirdParty/ANGLE/src/compiler/ParseContext.cpp
A Source/ThirdParty/ANGLE/src/compiler/ParseContext.h
R Source/ThirdParty/ANGLE/src/compiler/ParseHelper.cpp
R Source/ThirdParty/ANGLE/src/compiler/ParseHelper.h
M Source/ThirdParty/ANGLE/src/compiler/PoolAlloc.cpp
M Source/ThirdParty/ANGLE/src/compiler/PoolAlloc.h
M Source/ThirdParty/ANGLE/src/compiler/SearchSymbol.h
M Source/ThirdParty/ANGLE/src/compiler/ShHandle.h
M Source/ThirdParty/ANGLE/src/compiler/ShaderLang.cpp
M Source/ThirdParty/ANGLE/src/compiler/SymbolTable.cpp
M Source/ThirdParty/ANGLE/src/compiler/SymbolTable.h
M Source/ThirdParty/ANGLE/src/compiler/Types.h
M Source/ThirdParty/ANGLE/src/compiler/UnfoldShortCircuit.cpp
M Source/ThirdParty/ANGLE/src/compiler/UnfoldShortCircuit.h
A Source/ThirdParty/ANGLE/src/compiler/UnfoldShortCircuitAST.cpp
A Source/ThirdParty/ANGLE/src/compiler/UnfoldShortCircuitAST.h
M Source/ThirdParty/ANGLE/src/compiler/Uniform.cpp
M Source/ThirdParty/ANGLE/src/compiler/Uniform.h
M Source/ThirdParty/ANGLE/src/compiler/ValidateLimitations.cpp
M Source/ThirdParty/ANGLE/src/compiler/VariableInfo.cpp
M Source/ThirdParty/ANGLE/src/compiler/VariableInfo.h
M Source/ThirdParty/ANGLE/src/compiler/debug.cpp
M Source/ThirdParty/ANGLE/src/compiler/depgraph/DependencyGraph.cpp
M Source/ThirdParty/ANGLE/src/compiler/depgraph/DependencyGraphBuilder.cpp
M Source/ThirdParty/ANGLE/src/compiler/generate_parser.sh
M Source/ThirdParty/ANGLE/src/compiler/glslang.l
M Source/ThirdParty/ANGLE/src/compiler/glslang.y
M Source/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp
M Source/ThirdParty/ANGLE/src/compiler/glslang_tab.cpp
M Source/ThirdParty/ANGLE/src/compiler/glslang_tab.h
M Source/ThirdParty/ANGLE/src/compiler/intermediate.h
M Source/ThirdParty/ANGLE/src/compiler/localintermediate.h
M Source/ThirdParty/ANGLE/src/compiler/parseConst.cpp
M Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.cpp
M Source/ThirdParty/ANGLE/src/compiler/preprocessor/ExpressionParser.y
M Source/ThirdParty/ANGLE/src/compiler/preprocessor/Preprocessor.cpp
M Source/ThirdParty/ANGLE/src/compiler/preprocessor/Preprocessor.h
M Source/ThirdParty/ANGLE/src/compiler/preprocessor/Tokenizer.cpp
M Source/ThirdParty/ANGLE/src/compiler/preprocessor/Tokenizer.h
M Source/ThirdParty/ANGLE/src/compiler/preprocessor/Tokenizer.l
M Source/ThirdParty/ANGLE/src/compiler/preprocessor/generate_parser.sh
A Source/ThirdParty/ANGLE/src/compiler/preprocessor/preprocessor.vcxproj
A Source/ThirdParty/ANGLE/src/compiler/preprocessor/preprocessor.vcxproj.filters
M Source/ThirdParty/ANGLE/src/compiler/timing/RestrictFragmentShaderTiming.cpp
A Source/ThirdParty/ANGLE/src/compiler/translator.vcxproj
A Source/ThirdParty/ANGLE/src/compiler/translator.vcxproj.filters
M Source/ThirdParty/ANGLE/src/compiler/util.cpp
M Source/ThirdParty/ANGLE/src/compiler/util.h
M Source/ThirdParty/ANGLE/src/libEGL/Surface.cpp
M Source/ThirdParty/ANGLE/src/libEGL/libEGL.cpp
M Source/ThirdParty/ANGLE/src/libEGL/libEGL.rc
A Source/ThirdParty/ANGLE/src/libEGL/libEGL.vcxproj
A Source/ThirdParty/ANGLE/src/libEGL/libEGL.vcxproj.filters
M Source/ThirdParty/ANGLE/src/libGLESv2/Buffer.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/Buffer.h
M Source/ThirdParty/ANGLE/src/libGLESv2/Context.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/Context.h
M Source/ThirdParty/ANGLE/src/libGLESv2/Framebuffer.h
M Source/ThirdParty/ANGLE/src/libGLESv2/ProgramBinary.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/ProgramBinary.h
M Source/ThirdParty/ANGLE/src/libGLESv2/Renderbuffer.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/Renderbuffer.h
M Source/ThirdParty/ANGLE/src/libGLESv2/Shader.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/Shader.h
M Source/ThirdParty/ANGLE/src/libGLESv2/Texture.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/Uniform.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/Uniform.h
R Source/ThirdParty/ANGLE/src/libGLESv2/constants.h
M Source/ThirdParty/ANGLE/src/libGLESv2/libGLESv2.def
M Source/ThirdParty/ANGLE/src/libGLESv2/libGLESv2.rc
A Source/ThirdParty/ANGLE/src/libGLESv2/libGLESv2.vcxproj
A Source/ThirdParty/ANGLE/src/libGLESv2/libGLESv2.vcxproj.filters
M Source/ThirdParty/ANGLE/src/libGLESv2/precompiled.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/Image11.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/Image11.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/IndexBuffer.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/IndexBuffer.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/IndexBuffer11.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/IndexDataManager.cpp
A Source/ThirdParty/ANGLE/src/libGLESv2/renderer/IndexRangeCache.cpp
A Source/ThirdParty/ANGLE/src/libGLESv2/renderer/IndexRangeCache.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/InputLayoutCache.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/InputLayoutCache.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/RenderTarget11.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/RenderTarget11.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/Renderer.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/Renderer.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/Renderer11.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/Renderer11.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/Renderer9.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/Renderer9.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/SwapChain.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/SwapChain11.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/SwapChain9.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/TextureStorage11.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/VertexBuffer.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/VertexBuffer.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/VertexBuffer11.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/VertexBuffer11.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/VertexBuffer9.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/VertexBuffer9.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/VertexDataManager.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/VertexDataManager.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/renderer11_utils.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/shaders/compiled/clear11vs.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/shaders/compiled/clearmultiple11ps.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/shaders/compiled/clearsingle11ps.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/shaders/compiled/componentmaskps.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/shaders/compiled/flipyvs.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/shaders/compiled/luminanceps.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/shaders/compiled/passthrough11vs.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/shaders/compiled/passthroughlum11ps.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/shaders/compiled/passthroughlumalpha11ps.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/shaders/compiled/passthroughps.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/shaders/compiled/passthroughrgb11ps.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/shaders/compiled/passthroughrgba11ps.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/shaders/compiled/standardvs.h
M Source/ThirdParty/ANGLE/src/libGLESv2/renderer/shaders/generate_shaders.bat
M Source/ThirdParty/ANGLE/src/libGLESv2/utilities.cpp
M Source/ThirdParty/ANGLE/src/libGLESv2/utilities.h
M Source/ThirdParty/ANGLE/src/third_party/murmurhash/MurmurHash3.cpp
M Source/ThirdParty/ANGLE/src/third_party/murmurhash/MurmurHash3.h
A Source/ThirdParty/ANGLE/src/third_party/trace_event/trace_event.h
M Source/WebCore/ChangeLog
M Source/WebCore/platform/graphics/ANGLEWebKitBridge.cpp
Log Message:
-----------
Merge r159533 - Update ANGLE sources.
https://bugs.webkit.org/show_bug.cgi?id=124615.
Reviewed by Dean Jackson.
Tests covered by Khronos WebGL conformance tests.
Update ANGLE to checkout a60e0805721f62c28a55faf2df74472cc5fc91fc.
Modify xcodeproj files as necessary, update plist.
Stop using DerivedSources.make and just use the generated sources that are checked into ANGLE.
Add a note to bison generated files indicating that Apple elects to distribute said files under the BSD license:
ExpressionParser.cpp, glslang_tab.cpp, glslang_tab.h.
* ANGLE.plist:
* ANGLE.xcodeproj/project.pbxproj:
* DerivedSources.make: Removed.
* platform/graphics/ANGLEWebKitBridge.cpp: Resolve a build error that resulted from updating ANGLE.
(WebCore::getSymbolInfo):
(WebCore::ANGLEWebKitBridge::compileShaderSource):
* include/EGL/egl.h:
* include/EGL/eglsoftlinking.h: Removed.
* include/GLES2/gl2.h:
* include/GLES2/gl2softlinking.h: Removed.
* include/GLSLANG/ShaderLang.h:
* include/KHR/khrplatform.h:
* src/ANGLE.sln: Added.
* src/build_angle.gypi:
* src/common/debug.h:
* src/common/event_tracer.cpp: Added.
(gl::TraceGetTraceCategoryEnabledFlag):
(gl::TraceAddTraceEvent):
* src/common/event_tracer.h: Added.
* src/common/version.h:
* src/compiler/CodeGen.cpp: Added.
(ConstructCompiler):
(DeleteCompiler):
* src/compiler/CodeGenGLSL.cpp: Removed.
* src/compiler/CodeGenHLSL.cpp: Removed.
* src/compiler/Common.h:
(NewPoolTString):
* src/compiler/Compiler.cpp:
(TCompiler::Init):
(TCompiler::compile):
(TCompiler::InitBuiltInSymbolTable):
(TCompiler::clearResults):
(TCompiler::collectVariables):
* src/compiler/ConstantUnion.h:
* src/compiler/DetectDiscontinuity.cpp:
* src/compiler/InfoSink.h:
* src/compiler/InitializeDll.cpp:
(InitProcess):
(DetachProcess):
* src/compiler/InitializeDll.h:
* src/compiler/InitializeGLPosition.cpp: Added.
(InitializeGLPosition::visitAggregate):
(InitializeGLPosition::insertCode):
* src/compiler/InitializeGLPosition.h: Added.
(InitializeGLPosition::InitializeGLPosition):
(InitializeGLPosition::visitBinary):
(InitializeGLPosition::visitUnary):
(InitializeGLPosition::visitSelection):
(InitializeGLPosition::visitLoop):
(InitializeGLPosition::visitBranch):
* src/compiler/InitializeGlobals.h:
* src/compiler/InitializeParseContext.cpp:
(InitializeParseContextIndex):
(FreeParseContextIndex):
(SetGlobalParseContext):
(GetGlobalParseContext):
* src/compiler/InitializeParseContext.h:
* src/compiler/IntermTraverse.cpp:
(TIntermSymbol::traverse):
(TIntermConstantUnion::traverse):
(TIntermBinary::traverse):
(TIntermUnary::traverse):
(TIntermAggregate::traverse):
(TIntermSelection::traverse):
(TIntermLoop::traverse):
(TIntermBranch::traverse):
* src/compiler/Intermediate.cpp:
(GetHigherPrecision):
(getOperatorString):
(TIntermLoop::replaceChildNode):
(TIntermBranch::replaceChildNode):
(TIntermBinary::replaceChildNode):
(TIntermUnary::replaceChildNode):
(TIntermAggregate::replaceChildNode):
(TIntermSelection::replaceChildNode):
(TIntermOperator::isAssignment):
(TIntermediate::promoteConstantUnion):
* src/compiler/MapLongVariableNames.cpp:
* src/compiler/MapLongVariableNames.h:
* src/compiler/NodeSearch.h: Added.
(sh::NodeSearchTraverser::NodeSearchTraverser):
(sh::NodeSearchTraverser::found):
(sh::NodeSearchTraverser::search):
(sh::FindDiscard::visitBranch):
(sh::FindSideEffectRewriting::visitBinary):
* src/compiler/OutputGLSLBase.cpp:
(TOutputGLSLBase::visitSelection):
(TOutputGLSLBase::visitAggregate):
(TOutputGLSLBase::visitLoop):
* src/compiler/OutputGLSLBase.h:
* src/compiler/OutputHLSL.cpp:
(sh::OutputHLSL::OutputHLSL):
(sh::OutputHLSL::header):
(sh::OutputHLSL::visitBinary):
(sh::OutputHLSL::visitSelection):
(sh::OutputHLSL::visitBranch):
(sh::OutputHLSL::handleExcessiveLoop):
(sh::OutputHLSL::addConstructor):
* src/compiler/OutputHLSL.h:
* src/compiler/ParseContext.cpp: Added.
(TParseContext::parseVectorFields):
(TParseContext::parseMatrixFields):
(TParseContext::recover):
(TParseContext::error):
(TParseContext::warning):
(TParseContext::trace):
(TParseContext::assignError):
(TParseContext::unaryOpError):
(TParseContext::binaryOpError):
(TParseContext::precisionErrorCheck):
(TParseContext::lValueErrorCheck):
(TParseContext::constErrorCheck):
(TParseContext::integerErrorCheck):
(TParseContext::globalErrorCheck):
(TParseContext::reservedErrorCheck):
(TParseContext::constructorErrorCheck):
(TParseContext::voidErrorCheck):
(TParseContext::boolErrorCheck):
(TParseContext::samplerErrorCheck):
(TParseContext::structQualifierErrorCheck):
(TParseContext::parameterSamplerErrorCheck):
(TParseContext::containsSampler):
(TParseContext::arraySizeErrorCheck):
(TParseContext::arrayQualifierErrorCheck):
(TParseContext::arrayTypeErrorCheck):
(TParseContext::arrayErrorCheck):
(TParseContext::nonInitConstErrorCheck):
(TParseContext::nonInitErrorCheck):
(TParseContext::paramErrorCheck):
(TParseContext::extensionErrorCheck):
(TParseContext::supportsExtension):
(TParseContext::isExtensionEnabled):
(TParseContext::findFunction):
(TParseContext::executeInitializer):
(TParseContext::areAllChildConst):
(TParseContext::addConstructor):
(TParseContext::foldConstConstructor):
(TParseContext::constructBuiltIn):
(TParseContext::constructStruct):
(TParseContext::addConstVectorNode):
(TParseContext::addConstMatrixNode):
(TParseContext::addConstArrayNode):
(TParseContext::addConstStruct):
(TParseContext::enterStructDeclaration):
(TParseContext::exitStructDeclaration):
(TParseContext::structNestingErrorCheck):
(TParseContext::addIndexExpression):
(PaParseStrings):
* src/compiler/ParseContext.h: Added.
(TParseContext::TParseContext):
(TParseContext::numErrors):
(TParseContext::infoSink):
(TParseContext::pragma):
(TParseContext::extensionBehavior):
* src/compiler/ParseHelper.cpp: Removed.
* src/compiler/ParseHelper.h: Removed.
* src/compiler/PoolAlloc.cpp:
(InitializePoolIndex):
(FreePoolIndex):
(GetGlobalPoolAllocator):
(SetGlobalPoolAllocator):
* src/compiler/PoolAlloc.h:
(pool_allocator::pool_allocator):
* src/compiler/SearchSymbol.h:
* src/compiler/ShHandle.h:
(TCompiler::getVaryings):
* src/compiler/ShaderLang.cpp:
(checkVariableMaxLengths):
(ShInitialize):
(ShFinalize):
(ShConstructCompiler):
(ShCompile):
(ShGetInfo):
(ShGetVariableInfo):
(ShCheckVariablesWithinPackingLimits):
* src/compiler/SymbolTable.cpp:
(TSymbolTable::~TSymbolTable):
* src/compiler/SymbolTable.h:
(TSymbol::TSymbol):
(TSymbolTableLevel::insert):
(TSymbolTable::push):
(TSymbolTable::pop):
(TSymbolTable::findBuiltIn):
(TSymbolTable::relateToExtension):
(TSymbolTable::setDefaultPrecision):
(TSymbolTable::getDefaultPrecision):
(TSymbolTable::supportsPrecision):
* src/compiler/Types.h:
(NewPoolTFieldList):
(TType::TType):
(TType::setNominalSize):
(TPublicType::setAggregate):
* src/compiler/UnfoldShortCircuit.cpp:
(sh::UnfoldShortCircuit::visitBinary):
(sh::UnfoldShortCircuit::visitSelection):
* src/compiler/UnfoldShortCircuit.h:
* src/compiler/UnfoldShortCircuitAST.cpp: Added.
(UnfoldShortCircuitAST::visitBinary):
(UnfoldShortCircuitAST::updateTree):
* src/compiler/UnfoldShortCircuitAST.h: Added.
(UnfoldShortCircuitAST::UnfoldShortCircuitAST):
(UnfoldShortCircuitAST::NodeUpdateEntry::NodeUpdateEntry):
* src/compiler/Uniform.cpp:
(sh::Uniform::Uniform):
* src/compiler/Uniform.h:
* src/compiler/ValidateLimitations.cpp:
(ValidateLimitations::validateFunctionCall):
(ValidateLimitations::validateOperation):
* src/compiler/VariableInfo.cpp:
(TVariableInfo::TVariableInfo):
(CollectVariables::CollectVariables):
(CollectVariables::visitSymbol):
(CollectVariables::visitAggregate):
* src/compiler/VariableInfo.h:
* src/compiler/debug.cpp:
* src/compiler/depgraph/DependencyGraph.cpp:
* src/compiler/depgraph/DependencyGraphBuilder.cpp:
(TDependencyGraphBuilder::visitBinary):
* src/compiler/generate_parser.sh:
* src/compiler/glslang.l:
* src/compiler/glslang.y:
* src/compiler/glslang_lex.cpp:
(input):
(yyerror):
(int_constant):
(float_constant):
(glslang_scan):
* src/compiler/glslang_tab.cpp:
(yysyntax_error):
(glslang_parse):
* src/compiler/glslang_tab.h:
* src/compiler/intermediate.h:
(TIntermSymbol::hasSideEffects):
(TIntermSymbol::replaceChildNode):
(TIntermConstantUnion::hasSideEffects):
(TIntermConstantUnion::getIConst):
(TIntermConstantUnion::getFConst):
(TIntermConstantUnion::getBConst):
(TIntermConstantUnion::replaceChildNode):
(TIntermOperator::hasSideEffects):
(TIntermBinary::hasSideEffects):
(TIntermUnary::hasSideEffects):
(TIntermAggregate::hasSideEffects):
(TIntermSelection::hasSideEffects):
(TIntermTraverser::~TIntermTraverser):
(TIntermTraverser::incrementDepth):
(TIntermTraverser::decrementDepth):
(TIntermTraverser::getParentNode):
* src/compiler/localintermediate.h:
* src/compiler/parseConst.cpp:
* src/compiler/preprocessor/ExpressionParser.cpp:
(yy_symbol_print):
(yy_stack_print):
(yy_reduce_print):
(yystrlen):
(yystpcpy):
(yytnamerr):
(yysyntax_error):
(yydestruct):
(yyparse):
* src/compiler/preprocessor/ExpressionParser.y:
* src/compiler/preprocessor/Preprocessor.cpp:
(pp::Preprocessor::setMaxTokenLength):
(pp::Preprocessor::lex):
* src/compiler/preprocessor/Preprocessor.h:
* src/compiler/preprocessor/Tokenizer.cpp:
(pp::Tokenizer::Tokenizer):
(pp::Tokenizer::lex):
* src/compiler/preprocessor/Tokenizer.h:
(pp::Tokenizer::setMaxTokenLength):
* src/compiler/preprocessor/Tokenizer.l:
* src/compiler/preprocessor/generate_parser.sh:
* src/compiler/preprocessor/preprocessor.vcxproj: Added.
* src/compiler/preprocessor/preprocessor.vcxproj.filters: Added.
* src/compiler/timing/RestrictFragmentShaderTiming.cpp:
* src/compiler/translator.vcxproj: Added.
* src/compiler/translator.vcxproj.filters: Added.
* src/compiler/util.cpp:
(atof_clamp):
(atoi_clamp):
* src/compiler/util.h:
* src/libEGL/Surface.cpp:
(egl::Surface::checkForOutOfDateSwapChain):
* src/libEGL/libEGL.cpp:
* src/libEGL/libEGL.rc:
* src/libEGL/libEGL.vcxproj: Added.
* src/libEGL/libEGL.vcxproj.filters: Added.
* src/libGLESv2/Buffer.cpp:
(gl::Buffer::bufferData):
(gl::Buffer::bufferSubData):
(gl::Buffer::size):
(gl::Buffer::getIndexRangeCache):
* src/libGLESv2/Buffer.h:
* src/libGLESv2/Context.cpp:
(gl::Context::applyTextures):
(gl::Context::getBoundFramebufferTextureSerials):
* src/libGLESv2/Context.h:
(gl::Context::getRenderer):
* src/libGLESv2/Framebuffer.h:
* src/libGLESv2/ProgramBinary.cpp:
(gl::DiscardWorkaround):
(gl::ProgramBinary::load):
(gl::ProgramBinary::link):
(gl::ProgramBinary::linkAttributes):
(gl::AttributeSorter::AttributeSorter):
(gl::ProgramBinary::initAttributesByLayout):
(gl::ProgramBinary::sortAttributesByLayout):
* src/libGLESv2/ProgramBinary.h:
* src/libGLESv2/Renderbuffer.cpp:
(gl::RenderbufferTexture2D::getTextureSerial):
(gl::RenderbufferTextureCubeMap::getTextureSerial):
(gl::Renderbuffer::getTextureSerial):
* src/libGLESv2/Renderbuffer.h:
(gl::RenderbufferStorage::getTextureSerial):
* src/libGLESv2/Shader.cpp:
(gl::Shader::parseVaryings):
(gl::Shader::uncompile):
* src/libGLESv2/Shader.h:
* src/libGLESv2/Texture.cpp:
(gl::TextureCubeMap::storage):
* src/libGLESv2/Uniform.cpp:
(gl::Uniform::Uniform):
(gl::Uniform::~Uniform):
(gl::Uniform::isArray):
(gl::Uniform::elementCount):
* src/libGLESv2/Uniform.h:
* src/libGLESv2/constants.h: Removed.
* src/libGLESv2/libGLESv2.def:
* src/libGLESv2/libGLESv2.rc:
* src/libGLESv2/libGLESv2.vcxproj: Added.
* src/libGLESv2/libGLESv2.vcxproj.filters: Added.
* src/libGLESv2/precompiled.h:
* src/libGLESv2/renderer/Image11.cpp:
(rx::Image11::generateMipmap):
(rx::Image11::loadData):
(rx::Image11::loadCompressedData):
(rx::Image11::copy):
(rx::Image11::createStagingTexture):
(rx::Image11::map):
* src/libGLESv2/renderer/Image11.h:
* src/libGLESv2/renderer/IndexBuffer.cpp:
(rx::IndexBufferInterface::mapBuffer):
(rx::StaticIndexBufferInterface::getIndexRangeCache):
* src/libGLESv2/renderer/IndexBuffer.h:
* src/libGLESv2/renderer/IndexBuffer11.cpp:
(rx::IndexBuffer11::mapBuffer):
* src/libGLESv2/renderer/IndexDataManager.cpp:
(rx::IndexDataManager::prepareIndexData):
(rx::IndexDataManager::getCountingIndices):
* src/libGLESv2/renderer/IndexRangeCache.cpp: Added.
(rx::IndexRangeCache::addRange):
(rx::IndexRangeCache::invalidateRange):
(rx::IndexRangeCache::findRange):
(rx::IndexRangeCache::clear):
(rx::IndexRangeCache::IndexRange::IndexRange):
(rx::IndexRangeCache::IndexRange::operator<):
(rx::IndexRangeCache::IndexBounds::IndexBounds):
* src/libGLESv2/renderer/IndexRangeCache.h: Added.
* src/libGLESv2/renderer/InputLayoutCache.cpp:
(rx::InputLayoutCache::InputLayoutCache):
(rx::InputLayoutCache::clear):
(rx::InputLayoutCache::markDirty):
(rx::InputLayoutCache::applyVertexBuffers):
(rx::InputLayoutCache::hashInputLayout):
(rx::InputLayoutCache::compareInputLayouts):
* src/libGLESv2/renderer/InputLayoutCache.h:
(rx::InputLayoutCache::InputLayoutKey::begin):
(rx::InputLayoutCache::InputLayoutKey::end):
* src/libGLESv2/renderer/RenderTarget11.cpp:
(rx::RenderTarget11::getTexture):
(rx::RenderTarget11::getRenderTargetView):
(rx::RenderTarget11::getDepthStencilView):
(rx::RenderTarget11::getShaderResourceView):
* src/libGLESv2/renderer/RenderTarget11.h:
* src/libGLESv2/renderer/Renderer.cpp:
(rx::Renderer::initializeCompiler):
* src/libGLESv2/renderer/Renderer.h:
* src/libGLESv2/renderer/Renderer11.cpp:
(rx::Renderer11::initialize):
(rx::Renderer11::applyPrimitiveType):
(rx::Renderer11::applyRenderTarget):
(rx::Renderer11::drawLineLoop):
(rx::Renderer11::drawTriangleFan):
(rx::Renderer11::applyUniforms):
(rx::Renderer11::clear):
(rx::Renderer11::markAllStateDirty):
(rx::Renderer11::copyImage):
(rx::Renderer11::compileToExecutable):
(rx::Renderer11::getRenderTargetResource):
(rx::Renderer11::blitRenderbufferRect):
* src/libGLESv2/renderer/Renderer11.h:
* src/libGLESv2/renderer/Renderer9.cpp:
(rx::Renderer9::initialize):
(rx::Renderer9::setViewport):
(rx::Renderer9::drawLineLoop):
(rx::Renderer9::compileToExecutable):
* src/libGLESv2/renderer/Renderer9.h:
* src/libGLESv2/renderer/SwapChain.h:
* src/libGLESv2/renderer/SwapChain11.cpp:
(rx::SwapChain11::resetOffscreenTexture):
(rx::SwapChain11::reset):
(rx::SwapChain11::swapRect):
* src/libGLESv2/renderer/SwapChain9.cpp:
(rx::convertInterval):
* src/libGLESv2/renderer/TextureStorage11.cpp:
(rx::TextureStorage11::IsTextureFormatRenderable):
(rx::TextureStorage11::generateMipmapLayer):
(rx::TextureStorage11_Cube::getRenderTarget):
* src/libGLESv2/renderer/VertexBuffer.cpp:
(rx::VertexBufferInterface::storeVertexAttributes):
(rx::VertexBufferInterface::storeRawData):
(rx::VertexBufferInterface::reserveVertexSpace):
(rx::StaticVertexBufferInterface::lookupAttribute):
(rx::StaticVertexBufferInterface::storeVertexAttributes):
* src/libGLESv2/renderer/VertexBuffer.h:
* src/libGLESv2/renderer/VertexBuffer11.cpp:
(rx::VertexBuffer11::getSpaceRequired):
* src/libGLESv2/renderer/VertexBuffer11.h:
* src/libGLESv2/renderer/VertexBuffer9.cpp:
(rx::VertexBuffer9::storeVertexAttributes):
(rx::VertexBuffer9::getSpaceRequired):
(rx::VertexBuffer9::requiresConversion):
(rx::VertexBuffer9::getVertexSize):
(rx::VertexBuffer9::spaceRequired):
* src/libGLESv2/renderer/VertexBuffer9.h:
* src/libGLESv2/renderer/VertexDataManager.cpp:
(rx::elementsInBuffer):
(rx::StreamingBufferElementCount):
(rx::VertexDataManager::prepareVertexData):
* src/libGLESv2/renderer/VertexDataManager.h:
* src/libGLESv2/renderer/renderer11_utils.cpp:
(gl_d3d11::ConvertTextureFormat):
* src/libGLESv2/renderer/shaders/compiled/clear11vs.h:
* src/libGLESv2/renderer/shaders/compiled/clearmultiple11ps.h:
* src/libGLESv2/renderer/shaders/compiled/clearsingle11ps.h:
* src/libGLESv2/renderer/shaders/compiled/componentmaskps.h:
* src/libGLESv2/renderer/shaders/compiled/flipyvs.h:
* src/libGLESv2/renderer/shaders/compiled/luminanceps.h:
* src/libGLESv2/renderer/shaders/compiled/passthrough11vs.h:
* src/libGLESv2/renderer/shaders/compiled/passthroughlum11ps.h:
* src/libGLESv2/renderer/shaders/compiled/passthroughlumalpha11ps.h:
* src/libGLESv2/renderer/shaders/compiled/passthroughps.h:
* src/libGLESv2/renderer/shaders/compiled/passthroughrgb11ps.h:
* src/libGLESv2/renderer/shaders/compiled/passthroughrgba11ps.h:
* src/libGLESv2/renderer/shaders/compiled/standardvs.h:
* src/libGLESv2/renderer/shaders/generate_shaders.bat:
* src/libGLESv2/utilities.cpp:
(gl::ComputeTypeSize):
* src/libGLESv2/utilities.h:
* src/third_party/murmurhash/MurmurHash3.cpp:
(rotl32):
(rotl64):
(getblock):
(fmix):
(MurmurHash3_x86_32):
(MurmurHash3_x86_128):
(MurmurHash3_x64_128):
* src/third_party/murmurhash/MurmurHash3.h:
* src/third_party/trace_event: Added.
* src/third_party/trace_event/trace_event.h: Added.
(gl::TraceEvent::TraceID::TraceID):
(gl::TraceEvent::TraceID::data):
(gl::TraceEvent::TraceStringWithCopy::TraceStringWithCopy):
(gl::TraceEvent::TraceStringWithCopy::operator const char* ):
(gl::TraceEvent::setTraceValue):
(gl::TraceEvent::addTraceEvent):
(gl::TraceEvent::TraceEndOnScopeClose::TraceEndOnScopeClose):
(gl::TraceEvent::TraceEndOnScopeClose::~TraceEndOnScopeClose):
(gl::TraceEvent::TraceEndOnScopeClose::initialize):
(gl::TraceEvent::TraceEndOnScopeClose::addEventIfEnabled):
(gl::TraceEvent::SamplingStateScope::SamplingStateScope):
(gl::TraceEvent::SamplingStateScope::~SamplingStateScope):
(gl::TraceEvent::SamplingStateScope::current):
(gl::TraceEvent::SamplingStateScope::set):
Commit: 7a96504507117cd14101b84f3a072a25d1f237c5
https://github.com/WebKit/WebKit/commit/7a96504507117cd14101b84f3a072a25d1f237c5
Author: Dean Jackson <dino at apple.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/html/canvas/WebGLRenderingContext.cpp
M Source/WebCore/html/canvas/WebGLShader.cpp
M Source/WebCore/html/canvas/WebGLShader.h
Log Message:
-----------
Merge r156971 - [WebGL] program should not be able to link if a bad shader is attached
https://bugs.webkit.org/show_bug.cgi?id=94036
Reviewed by Darin Adler.
If you attempt to link a program when bad shaders are attached, the
link should fail. WebGL also requires that the previously linked
program should remain intact. We were doing the former, but not
the latter.
Fix this by not calling glLinkProgram if we know we have bad
shaders, and synthesize a bad link status instead.
Test: WebGL conformance test conformance/programs/program-test.html
(found in LayoutTests/webgl)
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::compileShader): Mark a shader as valid
if it compiled ok.
(WebCore::WebGLRenderingContext::linkProgram): Don't call into GraphicsContext3D::linkProgram
if we know that we don't have valid shaders.
* html/canvas/WebGLShader.cpp:
(WebCore::WebGLShader::WebGLShader): Initialize m_isValid.
* html/canvas/WebGLShader.h:
(WebCore::WebGLShader::isValid): New member variable getter and setter.
(WebCore::WebGLShader::setValid):
Commit: 7bdde26c391f6327c63426ce6b7cf12744ab9938
https://github.com/WebKit/WebKit/commit/7bdde26c391f6327c63426ce6b7cf12744ab9938
Author: Roger Fong <roger_fong at apple.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/html/canvas/WebGLRenderingContext.cpp
M Source/WebCore/platform/graphics/ANGLEWebKitBridge.cpp
M Source/WebCore/platform/graphics/ANGLEWebKitBridge.h
M Source/WebCore/platform/graphics/GraphicsContext3D.h
M Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp
M Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp
Log Message:
-----------
Merge r160223 - Hook into some shader symbol logic following the ANGLE update in r159533.
https://bugs.webkit.org/show_bug.cgi?id=125332.
Reviewed by Brent Fulgham.
No new functionality added.
* html/canvas/WebGLRenderingContext.cpp: Add some error checking for errors related to
shader symbols that exist across both vertex and fragment shaders.
(WebCore::WebGLRenderingContext::linkProgram):
* platform/graphics/ANGLEWebKitBridge.cpp: Add logic for handling varyings
and add new fields to the ANGLEShaderSymbol struct.
(WebCore::getSymbolInfo):
* platform/graphics/ANGLEWebKitBridge.h:
* platform/graphics/GraphicsContext3D.h: Add those same fields to the SymbolInfo struct
as well so that we can access them from our shader source map.
Also add a map of varyings along side the uniforms and attributes.
(WebCore::GraphicsContext3D::SymbolInfo::SymbolInfo):
(WebCore::GraphicsContext3D::ShaderSourceEntry::symbolMap):
* platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::areProgramSymbolsValid): Will be filled in later, this method
will use the shader source map to check for issues with unused varyings and precisions
mismatches of shader symbols that exist across both the vertex and fragment shaders.
Commit: 55c926b6c6b69f8631b216ae2c4e6ba75005de77
https://github.com/WebKit/WebKit/commit/55c926b6c6b69f8631b216ae2c4e6ba75005de77
Author: Gustavo Noronha Silva <gustavo.noronha at collabora.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Source/ThirdParty/ANGLE/ChangeLog
M Source/ThirdParty/ANGLE/GNUmakefile.am
Log Message:
-----------
Merge r160705 - [GTK] Some ANGLE headers missing from dist
https://bugs.webkit.org/show_bug.cgi?id=125782
Patch by Gustavo Noronha Silva <gustavo.noronha at collabora.com> on 2013-12-17
Reviewed by Carlos Garcia Campos.
* GNUmakefile.am: add a few headers that were missing from the build,
causing build failures when the system headers were incompatible.
Commit: 500bbea6044538118eb72b250e3d26a753bc9a9f
https://github.com/WebKit/WebKit/commit/500bbea6044538118eb72b250e3d26a753bc9a9f
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp
Log Message:
-----------
Merge r160480 - [GTK] Make sure unit tests don't use GVFS and dconf
https://bugs.webkit.org/show_bug.cgi?id=125620
Reviewed by Martin Robinson.
They should use the local vfs and the gsettings memory backend.
* UIProcess/API/gtk/tests/TestMain.cpp:
(main):
Commit: b2324630671bdfc31ddf504f145953461b74a86d
https://github.com/WebKit/WebKit/commit/b2324630671bdfc31ddf504f145953461b74a86d
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.cpp
Log Message:
-----------
Merge r160481 - [GTK] WebProcess tests are failing with newer glib
https://bugs.webkit.org/show_bug.cgi?id=125621
Reviewed by Martin Robinson.
Newer versions of glib unset the DISPLAY env variable in
g_test_dbus_up(). The WebProcess needs the DISPLAY variable to
work, and it's important to keep its value when running the tests
under Xvfb.
* UIProcess/API/gtk/tests/WebProcessTestRunner.cpp:
(WebProcessTestRunner::WebProcessTestRunner): Restore the DISPLAY
env variable after calling g_test_dbus_up().
Commit: 32266a4a748ae4c7d519a5a8c6ae4a3a0d8ae7bd
https://github.com/WebKit/WebKit/commit/32266a4a748ae4c7d519a5a8c6ae4a3a0d8ae7bd
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/tests/DOMNodeTest.cpp
M Source/WebKit2/UIProcess/API/gtk/tests/TestDOMNode.cpp
Log Message:
-----------
Merge r160540 - [GTK] Add a unit tests to WebKit2 to test node names
https://bugs.webkit.org/show_bug.cgi?id=125686
Reviewed by Gustavo Noronha Silva.
* UIProcess/API/gtk/tests/DOMNodeTest.cpp:
(WebKitDOMNodeTest::testTagNames):
(WebKitDOMNodeTest::runTest):
(registerTests):
* UIProcess/API/gtk/tests/TestDOMNode.cpp:
(testWebKitDOMNodeTagNames):
(beforeAll):
Commit: 99f4cdbf73ee5c63ba9ec854e7817ce015a1e32b
https://github.com/WebKit/WebKit/commit/99f4cdbf73ee5c63ba9ec854e7817ce015a1e32b
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp
Log Message:
-----------
Merge r160904 - [GTK] Some unit tests using web extensions fail when run alone
https://bugs.webkit.org/show_bug.cgi?id=126002
Reviewed by Gustavo Noronha Silva.
The problem is that the page is created before the dbus connection
has been established, and we are connecting to web-page-created
signal once we have a valid dbus connection. We should connect to
the signal before connecting to dbus and queue any request to emit
a dbus signal until the connection is set. This also fixes the
WebExtensions tests when using the network process because a new
web process is launched for every test case.
* UIProcess/API/gtk/tests/WebExtensionTest.cpp:
(DelayedSignal::DelayedSignal): Helper struct to queue signal
emissions requested before the dbus connection has been
established.
(emitDocumentLoaded): Emit the dbus DocumentLoaded signal.
(documentLoadedCallback): Queue the signal emission if we still
don't have a connection or call emitDocumentLoaded otherwise.
(emitURIChanged): Emit the dbus URIChanged signal.
(uriChangedCallback): Queue the signal emission if we still don't
have a connection or call emitURIChanged otherwise.
(pageCreatedCallback): Pass the web extension as user data to
document-loaded and uri-changed callbacks.
(busAcquiredCallback): Set the connection as user data of the web
extension and process any delayed signal emission pending.
(webkit_web_extension_initialize): Connect to web-page-create
signal before connecting to dbus.
Commit: 6399d1245dfe4d55aa007cf2deddaaff60136216
https://github.com/WebKit/WebKit/commit/6399d1245dfe4d55aa007cf2deddaaff60136216
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp
Log Message:
-----------
Merge r160965 - [GTK] Test /webkit2/WebKitWebResource/mime-type fails when run after /webkit2/WebKitWebView/resources
https://bugs.webkit.org/show_bug.cgi?id=126119
Reviewed by Martin Robinson.
The problem is that when the blank.ico resource is loaded from the
disk cache, the mime type is null, because the soup cache doesn't
cache sniffed mime types. This doesn't happen when a resource is
loaded form the memory cache, because the ResourceResponse is
cached, not only the headers. I think the disk cache should also
cache the sniffed content type, but that needs to be done in
soup. For now we can workaround the issue in the unit test by
making sure that resources that can be cached, also include the
Content-Type header, this way the mime type won't be sniffed and
it will be cached as a HTTP header in the disk cache.
* UIProcess/API/gtk/tests/TestResources.cpp:
(serverCallback): Add Content-Type header for resources that can
be cached.
Commit: bc7591a3e5cc0713c649d5499470f529b1b87b61
https://github.com/WebKit/WebKit/commit/bc7591a3e5cc0713c649d5499470f529b1b87b61
Author: Anton Obzhirov <a.obzhirov at samsung.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp
M Tools/ChangeLog
M Tools/Scripts/run-gtk-tests
Log Message:
-----------
Merge r158002 - [GTK] [WebKit2] CanHandleRequest API test fails
https://bugs.webkit.org/show_bug.cgi?id=88453
Patch by Anton Obzhirov <a.obzhirov at samsung.com> on 2013-10-25
Reviewed by Martin Robinson.
Source/WebKit2:
Make WebPage::platformCanHandleRequest return false by default
for unknown schemes.
* WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformCanHandleRequest):
Tools:
* Scripts/run-gtk-tests:
(TestRunner):
Commit: 8867fb7ad8ca033e3a48616508d0fed7a259cc0c
https://github.com/WebKit/WebKit/commit/8867fb7ad8ca033e3a48616508d0fed7a259cc0c
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Tools/ChangeLog
M Tools/Scripts/run-gtk-tests
Log Message:
-----------
Merge r160987 - [GTK] run-gtk-tests should always run glib tests with -k option
https://bugs.webkit.org/show_bug.cgi?id=126132
Reviewed by Philippe Normand.
With -k command line option, gtester continues running all other
test cases after a failure.
* Scripts/run-gtk-tests:
(TestRunner._run_test_glib): Use -k option when runing glib tests
to not stop on failure.
Commit: 82e291ee6ff51974e32a16b30804f79a2b864b3a
https://github.com/WebKit/WebKit/commit/82e291ee6ff51974e32a16b30804f79a2b864b3a
Author: Mario Sanchez Prada <mario at webkit.org>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M LayoutTests/ChangeLog
A LayoutTests/accessibility/paragraph-with-linebreaks.html
A LayoutTests/platform/efl/accessibility/paragraph-with-linebreaks-expected.txt
A LayoutTests/platform/gtk/accessibility/paragraph-with-linebreaks-expected.txt
M Source/WebCore/ChangeLog
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/html/parser/HTMLParserIdioms.h
M Tools/ChangeLog
M Tools/Scripts/run-gtk-tests
Log Message:
-----------
Merge r155428 - [GTK] Test /webkit/atk/getTextInParagraphAndBodyModerate fails
https://bugs.webkit.org/show_bug.cgi?id=105538
Reviewed by Chris Fleizach.
Source/WebCore:
Expose '\n' for linebreaks when they were explicitly set by the
author of the web content with a <br> tag.
Tests: accessibility/paragraph-with-linebreaks.html
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::shouldAddSpaceBeforeAppendingNextElement): Helper
function to decide when to append spaces when building the text
under an element, considering line breaks.
(WebCore::AccessibilityNodeObject::textUnderElement): Use the
shouldAddSpaceBeforeAppendingNextElement() function here.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement): Return the
renderer's text for accessibility objects exposing <br> elements.
* html/parser/HTMLParserIdioms.h:
(WebCore::isHTMLSpaceButNotLineBreak): New helper function, useful
to be passed to other functions like simplifyWhiteSpace().
Tools:
Unskip passing test getTextInParagraphAndBodyModerate.
* Scripts/run-gtk-tests:
(TestRunner): Unskip pasing test.
LayoutTests:
Added new Layout test and platform specific expectations.
* platform/efl/accessibility/paragraph-with-linebreaks-expected.txt: Added.
* platform/gtk/accessibility/paragraph-with-linebreaks-expected.txt: Added.
* accessibility/paragraph-with-linebreaks.html: Added.
Commit: 50d32b357189bdce263eb26e2f8571f83e1aab98
https://github.com/WebKit/WebKit/commit/50d32b357189bdce263eb26e2f8571f83e1aab98
Author: Mario Sanchez Prada <mario at webkit.org>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Tools/ChangeLog
M Tools/Scripts/run-gtk-tests
Log Message:
-----------
Merge r155038 - REGRESSION (r132328): /WebKit2APITests/TestWebKitAccessibility unit test is failing
https://bugs.webkit.org/show_bug.cgi?id=100408
Unreviewed gardening. Unskip TestWebKitAccessibility after
manually checking that it's running properly in the bot.
* Scripts/run-gtk-tests:
(TestRunner): Unskipped TestWebKitAccessibility.
Commit: e7bb8eaff16d6fa9f817a36346f7833f9b16c35f
https://github.com/WebKit/WebKit/commit/e7bb8eaff16d6fa9f817a36346f7833f9b16c35f
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Tools/ChangeLog
M Tools/Scripts/run-gtk-tests
Log Message:
-----------
Merge r155605 - [GTK] run-gtk-tests option --skipped=ignore doesn't work when the entire suite is skipped
https://bugs.webkit.org/show_bug.cgi?id=121218
Reviewed by Philippe Normand.
Skipping the entire suite was added to skip tests when they can't
be run because of the environment, for example to skip the a11y
tests when the at-spi daemons fail to start. This is no longer
true for all the cases, so we can disable the tests that are
impossible to run instead of skipping them.
* Scripts/run-gtk-tests:
(TestRunner.__init__): Initialize the skipped tests list.
(TestRunner._setup_testing_environment): Add
TestWebKitAccessibility path to the list of disabled tests when
at-spi daemon fail to start.
(TestRunner._should_run_test_program): Check first if the test
program is disabled and then whether it's skipped honoring the
skipped command line option.
Commit: cc19ffccb5818214659cd486fb3a97cae5110dc2
https://github.com/WebKit/WebKit/commit/cc19ffccb5818214659cd486fb3a97cae5110dc2
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/tests/GNUmakefile.am
A Source/WebKit2/UIProcess/API/gtk/tests/TestAuthentication.cpp
A Source/WebKit2/UIProcess/API/gtk/tests/TestUIClient.cpp
M Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp
M Tools/ChangeLog
M Tools/Scripts/run-gtk-tests
Log Message:
-----------
Merge r161138 - [GTK] Split WebKit2APITests/TestWebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=126284
Reviewed by Philippe Normand.
Source/WebKit2:
WebKitWebView test is too big already making more difficult to
handle timeouts and skipped tests. Split it in 3 by moving
UIClient and auth tests to their own files.
* UIProcess/API/gtk/tests/GNUmakefile.am:
* UIProcess/API/gtk/tests/TestAuthentication.cpp: Added.
(testWebViewAuthenticationRequest):
(testWebViewAuthenticationCancel):
(testWebViewAuthenticationLoadCancelled):
(testWebViewAuthenticationFailure):
(testWebViewAuthenticationNoCredential):
(testWebViewAuthenticationStorage):
(testWebViewAuthenticationSuccess):
(serverCallback):
(beforeAll):
(afterAll):
* UIProcess/API/gtk/tests/TestUIClient.cpp: Added.
(testWebViewCreateReadyClose):
(checkMimeTypeForFilter):
(testWebViewAllowModalDialogs):
(testWebViewDisallowModalDialogs):
(testWebViewJavaScriptDialogs):
(testWebViewWindowProperties):
(testWebViewMouseTarget):
(testWebViewPermissionRequests):
(testWebViewFileChooserRequest):
(beforeAll):
(afterAll):
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(beforeAll):
(afterAll):
Tools:
Skip only WebKitWebView/mouse-target and all TestAuthentication
tests that are timing out when running under xvfb.
* Scripts/run-gtk-tests:
(TestRunner):
Commit: f9af55f88fd29bcd70378473d8d26a84506c2dc2
https://github.com/WebKit/WebKit/commit/f9af55f88fd29bcd70378473d8d26a84506c2dc2
Author: Žan Doberšek <zdobersek at igalia.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/platform/graphics/GLContext.cpp
Log Message:
-----------
Merge r160997 - webkit gtk 2.2.3 stable tarball compilation error
https://bugs.webkit.org/show_bug.cgi?id=125987
Reviewed by Gustavo Noronha Silva.
Only try including <gdk/gdkwayland.h> and using GDK_IS_WAYLAND_DISPLAY if the Wayland support has been
enabled and when not compiling with GTK+ 2 (which occurs when building for libPlatformGtk2).
* platform/graphics/GLContext.cpp:
(WebCore::GLContext::createContextForWindow):
Commit: 322587913e8d19d89341af88c2c3b63bc775d200
https://github.com/WebKit/WebKit/commit/322587913e8d19d89341af88c2c3b63bc775d200
Author: Lukasz Gajowy <l.gajowy at samsung.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M LayoutTests/ChangeLog
A LayoutTests/accessibility/aria-mappings-expected.txt
A LayoutTests/accessibility/aria-mappings.html
A LayoutTests/platform/mac/accessibility/aria-mappings-expected.txt
M Source/WebCore/ChangeLog
M Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp
M Tools/ChangeLog
M Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp
M Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp
Log Message:
-----------
Merge r160220 - [ATK] Missing aria roles mappings
https://bugs.webkit.org/show_bug.cgi?id=117729
Patch by Lukasz Gajowy <l.gajowy at samsung.com> on 2013-12-06
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Added a few mappings from ARIA roles to ATK roles.
Test: accessibility/aria-mappings.html
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
Tools:
Added new mappings to AccessibilityUIElementAtk.cpp.
* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
LayoutTests:
Added new test, checking whether ARIA roles to ATK roles mappings work properly.
* accessibility/aria-mappings-expected.txt: Added.
* accessibility/aria-mappings.html: Added.
* platform/mac/accessibility/aria-mappings-expected.txt: Added.
Commit: ef0106dd2ac99e0c062b1d4dd15707da16ad3da3
https://github.com/WebKit/WebKit/commit/ef0106dd2ac99e0c062b1d4dd15707da16ad3da3
Author: Gustavo Noronha Silva <gns at gnome.org>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/tests/testatkroles.c
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp
Log Message:
-----------
Merge r160270 - Fix API test expectation following 160220.
Rubber-stamped by Martin Robinson.
Source/WebKit/gtk:
* tests/testatkroles.c:
(finish_loading): rename variable documentFrame -> document.
(test_webkit_atk_get_role_document_frame): check for ATK_ROLE_DOCUMENT_WEB instead of
ATK_ROLE_DOCUMENT_FRAME.
(test_webkit_atk_get_role_heading): rename variable documentFrame -> document.
(test_webkit_atk_get_role_image): ditto.
(test_webkit_atk_get_role_link): ditto.
(test_webkit_atk_get_role_list_and_item): ditto.
(test_webkit_atk_get_role_paragraph): ditto.
(test_webkit_atk_get_role_section): ditto.
(test_webkit_atk_get_role_table): ditto.
(test_webkit_atk_get_role_separator): ditto.
(test_webkit_atk_get_role_combobox): ditto.
(test_webkit_atk_get_role_form): ditto.
(test_webkit_atk_get_role_check_box): ditto.
(test_webkit_atk_get_role_entry): ditto.
(test_webkit_atk_get_role_label): ditto.
(test_webkit_atk_get_role_listbox): ditto.
(test_webkit_atk_get_role_password_text): ditto.
(test_webkit_atk_get_role_push_button): ditto.
(test_webkit_atk_get_role_radio_button): ditto.
Source/WebKit2:
* UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp:
(testAtspiBasicHierarchy): check for ATK_ROLE_DOCUMENT_WEB instead of ATK_ROLE_DOCUMENT_FRAME.
Commit: 4aaf2dbbaba735f2d54eb256d49c013aa7ea063e
https://github.com/WebKit/WebKit/commit/4aaf2dbbaba735f2d54eb256d49c013aa7ea063e
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M ChangeLog
M GNUmakefile.am
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/GNUmakefile.am
R Source/WebKit/gtk/tests/resources/blank.ico
R Source/WebKit/gtk/tests/resources/test.html
R Source/WebKit/gtk/tests/resources/test.ogg
R Source/WebKit/gtk/tests/resources/test.pdf
R Source/WebKit/gtk/tests/resources/test.txt
R Source/WebKit/gtk/tests/test_utils.c
R Source/WebKit/gtk/tests/test_utils.h
R Source/WebKit/gtk/tests/testapplicationcache.c
R Source/WebKit/gtk/tests/testatk.c
R Source/WebKit/gtk/tests/testatkroles.c
R Source/WebKit/gtk/tests/testcontextmenu.c
R Source/WebKit/gtk/tests/testcopyandpaste.c
R Source/WebKit/gtk/tests/testdomdocument.c
R Source/WebKit/gtk/tests/testdomdomwindow.c
R Source/WebKit/gtk/tests/testdomnode.c
R Source/WebKit/gtk/tests/testdownload.c
R Source/WebKit/gtk/tests/testfavicondatabase.c
R Source/WebKit/gtk/tests/testglobals.c
R Source/WebKit/gtk/tests/testhittestresult.c
R Source/WebKit/gtk/tests/testhttpbackend.c
R Source/WebKit/gtk/tests/testkeyevents.c
R Source/WebKit/gtk/tests/testloading.c
R Source/WebKit/gtk/tests/testmimehandling.c
R Source/WebKit/gtk/tests/testnetworkrequest.c
R Source/WebKit/gtk/tests/testnetworkresponse.c
R Source/WebKit/gtk/tests/testwebbackforwardlist.c
R Source/WebKit/gtk/tests/testwebdatasource.c
R Source/WebKit/gtk/tests/testwebframe.c
R Source/WebKit/gtk/tests/testwebhistoryitem.c
R Source/WebKit/gtk/tests/testwebinspector.c
R Source/WebKit/gtk/tests/testwebplugindatabase.c
R Source/WebKit/gtk/tests/testwebresource.c
R Source/WebKit/gtk/tests/testwebsettings.c
R Source/WebKit/gtk/tests/testwebview.c
R Source/WebKit/gtk/tests/testwindow.c
M Source/WebKit2/ChangeLog
R Source/WebKit2/UIProcess/API/gtk/tests/AccessibilityTestServer.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/DOMNodeTest.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/FrameTest.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/GNUmakefile.am
R Source/WebKit2/UIProcess/API/gtk/tests/InspectorTestServer.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.h
R Source/WebKit2/UIProcess/API/gtk/tests/TestAuthentication.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/TestBackForwardList.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/TestCookieManager.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/TestDOMNode.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/TestDownloads.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/TestFrame.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/TestInspector.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/TestInspectorServer.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/TestLoaderClient.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/TestMain.h
R Source/WebKit2/UIProcess/API/gtk/tests/TestPrinting.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/TestSSL.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/TestUIClient.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/TestWebExtensions.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitVersion.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebContext.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/TestWebViewEditor.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.h
R Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.h
R Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h
R Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.h
R Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp
R Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.h
R Source/WebKit2/UIProcess/API/gtk/tests/resources/link-title.js
R Source/WebKit2/UIProcess/API/gtk/tests/resources/test-cert.pem
R Source/WebKit2/UIProcess/API/gtk/tests/resources/test-key.pem
R Source/WebKit2/UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml
M Tools/ChangeLog
M Tools/Scripts/run-gtk-tests
M Tools/Scripts/webkitpy/style/checker.py
M Tools/Scripts/webkitpy/style/checker_unittest.py
M Tools/TestWebKitAPI/GNUmakefile.am
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/AccessibilityTestServer.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDOMDOMWindow.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitVersion.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem
A Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml
A Tools/TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico
A Tools/TestWebKitAPI/Tests/WebKitGtk/resources/test.html
A Tools/TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg
A Tools/TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf
A Tools/TestWebKitAPI/Tests/WebKitGtk/resources/test.txt
A Tools/TestWebKitAPI/Tests/WebKitGtk/test_utils.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/test_utils.h
A Tools/TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testatkroles.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testdomnode.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testdownload.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testglobals.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testloading.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testwebframe.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testwebresource.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testwebview.c
A Tools/TestWebKitAPI/Tests/WebKitGtk/testwindow.c
A Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp
A Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h
A Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp
A Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h
A Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp
A Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h
A Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp
A Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h
A Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp
A Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h
A Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp
A Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h
Log Message:
-----------
Merge r161366 - [GTK] Move all GTK/GObject unit tests to Tools/TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=126342
Patch by Carlos Garcia Campos <cgarcia at igalia.com> on 2014-01-04
Reviewed by Gustavo Noronha Silva.
.:
* GNUmakefile.am: Remove unused variable.
Source/WebKit/gtk:
* tests/GNUmakefile.am: Removed.
Source/WebKit2:
* UIProcess/API/gtk/tests/GNUmakefile.am: Removed.
Tools:
* Scripts/run-gtk-tests: Update to refer to the new build locations.
* Scripts/webkitpy/style/checker.py: Update the style checker.
* Scripts/webkitpy/style/checker_unittest.py:
* TestWebKitAPI/GNUmakefile.am:
* TestWebKitAPI/Tests/WebKit2Gtk/AccessibilityTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/AccessibilityTestServer.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Added.
* TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp: Added.
* TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/DOMNodeTest.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/FrameTest.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/InspectorTestServer.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.h.
* TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestAuthentication.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestBackForwardList.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestCookieManager.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/TestDOMDOMWindow.cpp: Added.
* TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDOMNode.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDownloads.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestFrame.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspector.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspectorServer.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestLoaderClient.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/TestMain.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/TestMain.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.h.
* TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestPrinting.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestSSL.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestUIClient.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebExtensions.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitVersion.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitVersion.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebContext.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebViewEditor.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.h.
* TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.h.
* TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h.
* TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.h.
* TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp.
* TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.h.
* TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/link-title.js.
* TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-cert.pem.
* TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-key.pem.
* TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml.
* TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Added.
* TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Renamed from Source/WebKit/gtk/tests/resources/blank.ico.
* TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Renamed from Source/WebKit/gtk/tests/resources/test.html.
* TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Renamed from Source/WebKit/gtk/tests/resources/test.ogg.
* TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Renamed from Source/WebKit/gtk/tests/resources/test.pdf.
* TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Renamed from Source/WebKit/gtk/tests/resources/test.txt.
* TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Renamed from Source/WebKit/gtk/tests/test_utils.c.
* TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Renamed from Source/WebKit/gtk/tests/test_utils.h.
* TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Renamed from Source/WebKit/gtk/tests/testapplicationcache.c.
* TestWebKitAPI/Tests/WebKitGtk/testatk.c: Renamed from Source/WebKit/gtk/tests/testatk.c.
* TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Renamed from Source/WebKit/gtk/tests/testatkroles.c.
* TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Renamed from Source/WebKit/gtk/tests/testcontextmenu.c.
* TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Renamed from Source/WebKit/gtk/tests/testcopyandpaste.c.
* TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Renamed from Source/WebKit/gtk/tests/testdomdocument.c.
* TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Renamed from Source/WebKit/gtk/tests/testdomdomwindow.c.
* TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Renamed from Source/WebKit/gtk/tests/testdomnode.c.
* TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Renamed from Source/WebKit/gtk/tests/testdownload.c.
* TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Renamed from Source/WebKit/gtk/tests/testfavicondatabase.c.
* TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Renamed from Source/WebKit/gtk/tests/testglobals.c.
* TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Renamed from Source/WebKit/gtk/tests/testhittestresult.c.
* TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Renamed from Source/WebKit/gtk/tests/testhttpbackend.c.
* TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Renamed from Source/WebKit/gtk/tests/testkeyevents.c.
* TestWebKitAPI/Tests/WebKitGtk/testloading.c: Renamed from Source/WebKit/gtk/tests/testloading.c.
* TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Renamed from Source/WebKit/gtk/tests/testmimehandling.c.
* TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Renamed from Source/WebKit/gtk/tests/testnetworkrequest.c.
* TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Renamed from Source/WebKit/gtk/tests/testnetworkresponse.c.
* TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Renamed from Source/WebKit/gtk/tests/testwebbackforwardlist.c.
* TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Renamed from Source/WebKit/gtk/tests/testwebdatasource.c.
* TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Renamed from Source/WebKit/gtk/tests/testwebframe.c.
* TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Renamed from Source/WebKit/gtk/tests/testwebhistoryitem.c.
* TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Renamed from Source/WebKit/gtk/tests/testwebinspector.c.
* TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Renamed from Source/WebKit/gtk/tests/testwebplugindatabase.c.
* TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Renamed from Source/WebKit/gtk/tests/testwebresource.c.
* TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Renamed from Source/WebKit/gtk/tests/testwebsettings.c.
* TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Renamed from Source/WebKit/gtk/tests/testwebview.c.
* TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Renamed from Source/WebKit/gtk/tests/testwindow.c.
Commit: 0c05094ec34472cf842270b839d3f1578680326f
https://github.com/WebKit/WebKit/commit/0c05094ec34472cf842270b839d3f1578680326f
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp
M Source/WebKit2/ChangeLog
M Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp
Log Message:
-----------
Merge r161176 - [SOUP] willSendRequest doesn't work after a redirect
https://bugs.webkit.org/show_bug.cgi?id=126290
Reviewed by Martin Robinson.
Source/WebCore:
The problem is that we are creating the new soup request for the
redirect before calling ResourceHandleClient::willSendRequest() so
that any change made to the request by the client is ignored.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::doRedirect): Create the new soup request and soup
message for the redirect after calling willSendRequest() on the
client.
Source/WebKit2:
Add test cases to test send-request signal in case of
redirection.
* UIProcess/API/gtk/tests/TestResources.cpp:
(testWebResourceSendRequest):
(serverCallback):
Commit: 3aa1da832ca4ecefddaa6b4d708de82f0dfae313
https://github.com/WebKit/WebKit/commit/3aa1da832ca4ecefddaa6b4d708de82f0dfae313
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/Shared/Downloads/soup/DownloadSoup.cpp
M Tools/ChangeLog
M Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp
Log Message:
-----------
Merge r161555 - [SOUP] Partial file left on disk after a download fails or is cancelled in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=126686
Reviewed by Martin Robinson.
Source/WebKit2:
We are currently writing the downloads directly into the
destination, and when a download fails or is cancelled after the
destination has been decided, the partial file is left on the
disk. Deleting the final file is not safe because there might be a
race condition, so we can use an intermediate file like other
browsers do, a file in the same directory than the target
destination but with .wkdownload suffix, that is removed when the
download fails or is cancelled. If the download finishes
successfully the intermediate file is renamed to the final
destination.
* Shared/Downloads/soup/DownloadSoup.cpp:
(WebKit::DownloadClient::deleteIntermediateFileInNeeded): Delete
the intermdiate file if it's been created already.
(WebKit::DownloadClient::downloadFailed): Call deleteIntermediateFileInNeeded.
(WebKit::DownloadClient::didReceiveResponse): Do not create a
SoupMessage for the given ResourceResponse that is not used, cache
the ResourceResponse instead. Create the intermediate file and use
it instead of the final destination.
(WebKit::DownloadClient::didReceiveData): Use the cached
ResourceResponse directly.
(WebKit::DownloadClient::didFinishLoading): Rename the
intermediate file to the final destination and write the metadata
in the final target destination.
(WebKit::DownloadClient::cancel): Handle the download cancellation
here, removing the intermediate file is needed and cancelling the
ResourceHandle and the download.
(WebKit::DownloadClient::handleResponseLater):
(WebKit::Download::cancel): Let the client handle the cancellation.
Tools:
Test that partial files are not left on disk after a download has
been cancelled after the destination has been decided. To make
sure the download is cancelled after the destination has been
decided and before the operation finishes, we cancel the download
in the destination decided callback, and we use an infinite
resource that writes chunks to the response body and never
completes the body.
* TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
(addContentDispositionHTTPHeaderToResponse): Helper function to
add the Content-Disposition to the response headers.
(writeNextChunkIdle): Write next chunk to response body.
(writeNextChunk): Write next chunk in an idle to avoid flooding
the network with the inifnite resource.
(serverCallback): Add an inifinite resource.
(testDownloadRemoteFileError): Check that partial file is not
present after the download has been cancelled.
Commit: 8c9e0441ebe15fa302b48215ca214a0963712b7e
https://github.com/WebKit/WebKit/commit/8c9e0441ebe15fa302b48215ca214a0963712b7e
Author: Tomáš Popela <tpopela at redhat.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp
Log Message:
-----------
Merge r162059 - [SOUP] [WK2] - Disable MemoryCache when the DOCUMENT_VIEWER cache model is set
https://bugs.webkit.org/show_bug.cgi?id=126577
Patch by Tomas Popela <tpopela at redhat.com> on 2014-01-15
Reviewed by Carlos Garcia Campos.
As in http://trac.webkit.org/changeset/152483, but this time for
WebKit2. When WEBKIT_CACHE_MODEL_DOCUMENT_VIEWER is set we need to
disable the MemoryCache completely to prevent caching of the resources.
* WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::platformSetCacheModel):
Commit: e8e4b14b64986b9078a3491fbe82616b59ff7113
https://github.com/WebKit/WebKit/commit/e8e4b14b64986b9078a3491fbe82616b59ff7113
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp
M Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
M Tools/ChangeLog
M Tools/Scripts/run-gtk-tests
M Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp
Log Message:
-----------
Merge r162056 - [GTK] UI process crashes when the web process crashes while printing
https://bugs.webkit.org/show_bug.cgi?id=126977
Reviewed by Gustavo Noronha Silva.
Source/WebKit2:
When the web process crashes, the printing callback is
invalidated, so the function is called with a NULL error.
* UIProcess/API/gtk/WebKitPrintOperation.cpp:
(drawPagesForPrintingCompleted): Check wkError is not NULL before
trying to use it.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewPrintFrame): Set the print mode of the operation
before emitting the print signal.
Tools:
Add new test case to check that closing the window right after
printing works. It's skipped for now, because this patch only
fixes the UI process crash, but not the web process one.
* Scripts/run-gtk-tests:
(TestRunner): Skip
/webkit2/WebKitPrintOperation/close-after-print.
* TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
(testPrintOperationPrintPrinter):
(findPrintToFilePrinter):
(testPrintOperationPrint):
(testPrintOperationErrors):
(testPrintOperationCloseAfterPrint):
(beforeAll):
Commit: a11826f2d95331065ad774fd36fe4004af298023
https://github.com/WebKit/WebKit/commit/a11826f2d95331065ad774fd36fe4004af298023
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp
Log Message:
-----------
Merge r162057 - [GTK] UI process crashes when closing the window right after printing with javascript
https://bugs.webkit.org/show_bug.cgi?id=126981
Reviewed by Gustavo Noronha Silva.
The UI process crashes because when the page is closed, the web
view is destroyed before the print operation has actually
finished. Use a weak pointer to make sure the web view pointer is
set to NULL when the it's destroyed and emit the finished callback
always so that the user can clean up the operation even when the
web view has been closed.
* UIProcess/API/gtk/WebKitPrintOperation.cpp:
(drawPagesForPrintingCompleted):
Commit: 9b2c38995645813d0479d3ee17baf8d487235ba8
https://github.com/WebKit/WebKit/commit/9b2c38995645813d0479d3ee17baf8d487235ba8
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp
Log Message:
-----------
Merge r162188 - [GTK] Remove the weak pointer added to the web view in WebKitPrintOperation
https://bugs.webkit.org/show_bug.cgi?id=127098
Reviewed by Martin Robinson.
If the print operation finishes and the web view is still alive,
the weak pointer added to the view should be removed.
* UIProcess/API/gtk/WebKitPrintOperation.cpp:
(_WebKitPrintOperationPrivate::~_WebKitPrintOperationPrivate):
Commit: 30b847b3682e7a12ef0f1b9347fbe6b8ae2b94f1
https://github.com/WebKit/WebKit/commit/30b847b3682e7a12ef0f1b9347fbe6b8ae2b94f1
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/GNUmakefile.list.am
M Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp
A Source/WebKit2/WebProcess/WebPage/gtk/PrinterListGtk.cpp
A Source/WebKit2/WebProcess/WebPage/gtk/PrinterListGtk.h
M Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp
M Tools/ChangeLog
M Tools/Scripts/run-gtk-tests
Log Message:
-----------
Merge r162073 - [GTK] Web process sometimes crashes when printing in synchronous mode
https://bugs.webkit.org/show_bug.cgi?id=126979
Reviewed by Gustavo Noronha Silva.
Source/WebKit2:
When printing synchronously in GTK+ we need to make sure that we
have a list of Printers before starting the print operation. Getting
the list of printers is done synchronously by GTK+, but using a
nested main loop that might process IPC messages comming from the
UI process like EndPrinting. When the EndPrinting message is
received while the printer list is being populated, the print
operation is finished unexpectely and the web process crashes. The
PrinterListGtk class gets the list of printers in the constructor
so we just need to ensure there's an instance alive during the
synchronous print operation. In case of asynchronous printing the
printer list will be created during the print operation without
any risk, because the EndPrinting message is not sent until the
printing callback has been received in the UI process.
* GNUmakefile.list.am: Add new files to compilation.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::print): Ensure PrinterListGtk is created
before the synchronous printing and destroyed afterwards.
* WebProcess/WebPage/gtk/PrinterListGtk.cpp: Added.
(WebKit::PrinterListGtk::shared): Return the singleton.
(WebKit::PrinterListGtk::enumeratePrintersFunction): Callback
called by gtk_enumerate_printers() when a new printer is found.
(WebKit::PrinterListGtk::PrinterListGtk): Call
gtk_enumerate_printers() in syhchronous mode.
(WebKit::PrinterListGtk::~PrinterListGtk):
(WebKit::PrinterListGtk::addPrinter): Add the printer to the list
and set the default printer if needed.
(WebKit::PrinterListGtk::findPrinter): Find the printer for the
given name.
* WebProcess/WebPage/gtk/PrinterListGtk.h: Added.
* WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp: Use
PrinterListGtk class to find the printer instead of calling
gtk_enumerate_printers().
Tools:
* Scripts/run-gtk-tests:
(TestRunner): Unskip
/webkit2/WebKitPrintOperation/close-after-print.
Commit: 5ffa953034450c398436b6004acebcb7cddec8b6
https://github.com/WebKit/WebKit/commit/5ffa953034450c398436b6004acebcb7cddec8b6
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-01-20 (Mon, 20 Jan 2014)
Changed paths:
M Source/WTF/ChangeLog
M Source/WTF/wtf/gobject/GRefPtr.cpp
Log Message:
-----------
Merge r162306 - [GLIB] GVariant floating references are not correctly handled by GRefPtr
https://bugs.webkit.org/show_bug.cgi?id=127246
Reviewed by Martin Robinson.
Source/WTF:
GRefPtr should always use g_variant_ref_sink to deal with GVariant
floating references. In case of full references,
g_variant_ref_sink calls g_variant_ref, so it's safe to use it always.
* wtf/gobject/GRefPtr.cpp:
(WTF::refGPtr): Use g_variant_ref_sink().
Commit: 9d276309e2bad8da721b756d5253d4efcd9820c3
https://github.com/WebKit/WebKit/commit/9d276309e2bad8da721b756d5253d4efcd9820c3
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-01-21 (Tue, 21 Jan 2014)
Changed paths:
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/webkit/webkitspellchecker.cpp
Log Message:
-----------
Merge r160171 - [GTK] Fix GObject introspection warnings in webkitspellchecker
https://bugs.webkit.org/show_bug.cgi?id=125299
Reviewed by Philippe Normand.
* webkit/webkitspellchecker.cpp: Add missing ':' after some
gobject-introspection annotations.
Commit: 353840fa43732344ba7cd7f094f54b0f6a0518a4
https://github.com/WebKit/WebKit/commit/353840fa43732344ba7cd7f094f54b0f6a0518a4
Author: Alberto Garcia <berto at igalia.com>
Date: 2014-01-21 (Tue, 21 Jan 2014)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp
M Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h
M Source/WebCore/platform/gtk/PopupMenuGtk.cpp
M Source/WebCore/platform/gtk/RedirectedXCompositeWindow.h
M Tools/ChangeLog
M Tools/GtkLauncher/main.c
Log Message:
-----------
Merge r161500 - Fix some compilation warnings
https://bugs.webkit.org/show_bug.cgi?id=126635
Reviewed by Csaba Osztrogonác.
Source/WebCore:
Remove code that is no longer being used.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
* platform/gtk/PopupMenuGtk.cpp:
* platform/gtk/RedirectedXCompositeWindow.h:
Tools:
* GtkLauncher/main.c:
(createWindow): This function is not supposed to receive any
parameter, yet we are passing one.
Commit: 9470f4d4c0fc1d8963357bbfec155cbe4dc08a70
https://github.com/WebKit/WebKit/commit/9470f4d4c0fc1d8963357bbfec155cbe4dc08a70
Author: Alberto Garcia <berto at igalia.com>
Date: 2014-01-21 (Tue, 21 Jan 2014)
Changed paths:
M Source/WTF/ChangeLog
M Source/WTF/wtf/Platform.h
Log Message:
-----------
Merge r162086 - [GTK] v2.3.3 fails to build in Debian / FreeBSD
https://bugs.webkit.org/show_bug.cgi?id=126502
Reviewed by Mark Lam.
* wtf/Platform.h: Add LLINT support to FreeBSD.
Commit: f80e15ced5a9c2ea38797363d33e14e00e8b793c
https://github.com/WebKit/WebKit/commit/f80e15ced5a9c2ea38797363d33e14e00e8b793c
Author: Alberto Garcia <berto at igalia.com>
Date: 2014-01-21 (Tue, 21 Jan 2014)
Changed paths:
M Source/WTF/ChangeLog
M Source/WTF/wtf/Atomics.h
Log Message:
-----------
Merge r162137 - Source/WTF/wtf/Atomics.h:300: Error: bad register name `%bpl'
https://bugs.webkit.org/show_bug.cgi?id=126985
Reviewed by Csaba Osztrogonác.
Use the 'q' constraint to force using a register that allows
access to its lower byte.
* wtf/Atomics.h:
(WTF::weakCompareAndSwap):
Commit: 0c2c0d9ac04dfd694cfa5bc3842fb669976a046d
https://github.com/WebKit/WebKit/commit/0c2c0d9ac04dfd694cfa5bc3842fb669976a046d
Author: Alberto Garcia <berto at igalia.com>
Date: 2014-01-21 (Tue, 21 Jan 2014)
Changed paths:
M Source/JavaScriptCore/ChangeLog
M Source/JavaScriptCore/jit/ThunkGenerators.cpp
M Source/JavaScriptCore/tools/CodeProfile.cpp
Log Message:
-----------
Merge r162266 - JavaScriptCore uses PLATFORM(MAC) when it means OS(DARWIN)
https://bugs.webkit.org/show_bug.cgi?id=99683
Reviewed by Anders Carlsson.
* jit/ThunkGenerators.cpp:
* tools/CodeProfile.cpp:
(JSC::symbolName):
(JSC::CodeProfile::sample):
Commit: 0fd3adb60fc1769dfa43aa6d92708be50011b14a
https://github.com/WebKit/WebKit/commit/0fd3adb60fc1769dfa43aa6d92708be50011b14a
Author: Carlos Garcia Campos <carlosgc at webkit.org>
Date: 2014-01-21 (Tue, 21 Jan 2014)
Changed paths:
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/GNUmakefile.am
Log Message:
-----------
Unreviewed. Fix make distcheck.
* GNUmakefile.am: Remove non existent files from EXTRA_DIST.
Commit: d74cd9036696643f437c5da8784b9da7e0b9d4f9
https://github.com/WebKit/WebKit/commit/d74cd9036696643f437c5da8784b9da7e0b9d4f9
Author: Carlos Garcia Campos <carlosgc at webkit.org>
Date: 2014-01-21 (Tue, 21 Jan 2014)
Changed paths:
M ChangeLog
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/NEWS
M Source/autotools/Versions.m4
Log Message:
-----------
Unreviewed. Update NEWS and Versions.m4 for 2.2.4 release.
.:
* Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
* NEWS: Add release notes.
Commit: 9316ea2367febcfd296be39b482c0d2f0a8915b7
https://github.com/WebKit/WebKit/commit/9316ea2367febcfd296be39b482c0d2f0a8915b7
Author: Victor Jaquez <vjaquez at igalia.com>
Date: 2014-02-17 (Mon, 17 Feb 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp
Log Message:
-----------
Merge r162724 - [GTK] youtube HTML5 videos in fullscreen, after <Esc>, can't go fullscreen again
https://bugs.webkit.org/show_bug.cgi?id=127064
When pressing <Esc> or <f> at full screen, the WebView shall emit the
event webkitfullscreenchange, but wk2gtk does not emit it. This is
because the WebView manages directly the exit of the full screen.
With this patch the WebView calls requestExitFullScreen to the full
screen manager, instead of managing directly the exit of the full
screen, and the event webkitfullscreenchange will be dispatched
correctly.
Reviewed by Martin Robinson.
No tests are included because there is a bug in WKTR that prevents the
execution of a test for this patch. See
https://bugs.webkit.org/show_bug.cgi?id=127348
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseKeyPressEvent): Call
webkitWebViewBaseRequestExitFullScreen.
(webkitWebViewBaseRequestExitFullScreen): Added.
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Ditto.
Commit: 1b0328257ad46923bb52fe5db5b9b0c66b7c62bc
https://github.com/WebKit/WebKit/commit/1b0328257ad46923bb52fe5db5b9b0c66b7c62bc
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-02-18 (Tue, 18 Feb 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/Shared/Downloads/soup/DownloadSoup.cpp
Log Message:
-----------
Merge r162830 - [SOUP] WebProcess sometimes crashes when a download is cancelled
https://bugs.webkit.org/show_bug.cgi?id=127650
Reviewed by Martin Robinson.
The problem is that when the download is cancelled, the download
manager removes the download from the map and it's deleted. The
Download destructor calls platformInvalidate() that cancels the
resource handle if there's still one. We set to nullptr the
ResourceHandle when the download is cancelled to avoid cancelling
it twice, but it's done after calling Download::didCancel(). It
should be done before, because at that moment, when the download
is deleted, the resource handle pointer is still valid.
* Shared/Downloads/soup/DownloadSoup.cpp:
(WebKit::Download::cancel):
Commit: 86ed952d96e93720300a34951be9245a0aaeae2c
https://github.com/WebKit/WebKit/commit/86ed952d96e93720300a34951be9245a0aaeae2c
Author: Sami Wagiaalla <swagiaal at redhat.com>
Date: 2014-02-18 (Tue, 18 Feb 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/WebProcess/WebPage/WebPage.cpp
M Source/WebKit2/WebProcess/WebPage/WebPage.h
Log Message:
-----------
[GTK] webkit_web_view_load_html reads UTF8 css files as UTF16
https://bugs.webkit.org/show_bug.cgi?id=127481
Patch by Sami Wagiaalla <swagiaal at redhat.com> on 2014-02-18
Reviewed by Carlos Garcia Campos.
Partial merge of r160572.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadString):
(WebKit::WebPage::loadHTMLString):
(WebKit::WebPage::loadAlternateHTMLString):
(WebKit::WebPage::loadPlainTextString):
(WebKit::WebPage::loadWebArchiveData):
* WebProcess/WebPage/WebPage.h:
Commit: 3f6841fa26c4f2bba3f307301c52af8c6dc79a33
https://github.com/WebKit/WebKit/commit/3f6841fa26c4f2bba3f307301c52af8c6dc79a33
Author: Filip Pizlo <fpizlo at apple.com>
Date: 2014-02-18 (Tue, 18 Feb 2014)
Changed paths:
M Source/JavaScriptCore/ChangeLog
M Source/JavaScriptCore/bytecode/SpeculatedType.cpp
M Source/JavaScriptCore/bytecode/SpeculatedType.h
Log Message:
-----------
Merge r155466 - SpecType should have SpecInt48AsDouble
https://bugs.webkit.org/show_bug.cgi?id=121065
Reviewed by Oliver Hunt.
* bytecode/SpeculatedType.cpp:
(JSC::dumpSpeculation):
(JSC::speculationToAbbreviatedString):
(JSC::speculationFromValue):
* bytecode/SpeculatedType.h:
(JSC::isInt48AsDoubleSpeculation):
(JSC::isIntegerSpeculation):
(JSC::isDoubleRealSpeculation):
Commit: 144ea2248db5d25af0e87f446ca944f02651b15c
https://github.com/WebKit/WebKit/commit/144ea2248db5d25af0e87f446ca944f02651b15c
Author: Filip Pizlo <fpizlo at apple.com>
Date: 2014-02-18 (Tue, 18 Feb 2014)
Changed paths:
M Source/JavaScriptCore/ChangeLog
M Source/JavaScriptCore/bytecode/SpeculatedType.cpp
M Source/JavaScriptCore/bytecode/SpeculatedType.h
M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h
M Source/JavaScriptCore/dfg/DFGAbstractValue.cpp
M Source/JavaScriptCore/dfg/DFGAbstractValue.h
M Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.cpp
M Source/JavaScriptCore/dfg/DFGJITCompiler.h
M Source/JavaScriptCore/dfg/DFGUseKind.h
Log Message:
-----------
Merge r155480 - Introduce a SpecInt48 type and be more careful about what we mean by "Top" https://bugs.webkit.org/show_bug.cgi?id=121116
Reviewed by Oliver Hunt.
SpecInt48 will mean that we have something that would be a double if it was a JSValue,
but it's profitable to represent it as something other than a double.
SpecInt48AsDouble means that it has a value that could have been represented like
SpecInt48, but we're making a heuristic decision not to do it.
* bytecode/SpeculatedType.h:
(JSC::isInt48Speculation):
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
(JSC::DFG::::clobberCapturedVars):
* dfg/DFGAbstractValue.cpp:
(JSC::DFG::AbstractValue::filter):
* dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::makeHeapTop):
(JSC::DFG::AbstractValue::makeBytecodeTop):
(JSC::DFG::AbstractValue::isHeapTop):
(JSC::DFG::AbstractValue::heapTop):
(JSC::DFG::AbstractValue::validateType):
(JSC::DFG::AbstractValue::validate):
(JSC::DFG::AbstractValue::makeTop):
* dfg/DFGInPlaceAbstractState.cpp:
(JSC::DFG::InPlaceAbstractState::initialize):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::noticeOSREntry):
* dfg/DFGUseKind.h:
(JSC::DFG::typeFilterFor):
Commit: 6c4332ee88b18b164ea7d0878987faeafd09b4a2
https://github.com/WebKit/WebKit/commit/6c4332ee88b18b164ea7d0878987faeafd09b4a2
Author: Filip Pizlo <fpizlo at apple.com>
Date: 2014-02-18 (Tue, 18 Feb 2014)
Changed paths:
M LayoutTests/ChangeLog
A LayoutTests/js/dfg-strict-mode-to-this-expected.txt
A LayoutTests/js/dfg-strict-mode-to-this.html
A LayoutTests/js/script-tests/dfg-strict-mode-to-this.js
M Source/JavaScriptCore/ChangeLog
M Source/JavaScriptCore/bytecode/CodeBlock.cpp
M Source/JavaScriptCore/bytecode/CodeOrigin.cpp
M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h
M Source/JavaScriptCore/dfg/DFGOperations.cpp
M Source/JavaScriptCore/dfg/DFGOperations.h
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp
M Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp
M Tools/ChangeLog
Log Message:
-----------
Merge r155730 - DFG AI assumes that ToThis can never return non-object if it is passed an object, and operationToThis will get the wrong value of isStrictMode() if there's inlining
https://bugs.webkit.org/show_bug.cgi?id=121330
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg and Oliver Hunt.
Also print whether a function is strict mode in debug dumps.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpAssumingJITType):
* bytecode/CodeOrigin.cpp:
(JSC::InlineCallFrame::dumpInContext):
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
Tools:
Reviewed by Mark Hahnenberg and Oliver Hunt.
We should run tests even if they don't have expected files yet.
* Scripts/run-layout-jsc:
LayoutTests:
Reviewed by Mark Hahnenberg and Oliver Hunt.
* js/dfg-strict-mode-to-this-expected.txt: Added.
* js/dfg-strict-mode-to-this.html: Added.
* js/jsc-test-list:
* js/script-tests/dfg-strict-mode-to-this.js: Added.
(thingy.bar):
(thingy.foo):
(thingy):
Commit: b162fe37a83adcce1522c5f943c6465b54b0537b
https://github.com/WebKit/WebKit/commit/b162fe37a83adcce1522c5f943c6465b54b0537b
Author: Alberto Garcia <berto at igalia.com>
Date: 2014-02-18 (Tue, 18 Feb 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp
M Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp
Log Message:
-----------
Merge r163292 - Fix wrong mix of fcntl commands and flags
https://bugs.webkit.org/show_bug.cgi?id=127842
Reviewed by Darin Adler.
We are mixing the commands to set file descriptor and file status
flags in a couple of fcntl() calls. FD_CLOEXEC must be set using
F_SETFD, and the access mode flags (O_RDONLY, O_WRONLY, O_RDWR)
with F_SETFL.
This combines patches by Guillem Jover and Sergio Correia.
* Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::readBytesFromSocket):
* Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::createHandle):
Commit: 37415b80cd7d37f20318d12e1f32f11d946bc040
https://github.com/WebKit/WebKit/commit/37415b80cd7d37f20318d12e1f32f11d946bc040
Author: Alberto Garcia <berto at igalia.com>
Date: 2014-02-18 (Tue, 18 Feb 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp
Log Message:
-----------
Merge r163875 - O_CLOEXEC in shm_open does not work on FreeBSD
https://bugs.webkit.org/show_bug.cgi?id=128572
Reviewed by Darin Adler.
The O_CLOEXEC is not supported by shm_open() and is also not
necessary since FD_CLOEXEC is already set by default when the new
file descriptor is created.
* Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::create):
Commit: 9809ff030be1ed8631910acc250de7a4b7e7e2b1
https://github.com/WebKit/WebKit/commit/9809ff030be1ed8631910acc250de7a4b7e7e2b1
Author: Ryan Lortie <desrt at desrt.ca>
Date: 2014-02-18 (Tue, 18 Feb 2014)
Changed paths:
M ChangeLog
M Source/autotools/SetupLibtool.m4
Log Message:
-----------
Merge r163954 - 'ar T' is not portable and breaks the build on FreeBSD
https://bugs.webkit.org/show_bug.cgi?id=128596
Patch by Ryan Lortie <desrt at desrt.ca> on 2014-02-12
Reviewed by Gustavo Noronha Silva.
Create thin archives only if we are using GNU ar.
* Source/autotools/SetupLibtool.m4:
Commit: 666653e81033a8aac5eaa75006e67a04ced08ef6
https://github.com/WebKit/WebKit/commit/666653e81033a8aac5eaa75006e67a04ced08ef6
Author: Ryuan Choi <ryuan.choi at navercorp.com>
Date: 2014-02-18 (Tue, 18 Feb 2014)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h
Log Message:
-----------
Merge r163435 - MediaPlayerPrivateGStreamerBase should have virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=128238
Reviewed by Carlos Garcia Campos.
MediaPlayerPrivateGStreamer inherit MediaPlayerPrivateGStreamerBase.
So MediaPlayerPrivateGStreamerBase should have virtual destructor.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h: Made destructor as virtual.
Commit: 135fac0052cab840a5025a3bb68a5c64c78df148
https://github.com/WebKit/WebKit/commit/135fac0052cab840a5025a3bb68a5c64c78df148
Author: Piotr Grad <p.grad at samsung.com>
Date: 2014-02-18 (Tue, 18 Feb 2014)
Changed paths:
M LayoutTests/ChangeLog
A LayoutTests/media/video-extreme-playbackrate-crash-expected.txt
A LayoutTests/media/video-extreme-playbackrate-crash.html
M Source/WebCore/ChangeLog
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
Log Message:
-----------
Merge r163871 - [GStreamer] High playback rate causes crash
https://bugs.webkit.org/show_bug.cgi?id=128453
Patch by Piotr Grad <p.grad at samsung.com> on 2014-02-11
Reviewed by Philippe Normand.
Source/WebCore:
To high playback rate passed to GStreamer was causing crash.
Added guard in setRate method.
Test: media/video-extreme-playbackrate-crash.html
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::setRate):
LayoutTests:
Test checks if passing high playback rate causes crash.
* media/video-extreme-playbackrate-crash-expected.txt: Added.
* media/video-extreme-playbackrate-crash.html: Added.
Commit: cdc6617ed55c64182da6cb01ede9187e8e9b6ab7
https://github.com/WebKit/WebKit/commit/cdc6617ed55c64182da6cb01ede9187e8e9b6ab7
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-02-18 (Tue, 18 Feb 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp
Log Message:
-----------
Merge r164167 - [GTK] Fix marshaller used in WebKitWebPage::document-loaded signal
https://bugs.webkit.org/show_bug.cgi?id=128808
Reviewed by Sergio Villar Senin.
* WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(webkit_web_page_class_init): Use g_cclosure_marshal_VOID__VOID
instead of g_cclosure_marshal_VOID__OBJECT.
Commit: 19da659e73a1db53645d6dc076f52764d24bdfd3
https://github.com/WebKit/WebKit/commit/19da659e73a1db53645d6dc076f52764d24bdfd3
Author: Carlos Garcia Campos <carlosgc at webkit.org>
Date: 2014-02-18 (Tue, 18 Feb 2014)
Changed paths:
M ChangeLog
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/NEWS
M Source/autotools/Versions.m4
Log Message:
-----------
Unreviewed. Update NEWS and Versions.m4 for 2.2.5 release.
.:
* Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
* NEWS: Add release notes.
Commit: 18dd97b724793f59434ead3b8999415514d7939b
https://github.com/WebKit/WebKit/commit/18dd97b724793f59434ead3b8999415514d7939b
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-02-27 (Thu, 27 Feb 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp
Log Message:
-----------
Merge r164787 - [GTK] Web Inspector doesn't work with network process enabled
https://bugs.webkit.org/show_bug.cgi?id=127651
Reviewed by Sergio Villar Senin.
The problem is that the web inspector loads so many resources,
that when using the network process, a lot of IPC traffic is
generated causing the send buffer of the socket to be full. When
that happens sendmsg() fails with EAGAIN, because we are using non
blocking sockets, and we are not handling neither EAGAIN nor
EWOULDBLOCK errors (we do when reading from the socket, though).
* Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::Connection::readyReadHandler): Add a log message to know
when reading from the socket fails for any unhandled error.
(IPC::Connection::sendOutgoingMessage): Handle EAGAIN and
EWOULDBLOCK errors to try again in those cases. Also add a log
message for unhandled errors.
Commit: bce350eb97a1d017ffff1bfed18daa90a3227f80
https://github.com/WebKit/WebKit/commit/bce350eb97a1d017ffff1bfed18daa90a3227f80
Author: Giovanni Campagna <gcampagna at src.gnome.org>
Date: 2014-03-19 (Wed, 19 Mar 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp
Log Message:
-----------
Merge r165745 - [GTK] Don't busy loop when the socket is full
https://bugs.webkit.org/show_bug.cgi?id=129802
Patch by Giovanni Campagna <gcampagna at src.gnome.org> on 2014-03-17
Reviewed by Carlos Garcia Campos.
When the socket is full and we see EAGAIN or EWOULDBLOCK
(because the socket is non blocking), don't busy loop by
tring to write again, instead poll() until the socket
becomes writable.
* Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::Connection::sendOutgoingMessage):
Commit: b9febe623e6d9425017cd054f454c0b5ea189f8c
https://github.com/WebKit/WebKit/commit/b9febe623e6d9425017cd054f454c0b5ea189f8c
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-03-19 (Wed, 19 Mar 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/GNUmakefile.am
M Source/WebKit2/GNUmakefile.list.am
M Source/WebKit2/Shared/Plugins/Netscape/NetscapePluginModule.h
M Source/WebKit2/Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp
A Source/WebKit2/UIProcess/Plugins/gtk/PluginInfoCache.cpp
A Source/WebKit2/UIProcess/Plugins/gtk/PluginInfoCache.h
M Source/WebKit2/UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp
Log Message:
-----------
Merge r164808 - [GTK][WK2] Blocks when fetching plugins information
https://bugs.webkit.org/show_bug.cgi?id=115650
Reviewed by Gustavo Noronha Silva.
Use a persistent cache to store the plugins metadata to avoid
having to load all the plugins everytime a plugin is used for the
first time.
* GNUmakefile.am:
* GNUmakefile.list.am:
* PlatformGTK.cmake:
* Shared/Plugins/Netscape/NetscapePluginModule.h:
* Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
(WebKit::NetscapePluginModule::parseMIMEDescription): Make this
method public.
(WebKit::NetscapePluginModule::buildMIMEDescription): Added this
helper to build the MIME description string.
* UIProcess/Plugins/gtk/PluginInfoCache.cpp: Added.
(WebKit::PluginInfoCache::shared):
(WebKit::PluginInfoCache::PluginInfoCache):
(WebKit::PluginInfoCache::~PluginInfoCache):
(WebKit::PluginInfoCache::saveToFileIdleCallback):
(WebKit::PluginInfoCache::saveToFile):
(WebKit::PluginInfoCache::getPluginInfo):
(WebKit::PluginInfoCache::updatePluginInfo):
* UIProcess/Plugins/gtk/PluginInfoCache.h: Added.
* UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:
(WebKit::PluginInfoStore::getPluginInfo): Check first if we have
metadata of the plugin in the cache and update the cache if we
loaded the plugin to get its metadata.
Commit: 6ab208ab92bb66493cc84dd1853acee8a899cac7
https://github.com/WebKit/WebKit/commit/6ab208ab92bb66493cc84dd1853acee8a899cac7
Author: Tomáš Popela <tpopela at redhat.com>
Date: 2014-03-19 (Wed, 19 Mar 2014)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm
Log Message:
-----------
Merge r164980 - [GTK] webkit_dom_range_compare_boundary_points fails when 0 is passed as how parameter
https://bugs.webkit.org/show_bug.cgi?id=129145
Patch by Tomas Popela <tpopela at redhat.com> on 2014-03-03
Reviewed by Carlos Garcia Campos.
While generating GObject DOM API the generator should skip non pointer
types while generating the g_return_val_if_fail macro.
This will avoid the situation when Range.START_TO_START is defined as 0,
thus the webkit_dom_range_compare_boundary_points function will fail
everytime it is called with 0 as how value.
* bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunction):
Commit: 9c9fe8ae848eb955f917d47840d87198b1bb64b8
https://github.com/WebKit/WebKit/commit/9c9fe8ae848eb955f917d47840d87198b1bb64b8
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-03-19 (Wed, 19 Mar 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp
Log Message:
-----------
Merge r165182 - [GTK] Close the page when the view is disposed instead of when finalized
https://bugs.webkit.org/show_bug.cgi?id=129783
Reviewed by Sergio Villar Senin.
Source/WebKit2:
When a GtkWidget is destroyed, the GObject is disposed, but not
finalized if it has additional references. When the destroyed
widget is leaked by the application, we leak the page proxy and
what is more important the web process in multi-process mode.
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseDispose): Close the WebPageProxy.
Commit: e4ecec6bcdcdf4ececdaec0348109e4747dc5260
https://github.com/WebKit/WebKit/commit/e4ecec6bcdcdf4ececdaec0348109e4747dc5260
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-03-19 (Wed, 19 Mar 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/WebProcess/WebPage/WebPage.cpp
M Source/WebKit2/WebProcess/WebPage/WebPage.h
M Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp
M Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.h
Log Message:
-----------
Merge r165489 - [GTK] Runtime error when page is closed while print operation is in progress
https://bugs.webkit.org/show_bug.cgi?id=129869
Reviewed by Anders Carlsson.
Sometimes when the page is closed right after printing the web
process aborts with the runtime message "pure virtual method
called terminate called without an active exception".
This happens because the page is closed when the pages have been
printed, but print job is still ongoing sending the data to the
printer. When print job finishes, we try to notify the UI process
sending the print callback message using WebPage::send(), but the
web page object has been destroyed. The virtual method it complains
about is probably MessageSender::messageSenderDestinationID() used
by send(). Since our print operation is always asynchronous, we
need a way to notify the web page when the print operation has
actually finished to clean it up, but also notify the print
operation when the page has been closed to not try to notify the
UI process in that case.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close): Call disconnectFromPage to notify the
print operation in case there's an ongoing print job.
(WebKit::WebPage::endPrinting): Do not cleanup the print operation
here, since the print opertation might not have finished yet.
(WebKit::WebPage::didFinishPrintOperation): Send
PrintFinishedCallback message to the Ui process and cleanup the
print operation.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::WebPrintOperationGtk::disconnectFromPage): Set m_webPage
to nullptr.
(WebKit::WebPrintOperationGtk::printDone): Call
didFinishPrintOperation() is the web page hasn't been closed.
* WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
Commit: 792c3cb4ae774e3a36bc7b7cac6104510edd1976
https://github.com/WebKit/WebKit/commit/792c3cb4ae774e3a36bc7b7cac6104510edd1976
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-03-19 (Wed, 19 Mar 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp
Log Message:
-----------
Merge r165371 - [GTK] The web process can finish while a print operation is still ongoing
https://bugs.webkit.org/show_bug.cgi?id=129871
Reviewed by Martin Robinson.
This can happen when the last page is closed while the print job
is sending data to the printer.
* WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp: Disable web
process termination when the print job is sending data to the
printer and enable it again when job finishes.
Commit: b3dfdb949416b0bd3194171444a1fa56f6281278
https://github.com/WebKit/WebKit/commit/b3dfdb949416b0bd3194171444a1fa56f6281278
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-03-19 (Wed, 19 Mar 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp
Log Message:
-----------
Merge r165550 - [GTK] Close the connection when we fail to read from the socket for any unhandled error
https://bugs.webkit.org/show_bug.cgi?id=130191
Reviewed by Martin Robinson.
We currently show an error message, but we should close the
connection avoid entering an infinite loop. Also provide more
information in the error message to help when debugging the issue.
* Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::Connection::readyReadHandler):
Commit: 2ab733df76071edd80ebde6eb20c69e989f69118
https://github.com/WebKit/WebKit/commit/2ab733df76071edd80ebde6eb20c69e989f69118
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-03-19 (Wed, 19 Mar 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/Platform/gtk/WorkQueueGtk.cpp
Log Message:
-----------
Merge r165812 - [GTK] Race condition when the socket event source is cancelled
https://bugs.webkit.org/show_bug.cgi?id=130395
Reviewed by Martin Robinson.
In some cases when the socket event source is cancelled the socket
event source callback is called with the condition of the previous
poll instead of 0. This can happen sometimes when the source is
cancelled from the socket event source callback. Once the socket
event source is cancelled, it's dispatched by glib without
polling, so the condition is never reset again and the callback is
called again and again with the previous condition. When the
condition is G_IO_IN, the source is re-scheduled entering into an
infinite loop. We should always check if the source has been
cancelled at the beginning of the callback to destroy the source
instead of relying on the condition being 0.
* Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::SocketEventSource::isCancelled):
(WorkQueue::SocketEventSource::eventCallback):
Commit: 64072395e1dc8ed8cf260d4abee2e11d07bd4663
https://github.com/WebKit/WebKit/commit/64072395e1dc8ed8cf260d4abee2e11d07bd4663
Author: Carlos Garcia Campos <carlosgc at webkit.org>
Date: 2014-03-19 (Wed, 19 Mar 2014)
Changed paths:
M ChangeLog
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/NEWS
M Source/autotools/Versions.m4
Log Message:
-----------
Unreviewed. Update NEWS and Versions.m4 for 2.2.6 release.
.:
* Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
* NEWS: Add release notes.
Commit: 90e328ba1dc5f3e3ebc83479cc70b06e16354c26
https://github.com/WebKit/WebKit/commit/90e328ba1dc5f3e3ebc83479cc70b06e16354c26
Author: Xabier Rodriguez-Calvar <calvaris at igalia.com>
Date: 2014-04-30 (Wed, 30 Apr 2014)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
M Source/WebCore/platform/graphics/texmap/TextureMapper.cpp
M Source/WebCore/platform/graphics/texmap/TextureMapper.h
Log Message:
-----------
Merge r166480 - [GTK] [TextureMapper] Weird brightness with some videos with acceletared compositing
https://bugs.webkit.org/show_bug.cgi?id=130665
Reviewed by Martin Robinson.
When we uploaded a video texture to the mapper we were not
considering that some videos could be decoded into a format
without alpha component. Now we check if the video has alpha and
if it does not, we remove the alpha flag when retrieving the
texture from the pool. For this, the method to get the texture
from the pool was modified to receive the flags, that is mapped to
have alpha by default in order not to break any other existing
code.
Though we have a problem with AC in WTR and that makes it
currently not testable, no new tests are needed because once this
is fixed the current test set suffices to detect a possible
regression in this.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture): Check
the video format and decide if the texture shall be pulled with
alpha support or not.
* platform/graphics/texmap/TextureMapper.cpp:
(WebCore::TextureMapper::acquireTextureFromPool): Use the flags
when resetting the texture.
* platform/graphics/texmap/TextureMapper.h:
(WebCore::BitmapTexture::Flag::None): Added with 0x00.
(WebCore::TextureMapper::acquireTextureFromPool): Added flag
parameter to set up the texture with the default for including
alpha channel.
Commit: 066b03782c9169bd6555be6bc1b41db03e3908e2
https://github.com/WebKit/WebKit/commit/066b03782c9169bd6555be6bc1b41db03e3908e2
Author: Žan Doberšek <zdobersek at igalia.com>
Date: 2014-04-30 (Wed, 30 Apr 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
Log Message:
-----------
Merge r166574 - [GTK] Don't copy the ResourceResponse object in webkitWebViewDecidePolicy
https://bugs.webkit.org/show_bug.cgi?id=131015
Reviewed by Carlos Garcia Campos.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewDecidePolicy): Avoid copying the ResourceResponce object returned by webkitURIResponseGetResourceResponse.
That function already returns a reference, so the return value should be stored accordingly.
Commit: 79cc661cc98d47900ea3b451afc01c47e7775fb7
https://github.com/WebKit/WebKit/commit/79cc661cc98d47900ea3b451afc01c47e7775fb7
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-04-30 (Wed, 30 Apr 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp
Log Message:
-----------
Merge r167883 - [GTK] Crash in debug build with removing windowed plugin child widgets from the view
https://bugs.webkit.org/show_bug.cgi?id=132252
Reviewed by Philippe Normand.
It crashes due to an assert in HashTable that checks the iterators
validity. The problem is that we are iterating the children map
and the callback called on every iteration might modify the map,
making the iterators invalid. This happens when the WebView is
destroyed, GtkContainer calls gtk_container_foreach() with
gtk_widget_destroy as callback. When a widget inside a container
is destroyed, it's removed from the container, and in our case,
the child widget is removed from the map. This fixes several
crashes when running layout tests in debug bot.
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseContainerForall): Use copyKeysToVector() instead
of using a range iterator for the map keys and check in every
iteration that the child widget from the keys vector is still
present in the map before calling the callback.
Commit: 956cb948264ebf436e16fd8cfe1c493b3a0f1e71
https://github.com/WebKit/WebKit/commit/956cb948264ebf436e16fd8cfe1c493b3a0f1e71
Author: Carlos Garcia Campos <carlosgc at webkit.org>
Date: 2014-04-30 (Wed, 30 Apr 2014)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/GNUmakefile.list.am
M Source/WebCore/plugins/PluginPackage.cpp
M Source/WebCore/plugins/PluginPackage.h
M Source/WebCore/plugins/PluginView.cpp
Log Message:
-----------
Unreviewed. [GTK] Plugin process crashes when loading totem plugin
https://bugs.webkit.org/show_bug.cgi?id=131357
Make Netscape browser functions static to avoid conflicts with
plugins defining those functions as well.
* GNUmakefile.list.am: Do not build npapi.cpp.
* plugins/PluginPackage.cpp:
(WebCore::pluginViewForInstance):
(WebCore::NPN_MemAlloc):
(WebCore::NPN_MemFree):
(WebCore::NPN_MemFlush):
(WebCore::NPN_ReloadPlugins):
(WebCore::NPN_RequestRead):
(WebCore::NPN_GetURLNotify):
(WebCore::NPN_GetURL):
(WebCore::NPN_PostURLNotify):
(WebCore::NPN_PostURL):
(WebCore::NPN_NewStream):
(WebCore::NPN_Write):
(WebCore::NPN_DestroyStream):
(WebCore::NPN_UserAgent):
(WebCore::NPN_Status):
(WebCore::NPN_InvalidateRect):
(WebCore::NPN_InvalidateRegion):
(WebCore::NPN_ForceRedraw):
(WebCore::NPN_GetValue):
(WebCore::NPN_SetValue):
(WebCore::NPN_GetJavaEnv):
(WebCore::NPN_GetJavaPeer):
(WebCore::NPN_PushPopupsEnabledState):
(WebCore::NPN_PopPopupsEnabledState):
(WebCore::NPN_PluginThreadAsyncCall):
(WebCore::NPN_GetValueForURL):
(WebCore::NPN_SetValueForURL):
(WebCore::NPN_GetAuthenticationInfo):
(WebCore::NPN_PopUpContextMenu):
* plugins/PluginPackage.h:
(WebCore::PluginPackage::browserFuncs): Add accessor to browser
function pointers.
* plugins/PluginView.cpp:
(WebCore::PluginView::stop): Use browser function pointers instead
of NPN wrappers that are now private.
(WebCore::PluginView::getValueForURL): Ditto.
Commit: b0844190e3b169932c3e34bba7a8e75dcbbb7403
https://github.com/WebKit/WebKit/commit/b0844190e3b169932c3e34bba7a8e75dcbbb7403
Author: Žan Doberšek <zdobersek at igalia.com>
Date: 2014-04-30 (Wed, 30 Apr 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h
M Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp
Log Message:
-----------
Merge r167116 - [GTK][WK2] Move Vector objects into WebEditorClient::executePendingEditorCommands() invocations
https://bugs.webkit.org/show_bug.cgi?id=131454
Reviewed by Carlos Garcia Campos.
* WebProcess/WebCoreSupport/WebEditorClient.h:
* WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
(WebKit::WebEditorClient::executePendingEditorCommands): Take a const reference of the Vector
object to avoid unnecessary copies. Also deploy two range-based for loops and efficiently move
the Editor::Command objects into the other Vector.
Commit: 4667ed7a1cbd90ac8fb9fa01ebc6a2e6553a61e4
https://github.com/WebKit/WebKit/commit/4667ed7a1cbd90ac8fb9fa01ebc6a2e6553a61e4
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-04-30 (Wed, 30 Apr 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp
Log Message:
-----------
Merge r167128 - wk2-gtk does not display anything
https://bugs.webkit.org/show_bug.cgi?id=125558
Reviewed by Martin Robinson.
Remove fcntl call to set access mode flags on the duplicated files
descriptor. Those flags are ignored in Linux and make fcntl to
fail in FreeBSD. We should handle the case where the passed
protection is ReadOnly.
Thanks to Raphael Kubo da Costa who proposed the solution.
* Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::createHandle):
(WebKit::accessModeFile): Deleted.
Commit: cff9b7713a0b50dc1b2071a4d81aece0a25aa12d
https://github.com/WebKit/WebKit/commit/cff9b7713a0b50dc1b2071a4d81aece0a25aa12d
Author: Renata Hodovan <rhodovan.u-szeged at partner.samsung.com>
Date: 2014-04-30 (Wed, 30 Apr 2014)
Changed paths:
M LayoutTests/ChangeLog
A LayoutTests/editing/execCommand/indent-with-uneditable-crash-expected.txt
A LayoutTests/editing/execCommand/indent-with-uneditable-crash.html
M Source/WebCore/ChangeLog
M Source/WebCore/editing/CompositeEditCommand.cpp
Log Message:
-----------
Merge r164170 - ASSERT_WITH_SECURITY_IMPLICATION in WebCore::toElement
https://bugs.webkit.org/show_bug.cgi?id=128810
Patch by Renata Hodovan <rhodovan.u-szeged at partner.samsung.com> on 2014-02-15
Reviewed by Ryosuke Niwa.
Source/WebCore:
Make CompositeEditCommand::cloneParagraphUnderNewElement() to work when |outerNode|
doesn't contain |start|.
Before this patch, CompositeEditCommand::cloneParagraphUnderNewElement() tried to copy
ancestry nodes from |start| to Document node when |start| position isn't in |outerNode|. This
patch changes CompositeEditCommand::cloneParagraphUnderNewElement() to copy |start| to
|outerNode| only if |outerNode| contains |start| position.
Merged from Blink https://src.chromium.org/viewvc/blink?revision=161762&view=revision by yosin at chromium.org.
Test: editing/execCommand/indent-with-uneditable-crash.html
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
LayoutTests:
* editing/execCommand/indent-with-uneditable-crash-expected.txt: Added.
* editing/execCommand/indent-with-uneditable-crash.html: Added.
Commit: 6bbc0220c713c00216ef948592042a514510e9dc
https://github.com/WebKit/WebKit/commit/6bbc0220c713c00216ef948592042a514510e9dc
Author: Andreas Kling <akling at apple.com>
Date: 2014-04-30 (Wed, 30 Apr 2014)
Changed paths:
M LayoutTests/ChangeLog
A LayoutTests/fast/frames/reattach-in-unload-expected.txt
A LayoutTests/fast/frames/reattach-in-unload.html
M Source/WebCore/ChangeLog
M Source/WebCore/html/HTMLFrameOwnerElement.h
Log Message:
-----------
Merge r164204 - Ensure that removing an iframe from the DOM tree disconnects its Frame.
<https://webkit.org/b/128889>
<rdar://problem/15671221>
Merged from Blink (patch by Adam Klein):
https://src.chromium.org/viewvc/blink?revision=156174&view=revision
Source/WebCore:
SubframeLoadingDisabler wasn't catching the case when an <iframe> was,
in its unload handler, removed and re-added to the same parent.
Fix this by using a count of SubframeLoadingDisablers that are on the
stack for a given root, rather than a simple boolean.
Test: fast/frames/reattach-in-unload.html
* html/HTMLFrameOwnerElement.h:
(WebCore::SubframeLoadingDisabler::disabledSubtreeRoots):
LayoutTests:
* fast/frames/reattach-in-unload-expected.txt: Added.
* fast/frames/reattach-in-unload.html: Added.
Commit: bc726f807734ed146ec382562e296c06e0fcec4f
https://github.com/WebKit/WebKit/commit/bc726f807734ed146ec382562e296c06e0fcec4f
Author: Daniel Bates <dbates at webkit.org>
Date: 2014-04-30 (Wed, 30 Apr 2014)
Changed paths:
M LayoutTests/ChangeLog
A LayoutTests/fast/forms/number/number-type-update-by-change-event-expected.txt
A LayoutTests/fast/forms/number/number-type-update-by-change-event.html
M Source/WebCore/ChangeLog
M Source/WebCore/html/InputType.cpp
Log Message:
-----------
Merge r164367 - Do not dispatch change event twice in single step action
https://bugs.webkit.org/show_bug.cgi?id=116936
<rdar://problem/16086828>
Reviewed by Ryosuke Niwa.
Merged from Blink (patch by Kent Tamura):
https://src.chromium.org/viewvc/blink?view=rev&revision=151175
Source/WebCore:
Test: fast/forms/number/number-type-update-by-change-event.html
* html/InputType.cpp:
(WebCore::InputType::stepUpFromRenderer):
LayoutTests:
* fast/forms/number/number-type-update-by-change-event-expected.txt: Added.
* fast/forms/number/number-type-update-by-change-event.html: Added.
Commit: 8deab3f7d2f980c625b9ae78e426d2dcec79e86a
https://github.com/WebKit/WebKit/commit/8deab3f7d2f980c625b9ae78e426d2dcec79e86a
Author: Jon Honeycutt <jhoneycutt at apple.com>
Date: 2014-04-30 (Wed, 30 Apr 2014)
Changed paths:
M Source/WTF/ChangeLog
M Source/WTF/wtf/text/StringBuilder.cpp
Log Message:
-----------
Merge r164408 - Crash in WTF::StringBuilder::append()
https://bugs.webkit.org/show_bug.cgi?id=125817
<rdar://problem/15671883>
Reviewed by Oliver Hunt.
* wtf/text/StringBuilder.cpp:
(WTF::expandedCapacity):
Ensure that we return a new capacity of at least 'requiredLength' in
the case where requiredLength is large. Also, use unsigned rather than
size_t for the parameters and the return value, as callers pass
unsigned arguments and treat the result as an unsigned int.
Commit: 0eee9e2469b70979b9348c6d39f854e8e17dbe1e
https://github.com/WebKit/WebKit/commit/0eee9e2469b70979b9348c6d39f854e8e17dbe1e
Author: Bem Jones-Bey <bjonesbe at adobe.com>
Date: 2014-04-30 (Wed, 30 Apr 2014)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/platform/text/BidiRunList.h
Log Message:
-----------
Merge r164876 - Properly clear m_logicallyLastRun to remove use-after-free possibility
https://bugs.webkit.org/show_bug.cgi?id=129489
Reviewed by David Hyatt.
A use-after-free issue was caught in Blink because m_logicallyLastRun
is not cleared when the item it points to is deleted. Clearing it
turns the use-after-free into a segfault, and prevents any future
use-after-frees from happening.
* platform/text/BidiRunList.h:
(WebCore::BidiRunList<Run>::deleteRuns):
Commit: b3847437b0b22f7f73f335559333205f1af41ffd
https://github.com/WebKit/WebKit/commit/b3847437b0b22f7f73f335559333205f1af41ffd
Author: David Kilzer <ddkilzer at webkit.org>
Date: 2014-04-30 (Wed, 30 Apr 2014)
Changed paths:
M LayoutTests/ChangeLog
A LayoutTests/svg/animations/animate-keysplines-crash-expected.txt
A LayoutTests/svg/animations/animate-keysplines-crash.html
M Source/WebCore/ChangeLog
M Source/WebCore/svg/SVGAnimationElement.cpp
Log Message:
-----------
Merge r164933 - Ensure keySplines is valid in SMIL animations
<http://webkit.org/b/129547>
<rdar://problem/15676128>
Reviewed by Darin Adler.
Merged from Blink (patch by Philip Rogers):
https://src.chromium.org/viewvc/blink?revision=156452&view=revision
http://crbug.com/276111
This patch fixes a crash in SMIL animations when keySplines are not
specified. The SMIL spec is clear on this:
http://www.w3.org/TR/2001/REC-smil-animation-20010904/#AnimFuncCalcMode
"If there are any errors in the keyTimes specification (bad values,
too many or too few values), the animation will have no effect."
This patch simply checks that keyTimes is not empty. Previously,
splinesCount was set to be m_keySplines.size() + 1 in
SVGAnimationElement.cpp; this patch changes splinesCount to be equal
to m_keySplines.size() to make the logic easier to follow and to
match other checks in SVGAnimationElement::startedActiveInterval.
Source/WebCore:
Test: svg/animations/animate-keysplines-crash.html
* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::startedActiveInterval):
LayoutTests:
* svg/animations/animate-keysplines-crash-expected.txt: Added.
* svg/animations/animate-keysplines-crash.html: Added.
Commit: 0f12da59db25b861c49776cc2ddf7a54697fc6d0
https://github.com/WebKit/WebKit/commit/0f12da59db25b861c49776cc2ddf7a54697fc6d0
Author: David Kilzer <ddkilzer at webkit.org>
Date: 2014-04-30 (Wed, 30 Apr 2014)
Changed paths:
M LayoutTests/ChangeLog
A LayoutTests/editing/execCommand/format-block-crash-expected.txt
A LayoutTests/editing/execCommand/format-block-crash.html
A LayoutTests/editing/execCommand/resources/format-block-crash-iframe.html
M Source/WebCore/ChangeLog
M Source/WebCore/editing/CompositeEditCommand.cpp
M Source/WebCore/editing/CompositeEditCommand.h
Log Message:
-----------
Merge r165138 - Fix crash in CompositeEditCommand::cloneParagraphUnderNewElement()
<http://webkit.org/b/129751>
<rdar://problem/16237965>
Reviewed by Jon Honeycutt.
Merged from Blink (patch by Yuta Kitamura):
https://src.chromium.org/viewvc/blink?revision=168160&view=revision
http://crbug.com/345005
The root cause is CompositeEditCommand::moveParagraphWithClones() passing
two positions |start| and |end| which do not follow the document order,
i.e. in some situations |start| is located after |end| because of
the difference in affinity.
This patch fixes this crash by normalizing |end| to |start| in such situations.
It also adds an ASSERT that checks the relationship between |start| and |end|.
Source/WebCore:
Test: editing/execCommand/format-block-crash.html
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
(WebCore::CompositeEditCommand::moveParagraphWithClones):
* editing/CompositeEditCommand.h:
LayoutTests:
* editing/execCommand/format-block-crash-expected.txt: Added.
* editing/execCommand/format-block-crash.html: Added.
* editing/execCommand/resources/format-block-crash-iframe.html: Added.
Commit: fad5cfc3f44cb9913aca65e26250e055a21b9f25
https://github.com/WebKit/WebKit/commit/fad5cfc3f44cb9913aca65e26250e055a21b9f25
Author: Daniel Bates <dbates at webkit.org>
Date: 2014-04-30 (Wed, 30 Apr 2014)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp
M Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp
M Source/WebCore/loader/appcache/ApplicationCacheStorage.h
Log Message:
-----------
Merge r165145 - ASSERT(newestManifest) fails in WebCore::ApplicationCacheGroup::didFinishLoadingManifest()
https://bugs.webkit.org/show_bug.cgi?id=129753
<rdar://problem/12069835>
Reviewed by Alexey Proskuryakov.
Fixes an issue where an assertion failure would occur when visiting a web site whose on-disk
app cache doesn't contain a manifest resource.
For some reason an app cache for a web site may be partially written to disk. In particular, the
app cache may only contain a CacheGroups entry. That is, the manifest resource and origin records
may not be persisted to disk. From looking over the code, we're unclear how such a situation can occur
and hence have been unable to create such an app cache. We were able to reproduce this issue using
an app cache database file that was provided by a person that was affected by this issue.
No test included because it's not straightforward to write a test for this change.
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Assert that m_cacheBeingUpdated->manifestResource()
is non-null. Currently we only document this assumption in a code comment. Also separated a single assertion
expression into two assertion expressions to make it straightforward to identify the failing sub-expression
on failure.
* loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::store): Modified to call ApplicationCacheStorage::deleteCacheGroupRecord()
to remove a cache group and associated cache records (if applicable) before inserting a cache group entry.
This replacement approach will ultimately repair incomplete app cache data for people affected by this bug.
(WebCore::ApplicationCacheStorage::loadCache): Log an error and return nullptr if the cache we loaded doesn't
have a manifest resource.
(WebCore::ApplicationCacheStorage::deleteCacheGroupRecord): Added.
(WebCore::ApplicationCacheStorage::deleteCacheGroup): Extracted deletion logic for cache group record into
ApplicationCacheStorage::deleteCacheGroupRecord().
* loader/appcache/ApplicationCacheStorage.h:
Commit: 1e9d57f0702c8c2acf9d487c487e04e908e7a88d
https://github.com/WebKit/WebKit/commit/1e9d57f0702c8c2acf9d487c487e04e908e7a88d
Author: Oliver Hunt <oliver at apple.com>
Date: 2014-04-30 (Wed, 30 Apr 2014)
Changed paths:
M LayoutTests/ChangeLog
A LayoutTests/fast/workers/resources/worker-copy-shared-blob-url-worker.js
A LayoutTests/fast/workers/worker-copy-shared-blob-url-expected.txt
A LayoutTests/fast/workers/worker-copy-shared-blob-url.html
M Source/WebCore/ChangeLog
M Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp
M Source/WebCore/bindings/js/SerializedScriptValue.cpp
M Source/WebCore/bindings/js/SerializedScriptValue.h
Log Message:
-----------
Merge r165339 - SerializedScriptValue may move Identifiers between worlds
https://bugs.webkit.org/show_bug.cgi?id=129979
Reviewed by Andreas Kling.
Source/WebCore:
Test: fast/workers/worker-copy-shared-blob-url.html
Don't use Strings to store blob URLs as String's may be Identifiers
and they can only exist in one world/thread at a time.
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::put):
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::deserializeString):
(WebCore::SerializedScriptValue::addBlobURL):
(WebCore::SerializedScriptValue::SerializedScriptValue):
* bindings/js/SerializedScriptValue.h:
LayoutTests:
Add test cases
* fast/workers/resources/worker-copy-shared-blob-url-worker.js: Added.
(count.0.onmessage):
* fast/workers/worker-copy-shared-blob-url-expected.txt: Added.
* fast/workers/worker-copy-shared-blob-url.html: Added.
Commit: 6e4f4494537484a4bf5202cfe32b380112e019a4
https://github.com/WebKit/WebKit/commit/6e4f4494537484a4bf5202cfe32b380112e019a4
Author: Antti Koivisto <koivisto at iki.fi>
Date: 2014-04-30 (Wed, 30 Apr 2014)
Changed paths:
M LayoutTests/ChangeLog
A LayoutTests/fast/css/getMatchedCSSProperties-rule-mutation-expected.txt
A LayoutTests/fast/css/getMatchedCSSProperties-rule-mutation.html
A LayoutTests/fast/css/getMatchedCSSRules-crash-expected.txt
A LayoutTests/fast/css/getMatchedCSSRules-crash.html
M Source/WebCore/ChangeLog
M Source/WebCore/css/CSSStyleRule.cpp
M Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp
M Source/WebCore/css/PropertySetCSSStyleDeclaration.h
Log Message:
-----------
Merge r165821 - Mutating rules returned by getMatchedCSSRules can result in crash
https://bugs.webkit.org/show_bug.cgi?id=130209
Source/WebCore:
Reviewed by Andreas Kling.
The non-standard getMatchedCSSRules API returns CSSStyleRule objects that don't
have parent stylesheet pointer (as we don't know which sheet the rule originated from).
Mutating the rule via such wrapper can lead to crashes later as we fail to invalidate
the underlying stylesheet.
Fix by disallowing mutation of style rules that don't have parent sheet pointer. CSSStyleRule
has two mutable properties selectorText and style. The latter gives back CSSStyleDeclaration.
This patch disallows mutations in both cases for CSSStyleRules that don't have parent stylesheet
pointer.
While it is technically possible to have CSSRules that are legitimately disconnected
from stylesheet (by removing rule from sheet while holding a reference to it) it never
makes sense to mutate such rule as there is no way to do anything with it afterwards.
Tests: fast/css/getMatchedCSSProperties-rule-mutation.html
fast/css/getMatchedCSSRules-crash.html
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):
Bail out if parent stylesheet is null.
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
Allow StyleRuleCSSStyleDeclaration subclass cancel the mutation via
boolean return value from willMutate.
(WebCore::StyleRuleCSSStyleDeclaration::willMutate):
Disallow mutation if the owning CSSStyleRule is null or has null stylesheet.
(WebCore::StyleRuleCSSStyleDeclaration::didMutate):
We never get here with null rule or stylesheet anymore.
* css/PropertySetCSSStyleDeclaration.h:
(WebCore::PropertySetCSSStyleDeclaration::willMutate):
LayoutTests:
Reviewed by Andreas Kling.
* fast/css/getMatchedCSSProperties-rule-mutation-expected.txt: Added.
* fast/css/getMatchedCSSProperties-rule-mutation.html: Added.
* fast/css/getMatchedCSSRules-crash-expected.txt: Added.
* fast/css/getMatchedCSSRules-crash.html: Added.
Commit: 0f4aaa7389330d53d7f769ca811eee4202922724
https://github.com/WebKit/WebKit/commit/0f4aaa7389330d53d7f769ca811eee4202922724
Author: Mark Lam <mark.lam at apple.com>
Date: 2014-04-30 (Wed, 30 Apr 2014)
Changed paths:
M Source/JavaScriptCore/ChangeLog
M Source/JavaScriptCore/runtime/JSStringJoiner.cpp
Log Message:
-----------
Merge r165902 - Update type of local vars to match the type of String length.
<https://webkit.org/b/130077>
Reviewed by Geoffrey Garen.
* runtime/JSStringJoiner.cpp:
(JSC::JSStringJoiner::join):
Commit: f18fbfde63597e4271bfb73ff396edd19c767609
https://github.com/WebKit/WebKit/commit/f18fbfde63597e4271bfb73ff396edd19c767609
Author: Antti Koivisto <koivisto at iki.fi>
Date: 2014-04-30 (Wed, 30 Apr 2014)
Changed paths:
M LayoutTests/ChangeLog
A LayoutTests/fast/css/long-selector-list-crash-expected.txt
A LayoutTests/fast/css/long-selector-list-crash.html
M Source/WebCore/ChangeLog
M Source/WebCore/css/CSSSelectorList.cpp
M Source/WebCore/css/StyleRule.cpp
Log Message:
-----------
Merge r165921 - Crash with long selector list
https://bugs.webkit.org/show_bug.cgi?id=123006
Reviewed by Andreas Kling.
Source/WebCore:
Test: fast/css/long-selector-list-crash.html
* css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::CSSSelectorList):
(WebCore::CSSSelectorList::adoptSelectorVector):
(WebCore::CSSSelectorList::operator=):
* css/StyleRule.cpp:
(WebCore::StyleRule::create):
Add a bunch of asserts.
(WebCore::StyleRule::splitIntoMultipleRulesWithMaximumSelectorComponentCount):
This could produce a zero-length selector list.
LayoutTests:
* fast/css/long-selector-list-crash-expected.txt: Added.
* fast/css/long-selector-list-crash.html: Added.
Commit: 346933a0304f7e86fdfd70c9acef6cf4ee6b6cd0
https://github.com/WebKit/WebKit/commit/346933a0304f7e86fdfd70c9acef6cf4ee6b6cd0
Author: Oliver Hunt <oliver at apple.com>
Date: 2014-04-30 (Wed, 30 Apr 2014)
Changed paths:
M LayoutTests/ChangeLog
A LayoutTests/fast/dom/navigation-with-sideeffects-expected.txt
A LayoutTests/fast/dom/navigation-with-sideeffects.html
M Source/WebCore/ChangeLog
M Source/WebCore/bindings/js/JSDocumentCustom.cpp
Log Message:
-----------
Merge r166090 - Source/WebCore: Fix a crash when assigning an object to document.location
https://bugs.webkit.org/show_bug.cgi?id=130213
Reviewed by Geoffrey Garen.
Convert location to string before we make use the document.
This prevents us from attempting to navigate a frame that
has already been removed.
Test: fast/dom/navigation-with-sideeffects-crash.html
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::location):
(WebCore::JSDocument::setLocation):
LayoutTests: Fix semantics of JS execution when assigning an object to document.location
https://bugs.webkit.org/show_bug.cgi?id=130213
Reviewed by Geoffrey Garen.
* fast/dom/navigation-with-sideeffects-expected.txt: Added.
* fast/dom/navigation-with-sideeffects.html: Added.
Commit: 34adcc31e7e11bfe71e88a3f9b0781f92edbb8be
https://github.com/WebKit/WebKit/commit/34adcc31e7e11bfe71e88a3f9b0781f92edbb8be
Author: Jer Noble <jer.noble at apple.com>
Date: 2014-04-30 (Wed, 30 Apr 2014)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/rendering/RenderLayerBacking.cpp
Log Message:
-----------
Merge r166304 - REGRESSION(r162679): Poster image visible under the video
https://bugs.webkit.org/show_bug.cgi?id=130783
Reviewed by Simon Fraser.
In the listed revision, we started checking for isRenderImage()
instead of isImage(). RenderMedias return 'true' for the first
but 'false' for the second. Change the if() statement to check
for isRenderMedia() in addition to !isRenderImage().
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::isDirectlyCompositedImage):
Commit: 52321e293706f96ad10ec526a8a12366dcad5cea
https://github.com/WebKit/WebKit/commit/52321e293706f96ad10ec526a8a12366dcad5cea
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-04-30 (Wed, 30 Apr 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
Log Message:
-----------
Merge r167656 - [GTK] Crash after getting web view context property with g_object_get
https://bugs.webkit.org/show_bug.cgi?id=131983
Reviewed by Philippe Normand.
The problem is that the getter is using g_value_take_object() and
the default context is destroyed when the caller releases its ref.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewGetProperty): Use g_value_set_object() instead of
g_value_take_object().
Commit: 9966254fb9b356e30420a4ed5ac3ed639938ffb2
https://github.com/WebKit/WebKit/commit/9966254fb9b356e30420a4ed5ac3ed639938ffb2
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-04-30 (Wed, 30 Apr 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp
Log Message:
-----------
Merge r167795 - [GTK] Plugin process crashes with GTK2 windowed plugins
https://bugs.webkit.org/show_bug.cgi?id=132127
Reviewed by Martin Robinson.
It happens sometimes because the socket is used before the plug
has been added. A runtime critical warnings is shown and it
sometimes ends up crashing.
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformPostInitializeWindowed): Do not
show the plug widget until the socket is connected.
Commit: 92151b8559d1363675c5bef30b2d7c756175e531
https://github.com/WebKit/WebKit/commit/92151b8559d1363675c5bef30b2d7c756175e531
Author: Carlos Garcia Campos <carlosgc at webkit.org>
Date: 2014-04-30 (Wed, 30 Apr 2014)
Changed paths:
M ChangeLog
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/NEWS
M Source/autotools/Versions.m4
Log Message:
-----------
Unreviewed. Update NEWS and Versions.m4 for 2.2.7 release.
.:
* Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
* NEWS: Add release notes.
Commit: 4c52ca6857ae3162683e8c2f055b20e435b57cc7
https://github.com/WebKit/WebKit/commit/4c52ca6857ae3162683e8c2f055b20e435b57cc7
Author: Sergio Villar Senin <svillar at igalia.com>
Date: 2014-06-06 (Fri, 06 Jun 2014)
Changed paths:
M LayoutTests/ChangeLog
M LayoutTests/http/tests/misc/resources/webtiming-ssl.html
M LayoutTests/http/tests/misc/webtiming-ssl-expected.txt
M LayoutTests/platform/gtk/TestExpectations
M Source/WebCore/ChangeLog
M Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp
Log Message:
-----------
Merge r154727 - [Soup] WebTiming information not shown in the inspector
https://bugs.webkit.org/show_bug.cgi?id=118395
Reviewed by Martin Robinson.
Source/WebCore:
WebTiming information was not correctly provided to WebCore
because the gotHeadersCallback was incorrectly resetting the
original ResourceResponse (which had the ResourceLoadTiming
object) instead of simply updating their contents using the
SoupMessage.
No new test required as this feature is already covered by the
existing webtiming tests. In any case this change includes a fix
for the http/tests/misc/webtiming-ssl.php test which was not
failing even if it should because it was not correct.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::gotHeadersCallback):
(WebCore::restartedCallback): restartedCallback should be
available only if WEB_TIMING is defined.
(WebCore::createSoupMessageForHandleAndRequest): Ditto.
LayoutTests:
Fixed the webiming-ssl.php test that was incorrectly considering a
FAIL as the expected result. It was probably just a legacy
decision which came from the times where DRT was responsible of
reporting WebTiming information.
Also added a new test that fails due to wkb.ug/103927. It was not
detected before because there were no timing information in the
response.
* http/tests/misc/resources/webtiming-ssl.html:
* http/tests/misc/webtiming-ssl-expected.txt:
* platform/gtk/TestExpectations: added
http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_attribute_order.html.
Commit: 5c030cef6b99b227c26c69f23438c5d9a1cfe4d1
https://github.com/WebKit/WebKit/commit/5c030cef6b99b227c26c69f23438c5d9a1cfe4d1
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-08-12 (Tue, 12 Aug 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/Plugins/gtk/PluginInfoCache.cpp
Log Message:
-----------
Merge r172442 - [GTK] The plugins metadata cache doesn't work if the user cache directory doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=135834
Reviewed by Philippe Normand.
Make sure the user cache directory exists. If creating the
directory fails for whatever reason, do not try to save the cache
to disk.
* UIProcess/Plugins/gtk/PluginInfoCache.cpp:
(WebKit::PluginInfoCache::PluginInfoCache):
(WebKit::PluginInfoCache::updatePluginInfo):
Commit: 1706242c4c25f6b5b6815ff27c758e81f6409405
https://github.com/WebKit/WebKit/commit/1706242c4c25f6b5b6815ff27c758e81f6409405
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-10-01 (Wed, 01 Oct 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/UIProcess/Plugins/gtk/PluginInfoCache.cpp
M Source/WebKit2/UIProcess/Plugins/gtk/PluginInfoCache.h
Log Message:
-----------
Merge r172920 - [GTK] Older versions of WebKit should use the plugins cache in read only mode
https://bugs.webkit.org/show_bug.cgi?id=136215
Reviewed by Philippe Normand.
Now that WebKitGTK+ 2.4 and 2.5 are parallel installable, since
they use different versions of the plugins cache, apps using 2.4
might override the plugins cache file. We should prevent this from
happening by making older versions use the plugin cache, but not
downgrade it.
* UIProcess/Plugins/gtk/PluginInfoCache.cpp:
(WebKit::PluginInfoCache::PluginInfoCache):
(WebKit::PluginInfoCache::updatePluginInfo):
* UIProcess/Plugins/gtk/PluginInfoCache.h:
Commit: e727aff32747dff78893d0d1d086151a24575f96
https://github.com/WebKit/WebKit/commit/e727aff32747dff78893d0d1d086151a24575f96
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-10-01 (Wed, 01 Oct 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/Shared/Plugins/Netscape/NetscapePluginModule.cpp
M Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp
Log Message:
-----------
Merge r172919 - [GTK] Should check if a plugin mixes GTK+ symbols earlier
https://bugs.webkit.org/show_bug.cgi?id=136214
Reviewed by Philippe Normand.
We are currently checking if the plugin module and the plugin
process mix GTK symbols after the plugin has been loaded and
initialized. This is too late in many cases, since plugins can use
GTK methods in the NP_Initialize implementation. This is causing
the apps using WebKitGTK+ 2.4 to freeze when the plugin process
scans the plugins and there's a plugin using GTK+3 installed. We
should move the check earlier, once the module is loaded but
before calling NP_Initialize.
* Shared/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::moduleMixesGtkSymbols):
(WebKit::NetscapePluginModule::tryLoad):
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformPostInitialize):
Commit: 468b8826ac112aac338a21d1334dea7de3913ee2
https://github.com/WebKit/WebKit/commit/468b8826ac112aac338a21d1334dea7de3913ee2
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-10-01 (Wed, 01 Oct 2014)
Changed paths:
M ChangeLog
M Source/autotools/SetupWebKitFeatures.m4
Log Message:
-----------
Merge r173999 - [GTK] Enable CSS_IMAGE_SET in production builds
https://bugs.webkit.org/show_bug.cgi?id=137142
Reviewed by Alejandro G. Castro.
This is required by the inspector to show some of the icons that
has a HiDPI variant.
* Source/cmake/OptionsGTK.cmake:
Commit: 62f530994c5f18309e0775f8b21113255f49a50d
https://github.com/WebKit/WebKit/commit/62f530994c5f18309e0775f8b21113255f49a50d
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-10-01 (Wed, 01 Oct 2014)
Changed paths:
M Source/WebInspectorUI/ChangeLog
M Source/WebInspectorUI/GNUmakefile.am
A Source/WebInspectorUI/UserInterface/Images/gtk/AUTHORS
A Source/WebInspectorUI/UserInterface/Images/gtk/ApplicationCache.png
A Source/WebInspectorUI/UserInterface/Images/gtk/ApplicationCache at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/ApplicationCacheManifest.png
A Source/WebInspectorUI/UserInterface/Images/gtk/ApplicationCacheManifest at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/BackArrow.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/BottomUpTree.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Breakpoint.png
A Source/WebInspectorUI/UserInterface/Images/gtk/Breakpoint at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/BreakpointActionAdd.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/BreakpointActionRemove.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/BreakpointButton.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/BreakpointInactive.png
A Source/WebInspectorUI/UserInterface/Images/gtk/BreakpointInactive at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/BreakpointInactiveButton.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Breakpoints.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/COPYING
A Source/WebInspectorUI/UserInterface/Images/gtk/COPYING_CCBYSA3
A Source/WebInspectorUI/UserInterface/Images/gtk/COPYING_LGPL2
A Source/WebInspectorUI/UserInterface/Images/gtk/ClippingCSS.png
A Source/WebInspectorUI/UserInterface/Images/gtk/ClippingCSS at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/ClippingGeneric.png
A Source/WebInspectorUI/UserInterface/Images/gtk/ClippingGeneric at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/ClippingJS.png
A Source/WebInspectorUI/UserInterface/Images/gtk/ClippingJS at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/Close.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/CloseTimeline.png
A Source/WebInspectorUI/UserInterface/Images/gtk/CloseTimeline at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/CloseWhite.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/ColorIcon.png
A Source/WebInspectorUI/UserInterface/Images/gtk/ColorIcon at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/Colors.png
A Source/WebInspectorUI/UserInterface/Images/gtk/Colors at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/ColorsLarge.png
A Source/WebInspectorUI/UserInterface/Images/gtk/ColorsLarge at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/ContentFlow.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Cookie.png
A Source/WebInspectorUI/UserInterface/Images/gtk/Cookie at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/Crosshair.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/DOMCharacterData.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/DOMComment.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/DOMDocument.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/DOMDocumentType.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/DOMElement.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/DOMNode.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/DOMTextNode.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/DOMTree.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Database.png
A Source/WebInspectorUI/UserInterface/Images/gtk/Database at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/DatabaseTable.png
A Source/WebInspectorUI/UserInterface/Images/gtk/DatabaseTable at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/DisclosureTriangleSmallClosed.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/DisclosureTriangleSmallOpen.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/DisclosureTriangleTinyClosed.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/DisclosureTriangleTinyOpen.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/DockBottom.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/DockRight.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/DocumentCSS.png
A Source/WebInspectorUI/UserInterface/Images/gtk/DocumentCSS at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/DocumentFont.png
A Source/WebInspectorUI/UserInterface/Images/gtk/DocumentFont at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/DocumentGeneric.png
A Source/WebInspectorUI/UserInterface/Images/gtk/DocumentGeneric at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/DocumentImage.png
A Source/WebInspectorUI/UserInterface/Images/gtk/DocumentImage at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/DocumentJS.png
A Source/WebInspectorUI/UserInterface/Images/gtk/DocumentJS at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/DocumentMarkup.png
A Source/WebInspectorUI/UserInterface/Images/gtk/DocumentMarkup at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/DownloadArrow.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Error.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Errors.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/ErrorsEnabled.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/EventListener.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Exception.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/FilterFieldGlyph.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/FolderGeneric.png
A Source/WebInspectorUI/UserInterface/Images/gtk/FolderGeneric at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/ForwardArrow.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Function.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/GoToArrow.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/HierarchicalNavigationItemChevron.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/HoverMenuButton.png
A Source/WebInspectorUI/UserInterface/Images/gtk/HoverMenuButton at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/IndeterminateProgressSpinner1.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/IndeterminateProgressSpinner10.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/IndeterminateProgressSpinner11.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/IndeterminateProgressSpinner12.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/IndeterminateProgressSpinner2.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/IndeterminateProgressSpinner3.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/IndeterminateProgressSpinner4.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/IndeterminateProgressSpinner5.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/IndeterminateProgressSpinner6.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/IndeterminateProgressSpinner7.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/IndeterminateProgressSpinner8.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/IndeterminateProgressSpinner9.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/InstructionPointer.png
A Source/WebInspectorUI/UserInterface/Images/gtk/InstructionPointer at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/Issues.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/IssuesEnabled.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/LayerBorders.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/LessColumns.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/LocalStorage.png
A Source/WebInspectorUI/UserInterface/Images/gtk/LocalStorage at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/Locked.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Log.png
A Source/WebInspectorUI/UserInterface/Images/gtk/Log at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/Logs.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Memory.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/MoreColumns.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Native.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemAngleBrackets.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemBug.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemCurleyBraces.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemFile.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemLayers.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemLog.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemMagnifyingGlass.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemStopwatch.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemStorage.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemTrash.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemVariable.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Network.png
A Source/WebInspectorUI/UserInterface/Images/gtk/Network at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/NetworkLarge.png
A Source/WebInspectorUI/UserInterface/Images/gtk/NetworkLarge at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/Pause.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Percent.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Plus.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Profile.png
A Source/WebInspectorUI/UserInterface/Images/gtk/Profile at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/PseudoElement.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Recording.png
A Source/WebInspectorUI/UserInterface/Images/gtk/Recording at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/RecordingHovered.png
A Source/WebInspectorUI/UserInterface/Images/gtk/RecordingHovered at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/RecordingStopped.png
A Source/WebInspectorUI/UserInterface/Images/gtk/RecordingStopped at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/Reflection.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Reload.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Request.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Resources.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Response.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/ResultLine.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Resume.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Script.png
A Source/WebInspectorUI/UserInterface/Images/gtk/Script at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/ScriptLarge.png
A Source/WebInspectorUI/UserInterface/Images/gtk/ScriptLarge at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/SessionStorage.png
A Source/WebInspectorUI/UserInterface/Images/gtk/SessionStorage at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/ShadowDOM.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/SliderThumb.png
A Source/WebInspectorUI/UserInterface/Images/gtk/SliderThumb at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/SliderThumbPressed.png
A Source/WebInspectorUI/UserInterface/Images/gtk/SliderThumbPressed at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/SortIndicatorDownArrow.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/SortIndicatorUpArrow.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/SourceCode.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/SplitToggleDown.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/SplitToggleUp.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/StepInto.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/StepOut.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/StepOver.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Stopwatch.png
A Source/WebInspectorUI/UserInterface/Images/gtk/Stopwatch at 2x.png
A Source/WebInspectorUI/UserInterface/Images/gtk/StyleRuleAuthor.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/StyleRuleInherited.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/StyleRuleInheritedElement.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/StyleRuleInspector.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/StyleRuleUser.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/StyleRuleUserAgent.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Time.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/TimelineRecordAnimation.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/TimelineRecordEvent.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/TimelineRecordLayout.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/TimelineRecordPaint.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/TimelineRecordStyle.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/TimelineRecordTimer.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Undock.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/UpDownArrows.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/UserInputPrompt.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/UserInputPromptPrevious.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/UserInputResult.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Warning.svg
A Source/WebInspectorUI/UserInterface/Images/gtk/Weight.svg
Log Message:
-----------
Merge r173753 - Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
https://bugs.webkit.org/show_bug.cgi?id=136632
Reviewed by Gustavo Noronha Silva.
Source/WebInspectorUI:
Add free icons for the GTK port. These icons are from the GNOME
project, some of them adapted by Andres Gomez for the inspector.
Commit: 4453301bb75bb11012c216a80737e5d102d088e7
https://github.com/WebKit/WebKit/commit/4453301bb75bb11012c216a80737e5d102d088e7
Author: Carlos Garcia Campos <cgarcia at igalia.com>
Date: 2014-10-01 (Wed, 01 Oct 2014)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/platform/gtk/RenderThemeGtk3.cpp
Log Message:
-----------
Merge r172958 - [GTK] Selection background is rendered white when unfocused with recent GTK+
https://bugs.webkit.org/show_bug.cgi?id=136251
Reviewed by Martin Robinson.
This is due to a change in the GTK+ theme, but because we are not
using the right flags to get the selections colors. We should use
GTK_STATE_FLAG_SELECTED | GTK_STATE_FLAG_FOCUSED when focused and
GTK_STATE_FLAG_SELECTED when unfocused, instead of
GTK_STATE_FLAG_ACTIVE when unfocused.
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeGtk::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeGtk::platformActiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformInactiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformActiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeGtk::platformInactiveListBoxSelectionForegroundColor):
Commit: 2936287f95fe68cdcbc8ec635ade51180c5161fb
https://github.com/WebKit/WebKit/commit/2936287f95fe68cdcbc8ec635ade51180c5161fb
Author: Michael Catanzaro <mcatanzaro at igalia.com>
Date: 2014-10-01 (Wed, 01 Oct 2014)
Changed paths:
M Source/WebCore/ChangeLog
M Source/WebCore/platform/gtk/RenderThemeGtk3.cpp
Log Message:
-----------
Merge r172896 - [GTK] Toggle buttons visually broken with GTK+ 3.13.7
https://bugs.webkit.org/show_bug.cgi?id=136130
Patch by Michael Catanzaro <mcatanzaro at igalia.com> on 2014-08-24
Reviewed by Martin Robinson.
No new tests. Hopefully covered by existing tests, and our tests only
run with GTK+ 3.6 anyway.
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::paintToggle): use GTK_STATE_FLAG_CHECKED when compiling for
GTK+ 3.13.7 and above to ensure toggle buttons display as toggled.
Commit: 0f81d029270866792ce66a7e91af776a0db5fba2
https://github.com/WebKit/WebKit/commit/0f81d029270866792ce66a7e91af776a0db5fba2
Author: Michael Catanzaro <mcatanzaro at igalia.com>
Date: 2014-10-01 (Wed, 01 Oct 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/Shared/Downloads/soup/DownloadSoup.cpp
Log Message:
-----------
Merge r173154 - [SOUP] WebKitDownload cannot overwrite existing file
https://bugs.webkit.org/show_bug.cgi?id=136322
Patch by Michael Catanzaro <mcatanzaro at igalia.com> on 2014-09-01
Reviewed by Carlos Garcia Campos.
* Shared/Downloads/soup/DownloadSoup.cpp:
(WebKit::DownloadClient::didReceiveResponse): pass a member variable
to Download::decideDestinationWithSuggestedFilename instead of a
temporary bool, so we can use the result in didFinishLoading.
(WebKit::DownloadClient::didFinishLoading): overwrite the destination
if Download::decideDestinationWithSuggestedFilename determined we
should do so.
Commit: 2d137eaa366d90262356d0a0ee02ce002097de88
https://github.com/WebKit/WebKit/commit/2d137eaa366d90262356d0a0ee02ce002097de88
Author: Michael Catanzaro <mcatanzaro at igalia.com>
Date: 2014-10-01 (Wed, 01 Oct 2014)
Changed paths:
M Source/WebKit2/ChangeLog
M Source/WebKit2/Shared/Downloads/soup/DownloadSoup.cpp
Log Message:
-----------
Merge r173252 - [SOUP] Race condition when downloading a file due to the intermediate temporary file
https://bugs.webkit.org/show_bug.cgi?id=136423
Patch by Michael Catanzaro <mcatanzaro at igalia.com> on 2014-09-03
Reviewed by Carlos Garcia Campos.
* Shared/Downloads/soup/DownloadSoup.cpp:
(WebKit::DownloadClient::DownloadClient): Replace m_destinationURI with
m_destinationFile and add m_createdDestination.
(WebKit::DownloadClient::deleteFilesIfNeeded): Added.
(WebKit::DownloadClient::downloadFailed): Call deleteFilesIfNeeded.
(WebKit::DownloadClient::didReceiveResponse): Attempt to create the
destination file before the intermediate file. Fail here if the file
exists and overwrite is not allowed, so we don't erroneously fire the
didCreateDestination event or waste time downloading the file when we
know the download will fail.
(WebKit::DownloadClient::didFinishLoading): Unconditionally overwrite
the empty destination file.
(WebKit::DownloadClient::cancel): Call deleteFilesIfNeeded.
(WebKit::DownloadClient::deleteIntermediateFileInNeeded): Deleted.
Commit: a2d903093bba2067a1163c623c18c0e4cbee07b7
https://github.com/WebKit/WebKit/commit/a2d903093bba2067a1163c623c18c0e4cbee07b7
Author: Carlos Garcia Campos <carlosgc at webkit.org>
Date: 2014-10-01 (Wed, 01 Oct 2014)
Changed paths:
M ChangeLog
M Source/WebKit/gtk/ChangeLog
M Source/WebKit/gtk/NEWS
M Source/autotools/Versions.m4
Log Message:
-----------
Unreviewed. Update NEWS and Versions.m4 for 2.2.8 release.
.:
* Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
* NEWS: Add release notes.
Compare: https://github.com/WebKit/WebKit/compare/7429a6b52e79%5E...a2d903093bba
More information about the webkit-changes
mailing list