[webkit-changes] [WebKit/WebKit] f494a4: Allow `auto` and `normal` as container-name

Karl Dubost noreply at github.com
Thu Dec 1 07:46:00 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f494a4e0965b65aa8d469aa4b49ab1171daebfcc
      https://github.com/WebKit/WebKit/commit/f494a4e0965b65aa8d469aa4b49ab1171daebfcc
  Author: Karl Dubost <karlcow at apple.com>
  Date:   2022-12-01 (Thu, 01 Dec 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/at-container-parsing-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/at-container-parsing.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/at-container-serialization-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/at-container-serialization.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-computed.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-for-shadow-dom-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-for-shadow-dom.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-inside-multicol-with-table-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-inside-multicol-with-table.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-name-parsing-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-name-parsing.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-name-tree-scoped-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-name-tree-scoped.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-parsing-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-parsing.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-size-shadow-invalidation-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-size-shadow-invalidation.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-type-parsing-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-type-parsing.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-invalidation-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-invalidation.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-shadow.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/crashtests/chrome-bug-1362391-crash.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/crashtests/chrome-layout-root-crash.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/crashtests/marker-gcs-after-disconnect-crash.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/crashtests/w3c-import.log
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-property-style-queries-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-property-style-queries.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-property-style-query-change-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-property-style-query-change.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/font-relative-units-dynamic-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/font-relative-units-dynamic.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/font-relative-units-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/font-relative-units.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/pseudo-elements-005-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/pseudo-elements-005.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/support/cq-testcommon.js
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/transition-style-change-event-002-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/transition-style-change-event-002.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/w3c-import.log
    A LayoutTests/imported/w3c/web-platform-tests/resources/declarative-shadow-dom-polyfill.js
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp

  Log Message:
  -----------
  Allow `auto` and `normal` as container-name
https://bugs.webkit.org/show_bug.cgi?id=248195
rdar://102591474

Reviewed by Tim Nguyen.

In addition to allowing `auto` and `normal` for valid container-name,
it imports the container-queries directory from WPT tests
and rebases accordingly the expected tests.
WPT Upstream import for container queries directory:
https://github.com/web-platform-tests/wpt/commit/4572ca03c2eb3516fee3b609b81149882274975b

* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/at-container-parsing-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/at-container-parsing.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/at-container-serialization-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/at-container-serialization.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-computed.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-for-shadow-dom-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-for-shadow-dom.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-inside-multicol-with-table-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-inside-multicol-with-table.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-name-parsing-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-name-parsing.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-name-tree-scoped-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-name-tree-scoped.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-parsing-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-parsing.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-size-shadow-invalidation-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-size-shadow-invalidation.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-type-parsing-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-type-parsing.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-invalidation-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-invalidation.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-shadow-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-shadow.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/crashtests/chrome-bug-1362391-crash.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/crashtests/chrome-layout-root-crash.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/crashtests/marker-gcs-after-disconnect-crash.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/crashtests/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-property-style-queries-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-property-style-queries.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-property-style-query-change-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-property-style-query-change.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/font-relative-units-dynamic-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/font-relative-units-dynamic.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/font-relative-units-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/font-relative-units.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/pseudo-elements-005-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/pseudo-elements-005.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/transition-style-change-event-002-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/transition-style-change-event-002.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/support/cq-testcommon.js:
(assert_implements_container_queries):
(polyfill_declarative_shadow_dom): Deleted.
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/w3c-import.log:
* LayoutTests/imported/w3c/web-platform-tests/resources/declarative-shadow-dom-polyfill.js: Added.
(polyfill_declarative_shadow_dom):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeSingleContainerName):

Canonical link: https://commits.webkit.org/257236@main




More information about the webkit-changes mailing list