[webkit-changes] [WebKit/WebKit] 5cecbf: [leading-trim] Add support for parsing "text-edge"...

Alan Baradlay noreply at github.com
Thu Dec 1 06:12:29 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5cecbfbd86053346af3e4bb4e87795e36cb981a6
      https://github.com/WebKit/WebKit/commit/5cecbfbd86053346af3e4bb4e87795e36cb981a6
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2022-12-01 (Thu, 01 Dec 2022)

  Changed paths:
    A LayoutTests/fast/text/text-edge-property-parsing-expected.txt
    A LayoutTests/fast/text/text-edge-property-parsing.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssom-getPropertyValue-common-checks-expected.txt
    M LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M Source/WebCore/Headers.cmake
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/css/CSSPrimitiveValueMappings.h
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/CSSValueKeywords.in
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.h
    M Source/WebCore/rendering/style/RenderStyle.cpp
    M Source/WebCore/rendering/style/RenderStyle.h
    M Source/WebCore/rendering/style/RenderStyleConstants.cpp
    M Source/WebCore/rendering/style/RenderStyleConstants.h
    M Source/WebCore/rendering/style/StyleRareInheritedData.cpp
    M Source/WebCore/rendering/style/StyleRareInheritedData.h
    A Source/WebCore/rendering/style/StyleTextEdge.h
    M Source/WebCore/style/StyleBuilderConverter.h

  Log Message:
  -----------
  [leading-trim] Add support for parsing "text-edge" CSS property
https://bugs.webkit.org/show_bug.cgi?id=248448

Reviewed by Antti Koivisto.

This patch add support for parsing "text-edge" (https://www.w3.org/TR/css-inline-3/#text-edges). This property is behind the "CSS leading-trim" run-time flag which is off by default.
(will WPTify the test cases soon after the expected behavior is confirmed -not so much about parsing, but more about how they interact with leading-trim.)

* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextEdge const):
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::valueForTextEdge):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeTextEdge):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.h:
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::textEdge const):
(WebCore::RenderStyle::setTextEdge):
(WebCore::RenderStyle::initialTextEdge):
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
* Source/WebCore/rendering/style/RenderStyleConstants.h:
* Source/WebCore/rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):
* Source/WebCore/rendering/style/StyleRareInheritedData.h:
* Source/WebCore/rendering/style/StyleTextEdge.h: Added.
(WebCore::operator==):
(WebCore::operator!=):
* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::convertTextEdge):

Canonical link: https://commits.webkit.org/257233@main




More information about the webkit-changes mailing list