No subject


Fri Mar 7 15:32:22 PST 2014


Therefore ewk_menu variable is not available anymore when on_popup_menu_h=
ide()
on MiniBrowser is called.
As a result, just set ewk_menu to NULL in order to prevent crash conditio=
n.

* MiniBrowser/efl/main.c:
(on_popup_menu_hide):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href=3D"#trunkToolsChangeLog">trunk/Tools/ChangeLog</a></li>
<li><a href=3D"#trunkToolsMiniBrowsereflmainc">trunk/Tools/MiniBrowser/ef=
l/main.c</a></li>
</ul>

</div>
<div id=3D"patch">
<h3>Diff</h3>
<a id=3D"trunkToolsChangeLog"></a>
<div class=3D"modfile"><h4>Modified: trunk/Tools/ChangeLog (174624 =3D> 1=
74625)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Tools/ChangeLog	2014-10-10 23:46:05 UTC (r=
ev 174624)
+++ trunk/Tools/ChangeLog	2014-10-10 23:49:23 UTC (rev 174625)
</span><span class=3D"lines">@@ -1,3 +1,21 @@
</span><ins>+2014-10-10  KwangHyuk Kim  &lt;hyuki.kim at samsung.com&gt;
+
+        [EFL] Crash on facebook.com
+        https://bugs.webkit.org/show_bug.cgi?id=3D137562
+
+        Reviewed by Chris Dumez.
+
+        Crash occurs on the facebook.com when the webview is resized
+        after the &lt;select&gt; item is clicked but no item is chosen.
+        This crash is just caused by the reference of invalidated variab=
le.
+        From the EwkView::closePopupMenu(), ewk_menu is just invalidated=
.
+        Therefore ewk_menu variable is not available anymore when on_pop=
up_menu_hide()
+        on MiniBrowser is called.
+        As a result, just set ewk_menu to NULL in order to prevent crash=
 condition.
+
+        * MiniBrowser/efl/main.c:
+        (on_popup_menu_hide):
+
</ins><span class=3D"cx"> 2014-10-10  Alexey Proskuryakov  &lt;ap at apple.c=
om&gt;
</span><span class=3D"cx">=20
</span><span class=3D"cx">         A small wording change for clarity.
</span></span></pre></div>
<a id=3D"trunkToolsMiniBrowsereflmainc"></a>
<div class=3D"modfile"><h4>Modified: trunk/Tools/MiniBrowser/efl/main.c (=
174624 =3D> 174625)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Tools/MiniBrowser/efl/main.c	2014-10-10 23=
:46:05 UTC (rev 174624)
+++ trunk/Tools/MiniBrowser/efl/main.c	2014-10-10 23:49:23 UTC (rev 17462=
5)
</span><span class=3D"lines">@@ -1529,6 +1529,7 @@
</span><span class=3D"cx">         return EINA_FALSE;
</span><span class=3D"cx">=20
</span><span class=3D"cx">     elm_menu_close(window-&gt;popup.elm_menu);
</span><ins>+    window-&gt;popup.ewk_menu =3D NULL;
</ins><span class=3D"cx">=20
</span><span class=3D"cx">     return EINA_TRUE;
</span><span class=3D"cx"> }
</span></span></pre>
</div>
</div>

</body>
</html>


More information about the webkit-changes mailing list