No subject

9546">r149546</a> by &lt;jbroman at chromium.org&gt;
&lt;http://src.chromium.org/viewvc/blink?view=3Drevision&amp;revision=3D1=
49546&gt;

Previously, there was asymmetry between changing and restoring state (cer=
tain state
would be restored only if thickness was positive, i.e. a line was actuall=
y drawn.)

* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href=3D"#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeL=
og</a></li>
<li><a href=3D"#trunkSourceWebCorerenderingRenderObjectcpp">trunk/Source/=
WebCore/rendering/RenderObject.cpp</a></li>
</ul>

</div>
<div id=3D"patch">
<h3>Diff</h3>
<a id=3D"trunkSourceWebCoreChangeLog"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (1495=
58 =3D> 149559)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/ChangeLog	2013-05-04 15:18:=
29 UTC (rev 149558)
+++ trunk/Source/WebCore/ChangeLog	2013-05-04 15:27:45 UTC (rev 149559)
</span><span class=3D"lines">@@ -1,3 +1,16 @@
</span><ins>+2013-05-04  Andreas Kling  &lt;akling at apple.com&gt;
+
+        RenderObject: don't change GraphicsContext state when not drawin=
g dashed/dotted lines.
+
+        From Blink r149546 by &lt;jbroman at chromium.org&gt;
+        &lt;http://src.chromium.org/viewvc/blink?view=3Drevision&amp;rev=
ision=3D149546&gt;
+
+        Previously, there was asymmetry between changing and restoring s=
tate (certain state
+        would be restored only if thickness was positive, i.e. a line wa=
s actually drawn.)
+
+        * rendering/RenderObject.cpp:
+        (WebCore::RenderObject::drawLineForBoxSide):
+
</ins><span class=3D"cx"> 2013-05-03  Andreas Kling  &lt;akling at apple.com=
&gt;
</span><span class=3D"cx">=20
</span><span class=3D"cx">         Remove CSS selector profiler branches =
from ElementRuleCollector loop.
</span></span></pre></div>
<a id=3D"trunkSourceWebCorerenderingRenderObjectcpp"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/rendering/Rende=
rObject.cpp (149558 =3D> 149559)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/rendering/RenderObject.cpp	=
2013-05-04 15:18:29 UTC (rev 149558)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp	2013-05-04 15:27:45 U=
TC (rev 149559)
</span><span class=3D"lines">@@ -874,14 +874,13 @@
</span><span class=3D"cx">             return;
</span><span class=3D"cx">         case DOTTED:
</span><span class=3D"cx">         case DASHED: {
</span><del>-            graphicsContext-&gt;setStrokeColor(color, m_styl=
e-&gt;colorSpace());
-            graphicsContext-&gt;setStrokeThickness(thickness);
-            StrokeStyle oldStrokeStyle =3D graphicsContext-&gt;strokeSty=
le();
-            graphicsContext-&gt;setStrokeStyle(style =3D=3D DASHED ? Das=
hedStroke : DottedStroke);
-
</del><span class=3D"cx">             if (thickness &gt; 0) {
</span><span class=3D"cx">                 bool wasAntialiased =3D graphi=
csContext-&gt;shouldAntialias();
</span><ins>+                StrokeStyle oldStrokeStyle =3D graphicsConte=
xt-&gt;strokeStyle();
</ins><span class=3D"cx">                 graphicsContext-&gt;setShouldAn=
tialias(antialias);
</span><ins>+                graphicsContext-&gt;setStrokeColor(color, m_=
style-&gt;colorSpace());
+                graphicsContext-&gt;setStrokeThickness(thickness);
+                graphicsContext-&gt;setStrokeStyle(style =3D=3D DASHED ?=
 DashedStroke : DottedStroke);
</ins><span class=3D"cx">=20
</span><span class=3D"cx">                 switch (side) {
</span><span class=3D"cx">                     case BSBottom:
</span></span></pre>
</div>
</div>

</body>
</html>