No subject
Mon Jan 28 08:41:14 PST 2013
9155">r149155</a> by <james.wei at intel.com>:
The parent class BasicInspectorNode already called addInput() and addOutp=
ut().
So it is reduplicative to call them in AnalyserNode.
* Modules/webaudio/AnalyserNode.cpp:
(WebCore::AnalyserNode::AnalyserNode):
* Modules/webaudio/AudioBasicInspectorNode.cpp:
(WebCore::AudioBasicInspectorNode::AudioBasicInspectorNode):
* Modules/webaudio/AudioBasicInspectorNode.h:
(AudioBasicInspectorNode):
* Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNod=
e):</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href=3D"#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeL=
og</a></li>
<li><a href=3D"#trunkSourceWebCoreModuleswebaudioAnalyserNodecpp">trunk/S=
ource/WebCore/Modules/webaudio/AnalyserNode.cpp</a></li>
<li><a href=3D"#trunkSourceWebCoreModuleswebaudioAudioBasicInspectorNodec=
pp">trunk/Source/WebCore/Modules/webaudio/AudioBasicInspectorNode.cpp</a>=
</li>
<li><a href=3D"#trunkSourceWebCoreModuleswebaudioAudioBasicInspectorNodeh=
">trunk/Source/WebCore/Modules/webaudio/AudioBasicInspectorNode.h</a></li=
>
<li><a href=3D"#trunkSourceWebCoreModuleswebaudioMediaStreamAudioDestinat=
ionNodecpp">trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioDestina=
tionNode.cpp</a></li>
</ul>
</div>
<div id=3D"patch">
<h3>Diff</h3>
<a id=3D"trunkSourceWebCoreChangeLog"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (1491=
74 =3D> 149175)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/ChangeLog 2013-04-26 10:30:=
32 UTC (rev 149174)
+++ trunk/Source/WebCore/ChangeLog 2013-04-26 11:48:15 UTC (rev 149175)
</span><span class=3D"lines">@@ -1,3 +1,22 @@
</span><ins>+2013-04-26 Andreas Kling <akling at apple.com>
+
+ Web Audio: Remove reduplicative addInput() in AnalyserNode.
+ <http://webkit.org/b/115244>
+
+ From Blink r149155 by <james.wei at intel.com>:
+
+ The parent class BasicInspectorNode already called addInput() an=
d addOutput().
+ So it is reduplicative to call them in AnalyserNode.
+
+ * Modules/webaudio/AnalyserNode.cpp:
+ (WebCore::AnalyserNode::AnalyserNode):
+ * Modules/webaudio/AudioBasicInspectorNode.cpp:
+ (WebCore::AudioBasicInspectorNode::AudioBasicInspectorNode):
+ * Modules/webaudio/AudioBasicInspectorNode.h:
+ (AudioBasicInspectorNode):
+ * Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
+ (WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDesti=
nationNode):
+
</ins><span class=3D"cx"> 2013-04-26 Allan Sandfeld Jensen <allan.je=
nsen at digia.com>
</span><span class=3D"cx">=20
</span><span class=3D"cx"> Mouseenter and mouseleave events not s=
upported
</span></span></pre></div>
<a id=3D"trunkSourceWebCoreModuleswebaudioAnalyserNodecpp"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudi=
o/AnalyserNode.cpp (149174 =3D> 149175)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/Modules/webaudio/AnalyserNo=
de.cpp 2013-04-26 10:30:32 UTC (rev 149174)
+++ trunk/Source/WebCore/Modules/webaudio/AnalyserNode.cpp 2013-04-26 11:=
48:15 UTC (rev 149175)
</span><span class=3D"lines">@@ -35,11 +35,8 @@
</span><span class=3D"cx"> namespace WebCore {
</span><span class=3D"cx">=20
</span><span class=3D"cx"> AnalyserNode::AnalyserNode(AudioContext* conte=
xt, float sampleRate)
</span><del>- : AudioBasicInspectorNode(context, sampleRate)
</del><ins>+ : AudioBasicInspectorNode(context, sampleRate, 2)
</ins><span class=3D"cx"> {
</span><del>- addInput(adoptPtr(new AudioNodeInput(this)));
- addOutput(adoptPtr(new AudioNodeOutput(this, 2)));
- =20
</del><span class=3D"cx"> setNodeType(NodeTypeAnalyser);
</span><span class=3D"cx"> =20
</span><span class=3D"cx"> initialize();
</span></span></pre></div>
<a id=3D"trunkSourceWebCoreModuleswebaudioAudioBasicInspectorNodecpp"></a=
>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudi=
o/AudioBasicInspectorNode.cpp (149174 =3D> 149175)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/Modules/webaudio/AudioBasic=
InspectorNode.cpp 2013-04-26 10:30:32 UTC (rev 149174)
+++ trunk/Source/WebCore/Modules/webaudio/AudioBasicInspectorNode.cpp 201=
3-04-26 11:48:15 UTC (rev 149175)
</span><span class=3D"lines">@@ -34,12 +34,12 @@
</span><span class=3D"cx">=20
</span><span class=3D"cx"> namespace WebCore {
</span><span class=3D"cx">=20
</span><del>-AudioBasicInspectorNode::AudioBasicInspectorNode(AudioContex=
t* context, float sampleRate)
</del><ins>+AudioBasicInspectorNode::AudioBasicInspectorNode(AudioContext=
* context, float sampleRate, unsigned outputChannelCount)
</ins><span class=3D"cx"> : AudioNode(context, sampleRate)
</span><span class=3D"cx"> , m_needAutomaticPull(false)
</span><span class=3D"cx"> {
</span><span class=3D"cx"> addInput(adoptPtr(new AudioNodeInput(this)=
));
</span><del>- addOutput(adoptPtr(new AudioNodeOutput(this, 2)));
</del><ins>+ addOutput(adoptPtr(new AudioNodeOutput(this, outputChanne=
lCount)));
</ins><span class=3D"cx"> }
</span><span class=3D"cx">=20
</span><span class=3D"cx"> // We override pullInputs() as an optimization=
allowing this node to take advantage of in-place processing,
</span></span></pre></div>
<a id=3D"trunkSourceWebCoreModuleswebaudioAudioBasicInspectorNodeh"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudi=
o/AudioBasicInspectorNode.h (149174 =3D> 149175)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/Modules/webaudio/AudioBasic=
InspectorNode.h 2013-04-26 10:30:32 UTC (rev 149174)
+++ trunk/Source/WebCore/Modules/webaudio/AudioBasicInspectorNode.h 2013-=
04-26 11:48:15 UTC (rev 149175)
</span><span class=3D"lines">@@ -34,7 +34,7 @@
</span><span class=3D"cx"> // AudioContext before the end of each render =
quantum so that it can inspect the audio stream.
</span><span class=3D"cx"> class AudioBasicInspectorNode : public AudioNo=
de {
</span><span class=3D"cx"> public:
</span><del>- AudioBasicInspectorNode(AudioContext*, float sampleRate)=
;
</del><ins>+ AudioBasicInspectorNode(AudioContext*, float sampleRate, =
unsigned outputChannelCount);
</ins><span class=3D"cx">=20
</span><span class=3D"cx"> // AudioNode
</span><span class=3D"cx"> virtual void pullInputs(size_t framesToPro=
cess);
</span></span></pre></div>
<a id=3D"trunkSourceWebCoreModuleswebaudioMediaStreamAudioDestinationNode=
cpp"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/Modules/webaudi=
o/MediaStreamAudioDestinationNode.cpp (149174 =3D> 149175)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/Modules/webaudio/MediaStrea=
mAudioDestinationNode.cpp 2013-04-26 10:30:32 UTC (rev 149174)
+++ trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioDestinationNode=
.cpp 2013-04-26 11:48:15 UTC (rev 149175)
</span><span class=3D"lines">@@ -44,7 +44,7 @@
</span><span class=3D"cx"> }
</span><span class=3D"cx">=20
</span><span class=3D"cx"> MediaStreamAudioDestinationNode::MediaStreamAu=
dioDestinationNode(AudioContext* context, size_t numberOfChannels)
</span><del>- : AudioBasicInspectorNode(context, context->sampleRat=
e())
</del><ins>+ : AudioBasicInspectorNode(context, context->sampleRate=
(), numberOfChannels)
</ins><span class=3D"cx"> , m_mixBus(numberOfChannels, ProcessingSize=
InFrames)
</span><span class=3D"cx"> {
</span><span class=3D"cx"> setNodeType(NodeTypeMediaStreamAudioDestin=
ation);
</span></span></pre>
</div>
</div>
</body>
</html>
More information about the webkit-changes
mailing list