No subject
Mon Jan 28 08:41:14 PST 2013
9058">r149058</a> by <pdr at chromium.org>.
* svg/stroke/animated-non-scaling-stroke-expected.html: Added.
* svg/stroke/animated-non-scaling-stroke.html: Added.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href=3D"#trunkLayoutTestsChangeLog">trunk/LayoutTests/ChangeLog</a=
></li>
<li><a href=3D"#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeL=
og</a></li>
<li><a href=3D"#trunkSourceWebCoresvgSVGSVGElementcpp">trunk/Source/WebCo=
re/svg/SVGSVGElement.cpp</a></li>
<li><a href=3D"#trunkSourceWebCoresvgSVGSVGElementh">trunk/Source/WebCore=
/svg/SVGSVGElement.h</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href=3D"#trunkLayoutTestssvgstrokeanimatednonscalingstrokeexpected=
html">trunk/LayoutTests/svg/stroke/animated-non-scaling-stroke-expected.h=
tml</a></li>
<li><a href=3D"#trunkLayoutTestssvgstrokeanimatednonscalingstrokehtml">tr=
unk/LayoutTests/svg/stroke/animated-non-scaling-stroke.html</a></li>
</ul>
</div>
<div id=3D"patch">
<h3>Diff</h3>
<a id=3D"trunkLayoutTestsChangeLog"></a>
<div class=3D"modfile"><h4>Modified: trunk/LayoutTests/ChangeLog (149101 =
=3D> 149102)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/LayoutTests/ChangeLog 2013-04-25 12:32:49 =
UTC (rev 149101)
+++ trunk/LayoutTests/ChangeLog 2013-04-25 12:56:20 UTC (rev 149102)
</span><span class=3D"lines">@@ -1,3 +1,13 @@
</span><ins>+2013-04-25 Andreas Kling <akling at apple.com>
+
+ SVG: Fix viewBox animations on shapes with non-scaling-stroke.
+ <http://webkit.org/b/115173>
+
+ From Blink r149058 by <pdr at chromium.org>.
+
+ * svg/stroke/animated-non-scaling-stroke-expected.html: Added.
+ * svg/stroke/animated-non-scaling-stroke.html: Added.
+
</ins><span class=3D"cx"> 2013-04-25 =C3=81d=C3=A1m Kallai <kadam at in=
f.u-szeged.hu>
</span><span class=3D"cx">=20
</span><span class=3D"cx"> [Qt] Unreviewed gardening. Unskip now =
passing tests.
</span></span></pre></div>
<a id=3D"trunkLayoutTestssvgstrokeanimatednonscalingstrokeexpectedhtml"><=
/a>
<div class=3D"addfile"><h4>Added: trunk/LayoutTests/svg/stroke/animated-n=
on-scaling-stroke-expected.html (0 =3D> 149102)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/LayoutTests/svg/stroke/animated-non-scalin=
g-stroke-expected.html (rev 0)
+++ trunk/LayoutTests/svg/stroke/animated-non-scaling-stroke-expected.htm=
l 2013-04-25 12:56:20 UTC (rev 149102)
</span><span class=3D"lines">@@ -0,0 +1,10 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<body>
+ Test for crbug.com/232890: this test passes if there is a green square=
with a small blue border.<br/>
+ <svg id=3D"actual" width=3D"300" height=3D"=
;300" viewBox=3D"0 0 25 25">
+ <rect x=3D"2" y=3D"2" width=3D"2" h=
eight=3D"2" vector-effect=3D"non-scaling-stroke" stro=
ke-width=3D"2" stroke=3D"blue" fill=3D"green&quo=
t;/>
+ </svg>
+</body>
+</html>
+
</ins></span></pre></div>
<a id=3D"trunkLayoutTestssvgstrokeanimatednonscalingstrokehtml"></a>
<div class=3D"addfile"><h4>Added: trunk/LayoutTests/svg/stroke/animated-n=
on-scaling-stroke.html (0 =3D> 149102)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/LayoutTests/svg/stroke/animated-non-scalin=
g-stroke.html (rev 0)
+++ trunk/LayoutTests/svg/stroke/animated-non-scaling-stroke.html 2013-04=
-25 12:56:20 UTC (rev 149102)
</span><span class=3D"lines">@@ -0,0 +1,11 @@
</span><ins>+<!DOCTYPE html>
+<html>
+<body>
+ Test for crbug.com/232890: this test passes if there is a green square=
with a small blue border.<br/>
+ <svg id=3D"actual" width=3D"300" height=3D"=
;300">
+ <rect x=3D"2" y=3D"2" width=3D"2" h=
eight=3D"2" vector-effect=3D"non-scaling-stroke" stro=
ke-width=3D"2" stroke=3D"blue" fill=3D"green&quo=
t;/>
+ <set attributeName=3D"viewBox" to=3D"0 0 25 25&quo=
t; begin=3D"0s" fill=3D"freeze"/>
+ </svg>
+</body>
+</html>
+
</ins></span></pre></div>
<a id=3D"trunkSourceWebCoreChangeLog"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (1491=
01 =3D> 149102)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/ChangeLog 2013-04-25 12:32:=
49 UTC (rev 149101)
+++ trunk/Source/WebCore/ChangeLog 2013-04-25 12:56:20 UTC (rev 149102)
</span><span class=3D"lines">@@ -1,5 +1,26 @@
</span><span class=3D"cx"> 2013-04-25 Andreas Kling <akling at apple.co=
m>
</span><span class=3D"cx">=20
</span><ins>+ SVG: Fix viewBox animations on shapes with non-scali=
ng-stroke.
+ <http://webkit.org/b/115173>
+
+ From Blink r149058 by <pdr at chromium.org>:
+
+ Previously hasAttribute() to determine if a viewBox was set in t=
he transform
+ code for non-scaling-strokes. hasAttribute() should not be used =
in this case,
+ as it will return false if the attribute is not set but the valu=
e is animating.
+
+ This patch switches to checking if the viewBox is empty instead =
of checking for
+ the presence of the attribute.
+
+ Test: svg/stroke/animated-non-scaling-stroke.html
+
+ * svg/SVGSVGElement.cpp:
+ (WebCore::SVGSVGElement::localCoordinateSpaceTransform):
+ * svg/SVGSVGElement.h:
+ (WebCore::SVGSVGElement::hasEmptyViewBox):
+
+2013-04-25 Andreas Kling <akling at apple.com>
+
</ins><span class=3D"cx"> Remove isPluginElement hack in Document=
::setFocusedNode()
</span><span class=3D"cx"> <http://webkit.org/b/115171>
</span><span class=3D"cx">=20
</span></span></pre></div>
<a id=3D"trunkSourceWebCoresvgSVGSVGElementcpp"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGSVGEleme=
nt.cpp (149101 =3D> 149102)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/svg/SVGSVGElement.cpp 2013-=
04-25 12:32:49 UTC (rev 149101)
+++ trunk/Source/WebCore/svg/SVGSVGElement.cpp 2013-04-25 12:56:20 UTC (r=
ev 149102)
</span><span class=3D"lines">@@ -437,7 +437,7 @@
</span><span class=3D"cx"> AffineTransform SVGSVGElement::localCoordinate=
SpaceTransform(SVGLocatable::CTMScope mode) const
</span><span class=3D"cx"> {
</span><span class=3D"cx"> AffineTransform viewBoxTransform;
</span><del>- if (hasAttribute(SVGNames::viewBoxAttr)) {
</del><ins>+ if (!hasEmptyViewBox()) {
</ins><span class=3D"cx"> FloatSize size =3D currentViewportSize(=
);
</span><span class=3D"cx"> viewBoxTransform =3D viewBoxToViewTran=
sform(size.width(), size.height());
</span><span class=3D"cx"> }
</span></span></pre></div>
<a id=3D"trunkSourceWebCoresvgSVGSVGElementh"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/svg/SVGSVGEleme=
nt.h (149101 =3D> 149102)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/svg/SVGSVGElement.h 2013-04=
-25 12:32:49 UTC (rev 149101)
+++ trunk/Source/WebCore/svg/SVGSVGElement.h 2013-04-25 12:56:20 UTC (rev=
149102)
</span><span class=3D"lines">@@ -135,7 +135,7 @@
</span><span class=3D"cx"> SVGZoomAndPanType zoomAndPan() const { ret=
urn m_zoomAndPan; }
</span><span class=3D"cx"> void setZoomAndPan(unsigned short zoomAndP=
an) { m_zoomAndPan =3D SVGZoomAndPan::parseFromNumber(zoomAndPan); }
</span><span class=3D"cx">=20
</span><del>- bool hasEmptyViewBox() { return hasAttribute(SVGNames::v=
iewBoxAttr) && viewBoxIsValid() && viewBox().isEmpty(); }
</del><ins>+ bool hasEmptyViewBox() const { return viewBoxIsValid() &a=
mp;& viewBox().isEmpty(); }
</ins><span class=3D"cx">=20
</span><span class=3D"cx"> protected:
</span><span class=3D"cx"> virtual void didMoveToNewDocument(Document=
* oldDocument) OVERRIDE;
</span></span></pre>
</div>
</div>
</body>
</html>
More information about the webkit-changes
mailing list