[webkit-changes] [105940] trunk/Source

Eric Seidel eric at webkit.org
Wed Jan 25 17:12:39 PST 2012 

Revered the partial change.  Apologies for the breakage.

On Wed, Jan 25, 2012 at 5:06 PM, Eric Seidel <eric at webkit.org> wrote:
> Certainly.  Looking now.
>
> On Wed, Jan 25, 2012 at 4:55 PM, Mark Rowe <mrowe at apple.com> wrote:
>> This change broke the build.  The ChangeLog entry suggests that you
>> committed only a subset of the changes that were expected to be in this
>> patch.  Can you please take a look and work out what is needed to fix this?
>>
>> Thanks,
>>
>> - Mark
>>
>> On 2012-01-25, at 16:18, eric at webkit.org wrote:
>>
>> Revision 105940 Author eric at webkit.org Date 2012-01-25 16:17:59 -0800 (Wed,
>> 25 Jan 2012)
>>
>> Log Message
>>
>> HTMLIsIndexElement should not expose HTMLInputElement properties
>> https://bugs.webkit.org/show_bug.cgi?id=76095
>>
>> Reviewed by Adam Barth.
>>
>> Source/WebCore:
>>
>> document.createElement("isindex") should produce an HTMLUnknownElement
>> per the HTML5 spec.  The parser automagically translates <isindex> into
>> a whole dom tree roughly representing what <isindex> used to do 15 years
>> ago. :)
>>
>> This patch just removes our support for HTMLIsIndexElement.  The parser
>> support was already in.  Having support for HTMLIsIndexElement was causing
>> one of the IE TestCenter tests to fail.
>>
>> Test: fast/dom/HTMLIsIndexElement/prototype-chain.html
>>
>> * DerivedSources.cpp:
>> * DerivedSources.make:
>> * DerivedSources.pri:
>> * GNUmakefile.list.am:
>> * Target.pri:
>> * WebCore.exp.in:
>> * WebCore.gypi:
>> * WebCore.order:
>> * WebCore.vcproj/WebCore.vcproj:
>> * WebCore.xcodeproj/project.pbxproj:
>> * bindings/gobject/GNUmakefile.am:
>> * bindings/gobject/WebKitHTMLElementWrapperFactory.cpp:
>> (WebKit::createHTMLElementWrapper):
>> * bindings/objc/DOM.mm:
>> (WebCore::createElementClassMap):
>> * bindings/objc/DOMHTML.h:
>> * bindings/objc/PublicDOMInterfaces.h:
>> * html/HTMLElementsAllInOne.cpp:
>> * html/HTMLIsIndexElement.cpp: Removed.
>> * html/HTMLIsIndexElement.h: Removed.
>> * html/HTMLIsIndexElement.idl: Removed.
>> * html/HTMLTagNames.in:
>> * page/DOMWindow.idl:
>>
>> Source/WebKit/mac:
>>
>> * MigrateHeaders.make:
>>
>> Modified Paths
>>
>> trunk/Source/WebCore/ChangeLog
>> trunk/Source/WebCore/DerivedSources.cpp
>> trunk/Source/WebCore/DerivedSources.make
>> trunk/Source/WebCore/DerivedSources.pri
>> trunk/Source/WebKit/mac/ChangeLog
>>
>> Diff
>>
>> Modified: trunk/Source/WebCore/ChangeLog (105939 => 105940)
>>
>> --- trunk/Source/WebCore/ChangeLog    2012-01-26 00:11:34 UTC (rev 105939)
>> +++ trunk/Source/WebCore/ChangeLog    2012-01-26 00:17:59 UTC (rev 105940)
>> @@ -1,5 +1,46 @@
>>  2012-01-25  Eric Seidel  <eric at webkit.org>
>>
>> +        HTMLIsIndexElement should not expose HTMLInputElement properties
>> +        https://bugs.webkit.org/show_bug.cgi?id=76095
>> +
>> +        Reviewed by Adam Barth.
>> +
>> +        document.createElement("isindex") should produce an
>> HTMLUnknownElement
>> +        per the HTML5 spec.  The parser automagically translates <isindex>
>> into
>> +        a whole dom tree roughly representing what <isindex> used to do 15
>> years ago. :)
>> +
>> +        This patch just removes our support for HTMLIsIndexElement.  The
>> parser
>> +        support was already in.  Having support for HTMLIsIndexElement was
>> causing
>> +        one of the IE TestCenter tests to fail.
>> +
>> +        Test: fast/dom/HTMLIsIndexElement/prototype-chain.html
>> +
>> +        * DerivedSources.cpp:
>> +        * DerivedSources.make:
>> +        * DerivedSources.pri:
>> +        * GNUmakefile.list.am:
>> +        * Target.pri:
>> +        * WebCore.exp.in:
>> +        * WebCore.gypi:
>> +        * WebCore.order:
>> +        * WebCore.vcproj/WebCore.vcproj:
>> +        * WebCore.xcodeproj/project.pbxproj:
>> +        * bindings/gobject/GNUmakefile.am:
>> +        * bindings/gobject/WebKitHTMLElementWrapperFactory.cpp:
>> +        (WebKit::createHTMLElementWrapper):
>> +        * bindings/objc/DOM.mm:
>> +        (WebCore::createElementClassMap):
>> +        * bindings/objc/DOMHTML.h:
>> +        * bindings/objc/PublicDOMInterfaces.h:
>> +        * html/HTMLElementsAllInOne.cpp:
>> +        * html/HTMLIsIndexElement.cpp: Removed.
>> +        * html/HTMLIsIndexElement.h: Removed.
>> +        * html/HTMLIsIndexElement.idl: Removed.
>> +        * html/HTMLTagNames.in:
>> +        * page/DOMWindow.idl:
>> +
>> +2012-01-25  Eric Seidel  <eric at webkit.org>
>> +
>>          HTMLEmbedObject should match HTMLObjectElement by stopping any load
>> when it is removed from beforeload
>>          https://bugs.webkit.org/show_bug.cgi?id=74360
>>
>>
>> Modified: trunk/Source/WebCore/DerivedSources.cpp (105939 => 105940)
>>
>> --- trunk/Source/WebCore/DerivedSources.cpp   2012-01-26 00:11:34 UTC (rev
>> 105939)
>> +++ trunk/Source/WebCore/DerivedSources.cpp   2012-01-26 00:17:59 UTC (rev
>> 105940)
>> @@ -168,7 +168,6 @@
>>  #include "JSHTMLIFrameElement.cpp"
>>  #include "JSHTMLImageElement.cpp"
>>  #include "JSHTMLInputElement.cpp"
>> -#include "JSHTMLIsIndexElement.cpp"
>>  #include "JSHTMLKeygenElement.cpp"
>>  #include "JSHTMLLabelElement.cpp"
>>  #include "JSHTMLLegendElement.cpp"
>>
>> Modified: trunk/Source/WebCore/DerivedSources.make (105939 => 105940)
>>
>> --- trunk/Source/WebCore/DerivedSources.make  2012-01-26 00:11:34 UTC (rev
>> 105939)
>> +++ trunk/Source/WebCore/DerivedSources.make  2012-01-26 00:17:59 UTC (rev
>> 105940)
>> @@ -215,7 +215,6 @@
>>      $(WebCore)/html/HTMLIFrameElement.idl \
>>      $(WebCore)/html/HTMLImageElement.idl \
>>      $(WebCore)/html/HTMLInputElement.idl \
>> -    $(WebCore)/html/HTMLIsIndexElement.idl \
>>      $(WebCore)/html/HTMLKeygenElement.idl \
>>      $(WebCore)/html/HTMLLIElement.idl \
>>      $(WebCore)/html/HTMLLabelElement.idl \
>>
>> Modified: trunk/Source/WebCore/DerivedSources.pri (105939 => 105940)
>>
>> --- trunk/Source/WebCore/DerivedSources.pri   2012-01-26 00:11:34 UTC (rev
>> 105939)
>> +++ trunk/Source/WebCore/DerivedSources.pri   2012-01-26 00:17:59 UTC (rev
>> 105940)
>> @@ -280,7 +280,6 @@
>>      $$PWD/html/HTMLIFrameElement.idl \
>>      $$PWD/html/HTMLImageElement.idl \
>>      $$PWD/html/HTMLInputElement.idl \
>> -    $$PWD/html/HTMLIsIndexElement.idl \
>>      $$PWD/html/HTMLKeygenElement.idl \
>>      $$PWD/html/HTMLLabelElement.idl \
>>      $$PWD/html/HTMLLegendElement.idl \
>>
>> Modified: trunk/Source/WebKit/mac/ChangeLog (105939 => 105940)
>>
>> --- trunk/Source/WebKit/mac/ChangeLog 2012-01-26 00:11:34 UTC (rev 105939)
>> +++ trunk/Source/WebKit/mac/ChangeLog 2012-01-26 00:17:59 UTC (rev 105940)
>> @@ -1,3 +1,12 @@
>> +2012-01-25  Eric Seidel  <eric at webkit.org>
>> +
>> +        HTMLIsIndexElement should not expose HTMLInputElement properties
>> +        https://bugs.webkit.org/show_bug.cgi?id=76095
>> +
>> +        Reviewed by Adam Barth.
>> +
>> +        * MigrateHeaders.make:
>> +
>>  2012-01-25  Hajime Morita  <morrita at google.com>
>>
>>          ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom
>>
>> _______________________________________________
>> webkit-changes mailing list
>> webkit-changes at lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
>>
>>

More information about the webkit-changes mailing list