No subject
Wed Aug 1 07:28:53 PDT 2012
to the web (via JavaScript) and are not used internally by WebCore.
I beleive all of them always have wrappers.
These were found using this code:
https://bugs.webkit.org/show_bug.cgi?id=3D102539#c2
Geolocation -- navigator.geolocation
WebKitCSSMatrix -- represent matrixes in JS through various APIs
DOMStringMap, NamedNodeMap, NodeIterator, TreeWalker -- exclusively for t=
he DOM API
Blob, FileList - used by the File, Clipboard and XHR, also exclusively as=
API
ValidityState -- formControl.validity
CanvasRenderingContext -- canvas.getContext()
DOMApplicationCache -- window.appcache
Screen -- window.screen
DOMMimeTypeArray -- navigator.mimetypes
DOMPlugin -- navigator.plugins[0]
DOMPluginArray -- navigator.plugins
* Modules/geolocation/Geolocation.h:
* css/WebKitCSSMatrix.h:
* dom/DOMStringMap.h:
* dom/NamedNodeMap.h:
* dom/NodeIterator.h:
* dom/TreeWalker.h:
* fileapi/Blob.h:
* fileapi/FileList.h: (had to un-indent to make check-webkit-style happy)
(FileList):
(WebCore::FileList::create):
(WebCore::FileList::length):
(WebCore::FileList::isEmpty):
(WebCore::FileList::clear):
(WebCore::FileList::append):
* html/ValidityState.h:
* html/canvas/CanvasRenderingContext.h:
* loader/appcache/DOMApplicationCache.h:
* page/Screen.h:
* platform/graphics/wince/MediaPlayerProxy.cpp:
(WebCore::WebMediaPlayerProxy::initEngine): This code was wrong, fixed to=
use internal APIs.
* plugins/DOMMimeTypeArray.h:
* plugins/DOMPlugin.h:
* plugins/DOMPluginArray.h:</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href=3D"#trunkSourceWebCoreChangeLog">trunk/Source/WebCore/ChangeL=
og</a></li>
<li><a href=3D"#trunkSourceWebCoreModulesgeolocationGeolocationh">trunk/S=
ource/WebCore/Modules/geolocation/Geolocation.h</a></li>
<li><a href=3D"#trunkSourceWebCorecssWebKitCSSMatrixh">trunk/Source/WebCo=
re/css/WebKitCSSMatrix.h</a></li>
<li><a href=3D"#trunkSourceWebCoredomDOMStringMaph">trunk/Source/WebCore/=
dom/DOMStringMap.h</a></li>
<li><a href=3D"#trunkSourceWebCoredomNamedNodeMaph">trunk/Source/WebCore/=
dom/NamedNodeMap.h</a></li>
<li><a href=3D"#trunkSourceWebCoredomNodeIteratorh">trunk/Source/WebCore/=
dom/NodeIterator.h</a></li>
<li><a href=3D"#trunkSourceWebCoredomTreeWalkerh">trunk/Source/WebCore/do=
m/TreeWalker.h</a></li>
<li><a href=3D"#trunkSourceWebCorefileapiBlobh">trunk/Source/WebCore/file=
api/Blob.h</a></li>
<li><a href=3D"#trunkSourceWebCorefileapiFileListh">trunk/Source/WebCore/=
fileapi/FileList.h</a></li>
<li><a href=3D"#trunkSourceWebCorehtmlValidityStateh">trunk/Source/WebCor=
e/html/ValidityState.h</a></li>
<li><a href=3D"#trunkSourceWebCorehtmlcanvasCanvasRenderingContexth">trun=
k/Source/WebCore/html/canvas/CanvasRenderingContext.h</a></li>
<li><a href=3D"#trunkSourceWebCoreloaderappcacheDOMApplicationCacheh">tru=
nk/Source/WebCore/loader/appcache/DOMApplicationCache.h</a></li>
<li><a href=3D"#trunkSourceWebCorepageScreenh">trunk/Source/WebCore/page/=
Screen.h</a></li>
<li><a href=3D"#trunkSourceWebCoreplatformgraphicswinceMediaPlayerProxycp=
p">trunk/Source/WebCore/platform/graphics/wince/MediaPlayerProxy.cpp</a><=
/li>
<li><a href=3D"#trunkSourceWebCorepluginsDOMMimeTypeArrayh">trunk/Source/=
WebCore/plugins/DOMMimeTypeArray.h</a></li>
<li><a href=3D"#trunkSourceWebCorepluginsDOMPluginh">trunk/Source/WebCore=
/plugins/DOMPlugin.h</a></li>
<li><a href=3D"#trunkSourceWebCorepluginsDOMPluginArrayh">trunk/Source/We=
bCore/plugins/DOMPluginArray.h</a></li>
</ul>
</div>
<div id=3D"patch">
<h3>Diff</h3>
<a id=3D"trunkSourceWebCoreChangeLog"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/ChangeLog (1350=
57 =3D> 135058)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/ChangeLog 2012-11-18 03:37:=
04 UTC (rev 135057)
+++ trunk/Source/WebCore/ChangeLog 2012-11-18 03:37:49 UTC (rev 135058)
</span><span class=3D"lines">@@ -1,3 +1,52 @@
</span><ins>+2012-11-17 Eric Seidel <eric at webkit.org>
+
+ Add ScriptWrappable to more WebCore classes which are commonly J=
S-wrapped
+ https://bugs.webkit.org/show_bug.cgi?id=3D102601
+
+ Reviewed by Adam Barth.
+
+ From my investigations all of these classes exist only to be exp=
osed
+ to the web (via JavaScript) and are not used internally by WebCo=
re.
+ I beleive all of them always have wrappers.
+ These were found using this code:
+ https://bugs.webkit.org/show_bug.cgi?id=3D102539#c2
+
+ Geolocation -- navigator.geolocation
+ WebKitCSSMatrix -- represent matrixes in JS through various APIs
+ DOMStringMap, NamedNodeMap, NodeIterator, TreeWalker -- exclusiv=
ely for the DOM API
+ Blob, FileList - used by the File, Clipboard and XHR, also exclu=
sively as API
+ ValidityState -- formControl.validity
+ CanvasRenderingContext -- canvas.getContext()
+ DOMApplicationCache -- window.appcache
+ Screen -- window.screen
+ DOMMimeTypeArray -- navigator.mimetypes
+ DOMPlugin -- navigator.plugins[0]
+ DOMPluginArray -- navigator.plugins
+
+ * Modules/geolocation/Geolocation.h:
+ * css/WebKitCSSMatrix.h:
+ * dom/DOMStringMap.h:
+ * dom/NamedNodeMap.h:
+ * dom/NodeIterator.h:
+ * dom/TreeWalker.h:
+ * fileapi/Blob.h:
+ * fileapi/FileList.h: (had to un-indent to make check-webkit-sty=
le happy)
+ (FileList):
+ (WebCore::FileList::create):
+ (WebCore::FileList::length):
+ (WebCore::FileList::isEmpty):
+ (WebCore::FileList::clear):
+ (WebCore::FileList::append):
+ * html/ValidityState.h:
+ * html/canvas/CanvasRenderingContext.h:
+ * loader/appcache/DOMApplicationCache.h:
+ * page/Screen.h:
+ * platform/graphics/wince/MediaPlayerProxy.cpp:
+ (WebCore::WebMediaPlayerProxy::initEngine): This code was wrong,=
fixed to use internal APIs.
+ * plugins/DOMMimeTypeArray.h:
+ * plugins/DOMPlugin.h:
+ * plugins/DOMPluginArray.h:
+
</ins><span class=3D"cx"> 2012-11-17 Alexandru Chiculita <achicu at ado=
be.com>
</span><span class=3D"cx">=20
</span><span class=3D"cx"> [Texmap][CSS Shaders] Reuse the precom=
piled shader for custom filters in TextureMapperGL
</span></span></pre></div>
<a id=3D"trunkSourceWebCoreModulesgeolocationGeolocationh"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/Modules/geoloca=
tion/Geolocation.h (135057 =3D> 135058)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/Modules/geolocation/Geoloca=
tion.h 2012-11-18 03:37:04 UTC (rev 135057)
+++ trunk/Source/WebCore/Modules/geolocation/Geolocation.h 2012-11-18 03:=
37:49 UTC (rev 135058)
</span><span class=3D"lines">@@ -35,6 +35,7 @@
</span><span class=3D"cx"> #include "PositionError.h"
</span><span class=3D"cx"> #include "PositionErrorCallback.h"
</span><span class=3D"cx"> #include "PositionOptions.h"
</span><ins>+#include "ScriptWrappable.h"
</ins><span class=3D"cx"> #include "Timer.h"
</span><span class=3D"cx">=20
</span><span class=3D"cx"> namespace WebCore {
</span><span class=3D"lines">@@ -47,7 +48,7 @@
</span><span class=3D"cx"> class Page;
</span><span class=3D"cx"> class ScriptExecutionContext;
</span><span class=3D"cx">=20
</span><del>-class Geolocation : public RefCounted<Geolocation>, pu=
blic ActiveDOMObject
</del><ins>+class Geolocation : public ScriptWrappable, public RefCounted=
<Geolocation>, public ActiveDOMObject
</ins><span class=3D"cx"> {
</span><span class=3D"cx"> public:
</span><span class=3D"cx"> static PassRefPtr<Geolocation> creat=
e(ScriptExecutionContext*);
</span></span></pre></div>
<a id=3D"trunkSourceWebCorecssWebKitCSSMatrixh"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/css/WebKitCSSMa=
trix.h (135057 =3D> 135058)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/css/WebKitCSSMatrix.h 2012-=
11-18 03:37:04 UTC (rev 135057)
+++ trunk/Source/WebCore/css/WebKitCSSMatrix.h 2012-11-18 03:37:49 UTC (r=
ev 135058)
</span><span class=3D"lines">@@ -26,6 +26,7 @@
</span><span class=3D"cx"> #ifndef WebKitCSSMatrix_h
</span><span class=3D"cx"> #define WebKitCSSMatrix_h
</span><span class=3D"cx">=20
</span><ins>+#include "ScriptWrappable.h"
</ins><span class=3D"cx"> #include "TransformationMatrix.h"
</span><span class=3D"cx"> #include <wtf/RefCounted.h>
</span><span class=3D"cx"> #include <wtf/RefPtr.h>
</span><span class=3D"lines">@@ -35,7 +36,7 @@
</span><span class=3D"cx">=20
</span><span class=3D"cx"> typedef int ExceptionCode;
</span><span class=3D"cx">=20
</span><del>-class WebKitCSSMatrix : public RefCounted<WebKitCSSMatrix=
> {
</del><ins>+class WebKitCSSMatrix : public ScriptWrappable, public RefCou=
nted<WebKitCSSMatrix> {
</ins><span class=3D"cx"> public:
</span><span class=3D"cx"> static PassRefPtr<WebKitCSSMatrix> c=
reate(const TransformationMatrix& m)
</span><span class=3D"cx"> {
</span></span></pre></div>
<a id=3D"trunkSourceWebCoredomDOMStringMaph"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/dom/DOMStringMa=
p.h (135057 =3D> 135058)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/dom/DOMStringMap.h 2012-11-=
18 03:37:04 UTC (rev 135057)
+++ trunk/Source/WebCore/dom/DOMStringMap.h 2012-11-18 03:37:49 UTC (rev =
135058)
</span><span class=3D"lines">@@ -26,6 +26,7 @@
</span><span class=3D"cx"> #ifndef DOMStringMap_h
</span><span class=3D"cx"> #define DOMStringMap_h
</span><span class=3D"cx">=20
</span><ins>+#include "ScriptWrappable.h"
</ins><span class=3D"cx"> #include <wtf/Noncopyable.h>
</span><span class=3D"cx"> #include <wtf/Vector.h>
</span><span class=3D"cx"> #include <wtf/text/WTFString.h>
</span><span class=3D"lines">@@ -35,7 +36,7 @@
</span><span class=3D"cx"> class Element;
</span><span class=3D"cx"> typedef int ExceptionCode;
</span><span class=3D"cx">=20
</span><del>-class DOMStringMap {
</del><ins>+class DOMStringMap : public ScriptWrappable {
</ins><span class=3D"cx"> WTF_MAKE_NONCOPYABLE(DOMStringMap); WTF_MAK=
E_FAST_ALLOCATED;
</span><span class=3D"cx"> public:
</span><span class=3D"cx"> virtual ~DOMStringMap();
</span></span></pre></div>
<a id=3D"trunkSourceWebCoredomNamedNodeMaph"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/dom/NamedNodeMa=
p.h (135057 =3D> 135058)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/dom/NamedNodeMap.h 2012-11-=
18 03:37:04 UTC (rev 135057)
+++ trunk/Source/WebCore/dom/NamedNodeMap.h 2012-11-18 03:37:49 UTC (rev =
135058)
</span><span class=3D"lines">@@ -25,6 +25,7 @@
</span><span class=3D"cx"> #ifndef NamedNodeMap_h
</span><span class=3D"cx"> #define NamedNodeMap_h
</span><span class=3D"cx">=20
</span><ins>+#include "ScriptWrappable.h"
</ins><span class=3D"cx"> #include <wtf/PassOwnPtr.h>
</span><span class=3D"cx"> #include <wtf/PassRefPtr.h>
</span><span class=3D"cx"> #include <wtf/text/WTFString.h>
</span><span class=3D"lines">@@ -36,7 +37,7 @@
</span><span class=3D"cx">=20
</span><span class=3D"cx"> typedef int ExceptionCode;
</span><span class=3D"cx">=20
</span><del>-class NamedNodeMap {
</del><ins>+class NamedNodeMap : public ScriptWrappable {
</ins><span class=3D"cx"> WTF_MAKE_FAST_ALLOCATED;
</span><span class=3D"cx"> friend class Element;
</span><span class=3D"cx"> public:
</span></span></pre></div>
<a id=3D"trunkSourceWebCoredomNodeIteratorh"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/dom/NodeIterato=
r.h (135057 =3D> 135058)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/dom/NodeIterator.h 2012-11-=
18 03:37:04 UTC (rev 135057)
+++ trunk/Source/WebCore/dom/NodeIterator.h 2012-11-18 03:37:49 UTC (rev =
135058)
</span><span class=3D"lines">@@ -26,6 +26,7 @@
</span><span class=3D"cx"> #define NodeIterator_h
</span><span class=3D"cx">=20
</span><span class=3D"cx"> #include "NodeFilter.h"
</span><ins>+#include "ScriptWrappable.h"
</ins><span class=3D"cx"> #include "Traversal.h"
</span><span class=3D"cx"> #include <wtf/PassRefPtr.h>
</span><span class=3D"cx"> #include <wtf/RefCounted.h>
</span><span class=3D"lines">@@ -34,7 +35,7 @@
</span><span class=3D"cx">=20
</span><span class=3D"cx"> typedef int ExceptionCode;
</span><span class=3D"cx">=20
</span><del>- class NodeIterator : public RefCounted<NodeIterator&g=
t;, public Traversal {
</del><ins>+ class NodeIterator : public ScriptWrappable, public RefCo=
unted<NodeIterator>, public Traversal {
</ins><span class=3D"cx"> public:
</span><span class=3D"cx"> static PassRefPtr<NodeIterator> =
create(PassRefPtr<Node> rootNode, unsigned whatToShow, PassRefPtr&l=
t;NodeFilter> filter, bool expandEntityReferences)
</span><span class=3D"cx"> {
</span></span></pre></div>
<a id=3D"trunkSourceWebCoredomTreeWalkerh"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/dom/TreeWalker.=
h (135057 =3D> 135058)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/dom/TreeWalker.h 2012-11-18=
03:37:04 UTC (rev 135057)
+++ trunk/Source/WebCore/dom/TreeWalker.h 2012-11-18 03:37:49 UTC (rev 13=
5058)
</span><span class=3D"lines">@@ -26,6 +26,7 @@
</span><span class=3D"cx"> #define TreeWalker_h
</span><span class=3D"cx">=20
</span><span class=3D"cx"> #include "NodeFilter.h"
</span><ins>+#include "ScriptWrappable.h"
</ins><span class=3D"cx"> #include "Traversal.h"
</span><span class=3D"cx"> #include <wtf/PassRefPtr.h>
</span><span class=3D"cx"> #include <wtf/RefCounted.h>
</span><span class=3D"lines">@@ -34,7 +35,7 @@
</span><span class=3D"cx">=20
</span><span class=3D"cx"> typedef int ExceptionCode;
</span><span class=3D"cx">=20
</span><del>- class TreeWalker : public RefCounted<TreeWalker>, =
public Traversal {
</del><ins>+ class TreeWalker : public ScriptWrappable, public RefCoun=
ted<TreeWalker>, public Traversal {
</ins><span class=3D"cx"> public:
</span><span class=3D"cx"> static PassRefPtr<TreeWalker> cr=
eate(PassRefPtr<Node> rootNode, unsigned whatToShow, PassRefPtr<=
NodeFilter> filter, bool expandEntityReferences)
</span><span class=3D"cx"> {
</span></span></pre></div>
<a id=3D"trunkSourceWebCorefileapiBlobh"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/fileapi/Blob.h =
(135057 =3D> 135058)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/fileapi/Blob.h 2012-11-18 0=
3:37:04 UTC (rev 135057)
+++ trunk/Source/WebCore/fileapi/Blob.h 2012-11-18 03:37:49 UTC (rev 1350=
58)
</span><span class=3D"lines">@@ -33,6 +33,7 @@
</span><span class=3D"cx">=20
</span><span class=3D"cx"> #include "BlobData.h"
</span><span class=3D"cx"> #include "KURL.h"
</span><ins>+#include "ScriptWrappable.h"
</ins><span class=3D"cx"> #include <wtf/PassOwnPtr.h>
</span><span class=3D"cx"> #include <wtf/PassRefPtr.h>
</span><span class=3D"cx"> #include <wtf/RefCounted.h>
</span><span class=3D"lines">@@ -43,7 +44,7 @@
</span><span class=3D"cx">=20
</span><span class=3D"cx"> class ScriptExecutionContext;
</span><span class=3D"cx">=20
</span><del>-class Blob : public RefCounted<Blob> {
</del><ins>+class Blob : public ScriptWrappable, public RefCounted<Blo=
b> {
</ins><span class=3D"cx"> public:
</span><span class=3D"cx"> static PassRefPtr<Blob> create()
</span><span class=3D"cx"> {
</span></span></pre></div>
<a id=3D"trunkSourceWebCorefileapiFileListh"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/fileapi/FileLis=
t.h (135057 =3D> 135058)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/fileapi/FileList.h 2012-11-=
18 03:37:04 UTC (rev 135057)
+++ trunk/Source/WebCore/fileapi/FileList.h 2012-11-18 03:37:49 UTC (rev =
135058)
</span><span class=3D"lines">@@ -27,6 +27,7 @@
</span><span class=3D"cx"> #define FileList_h
</span><span class=3D"cx">=20
</span><span class=3D"cx"> #include "File.h"
</span><ins>+#include "ScriptWrappable.h"
</ins><span class=3D"cx"> #include <wtf/PassRefPtr.h>
</span><span class=3D"cx"> #include <wtf/RefCounted.h>
</span><span class=3D"cx"> #include <wtf/RefPtr.h>
</span><span class=3D"lines">@@ -34,26 +35,26 @@
</span><span class=3D"cx">=20
</span><span class=3D"cx"> namespace WebCore {
</span><span class=3D"cx">=20
</span><del>- class FileList : public RefCounted<FileList> {
- public:
- static PassRefPtr<FileList> create()
- {
- return adoptRef(new FileList);
- }
</del><ins>+class FileList : public ScriptWrappable, public RefCounted<=
;FileList> {
+public:
+ static PassRefPtr<FileList> create()
+ {
+ return adoptRef(new FileList);
+ }
</ins><span class=3D"cx">=20
</span><del>- unsigned length() const { return m_files.size(); }
- File* item(unsigned index) const;
</del><ins>+ unsigned length() const { return m_files.size(); }
+ File* item(unsigned index) const;
</ins><span class=3D"cx">=20
</span><del>- bool isEmpty() const { return m_files.isEmpty(); }
- void clear() { m_files.clear(); }
- void append(PassRefPtr<File> file) { m_files.append(file);=
}
- Vector<String> paths() const;
</del><ins>+ bool isEmpty() const { return m_files.isEmpty(); }
+ void clear() { m_files.clear(); }
+ void append(PassRefPtr<File> file) { m_files.append(file); }
+ Vector<String> paths() const;
</ins><span class=3D"cx">=20
</span><del>- private:
- FileList();
</del><ins>+private:
+ FileList();
</ins><span class=3D"cx">=20
</span><del>- Vector<RefPtr<File> > m_files;
- };
</del><ins>+ Vector<RefPtr<File> > m_files;
+};
</ins><span class=3D"cx">=20
</span><span class=3D"cx"> } // namespace WebCore
</span><span class=3D"cx">=20
</span></span></pre></div>
<a id=3D"trunkSourceWebCorehtmlValidityStateh"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/html/ValiditySt=
ate.h (135057 =3D> 135058)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/html/ValidityState.h 2012-1=
1-18 03:37:04 UTC (rev 135057)
+++ trunk/Source/WebCore/html/ValidityState.h 2012-11-18 03:37:49 UTC (re=
v 135058)
</span><span class=3D"lines">@@ -25,11 +25,12 @@
</span><span class=3D"cx"> #define ValidityState_h
</span><span class=3D"cx">=20
</span><span class=3D"cx"> #include "FormAssociatedElement.h"
</span><ins>+#include "ScriptWrappable.h"
</ins><span class=3D"cx"> #include <wtf/PassOwnPtr.h>
</span><span class=3D"cx">=20
</span><span class=3D"cx"> namespace WebCore {
</span><span class=3D"cx">=20
</span><del>-class ValidityState {
</del><ins>+class ValidityState : public ScriptWrappable {
</ins><span class=3D"cx"> WTF_MAKE_NONCOPYABLE(ValidityState); WTF_MA=
KE_FAST_ALLOCATED;
</span><span class=3D"cx"> public:
</span><span class=3D"cx"> static PassOwnPtr<ValidityState> cre=
ate(FormAssociatedElement* control)
</span></span></pre></div>
<a id=3D"trunkSourceWebCorehtmlcanvasCanvasRenderingContexth"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/html/canvas/Can=
vasRenderingContext.h (135057 =3D> 135058)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/html/canvas/CanvasRendering=
Context.h 2012-11-18 03:37:04 UTC (rev 135057)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext.h 2012-11-18 =
03:37:49 UTC (rev 135058)
</span><span class=3D"lines">@@ -28,6 +28,7 @@
</span><span class=3D"cx">=20
</span><span class=3D"cx"> #include "GraphicsLayer.h"
</span><span class=3D"cx"> #include "HTMLCanvasElement.h"
</span><ins>+#include "ScriptWrappable.h"
</ins><span class=3D"cx"> #include <wtf/HashSet.h>
</span><span class=3D"cx"> #include <wtf/Noncopyable.h>
</span><span class=3D"cx"> #include <wtf/text/StringHash.h>
</span><span class=3D"lines">@@ -41,7 +42,7 @@
</span><span class=3D"cx"> class KURL;
</span><span class=3D"cx"> class WebGLObject;
</span><span class=3D"cx">=20
</span><del>-class CanvasRenderingContext {
</del><ins>+class CanvasRenderingContext : public ScriptWrappable {
</ins><span class=3D"cx"> WTF_MAKE_NONCOPYABLE(CanvasRenderingContext=
); WTF_MAKE_FAST_ALLOCATED;
</span><span class=3D"cx"> public:
</span><span class=3D"cx"> virtual ~CanvasRenderingContext() { }
</span></span></pre></div>
<a id=3D"trunkSourceWebCoreloaderappcacheDOMApplicationCacheh"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/loader/appcache=
/DOMApplicationCache.h (135057 =3D> 135058)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/loader/appcache/DOMApplicat=
ionCache.h 2012-11-18 03:37:04 UTC (rev 135057)
+++ trunk/Source/WebCore/loader/appcache/DOMApplicationCache.h 2012-11-18=
03:37:49 UTC (rev 135058)
</span><span class=3D"lines">@@ -30,6 +30,7 @@
</span><span class=3D"cx"> #include "DOMWindowProperty.h"
</span><span class=3D"cx"> #include "EventNames.h"
</span><span class=3D"cx"> #include "EventTarget.h"
</span><ins>+#include "ScriptWrappable.h"
</ins><span class=3D"cx"> #include <wtf/Forward.h>
</span><span class=3D"cx"> #include <wtf/HashMap.h>
</span><span class=3D"cx"> #include <wtf/PassRefPtr.h>
</span><span class=3D"lines">@@ -42,7 +43,7 @@
</span><span class=3D"cx"> class Frame;
</span><span class=3D"cx"> class KURL;
</span><span class=3D"cx">=20
</span><del>-class DOMApplicationCache : public RefCounted<DOMApplicat=
ionCache>, public EventTarget, public DOMWindowProperty {
</del><ins>+class DOMApplicationCache : public ScriptWrappable, public Re=
fCounted<DOMApplicationCache>, public EventTarget, public DOMWindow=
Property {
</ins><span class=3D"cx"> public:
</span><span class=3D"cx"> static PassRefPtr<DOMApplicationCache&g=
t; create(Frame* frame) { return adoptRef(new DOMApplicationCache(frame))=
; }
</span><span class=3D"cx"> ~DOMApplicationCache() { ASSERT(!m_frame);=
}
</span></span></pre></div>
<a id=3D"trunkSourceWebCorepageScreenh"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/page/Screen.h (=
135057 =3D> 135058)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/page/Screen.h 2012-11-18 03=
:37:04 UTC (rev 135057)
+++ trunk/Source/WebCore/page/Screen.h 2012-11-18 03:37:49 UTC (rev 13505=
8)
</span><span class=3D"lines">@@ -31,6 +31,7 @@
</span><span class=3D"cx"> #define Screen_h
</span><span class=3D"cx">=20
</span><span class=3D"cx"> #include "DOMWindowProperty.h"
</span><ins>+#include "ScriptWrappable.h"
</ins><span class=3D"cx"> #include <wtf/PassRefPtr.h>
</span><span class=3D"cx"> #include <wtf/RefCounted.h>
</span><span class=3D"cx">=20
</span><span class=3D"lines">@@ -38,7 +39,7 @@
</span><span class=3D"cx">=20
</span><span class=3D"cx"> class Frame;
</span><span class=3D"cx">=20
</span><del>- class Screen : public RefCounted<Screen>, public D=
OMWindowProperty {
</del><ins>+ class Screen : public ScriptWrappable, public RefCounted&=
lt;Screen>, public DOMWindowProperty {
</ins><span class=3D"cx"> public:
</span><span class=3D"cx"> static PassRefPtr<Screen> create=
(Frame *frame) { return adoptRef(new Screen(frame)); }
</span><span class=3D"cx">=20
</span></span></pre></div>
<a id=3D"trunkSourceWebCoreplatformgraphicswinceMediaPlayerProxycpp"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/platform/graphi=
cs/wince/MediaPlayerProxy.cpp (135057 =3D> 135058)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/platform/graphics/wince/Med=
iaPlayerProxy.cpp 2012-11-18 03:37:04 UTC (rev 135057)
+++ trunk/Source/WebCore/platform/graphics/wince/MediaPlayerProxy.cpp 201=
2-11-18 03:37:49 UTC (rev 135058)
</span><span class=3D"lines">@@ -101,9 +101,9 @@
</span><span class=3D"cx"> String serviceType;
</span><span class=3D"cx">=20
</span><span class=3D"cx"> // add all attributes set on the embed obj=
ect
</span><del>- if (NamedNodeMap* attributes =3D element->attributes(=
)) {
- for (unsigned i =3D 0; i < attributes->length(); ++i) {
- Attribute* it =3D attributes->attributeItem(i);
</del><ins>+ if (element->hasAttributes()) {
+ for (unsigned i =3D 0; i < element->attributeCount(); ++i)=
{
+ Attribute* it =3D element->attributeItem(i);
</ins><span class=3D"cx"> paramNames.append(it->name().loc=
alName().string());
</span><span class=3D"cx"> paramValues.append(it->value().=
string());
</span><span class=3D"cx"> }
</span></span></pre></div>
<a id=3D"trunkSourceWebCorepluginsDOMMimeTypeArrayh"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/plugins/DOMMime=
TypeArray.h (135057 =3D> 135058)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/plugins/DOMMimeTypeArray.h =
2012-11-18 03:37:04 UTC (rev 135057)
+++ trunk/Source/WebCore/plugins/DOMMimeTypeArray.h 2012-11-18 03:37:49 U=
TC (rev 135058)
</span><span class=3D"lines">@@ -23,6 +23,7 @@
</span><span class=3D"cx">=20
</span><span class=3D"cx"> #include "DOMMimeType.h"
</span><span class=3D"cx"> #include "DOMWindowProperty.h"
</span><ins>+#include "ScriptWrappable.h"
</ins><span class=3D"cx"> #include <wtf/Forward.h>
</span><span class=3D"cx"> #include <wtf/PassRefPtr.h>
</span><span class=3D"cx"> #include <wtf/RefCounted.h>
</span><span class=3D"lines">@@ -33,7 +34,7 @@
</span><span class=3D"cx"> class Frame;
</span><span class=3D"cx"> class PluginData;
</span><span class=3D"cx">=20
</span><del>-class DOMMimeTypeArray : public RefCounted<DOMMimeTypeArr=
ay>, public DOMWindowProperty {
</del><ins>+class DOMMimeTypeArray : public ScriptWrappable, public RefCo=
unted<DOMMimeTypeArray>, public DOMWindowProperty {
</ins><span class=3D"cx"> public:
</span><span class=3D"cx"> static PassRefPtr<DOMMimeTypeArray> =
create(Frame* frame) { return adoptRef(new DOMMimeTypeArray(frame)); }
</span><span class=3D"cx"> ~DOMMimeTypeArray();
</span></span></pre></div>
<a id=3D"trunkSourceWebCorepluginsDOMPluginh"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/plugins/DOMPlug=
in.h (135057 =3D> 135058)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/plugins/DOMPlugin.h 2012-11=
-18 03:37:04 UTC (rev 135057)
+++ trunk/Source/WebCore/plugins/DOMPlugin.h 2012-11-18 03:37:49 UTC (rev=
135058)
</span><span class=3D"lines">@@ -22,6 +22,7 @@
</span><span class=3D"cx">=20
</span><span class=3D"cx"> #include "FrameDestructionObserver.h"=
;
</span><span class=3D"cx"> #include "DOMMimeType.h"
</span><ins>+#include "ScriptWrappable.h"
</ins><span class=3D"cx"> #include <wtf/Forward.h>
</span><span class=3D"cx"> #include <wtf/RefPtr.h>
</span><span class=3D"cx"> #include <wtf/RefCounted.h>
</span><span class=3D"lines">@@ -31,7 +32,7 @@
</span><span class=3D"cx"> class Plugin;
</span><span class=3D"cx"> class PluginData;
</span><span class=3D"cx">=20
</span><del>-class DOMPlugin : public RefCounted<DOMPlugin>, public=
FrameDestructionObserver {
</del><ins>+class DOMPlugin : public ScriptWrappable, public RefCounted&l=
t;DOMPlugin>, public FrameDestructionObserver {
</ins><span class=3D"cx"> public:
</span><span class=3D"cx"> static PassRefPtr<DOMPlugin> create(=
PluginData* pluginData, Frame* frame, unsigned index) { return adoptRef(n=
ew DOMPlugin(pluginData, frame, index)); }
</span><span class=3D"cx"> ~DOMPlugin();
</span></span></pre></div>
<a id=3D"trunkSourceWebCorepluginsDOMPluginArrayh"></a>
<div class=3D"modfile"><h4>Modified: trunk/Source/WebCore/plugins/DOMPlug=
inArray.h (135057 =3D> 135058)</h4>
<pre class=3D"diff"><span>
<span class=3D"info">--- trunk/Source/WebCore/plugins/DOMPluginArray.h 20=
12-11-18 03:37:04 UTC (rev 135057)
+++ trunk/Source/WebCore/plugins/DOMPluginArray.h 2012-11-18 03:37:49 UTC=
(rev 135058)
</span><span class=3D"lines">@@ -23,6 +23,7 @@
</span><span class=3D"cx">=20
</span><span class=3D"cx"> #include "DOMPlugin.h"
</span><span class=3D"cx"> #include "DOMWindowProperty.h"
</span><ins>+#include "ScriptWrappable.h"
</ins><span class=3D"cx"> #include <wtf/Forward.h>
</span><span class=3D"cx"> #include <wtf/PassRefPtr.h>
</span><span class=3D"cx"> #include <wtf/RefCounted.h>
</span><span class=3D"lines">@@ -33,7 +34,7 @@
</span><span class=3D"cx"> class Frame;
</span><span class=3D"cx"> class PluginData;
</span><span class=3D"cx">=20
</span><del>-class DOMPluginArray : public RefCounted<DOMPluginArray&g=
t;, public DOMWindowProperty {
</del><ins>+class DOMPluginArray : public ScriptWrappable, public RefCoun=
ted<DOMPluginArray>, public DOMWindowProperty {
</ins><span class=3D"cx"> public:
</span><span class=3D"cx"> static PassRefPtr<DOMPluginArray> cr=
eate(Frame* frame) { return adoptRef(new DOMPluginArray(frame)); }
</span><span class=3D"cx"> ~DOMPluginArray();
</span></span></pre>
</div>
</div>
</body>
</html>
More information about the webkit-changes
mailing list