[webkit-changes] [97602] trunk/LayoutTests

Dan Bernstein mitz at apple.com
Mon Oct 17 09:10:15 PDT 2011


On Oct 17, 2011, at 9:07 AM, Antti Koivisto wrote:

> 
> On 17.10.2011, at 18.29, Dan Bernstein wrote:
> 
>> On Oct 17, 2011, at 3:38 AM, antti at apple.com wrote:
>> 
>>> Modified Paths
>>> 
>>> trunk/LayoutTests/ChangeLog
>>> trunk/LayoutTests/css3/selectors3/html/css3-modsel-17.html
>>> trunk/LayoutTests/css3/selectors3/html/css3-modsel-61.html
>>> trunk/LayoutTests/css3/selectors3/xhtml/css3-modsel-17.xml
>>> trunk/LayoutTests/css3/selectors3/xhtml/css3-modsel-61.xml
>>> trunk/LayoutTests/css3/selectors3/xml/css3-modsel-17.xml
>>> trunk/LayoutTests/css3/selectors3/xml/css3-modsel-61.xml
>> 
>> The css3/selectors3 directory contains an external test suite. We should not modify tests in that directory. You can make modified copies in a different directory instead.
> 
> Sounds like a sensible principle. In terms of practical problems this creates, is it worth the effort to go back?

I suppose not. Taking a broader look, the entire css3 directory has become a mixture of imported test suites and original content.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-changes/attachments/20111017/7faf551d/attachment.html>


More information about the webkit-changes mailing list