[webkit-changes] [85445] trunk/Source/JavaScriptCore

[Adam Barth]

We'll probably need to clean up some build errors on EFL, but
otherwise, success.  :)

Of course, there's still PassOwnPtr strictness...

Adam


On Sun, May 1, 2011 at 5:52 PM, Sam Weinig <weinig at apple.com> wrote:
> Woo!  Awesome work!
> -Sam
> On May 1, 2011, at 5:33 PM, abarth at webkit.org wrote:
>
> Revision 85445 Author abarth at webkit.org Date 2011-05-01 17:33:43 -0700 (Sun,
> 01 May 2011)
>
> Log Message
>
> 2011-05-01  Adam Barth  <abarth at webkit.org>
>
>         Reviewed by David Levin.
>
>         Enable strict mode for OwnPtr and PassOwnPtr
>         https://bugs.webkit.org/show_bug.cgi?id=59428
>
>         * wtf/OwnPtr.h:
>
> Modified Paths
>
> trunk/Source/JavaScriptCore/ChangeLog
> trunk/Source/JavaScriptCore/wtf/OwnPtr.h
>
> Diff
>
> Modified: trunk/Source/JavaScriptCore/ChangeLog (85444 => 85445)
>
> --- trunk/Source/JavaScriptCore/ChangeLog	2011-05-02 00:19:55 UTC (rev
> 85444)
> +++ trunk/Source/JavaScriptCore/ChangeLog	2011-05-02 00:33:43 UTC (rev
> 85445)
> @@ -1,3 +1,12 @@
> +2011-05-01  Adam Barth  <abarth at webkit.org>
> +
> +        Reviewed by David Levin.
> +
> +        Enable strict mode for OwnPtr and PassOwnPtr
> +        https://bugs.webkit.org/show_bug.cgi?id=59428
> +
> +        * wtf/OwnPtr.h:
> +
>  2011-05-01  Patrick Gansterer  <paroga at webkit.org>
>
>          Reviewed by Adam Barth.
>
> Modified: trunk/Source/JavaScriptCore/wtf/OwnPtr.h (85444 => 85445)
>
> --- trunk/Source/JavaScriptCore/wtf/OwnPtr.h	2011-05-02 00:19:55 UTC (rev
> 85444)
> +++ trunk/Source/JavaScriptCore/wtf/OwnPtr.h	2011-05-02 00:33:43 UTC (rev
> 85445)
> @@ -28,11 +28,6 @@
>  #include <algorithm>
>  #include <memory>
>
> -// Remove this once we make all WebKit code compatible with stricter rules
> about OwnPtr.
> -#if !PLATFORM(MAC) && !PLATFORM(CHROMIUM) && !PLATFORM(QT) &&
> !PLATFORM(GTK) && !PLATFORM(WIN)
> -#define LOOSE_OWN_PTR
> -#endif
> -
>  namespace WTF {
>
>      // Unlike most of our smart pointers, OwnPtr can take either the
> pointer type or the pointed-to type.
>
> _______________________________________________
> webkit-changes mailing list
> webkit-changes at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
>
>