[webkit-changes] [59165] trunk/LayoutTests

[Nikolas Zimmermann]

Am 11.05.2010 um 21:48 schrieb tonikitoo at webkit.org:

> Revision
> 59165
> Author
> tonikitoo at webkit.org
> Date
> 2010-05-11 12:48:39 -0700 (Tue, 11 May 2010)
> Log Message
>
> [Qt] fast/frames/flattening/frameset-flattening-subframesets.html  
> fails intermittently on Qt bot
> https://bugs.webkit.org/show_bug.cgi?id=37334
>
> Rubber-stamped by Kenneth Christiansen.
> Patch by Antonio Gomes <tonikitoo at webkit.org>
>
> Removing unneeded call to LayoutTestController.display(). It was  
> originally intending
> to force a layout, but a re-layout will happen regardless because  
> document.body.offsetTop
> is called afterwards
>
> * fast/frames/flattening/frameset-flattening-subframe-resize.html:
> * platform/qt/Skipped:
Are you sure about that? On mac at least, display() has a different  
purpose than forcing a layout.
display() paints a semi-transparent black rectangle over the WebView,  
so you can easilly spot repainting differences.
This means you've broken LayoutTests/platform/mac/fast/frames/ 
flattening/frameset-flattening-subframe-resize-expected.png.
I am not sure whether the actual display() call is needed here or  
whether it was on purpose, Simon Fraser may know?

Cheers,
Niko


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-changes/attachments/20100512/dc3e6c7b/attachment.html>