[webkit-changes] [56454] trunk

[Hayato Ito]

Oh. I am so sorry that I've altered tht reviewer line.
I don't remember why I've changed it. I guess that the line was pasted from
my personal memo.

I should have checked it before sending a review request.


On Thu, Mar 25, 2010 at 8:15 AM, Eric Seidel <eric at webkit.org> wrote:

> This is covered by bug https://bugs.webkit.org/show_bug.cgi?id=26927.
>
> Ideally this sort of problem should be caught by our scripts (see
> above bug), for now, whoever sets commit-queue+ should validate that
> the Reviewer line is present and un-altered so that the scripts can
> handle it.  Right now the scripts don't know the difference between a
> line like:
>
>        Reviewed by NOBODY (Need!).
>
> and a valid line link:
>
>        Reviewed by George Smith.
>
> They assume if they don't find "NOBODY (OOPS!)" that someone has
> filled in the reviewer line.
>
> -eric
>
> On Wed, Mar 24, 2010 at 4:10 PM, Dan Bernstein <mitz at apple.com> wrote:
> >
> > On Mar 24, 2010, at 1:38 PM, eric at webkit.org wrote:
> >
> > Revision 56454 Author eric at webkit.org Date 2010-03-24 13:38:05 -0700
> (Wed,
> > 24 Mar 2010)
> >
> > Modified: trunk/WebCore/ChangeLog (56453 => 56454)
> >
> > --- trunk/WebCore/ChangeLog   2010-03-24 20:20:32 UTC (rev 56453)
> > +++ trunk/WebCore/ChangeLog   2010-03-24 20:38:05 UTC (rev 56454)
> > @@ -1,3 +1,21 @@
> > +2010-03-24  Hayato Ito  <hayato at chromium.org>
> > +
> > +        Reviewed by NOBODY (Need!).
> >
> > Please make sure to include the reviewer name in the change log.
>



-- 
Hayato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-changes/attachments/20100325/cd2f3bf2/attachment.html>