[webkit-changes] [56454] trunk

[Adam Barth]

On Wed, Mar 24, 2010 at 7:29 PM, Mark Rowe <mrowe at apple.com> wrote:
> On 2010-03-24, at 19:25, Adam Barth wrote:
>> On Wed, Mar 24, 2010 at 6:24 PM, Mark Rowe <mrowe at apple.com> wrote:
>>> On 2010-03-24, at 18:19, Adam Barth wrote:
>>>> I've posted a patch to prevent this from happening in the future:
>>>>
>>>> https://bugs.webkit.org/show_bug.cgi?id=26927
>>>
>>> I'm not sure that I see how this would detect a "Reviewed by NOBODY (Need!)" line like the one that was present in the change in question.
>>
>> The intent is that it would detect that it hadn't filling in a proper
>> reviewed by line in the ChangeLog that was missing the reviewed by
>> line.
>
> I'm having trouble parsing what you've said here.

Yeah, that's pretty unintelligible.  :)

Turns out Eric doesn't like that approach either.  I'm going to add a
new step that just validates that all the ChangeLogs have proper
reviewers listed.

Adam