[webkit-changes] [56454] trunk

Mark Rowe mrowe at apple.com
Wed Mar 24 18:24:36 PDT 2010


On 2010-03-24, at 18:19, Adam Barth wrote:

> I've posted a patch to prevent this from happening in the future:
> 
> https://bugs.webkit.org/show_bug.cgi?id=26927

I'm not sure that I see how this would detect a "Reviewed by NOBODY (Need!)" line like the one that was present in the change in question.

- Mark

> On Wed, Mar 24, 2010 at 6:11 PM, Eric Seidel <eric at webkit.org> wrote:
>> http://trac.webkit.org/changeset/56476
>> 
>> Thanks for bringing this to my attention.
>> 
>> -eric
>> 
>> On Wed, Mar 24, 2010 at 5:59 PM, Mark Rowe <mrowe at apple.com> wrote:
>>> 
>>> On 2010-03-24, at 17:55, Eric Seidel wrote:
>>> 
>>>> I'm happy to make such a change to the Reviewer line in the ChangeLog
>>>> if the reviewer/commit-queuer are not around to do so.
>>> 
>>>> Does such a change warrant a ChangeLog?
>>> 
>>> Of course it doesn't.
>>> 
>>>> Let me know and I'll be happy to do so immediately.
>>> 
>>> Please do it.
>>> 
>>> - Mark
>>> 
>>> 
>> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2413 bytes
Desc: not available
URL: <http://lists.webkit.org/pipermail/webkit-changes/attachments/20100324/7ab18149/attachment.bin>


More information about the webkit-changes mailing list