[webkit-changes] [52903] trunk/WebKit/qt

[Adam Treat]

Does this allow you to remove LayoutTests/editing/style/fontsize-1.html from 
the Qt Skipped file?

On Thursday 07 January 2010 02:07:59 am eric at webkit.org wrote:
> Revision
> 52903
> Author
> eric at webkit.org
> Date
> 2010-01-06 23:07:54 -0800 (Wed, 06 Jan 2010)
> Log Message
> 2010-01-06  Andreas Kling  <andreas.kling at nokia.com>
>
>         Reviewed by Simon Hausmann.
>
>         [Qt] Return an invalid Qt::ImMicroFocus if queried while the view
> needs to layout.
>
>         https://bugs.webkit.org/show_bug.cgi?id=33204
>
>         * Api/qwebpage.cpp:
>         (QWebPage::inputMethodQuery):
> Modified Paths
> trunk/WebKit/qt/Api/qwebpage.cpp
> trunk/WebKit/qt/ChangeLog
> Diff
>
> Modified: trunk/WebKit/qt/Api/qwebpage.cpp (52902 => 52903)
>
> --- trunk/WebKit/qt/Api/qwebpage.cpp    2010-01-07 06:12:53 UTC (rev 52902)
> +++ trunk/WebKit/qt/Api/qwebpage.cpp    2010-01-07 07:07:54 UTC (rev 52903)
> @@ -1393,6 +1393,11 @@
>
>      switch (property) {
>          case Qt::ImMicroFocus: {
> +            WebCore::FrameView* view = frame->view();
> +            if (view && view->needsLayout()) {
> +                // We can't access absoluteCaretBounds() while the view
> needs to layout. +                return QVariant();
> +            }
>              return QVariant(frame->selection()->absoluteCaretBounds());
>          }
>          case Qt::ImFont: {
>
>
> Modified: trunk/WebKit/qt/ChangeLog (52902 => 52903)
>
> --- trunk/WebKit/qt/ChangeLog   2010-01-07 06:12:53 UTC (rev 52902)
> +++ trunk/WebKit/qt/ChangeLog   2010-01-07 07:07:54 UTC (rev 52903)
> @@ -1,3 +1,14 @@
> +2010-01-06  Andreas Kling  <andreas.kling at nokia.com>
> +
> +        Reviewed by Simon Hausmann.
> +
> +        [Qt] Return an invalid Qt::ImMicroFocus if queried while the view
> needs to layout. +
> +        https://bugs.webkit.org/show_bug.cgi?id=33204
> +
> +        * Api/qwebpage.cpp:
> +        (QWebPage::inputMethodQuery):
> +
>  2010-01-05  Yael Aharon  <yael.aharon at nokia.com>
>
>          Reviewed by Kenneth Rohde Christiansen.