[webkit-changes] [48609] trunk

[Greg Bolsinga]

Sorry about the build break! And thanks for the fix!

The -sysroot is needed for iPhone builds. It is how gcc knows to look  
for everything (headers libraries and tools) for the simulator or  
device.

I had built on SnowLeopard targetting macosx, but with an iPhone SDK  
installed. Somehow that doesn't hit this problem.

It is required for building for iPhone, so Dave or I will have to  
figure out a way to abstract it out nicely.

Sent from my iPhone

On Sep 21, 2009, at 6:37 PM, Brady Eidson <beidson at apple.com> wrote:

> This patch broke the Xcode build (in the UI only?) on SnowLeopard.
>
> On Sep 21, 2009, at 4:10 PM, bolsinga at apple.com wrote:
>
>> Revision
>> 48609
>> Author
>> bolsinga at apple.com
>> Date
>> 2009-09-21 16:10:30 -0700 (Mon, 21 Sep 2009)
>> Log Message
>>
>> JavaScriptCore: Add ENABLE(ORIENTATION_EVENTS)
>> https://bugs.webkit.org/show_bug.cgi?id=29508
>>
>> Reviewed by Simon Fraser & Sam Weinig.
>> Modified Paths
>>
>> trunk/WebCore/DerivedSources.make
>> Diff
>>
>> Modified: trunk/WebCore/DerivedSources.make (48608 => 48609)
>>
>> --- trunk/WebCore/DerivedSources.make	2009-09-21 22:59:00 UTC (rev  
>> 48608)
>> +++ trunk/WebCore/DerivedSources.make	2009-09-21 23:10:30 UTC (rev  
>> 48609)
>> @@ -483,6 +485,13 @@
>>      ENABLE_INSPECTOR = 0
>>  endif
>>
>> +ifeq ($(shell gcc -isysroot $(SDKROOT) -E -P -dM -F $ 
>> (BUILT_PRODUCTS_DIR) $(FRAMEWORK_FLAGS) WebCore/ForwardingHeaders/ 
>> wtf/Platform.h | grep ENABLE_ORIENTATION_EVENTS | cut -d' ' -f3), 1)
>> +    ENABLE_ORIENTATION_EVENTS = 1
>> +    ADDITIONAL_IDL_DEFINES := $(ADDITIONAL_IDL_DEFINES)  
>> ENABLE_ORIENTATION_EVENTS
>> +else
>> +    ENABLE_ORIENTATION_EVENTS = 0
>> +endif
>> +
>>  # CSS property names and value keywords
>
> To fix it I landed r48615:
>
> -ifeq ($(shell gcc -isysroot $(SDKROOT) -E -P -dM -F $ 
> (BUILT_PRODUCTS_DIR) $(FRAMEWORK_FLAGS) WebCore/ForwardingHeaders/ 
> wtf/Platform.h | grep ENABLE_ORIENTATION_EVENTS | cut -d' ' -f3), 1)
> +ifeq ($(shell gcc -E -P -dM -F $(BUILT_PRODUCTS_DIR) $ 
> (FRAMEWORK_FLAGS) WebCore/ForwardingHeaders/wtf/Platform.h | grep  
> ENABLE_ORIENTATION_EVENTS | cut -d' ' -f3), 1)
>
> Was there any specific reason you had the -isysroot ($SDKROOT)  
> command there?  None of the other feature defines in that file have  
> it.
>
>  Brady
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-changes/attachments/20090921/7d14482b/attachment.html>