[webkit-changes] [47890] trunk/WebCore

[Yong Li]

[47890] trunk/WebCoreIs "suspend_handle_id" webkit style?

  ----- Original Message ----- 
  From: eric at webkit.org 
  To: webkit-changes at lists.webkit.org 
  Sent: Monday, August 31, 2009 7:06 AM
  Subject: [webkit-changes] [47890] trunk/WebCore


    Revision 47890 
    Author eric at webkit.org 
    Date 2009-08-31 04:06:26 -0700 (Mon, 31 Aug 2009) 
  Log Message
2009-08-31  Cameron McCormack  <cam at mcc.id.au>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=28827
        SVGSVGElement.unsuspendRedraw() shouldn't throw

        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::unsuspendRedraw):
        * svg/SVGSVGElement.h:
        * svg/SVGSVGElement.idl:Modified Paths
    a.. trunk/WebCore/ChangeLog 
    b.. trunk/WebCore/svg/SVGSVGElement.cpp 
    c.. trunk/WebCore/svg/SVGSVGElement.h 
    d.. trunk/WebCore/svg/SVGSVGElement.idl 
  Diff
  Modified: trunk/WebCore/ChangeLog (47889 => 47890)

--- trunk/WebCore/ChangeLog	2009-08-31 10:55:42 UTC (rev 47889)
+++ trunk/WebCore/ChangeLog	2009-08-31 11:06:26 UTC (rev 47890)
@@ -1,3 +1,15 @@
+2009-08-31  Cameron McCormack  <cam at mcc.id.au>
+
+        Reviewed by Eric Seidel.
+
+        https://bugs.webkit.org/show_bug.cgi?id=28827
+        SVGSVGElement.unsuspendRedraw() shouldn't throw
+
+        * svg/SVGSVGElement.cpp:
+        (WebCore::SVGSVGElement::unsuspendRedraw):
+        * svg/SVGSVGElement.h:
+        * svg/SVGSVGElement.idl:
+
 2009-08-31  Kent Tamura  <tkent at chromium.org>
 
         Reviewed by Eric Seidel.
Modified: trunk/WebCore/svg/SVGSVGElement.cpp (47889 => 47890)

--- trunk/WebCore/svg/SVGSVGElement.cpp	2009-08-31 10:55:42 UTC (rev 47889)
+++ trunk/WebCore/svg/SVGSVGElement.cpp	2009-08-31 11:06:26 UTC (rev 47890)
@@ -313,9 +313,8 @@
     return 0;
 }
 
-void SVGSVGElement::unsuspendRedraw(unsigned long /* suspend_handle_id */, ExceptionCode&)
+void SVGSVGElement::unsuspendRedraw(unsigned long /* suspend_handle_id */)
 {
-    // if suspend_handle_id is not found, throw exception
     // FIXME: Implement me (see bug 11275)
 }
 
Modified: trunk/WebCore/svg/SVGSVGElement.h (47889 => 47890)

--- trunk/WebCore/svg/SVGSVGElement.h	2009-08-31 10:55:42 UTC (rev 47889)
+++ trunk/WebCore/svg/SVGSVGElement.h	2009-08-31 11:06:26 UTC (rev 47890)
@@ -95,7 +95,7 @@
         void setCurrentTime(float seconds);
 
         unsigned long suspendRedraw(unsigned long max_wait_milliseconds);
-        void unsuspendRedraw(unsigned long suspend_handle_id, ExceptionCode&);
+        void unsuspendRedraw(unsigned long suspend_handle_id);
         void unsuspendRedrawAll();
         void forceRedraw();
 
Modified: trunk/WebCore/svg/SVGSVGElement.idl (47889 => 47890)

--- trunk/WebCore/svg/SVGSVGElement.idl	2009-08-31 10:55:42 UTC (rev 47889)
+++ trunk/WebCore/svg/SVGSVGElement.idl	2009-08-31 11:06:26 UTC (rev 47890)
@@ -56,8 +56,7 @@
         readonly attribute SVGPoint currentTranslate;
 
         unsigned long suspendRedraw(in unsigned long maxWaitMilliseconds);
-        void unsuspendRedraw(in unsigned long suspendHandleId)
-            setter raises(DOMException);
+        void unsuspendRedraw(in unsigned long suspendHandleId);
         void unsuspendRedrawAll();
         void forceRedraw();
         void pauseAnimations();



------------------------------------------------------------------------------


  _______________________________________________
  webkit-changes mailing list
  webkit-changes at lists.webkit.org
  http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-changes/attachments/20090831/95232364/attachment.html>