[webkit-changes] [30373] trunk/WebCore

[Darin Adler]

On Feb 18, 2008, at 11:47 AM, Alexey Proskuryakov wrote:

> On Feb 18, 2008, at 9:59 PM, darin at apple.com wrote:
>
>> +__ZN7WebCore6String6appendEc
>
>
>  Is it still our intention to make String immutable in the future?

Not sure. I need to revisit my String proposal and see what things  
look like now that we've made some progress. StringImpl and the string  
buffers are now indeed immutable as you know!

> I see that some other flavors of append() are already exported, but  
> seeing another one added made me curious.

I don't think that adding another makes things worse. But perhaps I  
should use Vector<UChar> at those call sites instead, and then remove  
the append exports.

There's no major performance problem with a single append, though;  
there's really only trouble if there are multiple appends.

I guess this change was done with my "remove DeprecatedString" hat on,  
rather than the also important but less pressing "improve the design  
of String" hat.

     -- Darin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.webkit.org/pipermail/webkit-changes/attachments/20080218/d0130fb8/attachment.html