[webkit-changes] [35617] trunk/WebCore

[Timothy Hatcher]

None of our other console messages are localized yet. But they likely  
should be.

It is non trivial to let the Inspector JavaScript add these log  
messages since the JavaScript is only called when the Inspector is  
open, so log messages would be out of order of when they happened, but  
in the order of when the Inspector JavaScript was populated with the  
resource.

On Aug 7, 2008, at 7:26 AM, Adam Roben wrote:

>
> On Aug 6, 2008, at 7:08 PM, kmccullough at apple.com wrote:
>
>>
>> Modified: trunk/WebCore/xml/XMLHttpRequest.cpp (35616 => 35617)
>> --- trunk/WebCore/xml/XMLHttpRequest.cpp	2008-08-06 23:07:27 UTC  
>> (rev 35616)
>> +++ trunk/WebCore/xml/XMLHttpRequest.cpp	2008-08-06 23:08:20 UTC  
>> (rev 35617)
>> @@ -1064,7 +1064,7 @@
>>      if (Frame* frame = m_doc->frame()) {
>>          if (Page* page = frame->page()) {
>>              page->inspectorController()- 
>> >resourceRetrievedByXMLHttpRequest(m_loader ? m_loader- 
>> >identifier() : m_identifier, m_responseText);
>> -            page->inspectorController()- 
>> >addMessageToConsole(JSMessageSource, LogMessageLevel, "XHR did  
>> finish loading \"" + m_url + "\".", 0, m_doc->url());
>> +            page->inspectorController()- 
>> >addMessageToConsole(JSMessageSource, LogMessageLevel, "XHR  
>> finished loading \"" + m_url + "\".", 0, m_doc->url());
>>          }
>>      }
>>
>
> Another reason why we should let the Inspector control this is that  
> it would allow us to localize this message.
>
> -Adam
>
> _______________________________________________
> webkit-changes mailing list
> webkit-changes at lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

— Timothy Hatcher


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.webkit.org/pipermail/webkit-changes/attachments/20080807/ca49f032/attachment.html