[webkit-changes] [27751] trunk/JavaScriptCore

Darin Adler darin at apple.com
Tue Nov 13 10:15:19 PST 2007


On Nov 13, 2007, at 9:46 AM, Oliver Hunt wrote:

> If that assert is firing something is *wrong*
>
> Removing the assert is not safe.

Not true.

Consider, for example, JSImmediate::getUInt32 and  
JSImmediate::getTruncatedInt32, both of which check isNumber after  
calling getTruncatedInt32. They don't make *use* of the return value,  
but they need to be able to make the call without stopping in the  
debugger.

I'm not as sure about JSImmediate::toDouble -- you should take a look  
at that one.

We could restructure the functions so that these types of callers used  
a version without an assertion and other callers used a version with  
the assertion.

Lets not discuss this on the webkit-changes list. Future messages to  
webkit-dev please.

     -- Darin



More information about the webkit-changes mailing list